From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 31 11:29:52 2022 Received: (at submit) by debbugs.gnu.org; 31 Jul 2022 15:29:52 +0000 Received: from localhost ([127.0.0.1]:38484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIAt6-0002zo-7w for submit@debbugs.gnu.org; Sun, 31 Jul 2022 11:29:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:59050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIAt1-0002ze-PT for submit@debbugs.gnu.org; Sun, 31 Jul 2022 11:29:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIAsy-0002iV-6s for guix-patches@gnu.org; Sun, 31 Jul 2022 11:29:47 -0400 Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:38440 helo=nomad-cl1.muradm.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIAsv-0007tv-QV for guix-patches@gnu.org; Sun, 31 Jul 2022 11:29:43 -0400 Received: from localhost ([127.0.0.1]:58998) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oIAsT-0007UB-27 for guix-patches@gnu.org; Sun, 31 Jul 2022 15:29:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To: From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=a0Yfk076JquHNTHz6iAYDlnp4ws6iyw2loTffm1Ppn4=; b=hiOdNHJghD0Q0HHnln6Tm6bLAt fkbxo8VIia8iiJLe42XECjWInk52CEE7UaIckW2V55u10K2Lwg3+SXJOOMErR94MaTv7hkg/G8B0O diS5Ep3Xcus5hCBhIMnGiHndkTpLhd5tx6RfGubdpdNElaeHMM4QMSxsqGY6a1mmgLW/uBinRbL8h QqjMY/PVP1aatl5VR9EAbeKZYFnwOHtzfA78YV6ssoiwwUg7QZKdghsDcRITgvUTZIHztwkWbRsJS HQUDuSL7ilL9aSJ7HErCU4gREUKZwhXbWSWomgIFIbu3sHU5gKtqpkeVlAYRM2WN0YuWugwmtV4Dg GxId23dD772BZieWs7Q7cWxsPloL/wCRUk9kz0Qzuj0GIXkfaZDb8ZoII15UMOIvPnweKgM+qXKvH Th/zOTp7TLa3X2+cbnSXjRTirKe1esCUPb1bHAzIQb43/58O8yt/UoqoThaV8FFkE++dfdmHDPnq/ zEbKEIE6V9sp1Xz0G3Wju4H4; Received: from muradm by localhost with local (Exim 4.96) (envelope-from ) id 1oIAss-0007UA-0W for guix-patches@gnu.org; Sun, 31 Jul 2022 18:29:38 +0300 From: muradm To: guix-patches@gnu.org Subject: [PATCH] gnu: libcgroup: Update to 2.0.2. Date: Sun, 31 Jul 2022 18:29:38 +0300 Message-Id: <20220731152938.28770-1-mail@muradm.net> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.162.159.157; envelope-from=mail@muradm.net; helo=nomad-cl1.muradm.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/linux.scm (libcgroup): Update to 2.0.2. [source]: Project migrated to github. --- gnu/packages/linux.scm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 906303175d..bcb2bb284a 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -8146,15 +8146,15 @@ (define-public fbcat (define-public libcgroup (package (name "libcgroup") - (version "0.41") + (version "2.0.2") + (home-page "https://github.com/libcgroup/libcgroup") (source (origin (method url-fetch) - (uri (string-append - "mirror://sourceforge/libcg/" name "/" - version "/" name "-" version ".tar.bz2")) + (uri (string-append home-page "/releases/download/v" + version "/" name "-" version ".tar.gz")) (sha256 - (base32 "0lgvyq37gq84sk30sg18admxaj0j0p5dq3bl6g74a1ppgvf8pqz4")))) + (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) (build-system gnu-build-system) (arguments `(#:tests? #f)) @@ -8162,7 +8162,6 @@ (define-public libcgroup (list bison flex)) (inputs (list linux-pam)) - (home-page "https://sourceforge.net/projects/libcg/") (synopsis "Control groups management tools") (description "Control groups is Linux kernel method for process resource restriction, permission handling and more. This package provides userspace -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 31 17:48:24 2022 Received: (at 56858) by debbugs.gnu.org; 31 Jul 2022 21:48:24 +0000 Received: from localhost ([127.0.0.1]:38715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIGnQ-0006SO-Kt for submit@debbugs.gnu.org; Sun, 31 Jul 2022 17:48:24 -0400 Received: from knopi.disroot.org ([178.21.23.139]:37300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIGnO-0006SG-K5 for 56858@debbugs.gnu.org; Sun, 31 Jul 2022 17:48:22 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id DEFF540E79; Sun, 31 Jul 2022 23:48:21 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wGefwk5stS67; Sun, 31 Jul 2022 23:48:20 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659304100; bh=GtkTBEu1fFRG/G7vCuT9ctPbvOtP1IFzNrLFUPkiRbY=; h=Date:Subject:From:To:References:In-Reply-To; b=JIfMF5MPM6QciSEGzUe6C+SujkJHvh6gDN1Mvg+gRH6PgTqXmuhkBz70DNmte4RgM oHGlIGPXooPLNgXpuJqjZkEf66VpQWHyn5nBj7+yXfzLOQ0h9TyZhekRvRiSMrIgLm yGxHLtjkQWUFA+P9vVOVpW6U9nqyrQGhG9RrvrX+8jYyLxjP+vpefD57+pD0XO3TOs 8UtdAYK1rkOTkkdJIrkXp98MtpRNBemYN+kbwltr43hB2OgRZSewIw5gida7vh6f1G e5JLRDAj1RH/pH+dm1bcbBkfI5R0CjShoev91QfyFQve9UpQ7HhBpytvIYmjbct2hV wu2QMAaApvzTA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 31 Jul 2022 22:48:20 +0100 Message-Id: Subject: Re: [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2. From: "(" To: "muradm" , <56858@debbugs.gnu.org> References: <20220731152938.28770-1-mail@muradm.net> In-Reply-To: <20220731152938.28770-1-mail@muradm.net> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56858 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! On Sun Jul 31, 2022 at 4:29 PM BST, muradm wrote: > + (home-page "https://github.com/libcgroup/libcgroup") Put home-page under inputs and above synopsis, where it was before. > (method url-fetch) > - (uri (string-append > - "mirror://sourceforge/libcg/" name "/" > - version "/" name "-" version ".tar.bz2")) > + (uri (string-append home-page "/releases/download/v" > + version "/" name "-" version ".tar.gz")) Since we're using github now, we likely want to use git-fetch here. I've been told Github releases are volatile. -- ( From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 01 01:45:03 2022 Received: (at 56858) by debbugs.gnu.org; 1 Aug 2022 05:45:03 +0000 Received: from localhost ([127.0.0.1]:39064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIOEh-0003w6-Fb for submit@debbugs.gnu.org; Mon, 01 Aug 2022 01:45:03 -0400 Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:51346 helo=nomad-cl1.muradm.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIOEf-0003vJ-4i for 56858@debbugs.gnu.org; Mon, 01 Aug 2022 01:45:01 -0400 Received: from localhost ([127.0.0.1]:38592) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oIOE9-0007f4-2E; Mon, 01 Aug 2022 05:44:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To :From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Xyesm8Vwa0CBdstCuGs9RjS+XbQa3PiZG44vXqAJhXo=; b=JO8gsFqsW2aAoimSsfHb6BF8Bc C8w0Cht+kjQzCpmfLgWBIY5vpKuCO0fJ62GVQyI8m4BTyQBoa+PKjXoIXUYu0x4JRG2rFp1DpU7E3 iqdTjFfMf3MXsnWoASMkqFoVRsH4Znnk7alt4D+t9hYlWEf0Tg6Y6z+noBZ9KFmtvlpezcKYT7SDf w07AcwL3ZhaJWfaloDSFqrt/r+Qyoykw11i671bPu650UWZCIEFeJexDYKTg/0PLaeoZyKRxgLg3N bvaNl7Vagh2i9QrJ+nS4zjxQKhc03/byu7Q3HkeONLsSS7plo9MeMGFSCYbWeJWf1X/TAjk0C07UA vmXAIPxQ8iSxMRfqko21hHQYVNBhKC9YCL9f8y5ySvW79qiAodrCDMDKaah51j4hlBYZy2P1l1M+d WlIXYO3vSS5gRWFOBgvEdr7HHgBDIAutfPRDvtzssAZzN+StJCtxigCYgPZWFPeiyJJRpm60/7p0f 36atqJFfAgvoDcXgmRIbvvSb; Received: from muradm by localhost with local (Exim 4.96) (envelope-from ) id 1oIOEW-0000ez-1s; Mon, 01 Aug 2022 08:44:52 +0300 References: <20220731152938.28770-1-mail@muradm.net> User-agent: mu4e 1.6.11; emacs 29.0.50 From: muradm To: "(" Subject: Re: [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2. Date: Mon, 01 Aug 2022 08:42:20 +0300 In-reply-to: Message-ID: <87sfmgplez.fsf@muradm.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56858 Cc: 56858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed "(" writes: > Hi! > > On Sun Jul 31, 2022 at 4:29 PM BST, muradm wrote: >> + (home-page "https://github.com/libcgroup/libcgroup") > Put home-page under inputs and above synopsis, where it was > before. > Is there a guideline where home-page should be? I find it more DRY when reusing. >> (method url-fetch) >> - (uri (string-append >> - "mirror://sourceforge/libcg/" name "/" >> - version "/" name "-" version ".tar.bz2")) >> + (uri (string-append home-page "/releases/download/v" >> + version "/" name "-" version >> ".tar.gz")) > Since we're using github now, we likely want to use git-fetch > here. > I've been told Github releases are volatile. > > -- ( Their repo is not suitable for building from, instead they release sources manually. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLnaFQACgkQ6M7O0mLO BeJuqA//f3Iw7VMHIWnUixT04M92fmybkjrGtMqwM2lK1qsEFEP3ogAhhpbv96gL gb/rY1FbfzO6OSrhNk4JETdN4OjfR9ZtyQmBWnLdHIrQGDtTLr0CRu7nMUuFL2yc aVnPLADdQ1cOJcWkgYtuHEVh2ocVQL5s1p9G428xDF84G4wq/vWpvgwFsv1EJd1v ApiW3dw5vXVr+GWki+IGo3hxb4uOqbEHQLvtRrZzhvWMctu3mshdMpMj3z1dAQ9M zl3+fDW0NXTfUnQUzbChGGG4bUovujCq88MDIoqw/YY6DUNyAyV8UoRW+uw0wPcq qOc5rTVEPrGUg7YnPMWVk6VA5RkLqgk1ZnZIHUtbl84el+cX5RAGf6oZTXFR4MVw ZlKMzwyTMFMJzgjg/FXRYMBB9+jUoJT2uwN0SRvJeLF5ViCihWYx8CgFh8TXJFM4 1SuRcq01z0GNw9QmYmjtIzxpDjB+M6fCqU3XtafT/H/0w36zM7S1+41WVfRWQTC8 gbU/eDnu2RzzqOnUoi+jpPNdsbVQO6FYjhf2xPAiNw31wunhxlZxZqThp7yevQfq /eOQXz5wdYoKHjYxV+tMCVg+shlGTLMhOrpqQbeGa+ljdF+/NXWL7++UCuVOAaQ9 72iqq6+UtHsKotGULtzm8qGs1ri9weMsaK84bp2H24MQQXXGRSs= =uMux -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 01 05:02:59 2022 Received: (at 56858) by debbugs.gnu.org; 1 Aug 2022 09:02:59 +0000 Received: from localhost ([127.0.0.1]:39242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIRKF-000196-01 for submit@debbugs.gnu.org; Mon, 01 Aug 2022 05:02:59 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIRKD-00018t-6r for 56858@debbugs.gnu.org; Mon, 01 Aug 2022 05:02:58 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A4A6E40DB7; Mon, 1 Aug 2022 11:02:55 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id ZZXODh4TkYeS; Mon, 1 Aug 2022 11:02:54 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659344550; bh=3albHDsusBpaw9aYddagiegyHAGcr6lx6ssbjt9NKu0=; h=Date:Cc:Subject:From:To:References:In-Reply-To; b=Pmbct4o+Dzke9pZFVF9K8CbtnPr7PJGgDrCWey947UgNWOt7EPP4zobMCytt45ax2 9Y0l5/M5LQ6LCZ1Mm+0QwbBxCjbYWPApcyGyu6XPdQts/VKVchYJMwLqGfP6XUZTkh 5DlPcMsPSUvdFb3SxwJ4Pnfau1xilF49bwXUEWDaxGkGxSjUqhpAXnqh5WHjrorHgr L1eeSywe+OWAu9Egys7JByrkMHBm6+cBd6m8DGtYC0sjP4FE7gW6JQ/l1DOOa0+GpV QUS8CzsguRADL9dhq6cEip2uFkUvFzevO3f4/m5QT168zrLHuYly8KLN1zpXmnQNrg 7VU/VfzHjaTHg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 01 Aug 2022 10:02:30 +0100 Message-Id: Subject: Re: [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2. From: "(" To: "muradm" References: <20220731152938.28770-1-mail@muradm.net> <87sfmgplez.fsf@muradm.net> In-Reply-To: <87sfmgplez.fsf@muradm.net> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56858 Cc: 56858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote: > Is there a guideline where home-page should be? I find it more > DRY when reusing. Almost every package in Guix puts it directly above synopsis, though you do have a point about DRY. > Their repo is not suitable for building from, instead > they release sources manually. Looks okay to me: But there is a problem with vendoring googletest, it seems. You'll want to use the system's googletest, and (recursive? #t) in the git-reference to clone the tests repo. Also, the tarball seems to contain pregenerated autotools files, which are discouraged by Guix. -- ( From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 01 05:06:09 2022 Received: (at 56858) by debbugs.gnu.org; 1 Aug 2022 09:06:09 +0000 Received: from localhost ([127.0.0.1]:39250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIRNJ-0001GB-KB for submit@debbugs.gnu.org; Mon, 01 Aug 2022 05:06:09 -0400 Received: from knopi.disroot.org ([178.21.23.139]:39490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIRNH-0001Fy-JC for 56858@debbugs.gnu.org; Mon, 01 Aug 2022 05:06:08 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id EB67940DB1; Mon, 1 Aug 2022 11:06:06 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rXIsNxKUanVl; Mon, 1 Aug 2022 11:06:06 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659344765; bh=rA9AmLnxcU1uPs/5c5cQ0skxldguKsDNW5YLNl95AVs=; h=Date:Cc:Subject:From:To:References:In-Reply-To; b=b5DDxe108kUV7eWbhdsTYnuSuiNahaswy4WllJRKzkZWEk6EKEyt4gHgh/I/Dl/Oq n90hSZWHnz7U24QasKESpRr/i2Ae9vBSkHY7SBvSPhI1hoM6WZ9PTRNty4Tr75BstU YacgT131+qXB1lzjHo3stBZp4mSGFO7lj1R1bNzWmpVUVbdp/HF2HYGfeuqsvBZsxT 8UMkkAVY2AEU33Flw1zl9OuVw38BEHq3q+HHWt7paQ+acdkdzxJLWLw3D7UXK0riF3 dbX++7fmy90q66xmlBFFipHT1ZrNCL9H0CzdFz/0s7geUvY2lko6/Op+ZTV/UqPvqj nGGpNuiKkirlQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 01 Aug 2022 10:06:05 +0100 Message-Id: Subject: Re: [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2. From: "(" To: "(" , "muradm" References: <20220731152938.28770-1-mail@muradm.net> <87sfmgplez.fsf@muradm.net> In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56858 Cc: 56858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon Aug 1, 2022 at 10:02 AM BST, ( via Guix-patches via wrote: > (recursive? #t) in the git-reference to clone the tests repo. Alternatively, write an for the tests repo, then use that as an input for the libcgroup package. -- ( From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 01 09:17:42 2022 Received: (at 56858) by debbugs.gnu.org; 1 Aug 2022 13:17:42 +0000 Received: from localhost ([127.0.0.1]:39719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIVIk-0003Ap-6J for submit@debbugs.gnu.org; Mon, 01 Aug 2022 09:17:42 -0400 Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:54654 helo=nomad-cl1.muradm.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIVIi-0003Ac-St for 56858@debbugs.gnu.org; Mon, 01 Aug 2022 09:17:41 -0400 Received: from localhost ([127.0.0.1]:33142) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oIVID-0007mk-0R; Mon, 01 Aug 2022 13:17:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To :From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Gx/pxLEDyVI9eHz97FL1NIE4b65LqYS1pjTsfJzoJpw=; b=rDRXxwVvaeA1BSD5TT3m+0sQpS bmgMTEASNWTcQYZEguAqQTRK8XzZlEpUbKUcGvFbR7ZPb8Nxw83l2tjGq9pZmVLXeUFrJtuqXad8F BZabszJxpl2x00jDNhNxBqNOsJfvZWrLF0El3r5rjS4AVG/uhdHS7hsvaKGrul3KHPitewRJd1+kB W5fyRY9kA4MaTwAmMjWlLvTZtHlBA4oNMK6SzqpR/4AeaiAqDwPnuw8pu0r2sZnDLPe18N65IPyiJ xPlQxs0MztEfg4xpjELF7eC2wk8/uCHZOhUF+c8huXcQQMNDB2a/Bz/VhXssPzjvADCh+aX9APH6o xIfKVCgRfSEnHrmzUkIUcs8BEJm6JzsmSvz4AUjxEkLNbDNm1Z29ujKj98K1YfvnAqSPDdi1q48EB 4Ofj1SJvGuQad6M754NUPsVGSl7dtNw8xLBrOBtj0vMBrmvii5XodVIecC2H98I6qMJG3SWtLdOQ9 Z5y31MtvuXgccw3Q/z57LI6O; Received: from muradm by localhost with local (Exim 4.96) (envelope-from ) id 1oIVIc-0005EP-2L; Mon, 01 Aug 2022 16:17:34 +0300 References: <20220731152938.28770-1-mail@muradm.net> <87sfmgplez.fsf@muradm.net> User-agent: mu4e 1.8.7; emacs 29.0.50 From: muradm To: "(" Subject: Re: [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2. Date: Mon, 01 Aug 2022 16:13:48 +0300 In-reply-to: Message-ID: <87y1w8ays1.fsf@muradm.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56858 Cc: 56858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed Previous version was also built from sources. I didn't find it feasible to battle with bootstraping for this version either. Tests are very intrusive and/or containerized with lxc. So yeah, as per their process, there are tons of things to be done manually from bootstraping. May be sometime in the future if they will move to more modern project layout, that could become feasible. "(" writes: > On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote: >> Is there a guideline where home-page should be? I find it more >> DRY when reusing. > Almost every package in Guix puts it directly above synopsis, > though > you do have a point about DRY. > >> Their repo is not suitable for building from, instead >> they release sources manually. > Looks okay to me: > > But there is a problem with vendoring googletest, it seems. > You'll want > to use the system's googletest, and (recursive? #t) in the > git-reference > to clone the tests repo. Also, the tarball seems to contain > pregenerated > autotools files, which are discouraged by Guix. > > > -- ( --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLn0m4ACgkQ6M7O0mLO BeKdfxAAu0HXINxE00K8BRNKtXj+YRSni9qbQfCoaUvMl9qnRBxNYjTU1qeuinPD yYv+Ytsuw9SH6WdpFiBH8QDh/7SQjHkJs0ZNkTIFnvHbDpMbrjl497gnvr4fTuZI C1ulQVzPBgasCqTtpouX/I97DlNFRldX6EYzFgC/K0XKLu6yoJRwV0uAL/tFDT7+ /AZUOOfnM6eiHLW3gCeQe/BX31/pmND5aVmX+TyeDIKOJ5Hk/NCDAmYcyfKy7wND TIifJPGV22LY6sQob/RUTZPyAf4XU3t/LjCBz6heffFHHe6j30byNBDG/JOM0mtn V7HZ7TAddd4p/Yd7PEsvenvu2azAhoVILzuRnRej3RK/E/G7qUpurhfgTF2Vuycs Xje1PNRq+jj6xTUXhQX2z2e8z8F2iCUUHjlpcAYjN9WllGdv81uatqs14eRG48C6 lyi+HoeEplSdnlG1e5oh2L1kKdomfcbQfqxLWkOfMuSaaeLFcc8VQNGQYy+huwJv 2sfupdHfkBxucHsXFDFkCCIxLirBOT5I/hYC09/VZ/iyAe8i9zzkThTQ8FWrzXLO 3bvVvsJ7Hnp4/i531+zjSx1yFPrqD8ZvtIfaOLzY/ttM/BX0JORMjwclftU3XMkx 4azgDhwIFM1X+PVUHhbjtHbETRGwWzZJRBIwXZUIRnG4cwklcws= =XQGp -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 01:56:14 2022 Received: (at 56858) by debbugs.gnu.org; 4 Aug 2022 05:56:14 +0000 Received: from localhost ([127.0.0.1]:50825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJTqA-0005IP-HU for submit@debbugs.gnu.org; Thu, 04 Aug 2022 01:56:14 -0400 Received: from envs.net ([89.163.145.170]:37630 helo=mail.envs.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJTq6-0005IB-C0 for 56858@debbugs.gnu.org; Thu, 04 Aug 2022 01:56:13 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 665EC38A0658; Thu, 4 Aug 2022 05:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1659592566; bh=3J/mFTDjg6XYPQ4YRCpKpSoHS1PimlOpD3MwLn+cBQs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D3BEQIGa2nca119DjGBiRJDnh9EGZ5BCBQr3NWLo3dAyFGKdeS5R17y+G59GlP520 91CAMhenz8XfsiO5yjvZmGTqYbCHg4Z+PRz9r9M71mik9PGY3rY9cXRaWCtM/7GEGR J4LWDVzfmVphTTTewlsA94y2UuKBFTEY9v30iAW+QP4vT85SKmOVgVF8/qDHLDcWrz 7ZcyK+Zk3Us7+xyLdf0fWFe7CdBMZxicdHsOYHzEpo86rY9yC7SV29kjFu/YT5GBI4 LeKSf0JRMGeoe8SHjcW4a88AkCoW8wYikfMRXFxWMPvVR/KXOK1XIl2fQgumkCoqDw VwNqrWuSgB/RxYOXAyysHqYnEyINCTv7pi12ZjIS6O/h/XnF167jMot8sh4pEUBe8c sxdBYDQU5Xf5f/mU9VSEn+g/PDhQIORAvKeFSg29Aqupan5/sZzsndO47pJ0W0RXDR ZWGUdehgobNy8wuOQfA1jtj0nZKGzi53HFa1kVpfK850hDM99InhfTJNNtZUFeec4S 0xwUW+HUaxnG1GMSBw80T0XMrglG1u7Cf9kJRQXK5Ny4qUf7E76xKG+Ax+mN3IYJXB L8UO9ppebWR7gq5QntUb7MDdpvbeE+iQS9pbIdKeQKbafliu8k8xjE9yyLaUlMSzSJ 1Naa1ucv0Uh6R9NOi/rFQ448= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LzVO71n1ESJR; Thu, 4 Aug 2022 05:56:02 +0000 (UTC) Received: from localhost (unknown [182.150.116.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: iyzsong@envs.net) by mail.envs.net (Postfix) with ESMTPSA; Thu, 4 Aug 2022 05:56:02 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id df3cf9ed; Thu, 4 Aug 2022 05:55:57 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: "(" Subject: Re: bug#56858: [PATCH] gnu: libcgroup: Update to 2.0.2. References: <20220731152938.28770-1-mail@muradm.net> Date: Thu, 04 Aug 2022 13:55:57 +0800 In-Reply-To: (paren@disroot.org's message of "Sun, 31 Jul 2022 22:48:20 +0100") Message-ID: <87wnbor1qq.fsf_-_@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56858 Cc: muradm , 56858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "(" writes: > Hi! > > On Sun Jul 31, 2022 at 4:29 PM BST, muradm wrote: >> + (home-page "https://github.com/libcgroup/libcgroup") > Put home-page under inputs and above synopsis, where it was before. > >> (method url-fetch) >> - (uri (string-append >> - "mirror://sourceforge/libcg/" name "/" >> - version "/" name "-" version ".tar.bz2")) >> + (uri (string-append home-page "/releases/download/v" >> + version "/" name "-" version ".tar.gz")) > Since we're using github now, we likely want to use git-fetch here. > I've been told Github releases are volatile. Hello, I believe '/releases' are okay, since they are uploaded manual by the owner, the unstable ones are under '/archive' which are auto-generated tarballs for tags. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 11:37:19 2022 Received: (at 56858) by debbugs.gnu.org; 9 Aug 2022 15:37:19 +0000 Received: from localhost ([127.0.0.1]:44515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLRI9-0004IQ-U4 for submit@debbugs.gnu.org; Tue, 09 Aug 2022 11:37:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLRI7-0004IE-OG for 56858@debbugs.gnu.org; Tue, 09 Aug 2022 11:37:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLRI2-00047Y-2l; Tue, 09 Aug 2022 11:37:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ga56tLovIV1LqrDpRLer1PonCpwLXYEwO7lt2V0/Cdg=; b=LDWRxyEmlElvYd2nSmVC LaVTL2nYFDpPPI25Z6RVRho6eu7n6Ax1VW2Aro7+ZIPYaSHaEc0/wGYwBh58Q0cHe4PTwiE/1+WV8 YNORudej97bQAo48gaXK7PttO8u797SGWAz9wSp5lOTLafEGUHt83r/4YvlbWyhG5g30n+vpPEkRx rbX4u4IKeJcIbJdYimVdTQND8qSDtg0vnVGGUqs7TRSIGplj/otO/RmSvfggT92JP5gGn4rzkp4OH jsZbyLiqhnkcOZF4Ox/SZqMWYfuQO4Utjj/jkU1cUxDP68oP/q0H+uUnnl/RvmTywtkhM4DX5v34x 61N3mTDdY5Kv3A==; Received: from [193.50.110.201] (port=56142 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLRI1-00044l-IB; Tue, 09 Aug 2022 11:37:05 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "(" Subject: Re: bug#56858: [PATCH] gnu: libcgroup: Update to 2.0.2. References: <20220731152938.28770-1-mail@muradm.net> <87sfmgplez.fsf@muradm.net> Date: Tue, 09 Aug 2022 17:37:02 +0200 In-Reply-To: (paren@disroot.org's message of "Mon, 01 Aug 2022 10:02:30 +0100") Message-ID: <87bkst5syp.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56858 Cc: muradm , 56858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, "(" skribis: > On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote: >> Is there a guideline where home-page should be? I find it more >> DRY when reusing. > Almost every package in Guix puts it directly above synopsis, though > you do have a point about DRY. Yeah IMO it=E2=80=99s a good idea to reuse =E2=80=98home-page=E2=80=99 like= this patch does. >> Their repo is not suitable for building from, instead >> they release sources manually. > Looks okay to me: > But there is a problem with vendoring googletest, it seems. You'll want > to use the system's googletest, and (recursive? #t) in the git-reference > to clone the tests repo. Also, the tarball seems to contain pregenerated > autotools files, which are discouraged by Guix. So, first things first. The priority should be to run tests and remove the bundled googletest, which I tried with the patch below. Now, tests won=E2=80=99t run because apparently they try to use =E2=80=98su= do=E2=80=99 (!): --8<---------------cut here---------------start------------->8--- Traceback (most recent call last): File "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/= ./ftests.py", line 353, in sys.exit(main(config)) File "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/= ./ftests.py", line 337, in main setup(config, record_time=3DTrue) File "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/= ./ftests.py", line 170, in setup Run.run(['sudo', 'lxd', 'init', '--auto']) File "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/= run.py", line 38, in run subproc =3D subprocess.Popen(command, shell=3Dshell_bool, File "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python= 3.9/subprocess.py", line 951, in __init__ self._execute_child(args, executable, preexec_fn, close_fds, File "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python= 3.9/subprocess.py", line 1821, in _execute_child raise child_exception_type(errno_num, err_msg, err_filename) FileNotFoundError: [Errno 2] No such file or directory: 'sudo' FAIL ftests.sh (exit status: 1) --8<---------------cut here---------------end--------------->8--- Could you check whether they can run at all without root privileges, and if not, document it in a comment above #:tests? #f? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index e70d8d1a90..7eb309dfa5 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -8177,14 +8177,18 @@ (define-public libcgroup (uri (string-append home-page "/releases/download/v" version "/" name "-" version ".tar.gz")) (sha256 - (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) + (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")) + (modules '((guix build utils))) + (snippet + ;; Delete the bundled copy of googletest, that even includes a .so. + '(delete-file-recursively "googletest")))) (build-system gnu-build-system) - (arguments - `(#:tests? #f)) + ;; (arguments + ;; `(#:tests? #f)) (native-inputs - (list bison flex)) + (list bison flex python-wrapper)) (inputs - (list linux-pam)) + (list linux-pam googletest)) (synopsis "Control groups management tools") (description "Control groups is Linux kernel method for process resource restriction, permission handling and more. This package provides userspace --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 16:34:43 2022 Received: (at 56858) by debbugs.gnu.org; 9 Aug 2022 20:34:43 +0000 Received: from localhost ([127.0.0.1]:45201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLVw2-0004DE-NK for submit@debbugs.gnu.org; Tue, 09 Aug 2022 16:34:43 -0400 Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:34288 helo=nomad-cl1.muradm.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLVvx-0004Cz-OO for 56858@debbugs.gnu.org; Tue, 09 Aug 2022 16:34:40 -0400 Received: from localhost ([127.0.0.1]:41150) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oLVvH-0002Qf-1t; Tue, 09 Aug 2022 20:33:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To :From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uocannNtvB5N16c6CRJj1wAoZIlZDKML/ByY61La+rI=; b=ID5LaBZCXv4Z27/k5235C+TOS2 a6JfTQQ3LRHsIFK4ZZaxwalCAt/IoD57YL/pIvkDefwqYMDWsrana0Ikl1vff/JjIgHYuiYoZD0x1 /HAWdjCDzQgJyU7C398YW69ELuS1qOCEH3LVd/UuxhKT793P/QAE0Ka5PO217D89n7/aeA4BNUga0 Nu+OpQrXx73WFSjWbOyYKmu7Bw/gZ+Gtd4P5IbuCgnRtOYvum5bksrM9wchf8YtOg4w0LhHbF49Gw Hh1A4SucYTEpNMmcHXgavzLPrlKR8FFSo0p17mE6UQz+jATx3EI1ZyvSJ34lNZTwEzXuBZnEv1CRT GrWcUVbLf9T8IGz5kQX+y7JxuRWAsaMrASvkRYZ5xFwgmc96JtApbonRdWhFVURIqxEhLG/goJUnr pQp9CrUILhqw2i76BgCkBY+4VY95MAQiBulHolCeZpXjqWFZZjzoItdEyNpC2zz1+uM5ewwkYVe8W cEm6r67na5tHjGXbMZLBpi/p; Received: from muradm by localhost with local (Exim 4.96) (envelope-from ) id 1oLVvk-0007uk-2P; Tue, 09 Aug 2022 23:34:24 +0300 References: <20220731152938.28770-1-mail@muradm.net> <87sfmgplez.fsf@muradm.net> <87bkst5syp.fsf_-_@gnu.org> User-agent: mu4e 1.8.7; emacs 29.0.50 From: muradm To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#56858: [PATCH] gnu: libcgroup: Update to 2.0.2. Date: Tue, 09 Aug 2022 23:29:09 +0300 In-reply-to: <87bkst5syp.fsf_-_@gnu.org> Message-ID: <87tu6lxijz.fsf@muradm.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Ludovic Courtès writes: > Hi, > > "(" skribis: > >> On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote: >>> Is there a guideline where home-page should be? I find it more >>> DRY when reusing. >> Almost ever [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist [URIs: muradm.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 56858 Cc: "\(" , 56858@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > "(" skribis: > >> On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote: >>> Is there a guideline where home-page should be? I find it more >>> DRY when reusing. >> Almost every package in Guix puts it directly above synopsis,=20 >> though >> you do have a point about DRY. > > Yeah IMO it=E2=80=99s a good idea to reuse =E2=80=98home-page=E2=80=99 li= ke this patch=20 > does. > >>> Their repo is not suitable for building from, instead >>> they release sources manually. >> Looks okay to me:=20 >> >> But there is a problem with vendoring googletest, it seems.=20 >> You'll want >> to use the system's googletest, and (recursive? #t) in the=20 >> git-reference >> to clone the tests repo. Also, the tarball seems to contain=20 >> pregenerated >> autotools files, which are discouraged by Guix. > > So, first things first. The priority should be to run tests and=20 > remove > the bundled googletest, which I tried with the patch below. > > Now, tests won=E2=80=99t run because apparently they try to use =E2=80=98= sudo=E2=80=99=20 > (!): > > Traceback (most recent call last): > File=20 > "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./f= tests.py",=20 > line 353, in > sys.exit(main(config)) > File=20 > "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./f= tests.py",=20 > line 337, in main > setup(config, record_time=3DTrue) > File=20 > "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./f= tests.py",=20 > line 170, in setup > Run.run(['sudo', 'lxd', 'init', '--auto']) > File=20 > "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/run= .py",=20 > line 38, in run > subproc =3D subprocess.Popen(command, shell=3Dshell_bool, > File=20 > "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9= /subprocess.py",=20 > line 951, in __init__ > self._execute_child(args, executable, preexec_fn, close_fds, > File=20 > "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9= /subprocess.py",=20 > line 1821, in _execute_child > raise child_exception_type(errno_num, err_msg, err_filename) > FileNotFoundError: [Errno 2] No such file or directory: 'sudo' > FAIL ftests.sh (exit status: 1) > > Could you check whether they can run at all without root=20 > privileges, and > if not, document it in a comment above #:tests? #f? unfortunately, tests are executed virtualized with lxc/lxd, while technically it seems to be possible to execute them, but it will=20 require fixing (but probably rewriting) python test runner code. Possible=20 but not feasible i think. On the other hand, as far as it is mentioned in their release=20 process, sources release tarball is releaced after tests passing. ;; tests are virtualized with lxc/lxd, it is not very feasible ;; to make them executable under guix build Will this commend do the work? > Thanks, > Ludo=E2=80=99. > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index e70d8d1a90..7eb309dfa5 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -8177,14 +8177,18 @@ (define-public libcgroup > (uri (string-append home-page "/releases/download/v" > version "/" name "-" version=20 > ".tar.gz")) > (sha256 > - (base32=20 > "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) > + (base32=20 > "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")) > + (modules '((guix build utils))) > + (snippet > + ;; Delete the bundled copy of googletest, that even=20 > includes a .so. > + '(delete-file-recursively "googletest")))) > (build-system gnu-build-system) > - (arguments > - `(#:tests? #f)) > + ;; (arguments > + ;; `(#:tests? #f)) > (native-inputs > - (list bison flex)) > + (list bison flex python-wrapper)) > (inputs > - (list linux-pam)) > + (list linux-pam googletest)) > (synopsis "Control groups management tools") > (description "Control groups is Linux kernel method for=20 > process resource > restriction, permission handling and more. This package=20 > provides userspace --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLyxNAACgkQ6M7O0mLO BeK3fw//XYfbkJlA9cP8IF8G/v4F9ev+26AwIG7YHjM45qMK7Pa3CeK3a2MNI5O9 v2PzHaPmsyaz7Sb1H9rz+RqWkuGalsbakxsTfDLFu3a6i4fuK4zElktzyTdpyRCc jo5u4GofX0Dkb5OuRs65frDdaAdtxaL6deQdfpbZEjDY+a3q8Mt/huMnKHUV7GHQ rpd0q9hSMVpUiYIaMYG7Ojp8CO7q3rm8r+IAMsiIBu08PjnSYgu6BunKl8TTj3lI GU3mRCdkPxModztTULf41g5jL1vH6AtXlv5a27bocwTzXTAlX7dP3dnUIEBsKG3s UP5cpZej8sHRJvbiYoMTnKeP5G3H8aBVKWXJQ/rpKSVI58Tm7uySySpSaFKAZeeB 1xwja9Pq55/tlxkE2iqPT6NQldIem1NRAsXdolcXtqvzlU7Tn6fyB984QbpHY3W3 XMXrkui5AW40ehLv9F5rZvLkuTXKfJBuJyO6etZ18QwQuEJG0OYFBglmA7XyNrBa 64M/3kK8DHieOImVjDVHBUffHrw/U/kdAE5kEAznFFrDZwlmFX2U2JdUkhojiy3D i352GL6NdLAeueWcH8w9XBklE5ETaXQigAnVs55x2z8a2S/yJ42BcPrFBMEcV9s1 +i/VH+ujGxH7F8rPPReoORzaWy8zqCXoIBi+UzDPrpjlDiMdl8o= =bggf -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 17:10:37 2022 Received: (at 56858) by debbugs.gnu.org; 23 Aug 2022 21:10:37 +0000 Received: from localhost ([127.0.0.1]:45178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQbAS-0002Tg-VE for submit@debbugs.gnu.org; Tue, 23 Aug 2022 17:10:37 -0400 Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:59094 helo=nomad-cl1.muradm.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQbAR-0002TQ-TB for 56858@debbugs.gnu.org; Tue, 23 Aug 2022 17:10:36 -0400 Received: from localhost ([127.0.0.1]:54290) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oQb9W-0006pC-0o; Tue, 23 Aug 2022 21:09:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KrcUsaT1Y2ru4t/cTy8sgm0BfensR0hc/OHMg6nWYDw=; b=XuWoAViDFxvApqQ676eZNTJAqY ri5a0YYHTPdsHk7TQDlJvofI2foxPFVZZTgwYs1y3l+DCaJrGNTRGZyJBL0CXElMNnbhHVwXPSldH ohR2limZzQVUehbxfUQV1aoYR4hYWCeBO6qDqrf6iEv6qe78Nb1bLKRa5LnzqNfnVRbcTV3hoXCAh 5EG/XR9fEazoi3yC8crUuN0rpU+Rb590SgVfhTBI/K2SBUDP00lB/fpX0NPko1EBmblx71A8PnyD2 86jFY0HO+xKnfm/YoQAltxZQA5PpZ7BgECHjtVoerhYEI/BU4QYzsSnW95gIGq045YpNnP+XDhhUq puwAv0VQ+J3WEFrHXODrEWhlMoDgDRXLMHUBDwUMCsL37+yIlqkTRBD05t2BiS0ChKTmVdIXbXsh/ 8QKXffLWhKwtaD9rTq/SIaMsfyFuQ5ydecrVKUXMdyYOhwog99QDj6x1anZOoyZzcAXiWIMIdPSJ+ syX1FZTcD+7BySwEYLIJxRDG; Received: from muradm by localhost with local (Exim 4.96) (envelope-from ) id 1oQbAL-0007bY-0J; Wed, 24 Aug 2022 00:10:29 +0300 From: muradm To: 56858@debbugs.gnu.org, ludo@gnu.org Subject: [PATCH v2] gnu: libcgroup: Update to 2.0.2. Date: Wed, 24 Aug 2022 00:10:29 +0300 Message-Id: <20220823211029.29228-1-mail@muradm.net> X-Mailer: git-send-email 2.37.1 In-Reply-To: <87tu6lxijz.fsf@muradm.net> References: <87tu6lxijz.fsf@muradm.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56858 Cc: paren@disroot.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/linux.scm (libcgroup): Update to 2.0.2. [source]: Project migrated to github. --- gnu/packages/linux.scm | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index a7d92816a8..6ea26b315c 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -63,6 +63,7 @@ ;;; Copyright © 2021, 2022 Petr Hodina ;;; Copyright © 2022 Artyom V. Poptsov ;;; Copyright © 2022 Rene Saavedra +;;; Copyright © 2022 muradm ;;; ;;; This file is part of GNU Guix. @@ -8089,23 +8090,26 @@ (define-public fbcat (define-public libcgroup (package (name "libcgroup") - (version "0.41") + (version "2.0.2") + (home-page "https://github.com/libcgroup/libcgroup") (source (origin (method url-fetch) - (uri (string-append - "mirror://sourceforge/libcg/" name "/" - version "/" name "-" version ".tar.bz2")) + (uri (string-append home-page "/releases/download/v" + version "/" name "-" version ".tar.gz")) (sha256 - (base32 "0lgvyq37gq84sk30sg18admxaj0j0p5dq3bl6g74a1ppgvf8pqz4")))) + (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) (build-system gnu-build-system) (arguments + ;; Tests are virtualized with lxc, it is not very feasible + ;; to make them executable under guix build. Also, note that + ;; origin is using source tarball release which is prepared + ;; after testing. `(#:tests? #f)) (native-inputs (list bison flex)) (inputs (list linux-pam)) - (home-page "https://sourceforge.net/projects/libcg/") (synopsis "Control groups management tools") (description "Control groups is Linux kernel method for process resource restriction, permission handling and more. This package provides userspace -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 31 06:38:25 2022 Received: (at 56858-done) by debbugs.gnu.org; 31 Aug 2022 10:38:25 +0000 Received: from localhost ([127.0.0.1]:38314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTL73-0006Ql-DU for submit@debbugs.gnu.org; Wed, 31 Aug 2022 06:38:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTL71-0006QY-IF for 56858-done@debbugs.gnu.org; Wed, 31 Aug 2022 06:38:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTL6w-0008VO-4e; Wed, 31 Aug 2022 06:38:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=sWWLGVrh0VmgKimsG/o0AtuwTb1d7ywES/DWlCu/wqg=; b=gShLqpMvvEEhnc7Xd7Qy VLo6xzbLWV1t+DAnvByAPJkCsHzlCs5pTZo3p6CbTeGOvTbsDcVejAmb/A1tm+3bSl0aHS9XAFVxV YHK0J2qj1PRzxT5yQPKb81vxPzc+IrPQh8Wj1VF1H3nvvOWzkfGuuZk/ENcL+eOpbCjJZpfrWJDXR VDWWVN8axJ1/MogJtYwPxdCfcTpRJ2dy3Zpmpz/vxAaQnc1l52HlvRkutW7vg001ekbY1GC54Eamk YfNyd8TxyKn/uWDog02RBVbOQ8444RmAEEq4GtvCaMBO8axly0XpcXV+IrotAcZOC4ng5gjxjXXPt Jh5rqH6YHMInRQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:62261 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTL6u-0001cv-Sz; Wed, 31 Aug 2022 06:38:17 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: muradm Subject: Re: [PATCH v2] gnu: libcgroup: Update to 2.0.2. References: <87tu6lxijz.fsf@muradm.net> <20220823211029.29228-1-mail@muradm.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 14 Fructidor an 230 de la =?utf-8?Q?R=C3=A9?= =?utf-8?Q?volution=2C?= jour de la Noix X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 31 Aug 2022 12:38:15 +0200 In-Reply-To: <20220823211029.29228-1-mail@muradm.net> (muradm's message of "Wed, 24 Aug 2022 00:10:29 +0300") Message-ID: <87wnaobsvc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56858-done Cc: paren@disroot.org, 56858-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, muradm skribis: > * gnu/packages/linux.scm (libcgroup): Update to 2.0.2. > [source]: Project migrated to github. Applied, thanks! Ludo=E2=80=99. From unknown Sat Jun 21 03:21:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 28 Sep 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator