Subject: Re: bug#56846: [PATCH] FeatherNotes package

From: 宋文武 <[email-masked]>
Date: Wed, 03 Aug 2022 09:28:55 +0800

Pavel Shlyak <[email-masked]> writes:

> I updated the patch as qt5 packages were renamed.

Hello, I'm not a native English speaker, well some comments about
wording follow:
>
> From 17daab0381b5d69d6be59c5aa415b3f1fefeaba7 Mon Sep 17 00:00:00 2001
> From: Pavel Shlyak <[email-masked]>
> Date: Sun, 31 Jul 2022 01:19:07 +0300
> Subject: [PATCH] gnu: feathernotes: new package.
>
>      * gnu/packages/task-management.scm (feathernotes): new package.
When adding a new package, the "tradition" is:

gnu: Add feathernotes.

* gnu/packages/task-management.scm (feathernotes): New package.

> ---
>  gnu/packages/task-management.scm | 35 +++++++++++++++++++++++++++++++-
>  1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/task-management.scm b/gnu/packages/task-management.scm
> index f8f52a8ccd..93e784da18 100644
> --- a/gnu/packages/task-management.scm
> +++ b/gnu/packages/task-management.scm
> @@ -1,10 +1,13 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2015 Tomáš Čech <[email-masked]>
>  ;;; Copyright © 2020 Vinicius Monego <[email-masked]>
> +;;; Copyright © 2020 Hamzeh Nasajpour <[email-masked]>
>  ;;; Copyright © 2021 Eric Bavier <[email-masked]>
>  ;;; Copyright © 2021 Stefan Reichör <[email-masked]>
>  ;;; Copyright © 2021 LibreMiami <[email-masked]>
> +;;; Copyright © 2021 Reza Alizadeh Majd <[email-masked]>

Why here are 2020 and 2021 changes?

>  ;;; Copyright © 2022 Foo Chuan Wei <[email-masked]>
> +;;; Copyright © 2022 Pavel Shlyak <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -32,6 +35,7 @@ (define-module (gnu packages task-management)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gstreamer)
>    #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages libreoffice)  ;for hunspell
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages lua)
>    #:use-module (gnu packages ncurses)
> @@ -39,6 +43,7 @@ (define-module (gnu packages task-management)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages python-build)
>    #:use-module (gnu packages python-xyz)
> +  #:use-module (gnu packages qt)
>    #:use-module (gnu packages time)
>    #:use-module (gnu packages tls)
>    #:use-module (guix download)
> @@ -49,7 +54,8 @@ (define-module (gnu packages task-management)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system go)
>    #:use-module (guix build-system meson)
> -  #:use-module (guix build-system python))
> +  #:use-module (guix build-system python)
> +  #:use-module (guix build-system qt))
>  
>  (define-public clikan
>    (let ((commit "55ab29e68263c6fed2844aef96fbebacda3eba9b")
> @@ -281,6 +287,33 @@ (define-public blanket
>  You can also use it to fall asleep in a noisy environment.")
>      (license license:gpl3+)))
>  
> +(define-public feathernotes
> +  (package
> +    (name "feathernotes")
> +    (version "0.10.0")
> +    (home-page "https://github.com/tsujan/FeatherNotes")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)
> +                    (commit (string-append "V" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "122pbbxvi0mmhbz8m8far71vm72090r5cafss4hvrsjmq52a0y4k"))))
> +    (build-system qt-build-system)
> +    (arguments (list #:tests? #f))           ; no upstream tests
> +    (native-inputs (list pkg-config qttools-5))           ; for lrelease
> +    (inputs (list hunspell qtsvg-5 qtx11extras qtbase-5))
> +    (synopsis "GUI hierarchical notes-manager")

Maybe "notes manager" is better than "notes-manager"?
> +    (description "FeatherNotes is a GUI hierarchical notes-manager for Linux.
> +It is independent of any desktop environment and has
> +rich text formatting, image embedding and inserting editable tables
Seem missing a "," after "editable tables".

> +spell checking, searchable tags, drag and drop support, tray icon,
> +node icons, hyperlinks, pdf and html export, password protection
> +and auto-saving.")
> +    (license license:gpl3+)))
> +
>  (define-public wtime
>    (package
>      (name "wtime")

Otherwise it looks good to me, thank you!