GNU bug report logs - #56846
[PATCH] FeatherNotes package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56846 in the body.
You can then email your comments to 56846 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pavel Shlyak <p.shlyak <at> pantherx.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] FeatherNotes package 
Date: Sun, 31 Jul 2022 01:50:23 +0300

[Message part 1 (text/plain, inline)]

Hello!

Here is my patch to add FeatherNotes package to guix. I upstream it from PantherX channel, hence 3 copyright lines.
I build it against Qt5 as Qt6 support in FeatherNotes is experimental and is not recommended for daily usage yet.

Thank you in advance for your feedback.
Have a nice day!

[0001-gnu-feathernotes-new-package.patch (application/octet-stream, attachment)]

Message #8 received at 56846 <at> debbugs.gnu.org (full text, mbox):

From: Pavel Shlyak <p.shlyak <at> pantherx.org>
To: 56846 <at> debbugs.gnu.org
Subject: [PATCH] FeatherNotes package
Date: Tue, 2 Aug 2022 01:11:31 +0300

[Message part 1 (text/plain, inline)]

I updated the patch as qt5 packages were renamed.

[0001-gnu-feathernotes-new-package.patch (application/octet-stream, attachment)]

Message #11 received at 56846 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Pavel Shlyak <p.shlyak <at> pantherx.org>
Cc: 56846 <at> debbugs.gnu.org
Subject: Re: bug#56846: [PATCH] FeatherNotes package 
Date: Wed, 03 Aug 2022 09:28:55 +0800

Pavel Shlyak <p.shlyak <at> pantherx.org> writes:

> I updated the patch as qt5 packages were renamed.

Hello, I'm not a native English speaker, well some comments about
wording follow:
>
> From 17daab0381b5d69d6be59c5aa415b3f1fefeaba7 Mon Sep 17 00:00:00 2001
> From: Pavel Shlyak <p.shlyak <at> pantherx.org>
> Date: Sun, 31 Jul 2022 01:19:07 +0300
> Subject: [PATCH] gnu: feathernotes: new package.
>
>      * gnu/packages/task-management.scm (feathernotes): new package.
When adding a new package, the "tradition" is:

gnu: Add feathernotes.

* gnu/packages/task-management.scm (feathernotes): New package.


> ---
>  gnu/packages/task-management.scm | 35 +++++++++++++++++++++++++++++++-
>  1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/task-management.scm b/gnu/packages/task-management.scm
> index f8f52a8ccd..93e784da18 100644
> --- a/gnu/packages/task-management.scm
> +++ b/gnu/packages/task-management.scm
> @@ -1,10 +1,13 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2015 Tomáš Čech <sleep_walker <at> suse.cz>
>  ;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
> +;;; Copyright © 2020 Hamzeh Nasajpour <h.nasajpour <at> pantherx.org>
>  ;;; Copyright © 2021 Eric Bavier <bavier <at> posteo.net>
>  ;;; Copyright © 2021 Stefan Reichör <stefan <at> xsteve.at>
>  ;;; Copyright © 2021 LibreMiami <packaging-guix <at> libremiami.org>
> +;;; Copyright © 2021 Reza Alizadeh Majd <r.majd <at> pantherx.org>

Why here are 2020 and 2021 changes?

>  ;;; Copyright © 2022 Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
> +;;; Copyright © 2022 Pavel Shlyak <p.shlyak <at> pantherx.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -32,6 +35,7 @@ (define-module (gnu packages task-management)
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gstreamer)
>    #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages libreoffice)  ;for hunspell
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages lua)
>    #:use-module (gnu packages ncurses)
> @@ -39,6 +43,7 @@ (define-module (gnu packages task-management)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages python-build)
>    #:use-module (gnu packages python-xyz)
> +  #:use-module (gnu packages qt)
>    #:use-module (gnu packages time)
>    #:use-module (gnu packages tls)
>    #:use-module (guix download)
> @@ -49,7 +54,8 @@ (define-module (gnu packages task-management)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system go)
>    #:use-module (guix build-system meson)
> -  #:use-module (guix build-system python))
> +  #:use-module (guix build-system python)
> +  #:use-module (guix build-system qt))
>  
>  (define-public clikan
>    (let ((commit "55ab29e68263c6fed2844aef96fbebacda3eba9b")
> @@ -281,6 +287,33 @@ (define-public blanket
>  You can also use it to fall asleep in a noisy environment.")
>      (license license:gpl3+)))
>  
> +(define-public feathernotes
> +  (package
> +    (name "feathernotes")
> +    (version "0.10.0")
> +    (home-page "https://github.com/tsujan/FeatherNotes")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)
> +                    (commit (string-append "V" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "122pbbxvi0mmhbz8m8far71vm72090r5cafss4hvrsjmq52a0y4k"))))
> +    (build-system qt-build-system)
> +    (arguments (list #:tests? #f))           ; no upstream tests
> +    (native-inputs (list pkg-config qttools-5))           ; for lrelease
> +    (inputs (list hunspell qtsvg-5 qtx11extras qtbase-5))
> +    (synopsis "GUI hierarchical notes-manager")

Maybe "notes manager" is better than "notes-manager"?
> +    (description "FeatherNotes is a GUI hierarchical notes-manager for Linux.
> +It is independent of any desktop environment and has
> +rich text formatting, image embedding and inserting editable tables
Seem missing a "," after "editable tables".

> +spell checking, searchable tags, drag and drop support, tray icon,
> +node icons, hyperlinks, pdf and html export, password protection
> +and auto-saving.")
> +    (license license:gpl3+)))
> +
>  (define-public wtime
>    (package
>      (name "wtime")

Otherwise it looks good to me, thank you!

Message #14 received at 56846 <at> debbugs.gnu.org (full text, mbox):

From: Pavel Shlyak <p.shlyak <at> pantherx.org>
To: 宋文武 <iyzsong <at> envs.net>
Cc: 56846 <at> debbugs.gnu.org
Subject: Re: bug#56846: [PATCH] FeatherNotes package 
Date: Wed, 3 Aug 2022 11:16:28 +0300

> Maybe "notes manager" is better than "notes-manager"?

I copied the this from the original README (https://github.com/tsujan/FeatherNotes/blob/master/README.md)

> Why here are 2020 and 2021 changes?

Because I upstream this package from another repo where it was packaged long time ago.

> Seem missing a "," after "editable tables».

Yes

> When adding a new package, the "tradition" is:

I would be happy if it was edited during merge.

Message #19 received at 56846-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Pavel Shlyak <p.shlyak <at> pantherx.org>
Cc: 56846-done <at> debbugs.gnu.org
Subject: Re: bug#56846: [PATCH] FeatherNotes package 
Date: Thu, 04 Aug 2022 09:23:20 +0800

Pavel Shlyak <p.shlyak <at> pantherx.org> writes:

>> Maybe "notes manager" is better than "notes-manager"?
>
> I copied the this from the original README (https://github.com/tsujan/FeatherNotes/blob/master/README.md)
>
>> Why here are 2020 and 2021 changes?
>
> Because I upstream this package from another repo where it was packaged long time ago.
>
>> Seem missing a "," after "editable tables».
>
> Yes
>
>> When adding a new package, the "tradition" is:
>
> I would be happy if it was edited during merge.

Done, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.