GNU bug report logs - #56821
[PATCH] * subr.el (buffer-match-p): Add t as trivial a condition

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56821 in the body.
You can then email your comments to 56821 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] * subr.el (buffer-match-p): Add t as trivial a condition
Date: Fri, 29 Jul 2022 12:01:32 +0000

[Message part 1 (text/plain, inline)]

Tags: patch


The proposed patch adds a simple condition to buffer-match-p, that had
previously either be expressed using an empty string (or any regular
expression that matches all words), an empty (and) or a symbol like
`always'.  I think it would be intuitive to add t, especially when
considering new user options like `outline-minor-mode-use-buttons' being
added that indicate they should be used as boolean value.

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6)
 of 2022-07-29 built on rhea
Repository revision: dedd05d2831d650b07cd9f0c639bdc8eb3bef1e4
Repository branch: master
System Description: Fedora Linux 36 (Workstation Edition)

Configured using:
 'configure --with-pgtk --with-imagemagick 'CFLAGS=-march=native -O2
 -pipe' LDFLAGS=-flto'

[0001-subr.el-buffer-match-p-Add-t-as-trivial-a-condition.patch (text/patch, attachment)]

Message #8 received at 56821 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 56821 <at> debbugs.gnu.org
Subject: Re: bug#56821: [PATCH] * subr.el (buffer-match-p): Add t as trivial
 a condition
Date: Fri, 29 Jul 2022 14:04:31 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

> The proposed patch adds a simple condition to buffer-match-p, that had
> previously either be expressed using an empty string (or any regular
> expression that matches all words), an empty (and) or a symbol like
> `always'.  I think it would be intuitive to add t, especially when
> considering new user options like `outline-minor-mode-use-buttons' being
> added that indicate they should be used as boolean value.

Makes sense to me.

Message #11 received at 56821 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philip.kaludercic <at> fau.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56821 <at> debbugs.gnu.org
Subject: Re: bug#56821: [PATCH] * subr.el (buffer-match-p): Add t as trivial
 a condition
Date: Fri, 29 Jul 2022 17:54:19 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> The proposed patch adds a simple condition to buffer-match-p, that had
>> previously either be expressed using an empty string (or any regular
>> expression that matches all words), an empty (and) or a symbol like
>> `always'.  I think it would be intuitive to add t, especially when
>> considering new user options like `outline-minor-mode-use-buttons' being
>> added that indicate they should be used as boolean value.
>
> Makes sense to me.

Ok, I would push the commit in that case.

Message #16 received at 56821-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56821-done <at> debbugs.gnu.org
Subject: Re: bug#56821: [PATCH] * subr.el (buffer-match-p): Add t as trivial
 a condition
Date: Sat, 30 Jul 2022 10:43:22 +0000

Philip Kaludercic <philip.kaludercic <at> fau.de> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> Philip Kaludercic <philipk <at> posteo.net> writes:
>>
>>> The proposed patch adds a simple condition to buffer-match-p, that had
>>> previously either be expressed using an empty string (or any regular
>>> expression that matches all words), an empty (and) or a symbol like
>>> `always'.  I think it would be intuitive to add t, especially when
>>> considering new user options like `outline-minor-mode-use-buttons' being
>>> added that indicate they should be used as boolean value.
>>
>> Makes sense to me.
>
> Ok, I would push the commit in that case.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.