GNU bug report logs - #56815
29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 56815 <at> debbugs.gnu.org, larsi <at> gnus.org, juri <at> linkov.net
Subject: bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect
Date: Tue, 02 Aug 2022 14:10:21 +0300

> Date: Tue, 02 Aug 2022 07:31:16 +0000
> From: Gregory Heytings <gregory <at> heytings.org>
> cc: Eli Zaretskii <eliz <at> gnu.org>, 56815 <at> debbugs.gnu.org, larsi <at> gnus.org
> 
> 
> >> So if no good ideas arise that are simple enough to implement, I'm okay 
> >> with simply disabling isearch-lazy-highlight in such buffers, as I 
> >> wrote in the original bug report.  (Doing that will probably require 
> >> exposing the "long-lines" flag to Lisp, but that's fine by me.)
> >
> > Exposing the "long-lines" flag to Lisp is exactly what is needed.
> >
> 
> My current plan is to run a hook when long lines are detected, in which 
> modes such as isearch will be free to add any function they like.

I'm not sure I agree that a hook is a better interface.  A hook is
only useful to features that are already turned on when the hook is
called; features that are turned on later will miss it.

By contrast, an accessor function can be called at any time, and for
an attribute that, once set remains set, I think it's a more
convenient way of adapting features and packages to this condition.

Or am I missing something?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.