GNU bug report logs - #56815
29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect

Previous Next

Full log

Message #20 received at 56815 <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 56815 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#56815: 29.0.50; Isearch lazy-highlight highlights too much
 when truncate-lines is in effect
Date: Fri, 29 Jul 2022 18:37:55 +0000

>> Would it be possibly to make the isearch lazy-highlight just skip the 
>> portions of the buffer that aren't visible?
>
> Indeed what is worth trying is to add pos-visible-in-window-group-p 
> either to isearch-filter-predicate, or directly to 
> isearch-lazy-highlight-search.
>

That wouldn't work alas.

The problem is how "visible" is defined here (by pos-visible-in-window-p). 
With truncated lines, all buffer positions between window-start and 
window-end are "visible", or IOW, all buffer positions on the left or 
right of the actually visible line portion are "visible".

Moreover pos-visible-in-window-p is a slow function, so it would be 
terribly slow to call it for each candidate position in a buffer with 
(tens of) thousands of candidate positions.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.