From unknown Mon Aug 18 17:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56813] [PATCH 0/2] Add a test for qemu-guest-agent service Resent-From: Timotej Lazar Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Jul 2022 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56813 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56813@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16590202891307 (code B ref -1); Thu, 28 Jul 2022 14:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jul 2022 14:58:09 +0000 Received: from localhost ([127.0.0.1]:59244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH4xl-0000L0-4v for submit@debbugs.gnu.org; Thu, 28 Jul 2022 10:58:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:40048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH4xf-0000Kn-Lw for submit@debbugs.gnu.org; Thu, 28 Jul 2022 10:58:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4xf-0006wk-Fg for guix-patches@gnu.org; Thu, 28 Jul 2022 10:58:03 -0400 Received: from araneo.si ([2001:15c0:2110:3400::2]:55292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4xd-00028s-6s for guix-patches@gnu.org; Thu, 28 Jul 2022 10:58:02 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 3d5df7b0 for ; Thu, 28 Jul 2022 14:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=20180623; bh=/V4K8Fm0S6wYFKF4KpwJf FC3I8o=; b=TL/9HACqWtqPiJhlgrZX74XP/5awaIU7OMBBZsypQSPankUnn4vSD Zat2Lcgy9Y3NpCw4mpCDSVsKnIN9I8mdyRcNCo+5ovgy8NM482GUXHr9ascc9dKs 2uVYcf/JqF+i+0Iu8IEVEmF/7MtSeUwi9pncKme3BHovZYkcN5g1fIxyHdHWm0OQ iUlcF5jsnb7FaUEXlUZhJjy2Lx2hYvjmPIUJ7brt1Hnw1ljkr0TnTSeXatCGswwl x2+F9KCj4ArPSqnsJ+ftB4A63w9KGp8JUcwy7tWmepuZ+4jHXmIEJf4dCt7DFg1o IRIj5c6vpIUGPZUU7Y45UTbcZZEnewBMQ== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 079c3904 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 28 Jul 2022 14:57:55 +0000 (UTC) From: Timotej Lazar Date: Thu, 28 Jul 2022 16:57:55 +0200 Message-ID: <87y1wdb7yk.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:15c0:2110:3400::2; envelope-from=timotej.lazar@araneo.si; helo=araneo.si X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, these patches fix some issues with the QEMU guest agent service, and add a system test for it. The test runs the service in a marionette VM and tries communicating with it. For that, I enabled the guest agent serial device in marionette QEMU options. This change touches all system tests, but should be harmless. I=E2=80=99m not sure if it would be better instead to add a keyword argumen= t to make-marionette for (extra) extra QEMU options. In any case, all tests that pass on master still pass after this change, at least on x86_64 (most installation tests currently fail here). Please let me know if I should change or improve anything. Thanks! Timotej Lazar (2): services: qemu-guest-agent: Fix arguments to qemu-ga. tests: Add qemu-guest-agent system test. gnu/build/marionette.scm | 5 +- gnu/services/virtualization.scm | 12 ++--- gnu/tests/virtualization.scm | 84 +++++++++++++++++++++++++++++++++ 3 files changed, 93 insertions(+), 8 deletions(-) --=20 2.36.1 From unknown Mon Aug 18 17:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56813] [PATCH 1/2] services: qemu-guest-agent: Fix arguments to qemu-ga. Resent-From: Timotej Lazar Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Jul 2022 15:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56813 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56813@debbugs.gnu.org Cc: Timotej Lazar Received: via spool by 56813-submit@debbugs.gnu.org id=B56813.16590206262046 (code B ref 56813); Thu, 28 Jul 2022 15:04:01 +0000 Received: (at 56813) by debbugs.gnu.org; 28 Jul 2022 15:03:46 +0000 Received: from localhost ([127.0.0.1]:59262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH53B-0000Ww-W4 for submit@debbugs.gnu.org; Thu, 28 Jul 2022 11:03:46 -0400 Received: from araneo.si ([90.157.193.204]:53554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH539-0000Wk-0f for 56813@debbugs.gnu.org; Thu, 28 Jul 2022 11:03:45 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id eba549bc for <56813@debbugs.gnu.org>; Thu, 28 Jul 2022 15:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=20180623; bh=f6UJHSAe+ZRty9GlWclPM aONNgU=; b=ot4JtNiAFHkAHw+rLArNppHHtbro2OL5e7byfSr+KSH1pMqrcnSRM IVN3TzjJyQ15v9uxqrUNRuILmltCKBkz7ijjNxgr8KivExlTaJXVgGyOjkv8TJ92 8P1JUBvRkYFB/ge980LJi4WGZSoWuXZ0XIHm7fKf+519O/tmWOGfhm4EbauKx6+g oEb+bNjz7ssTq8FIwqSexqTehrNnstw4ZH2nk8Y9za7CxQJ9QKKJGEVtRLct9AXH QclQCqIUXuWE52elEDDOHZ6VQAQ9mVnkdhoNbo3wp1m6GkZ2xih3Ms5VVaUTEOaY 2+HV385Uqx5DyUHt38gvI7whL6GRf8eBA== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 519c11cb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 28 Jul 2022 15:03:41 +0000 (UTC) From: Timotej Lazar Date: Thu, 28 Jul 2022 17:03:25 +0200 Message-Id: <20220728150326.14182-1-timotej.lazar@araneo.si> X-Mailer: git-send-email 2.36.1 In-Reply-To: <87y1wdb7yk.fsf@araneo.si> References: <87y1wdb7yk.fsf@araneo.si> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fix the check for empty device path. Do not use --daemonize, since that is handled by make-forkexec-constructor. Drop the --pidfile option which is unused without --daemonize. * gnu/services/virtualization.scm (qemu-guest-agent-shepherd-service): Modify command arguments. --- gnu/services/virtualization.scm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm index 41afe451c1..406752b35c 100644 --- a/gnu/services/virtualization.scm +++ b/gnu/services/virtualization.scm @@ -879,13 +879,11 @@ (define (qemu-guest-agent-shepherd-service config) (provision '(qemu-guest-agent)) (documentation "Run the QEMU guest agent.") (start #~(make-forkexec-constructor - `(,(string-append #$qemu "/bin/qemu-ga") "--daemon" - "--pidfile=/var/run/qemu-ga.pid" - "--statedir=/var/run" - ,@(if #$device - (list (string-append "--path=" #$device)) - '())) - #:pid-file "/var/run/qemu-ga.pid" + `(,(string-append #$qemu "/bin/qemu-ga") + "--statedir" "/var/run" + ,@(if (string-null? #$device) + '() + (list "--path" #$device))) #:log-file "/var/log/qemu-ga.log")) (stop #~(make-kill-destructor)))))) -- 2.36.1 From unknown Mon Aug 18 17:54:38 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56813] [PATCH 2/2] tests: Add qemu-guest-agent system test. Resent-From: Timotej Lazar Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Jul 2022 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56813 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56813@debbugs.gnu.org Cc: Timotej Lazar Received: via spool by 56813-submit@debbugs.gnu.org id=B56813.16590206302066 (code B ref 56813); Thu, 28 Jul 2022 15:04:02 +0000 Received: (at 56813) by debbugs.gnu.org; 28 Jul 2022 15:03:50 +0000 Received: from localhost ([127.0.0.1]:59266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH53G-0000XG-At for submit@debbugs.gnu.org; Thu, 28 Jul 2022 11:03:50 -0400 Received: from araneo.si ([90.157.193.204]:53554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH53B-0000Wk-T0 for 56813@debbugs.gnu.org; Thu, 28 Jul 2022 11:03:46 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 58c9ebac for <56813@debbugs.gnu.org>; Thu, 28 Jul 2022 15:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=20180623; bh=2uAWWxxuFtNTO66J0AV8h OEeA14=; b=XqwV2hjNXFxqqPolKuaqAYqI5MeZZDzJpbs437kZY7ygj4I+Kvd0m /0sV1rNCykXkNZvutoB9fiT3mtc76VOhogVoH9eqlpqXKSkSpSpSAuO21ZuG9bWg CMGxLGI2FLI8qSHAtZRcnmF1FgVU3FelaHLo0nvAEY6gUtexDfHuKSTZcbMIKxSu SnVICS+Z5UitTCXkvJcM4OeRs2B2MTwEzjCImEK0UGoCo5l2PsakhOCaFTW9Aeoc qc+suyfIg/f81s+nz54tVilUe8brYRmVbslyGjzVGYDn9tpRtyEyyv/1x5fPECVy fPsF7VrTwX2UuYbNN1A/Sp4/Natls61WQ== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 5a514d13 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 28 Jul 2022 15:03:42 +0000 (UTC) From: Timotej Lazar Date: Thu, 28 Jul 2022 17:03:26 +0200 Message-Id: <20220728150326.14182-2-timotej.lazar@araneo.si> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220728150326.14182-1-timotej.lazar@araneo.si> References: <87y1wdb7yk.fsf@araneo.si> <20220728150326.14182-1-timotej.lazar@araneo.si> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Enable the QEMU guest agent interface in marionette VMs, run the qemu-guest-agent service in one and try talking to it. * gnu/build/marionette.scm (make-marionette): Enable the guest agent device. * gnu/tests/virtualization.scm (run-qemu-guest-agent-test): New procedure. (%test-qemu-guest-agent): New variable. --- gnu/build/marionette.scm | 5 ++- gnu/tests/virtualization.scm | 84 ++++++++++++++++++++++++++++++++++++ 2 files changed, 88 insertions(+), 1 deletion(-) diff --git a/gnu/build/marionette.scm b/gnu/build/marionette.scm index 0d2af642c8..2b241d19e8 100644 --- a/gnu/build/marionette.scm +++ b/gnu/build/marionette.scm @@ -105,11 +105,14 @@ (define extra-options "-monitor" (string-append "unix:" socket-directory "/monitor") "-chardev" (string-append "socket,id=repl,path=" socket-directory "/repl") + "-chardev" (string-append "socket,id=qga,server=on,wait=off,path=" + socket-directory "/qemu-ga") ;; See ;; . "-device" "virtio-serial" - "-device" "virtserialport,chardev=repl,name=org.gnu.guix.port.0")) + "-device" "virtserialport,chardev=repl,name=org.gnu.guix.port.0" + "-device" "virtserialport,chardev=qga,name=org.qemu.guest_agent.0")) (define (accept* port) (match (select (list port) '() (list port) timeout) diff --git a/gnu/tests/virtualization.scm b/gnu/tests/virtualization.scm index 299acc4945..4bd56e5d9d 100644 --- a/gnu/tests/virtualization.scm +++ b/gnu/tests/virtualization.scm @@ -37,6 +37,7 @@ (define-module (gnu tests virtualization) #:use-module (guix records) #:use-module (guix store) #:export (%test-libvirt + %test-qemu-guest-agent %test-childhurd)) @@ -115,6 +116,89 @@ (define %test-libvirt (description "Connect to the running LIBVIRT service.") (value (run-libvirt-test)))) + +;;; +;;; QEMU Guest Agent service. +;;; + +(define %qemu-guest-agent-os + (simple-operating-system + (service qemu-guest-agent-service-type))) + +(define (run-qemu-guest-agent-test) + "Run tests in %QEMU-GUEST-AGENT-OS." + (define os + (marionette-operating-system + %qemu-guest-agent-os + #:imported-modules '((gnu services herd)))) + + (define vm + (virtual-machine + (operating-system os) + (port-forwardings '()))) + + (define test + (with-imported-modules '((gnu build marionette)) + #~(begin + (use-modules (gnu build marionette) + (ice-9 rdelim) + (srfi srfi-64)) + + (define marionette + ;; Ensure we look for the socket in the correct place below. + (make-marionette (list #$vm) #:socket-directory "/tmp")) + + (define* (try-read port #:optional (attempts 10)) + ;; Try reading from a port several times before giving up. + (cond ((char-ready? port) + (let ((response (read-line port))) + (close-port port) + response)) + ((> attempts 1) + (sleep 1) + (try-read port (- attempts 1))) + (else ""))) + + (define (run command) + ;; Run a QEMU guest agent command and return the response. + (let ((s (socket PF_UNIX SOCK_STREAM 0))) + (connect s AF_UNIX "/tmp/qemu-ga") + (display command s) + (try-read s))) + + (test-runner-current (system-test-runner #$output)) + (test-begin "qemu-guest-agent") + + (test-assert "service running" + (marionette-eval + '(begin + (use-modules (gnu services herd)) + (match (start-service 'qemu-guest-agent) + (#f #f) + (('service response-parts ...) + (match (assq-ref response-parts 'running) + ((pid) (number? pid)))))) + marionette)) + + (test-equal "ping guest" + "{\"return\": {}}" + (run "{\"execute\": \"guest-ping\"}")) + + (test-assert "get network interfaces" + (string-contains + (run "{\"execute\": \"guest-network-get-interfaces\"}") + "127.0.0.1")) + + (test-end)))) + + (gexp->derivation "qemu-guest-agent-test" test)) + +(define %test-qemu-guest-agent + (system-test + (name "qemu-guest-agent") + (description "Run commands in a virtual machine using QEMU guest agent.") + (value (run-qemu-guest-agent-test)))) + ;;; ;;; GNU/Hurd virtual machines, aka. childhurds. -- 2.36.1 From unknown Mon Aug 18 17:54:38 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Timotej Lazar Subject: bug#56813: closed (Re: bug#56813: [PATCH 0/2] Add a test for qemu-guest-agent service) Message-ID: References: <87h72l5tl1.fsf@gnu.org> <87y1wdb7yk.fsf@araneo.si> X-Gnu-PR-Message: they-closed 56813 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 56813@debbugs.gnu.org Date: Tue, 09 Aug 2022 15:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1660058642-15226-1" This is a multi-part message in MIME format... ------------=_1660058642-15226-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #56813: [PATCH 0/2] Add a test for qemu-guest-agent service which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 56813@debbugs.gnu.org. --=20 56813: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56813 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1660058642-15226-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 56813-done) by debbugs.gnu.org; 9 Aug 2022 15:23:49 +0000 Received: from localhost ([127.0.0.1]:44495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLR5B-0003xA-D8 for submit@debbugs.gnu.org; Tue, 09 Aug 2022 11:23:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLR59-0003ww-9c for 56813-done@debbugs.gnu.org; Tue, 09 Aug 2022 11:23:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40462) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLR53-0001zV-64; Tue, 09 Aug 2022 11:23:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DC/hrNTPjz8qlmb5H9CzcfHJ05siUA/8dI2dosclx7o=; b=chrtg01w13e+asu06GqG Ld9qQjCwnb3Te8yhIWqE6zvVDW7iVvH5ILTtXidSXUJXLAH3b2nAgx9VOHU3cGCZcH39l1Q6Tu8s1 zKvWt0vxhOi8syOZCwTHptRFmDsw+T1wD54jPoDYEWkunWAsiN0aGIJkVgbDbTwSMU1qWgesZqDnQ /hjAwllwPA+KqSBxbhODRafNAgKKuaMiOY4/OvDf5xfjPp29MNvp6hNI5Ei8KViJlRo9wtxElTb3l KXTJrByRtiRE/LDYDDK3qQvio7QFyrH/yx4PAFFwXOZGxrqb/+tzWaFyQT+3wa1S2/RaLwRWfuEd8 MT1iR4nQDvgkQg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=52170 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLR52-00079w-PW; Tue, 09 Aug 2022 11:23:41 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timotej Lazar Subject: Re: bug#56813: [PATCH 0/2] Add a test for qemu-guest-agent service References: <87y1wdb7yk.fsf@araneo.si> Date: Tue, 09 Aug 2022 17:23:38 +0200 In-Reply-To: <87y1wdb7yk.fsf@araneo.si> (Timotej Lazar's message of "Thu, 28 Jul 2022 16:57:55 +0200") Message-ID: <87h72l5tl1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56813-done Cc: 56813-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Timotej, Timotej Lazar skribis: > these patches fix some issues with the QEMU guest agent service, and add > a system test for it. The test runs the service in a marionette VM and > tries communicating with it. For that, I enabled the guest agent serial > device in marionette QEMU options. This change touches all system tests, > but should be harmless. Yes, sounds good. > I=E2=80=99m not sure if it would be better instead to add a keyword argum= ent to > make-marionette for (extra) extra QEMU options. In any case, all tests > that pass on master still pass after this change, at least on x86_64 > (most installation tests currently fail here). Perfect. > services: qemu-guest-agent: Fix arguments to qemu-ga. > tests: Add qemu-guest-agent system test. Applied, thanks! Ludo=E2=80=99. ------------=_1660058642-15226-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jul 2022 14:58:09 +0000 Received: from localhost ([127.0.0.1]:59244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH4xl-0000L0-4v for submit@debbugs.gnu.org; Thu, 28 Jul 2022 10:58:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:40048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH4xf-0000Kn-Lw for submit@debbugs.gnu.org; Thu, 28 Jul 2022 10:58:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4xf-0006wk-Fg for guix-patches@gnu.org; Thu, 28 Jul 2022 10:58:03 -0400 Received: from araneo.si ([2001:15c0:2110:3400::2]:55292) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH4xd-00028s-6s for guix-patches@gnu.org; Thu, 28 Jul 2022 10:58:02 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 3d5df7b0 for ; Thu, 28 Jul 2022 14:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=20180623; bh=/V4K8Fm0S6wYFKF4KpwJf FC3I8o=; b=TL/9HACqWtqPiJhlgrZX74XP/5awaIU7OMBBZsypQSPankUnn4vSD Zat2Lcgy9Y3NpCw4mpCDSVsKnIN9I8mdyRcNCo+5ovgy8NM482GUXHr9ascc9dKs 2uVYcf/JqF+i+0Iu8IEVEmF/7MtSeUwi9pncKme3BHovZYkcN5g1fIxyHdHWm0OQ iUlcF5jsnb7FaUEXlUZhJjy2Lx2hYvjmPIUJ7brt1Hnw1ljkr0TnTSeXatCGswwl x2+F9KCj4ArPSqnsJ+ftB4A63w9KGp8JUcwy7tWmepuZ+4jHXmIEJf4dCt7DFg1o IRIj5c6vpIUGPZUU7Y45UTbcZZEnewBMQ== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 079c3904 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Thu, 28 Jul 2022 14:57:55 +0000 (UTC) From: Timotej Lazar To: guix-patches@gnu.org Subject: [PATCH 0/2] Add a test for qemu-guest-agent service Date: Thu, 28 Jul 2022 16:57:55 +0200 Message-ID: <87y1wdb7yk.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:15c0:2110:3400::2; envelope-from=timotej.lazar@araneo.si; helo=araneo.si X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, these patches fix some issues with the QEMU guest agent service, and add a system test for it. The test runs the service in a marionette VM and tries communicating with it. For that, I enabled the guest agent serial device in marionette QEMU options. This change touches all system tests, but should be harmless. I=E2=80=99m not sure if it would be better instead to add a keyword argumen= t to make-marionette for (extra) extra QEMU options. In any case, all tests that pass on master still pass after this change, at least on x86_64 (most installation tests currently fail here). Please let me know if I should change or improve anything. Thanks! Timotej Lazar (2): services: qemu-guest-agent: Fix arguments to qemu-ga. tests: Add qemu-guest-agent system test. gnu/build/marionette.scm | 5 +- gnu/services/virtualization.scm | 12 ++--- gnu/tests/virtualization.scm | 84 +++++++++++++++++++++++++++++++++ 3 files changed, 93 insertions(+), 8 deletions(-) --=20 2.36.1 ------------=_1660058642-15226-1--