GNU bug report logs -
#56803
[PATCH 0/6] Add hydrus network and its dependencies
Previous Next
Reported by: Tomasz Jeneralczyk <tj <at> schwi.pl>
Date: Wed, 27 Jul 2022 18:59:02 UTC
Severity: normal
Tags: patch
Done: Ludovic Courtès <ludo <at> gnu.org>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
On 27-07-2022 21:00, Tomasz Jeneralczyk wrote:
> + (with-extensions (list mpv)
IIUC, that's for using Guile modules defined in packages -- but mpv is
not a Guile package, so I expect that the surrounding with-extensions
can be dropped.
> + (let* ((args (package-arguments opencv)))
> + (assoc-set! args #:configure-flags
> + (append (list "-DBUILD_opencv_python3=ON")
> + (assoc-ref args #:configure-flags)))
Look for substitute-keyword-arguments, which isn't stateful and hence
there is less risk of accidentally modifying the arguments of the parent
package. Also, any reason for not adding this to the original package?
(Possibly there is one).
> + (replace 'check
> + (lambda _
> + (setenv "DISPLAY" ":0")
> + (setenv "XDG_CACHE_HOME" (getcwd))
> + (setenv "HOME" (getcwd))
> + (system "Xvfb &")
> + (invoke "python" "test.py")))
Run "./pre-inst-env guix lint hydrus-network", it will have a remark
about this. Also, technically this is racy -- it's possible for python
to start before Xvfb is ready though so far this doesn't seem to have
caused trouble for other packages yet AFAIK -- I recommend "xvfb-run"
"--" "python" "test.py" instead.
(I just scrolled quickly through the patches, a more full review will
have to come later.)
Greetings,
Maxime.
[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]
This bug report was last modified 2 years and 324 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.