GNU bug report logs - #56781
[PATCH] home: Add explicit dependency on env to activation script.

Previous Next

Package: guix-patches;

Reported by: Andrew Tropin <andrew <at> trop.in>

Date: Tue, 26 Jul 2022 11:27:01 UTC

Severity: normal

Tags: patch

Done: Andrew Tropin <andrew <at> trop.in>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrew Tropin <andrew <at> trop.in>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#56781: closed ([PATCH] home: Add explicit dependency on env
 to activation script.)
Date: Tue, 02 Aug 2022 14:37:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 02 Aug 2022 17:35:57 +0300
with message-id <875yja1zn6.fsf <at> trop.in>
and subject line Re: bug#56781: [PATCH] home: Add explicit dependency on env to activation script.
has caused the debbugs.gnu.org bug report #56781,
regarding [PATCH] home: Add explicit dependency on env to activation script.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
56781: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56781
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Subject: [PATCH] home: Add explicit dependency on env to activation script.
Date: Tue, 26 Jul 2022 13:10:08 +0300
[Message part 3 (text/plain, inline)]
* gnu/home/services.scm (compute-activation-script): Add explicit dependency
on env to activation script.
---
 gnu/home/services.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/home/services.scm b/gnu/home/services.scm
index d500ba8c68..61a7419f4e 100644
--- a/gnu/home/services.scm
+++ b/gnu/home/services.scm
@@ -20,6 +20,7 @@
 (define-module (gnu home services)
   #:use-module (gnu services)
   #:use-module ((gnu packages package-management) #:select (guix))
+  #:use-module ((gnu packages base) #:select (coreutils))
   #:use-module (guix channels)
   #:use-module (guix monads)
   #:use-module (guix store)
@@ -427,8 +428,9 @@ (define (compute-activation-script init-gexp gexps)
                               #f))))
        (if (file-exists? (he-init-file new-home))
            (let* ((port   ((@ (ice-9 popen) open-input-pipe)
-                           (format #f "source ~a && env -0"
-                                   (he-init-file new-home))))
+                           (format #f "source ~a && ~a -0"
+                                   (he-init-file new-home)
+                                   #$(file-append coreutils "/bin/env"))))
                   (result ((@ (ice-9 rdelim) read-delimited) "" port))
                   (vars (map (lambda (x)
                                (let ((si (string-index x #\=)))
-- 
2.37.0

[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: Andrew Tropin <andrew <at> trop.in>
To: 宋文武 <iyzsong <at> envs.net>
Cc: 56781-done <at> debbugs.gnu.org
Subject: Re: bug#56781: [PATCH] home: Add explicit dependency on env to
 activation script.
Date: Tue, 02 Aug 2022 17:35:57 +0300
[Message part 6 (text/plain, inline)]
On 2022-08-02 16:54, 宋文武 wrote:

> Andrew Tropin <andrew <at> trop.in> writes:
>
>> * gnu/home/services.scm (compute-activation-script): Add explicit dependency
>> on env to activation script.
>
> Pushed, thanks!

Thank you very much!

-- 
Best regards,
Andrew Tropin
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 2 years and 290 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.