From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 26 04:08:47 2022 Received: (at submit) by debbugs.gnu.org; 26 Jul 2022 08:08:47 +0000 Received: from localhost ([127.0.0.1]:52162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGFcU-00080i-Tu for submit@debbugs.gnu.org; Tue, 26 Jul 2022 04:08:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:36910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGFcT-00080b-8t for submit@debbugs.gnu.org; Tue, 26 Jul 2022 04:08:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGFcT-0003yc-2u for guix-patches@gnu.org; Tue, 26 Jul 2022 04:08:45 -0400 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:36003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGFcM-0003Dc-Js for guix-patches@gnu.org; Tue, 26 Jul 2022 04:08:44 -0400 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id 25A7F240002 for ; Tue, 26 Jul 2022 08:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1658822910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=MhmXPr+aELpAnlFHdmo1Ljrh9cdSQyFJgOFw3cp/GiE=; b=Oqb5pHuwCZssRViwG5APggPDRDmHA0gnSPUVLloqgDJcas2pwUlzh9jhTWe/VSkJR0CYBJ V5nuQRhH29fL8moEyu+fXmJ7VAclgDYPZr7l/98rjq/4cI3aY0rYvVq7zVQ9L7BM77KJZr 1l4Le92ViDQSrp3DbANNx8UMaIT16aumuravpEvOTIdAtysJznVHf5UwN1t2622FiGuuU1 JjW1oZhgATEPYpO/fUZjtCWH1aAqkWc4Yfqry8I7g/mprcj1RBnevEGv8ZmayReqnhI/qX 3AqON15l5ec4NBGeH6ZXtDVBd/n/2N958HeD7d6tVEnzsv4Kh3eeFTS0IZ71Bg== From: Andrew Tropin To: guix-patches@gnu.org Subject: [PATCH] Use absolute path for home activation script. Date: Fri, 14 Jan 2022 09:16:32 +0300 Message-ID: <87tu74z479.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2001:4b98:dc4:8::221; envelope-from=andrew@trop.in; helo=relay1-d.mail.gandi.net X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_96_XX=3.405, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable * gnu/home/services.scm (compute-activation-script): Use absolute path for home activation script. =2D-- gnu/home/services.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/home/services.scm b/gnu/home/services.scm index b05ec53e2a..6d5e4308a0 100644 =2D-- a/gnu/home/services.scm +++ b/gnu/home/services.scm @@ -418,7 +418,7 @@ (define (compute-activation-script init-gexp gexps) (new-home-env (getenv "GUIX_NEW_HOME")) (new-home (or new-home-env ;; Path of the activation file if called interac= tively =2D (dirname (car (command-line))))) + (canonicalize-path (dirname (car (command-line))= )))) (old-home-env (getenv "GUIX_OLD_HOME")) (old-home (or old-home-env (if (file-exists? (he-init-file he-path)) =2D-=20 2.37.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmLfoPoACgkQIgjSCVjB 3rDtTA/+Icr92AcMQPhA+JwYCyC3P6w/v12tCTerGWodNzRk1m42y35KpDY2QUfc hvOz+Vb5w+VJZALcC/iPcB1Hp2Hrnf5BoMEhtin1XYZ40nx4yh5kUXde5qdkuqxT xkqHzoJ4JjjQHeH1ZCTyvLlLRP/THuLY5OxSjUvpf4lrzULnd4GpMNbFcYdyqWTq YWjxvZEfwHf0C/jYZZ3dqWDoTPVdb40f0K5jGqIYrdlmdBsvR4qQJGpMpxD3XlQK Gl9Tmm5rZ9aDXBXwCCk03QPnkvYlP9olCfvuYLwUE84J738979hhCfyUDn2kS1zi xvLlU0cXxNMoayNRtopZ1r346Oc4oKbIKohS9xWc6z8NhhLie+51MXrBVax2zqbD j00Ol2Mn0hetbrNfGgRPqLEqlPQbkswDuC3khIuhUsEAjEoVKKj6qIMAa5aDKPoC buGN2rHxMWe2/pAMaJyde8mnUnW6HXwv3ljrfMkKQJVpfZ4IWuswKlVApOz6m1Xw G+lIkfVX55rJWBArVpQYDLRNh5zf9z4K9IyxsMMB4a7utC+7nhhSLXz5mzp3EWO+ FAGYxOKQ7StRAcSGot/USgkcV0YIpfFjXVbqtIO3bjuXNqbob3augBeUGlDF9+uf gs/X1DVToctvU1XQA5zTUQvYmorEIyfonagpFWsZ2GAbXMU+hqE= =i8pA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 17:24:12 2022 Received: (at 56777) by debbugs.gnu.org; 29 Aug 2022 21:24:12 +0000 Received: from localhost ([127.0.0.1]:34047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSmEt-0006oT-UB for submit@debbugs.gnu.org; Mon, 29 Aug 2022 17:24:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSmEr-0006oE-QM for 56777@debbugs.gnu.org; Mon, 29 Aug 2022 17:24:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSmEm-0000Hu-Ca; Mon, 29 Aug 2022 17:24:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=3NaW8pWz3gtUP+VR2/Wnt/bH+q37NtisW8TwNv+Wc2g=; b=LiN1G8qsmBcwNSqY5XnM MF0I00bLMRiQ/Zldrp63FMMNJ6nUred0PiJ6jI4Hw1Ckl4yVNFDPjRv3VmFUcxWix8Pm9HpgyEKYq WOQID6bjoBzsbJIhbCiJAJALhR5yTUKpub1zBRr3Uef2Zoc3KQ+bwyHwHGBf7IdmCyCcBqUgc32XG q9liux92ZVIuuZYFrTRbM2OHoVU1AexECXMvL57V8D/PbN4q7T8vwmaeNJKQCPiN2pysOCKE+Xc1W MmKNt0n+Sv25otNPvOifX2TjcoMCa9fQMPDqX294EYggqj3kUXIoSJXl+z/liAPQa6/Atb4Jvgh4x 86Tb++sydLcgOw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53935 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSmEl-0004m8-VG; Mon, 29 Aug 2022 17:24:04 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Andrew Tropin Subject: Re: bug#56777: [PATCH] Use absolute path for home activation script. References: <87tu74z479.fsf@trop.in> Date: Mon, 29 Aug 2022 23:24:02 +0200 In-Reply-To: <87tu74z479.fsf@trop.in> (Andrew Tropin's message of "Fri, 14 Jan 2022 09:16:32 +0300") Message-ID: <871qsy68wd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56777 Cc: 56777@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Andrew, Andrew Tropin skribis: > * gnu/home/services.scm (compute-activation-script): Use absolute path for > home activation script. > > --- > gnu/home/services.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gnu/home/services.scm b/gnu/home/services.scm > index b05ec53e2a..6d5e4308a0 100644 > --- a/gnu/home/services.scm > +++ b/gnu/home/services.scm > @@ -418,7 +418,7 @@ (define (compute-activation-script init-gexp gexps) > (new-home-env (getenv "GUIX_NEW_HOME")) > (new-home (or new-home-env > ;; Path of the activation file if called inter= actively > - (dirname (car (command-line))))) > + (canonicalize-path (dirname (car (command-line= )))))) Just wondering: what=E2=80=99s the rationale? This is harmless-looking and perhaps it=E2=80=99s all fine, but IME calling =E2=80=98canonicalize-path=E2=80=99 might sometimes paper over problems rel= ated to file name handling. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 30 03:01:46 2022 Received: (at 56777) by debbugs.gnu.org; 30 Aug 2022 07:01:46 +0000 Received: from localhost ([127.0.0.1]:34560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSvFp-0004V5-MA for submit@debbugs.gnu.org; Tue, 30 Aug 2022 03:01:45 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:33203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSvFm-0004Uq-SS for 56777@debbugs.gnu.org; Tue, 30 Aug 2022 03:01:43 -0400 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id 12E10FF806; Tue, 30 Aug 2022 07:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1661842896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gIsmC+O76EZz/s+feE7CvgfrTDvkGz6+wEth/77mKaU=; b=YUu02wbwzJKSmnIQs3py5ULlwmrmyBGOfkb+OpZwtyGV3ws7DoSCP771epochgkcok9Wq2 7hAp1EjxvU6hiF4spZTS6YfSa5VSV21uFHRlbODRm0xgrHlwsZ838KVk3G8iVscMn5oqlH xENOLsF/IEq/ZCLdXKQqtd4fVstnRnaBD8fxTBRJ8kyHPcbWZeQk0K15Yf5ZuFsckOkBFy /UMzg7tlrDVulhPr6Tg269OE32YaqZZMrJZrJsHH3cm35qF/ettus3GA4c62orxxLZ0Yys eyXoYBT7m80q4XSzwmO7g/N7FMyZQrtksQhD/6U+7LrDwBB47qjADjq7xZDGww== From: Andrew Tropin To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#56777: [PATCH] Use absolute path for home activation script. In-Reply-To: <871qsy68wd.fsf@gnu.org> References: <87tu74z479.fsf@trop.in> <871qsy68wd.fsf@gnu.org> Date: Tue, 30 Aug 2022 10:01:31 +0300 Message-ID: <87pmgi2p10.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56777 Cc: 56777@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-08-29 23:24, Ludovic Court=C3=A8s wrote: > Hi Andrew, > > Andrew Tropin skribis: > >> * gnu/home/services.scm (compute-activation-script): Use absolute path f= or >> home activation script. >> >> --- >> gnu/home/services.scm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gnu/home/services.scm b/gnu/home/services.scm >> index b05ec53e2a..6d5e4308a0 100644 >> --- a/gnu/home/services.scm >> +++ b/gnu/home/services.scm >> @@ -418,7 +418,7 @@ (define (compute-activation-script init-gexp gexps) >> (new-home-env (getenv "GUIX_NEW_HOME")) >> (new-home (or new-home-env >> ;; Path of the activation file if called inte= ractively >> - (dirname (car (command-line))))) >> + (canonicalize-path (dirname (car (command-lin= e)))))) > > Just wondering: what=E2=80=99s the rationale? It's been a while since I posted it, but IIRC, in case the activation script called manually from other directory without this change the relative new-home can be set, which can fail later if some of activation code changes the current working directory, but reference home environment by relative path. Probably I faced this one, when was working on prototype for https://issues.guix.gnu.org/56669 Another hypothetical case, which can fail: ln -s /gnu/store/...-home ~/tmp/he ~/tmp/he/activate rm ~/tmp/he # Dangling symlink ~/.guix-home -> ~/tmp/he Last one can be solved by resolving full path of new-home in symlink-manager, but always setting new-home to absolute path to home item in the store seems as a way to avoid both potential problems mentioned above. This change is pushed as ffc391500ac7eae1ef100d8d36f6c01f4f606170 > > This is harmless-looking and perhaps it=E2=80=99s all fine, but IME calli= ng > =E2=80=98canonicalize-path=E2=80=99 might sometimes paper over problems r= elated to file > name handling. Will keep it in mind. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmMNtcwACgkQIgjSCVjB 3rBfIw//VXg1ZYs8D3ednwtwK/+yiNin/j1LmPtGk8D5wgHQuommMvxw6sMTXIve TiGgBcoJI/4HiSD1RfOgAT2EpoO8XkYNmmPRztkYSMFVfSQ+C90ELv2//sFXgEqN qGjOnS+fa+/hpSPgaUl1XFRznNj4RGjE3Bt/l28qML/hr/MBlXu/Tjv3sYbjm36n VDgeV7lWU3ieaXNNkhymRZ691I3lXL/09xoMvBvmnm6Ww49PQKUEORkDfvx12ZVD ySQYOTwZvN74owc21aa5hscimePnwBS0o+gfmt/KmIFte7tgxGn8roMaDKKhYes1 Z4oEbmVnC0lI1HEvfl+B33Pn0DdZwYFcd9EXsLRfqnY2EfaM9PuS9RSlX8lfLr+6 HTWx+Fy48XvMgfATTNk1W4GavpTRH8StggIHNhALVtGQ9p5+gHNqA5OBwH1xWpdr 9vTHzGjUXycDln/MDuuhjGHLCnM8RLzVGpbCFVmXO1wn1cmW6h1GRiKrqNH4DdrR 8QSrHBuZzYMoO/LVA96kAXi/6WCGjj3iWK2AwXLb2zLAbDuSHIjgkIQDFVY3SSpo jIEpEj+9914sayp4f2/EKpvkA5rZX2tL5RedD/Lj3cpoxf7bRgjhtdOZDhZ3cqz6 Atm5Ta1Tf6zbMnu2xAozx6PIw10uZ1ypdBJtaxo5oVeJgB++JDY= =7yv2 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 31 16:42:34 2022 Received: (at control) by debbugs.gnu.org; 31 Aug 2022 20:42:34 +0000 Received: from localhost ([127.0.0.1]:40574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTUXi-0007tq-KF for submit@debbugs.gnu.org; Wed, 31 Aug 2022 16:42:34 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:39218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTUXf-0007tX-Vr for control@debbugs.gnu.org; Wed, 31 Aug 2022 16:42:33 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 38CC21651 for ; Wed, 31 Aug 2022 22:42:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vcalnlswjsNf for ; Wed, 31 Aug 2022 22:42:23 +0200 (CEST) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id AE61F264 for ; Wed, 31 Aug 2022 22:42:23 +0200 (CEST) Date: Wed, 31 Aug 2022 22:42:23 +0200 Message-Id: <87pmgg9mc0.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #56777 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) close 56777 quit From unknown Sun Aug 10 00:24:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Sep 2022 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator