Subject: bug#56775: closed (Re: [bug#56775] [PATCH] gnu: Add rust-miniz-oxide-0.5.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 27 Jul 2022 09:53:02 +0000

Your bug report

#56775: [PATCH] gnu: rust-miniz-oxide: Do not skip build.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
56775: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56775
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#56775] [PATCH] gnu: Add rust-miniz-oxide-0.5.
From: Marius Bakke <[email-masked]>
To: [email-masked]
Cc: Nicolas Graves <[email-masked]>
Date: Wed, 27 Jul 2022 11:52:24 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Nicolas Graves via Guix-patches via <[email-masked]> skriver:

> * gnu/packages/crates-io.scm (rust-miniz-oxide-0.5): New variable.

[...]

> +(define-public rust-miniz-oxide-0.4
> +  (package
> +    (inherit rust-miniz-oxide-0.5)
> +    (name "rust-miniz-oxide")
> +    (version "0.4.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (crate-uri "miniz_oxide" version))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "17d1xp29v5xgh4vahxld14w1c1hgh38qmxpv7i18wy096gn2cb8g"))))
> +    (arguments
> +     `(#:cargo-inputs
> +       (("rust-adler" ,rust-adler-0.2)
> +        ("rust-autocfg" ,rust-autocfg-1)
> +        ("rust-compiler-builtins" ,rust-compiler-builtins-0.1)
> +        ("rust-rustc-std-workspace-alloc" ,rust-rustc-std-workspace-alloc-1)
> +        ("rust-rustc-std-workspace-core" ,rust-rustc-std-workspace-core-1)))))
                                                                                 ^
This message was missing a closing paren.  I fixed that, and also
updated your copyright header in crates-io.scm, hope that was okay.

Patches pushed in 9a1cd6e7e8..56e17f6493.

Subject: [PATCH] gnu: rust-miniz-oxide: Do not skip build.
From: Nicolas Graves <[email-masked]>
To: [email-masked]
Cc: Nicolas Graves <[email-masked]>
Date: Tue, 26 Jul 2022 08:41:57 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/crates-io.scm
(rust-miniz-oxide-0.2): Keeping skip-build? #t.
(rust-miniz-oxide-0.3): Deleting skip-build? #t.
(rust-miniz-oxide-0.4): Deleting skip-build? #t.
---
 gnu/packages/crates-io.scm | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 41e5041c79..30e2db0777 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -34832,8 +34832,7 @@ (define-public rust-miniz-oxide-0.4
         (base32 "17d1xp29v5xgh4vahxld14w1c1hgh38qmxpv7i18wy096gn2cb8g"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs
+     `(#:cargo-inputs
        (("rust-adler" ,rust-adler-0.2)
         ("rust-autocfg" ,rust-autocfg-1)
         ("rust-compiler-builtins" ,rust-compiler-builtins-0.1)
@@ -34861,8 +34860,7 @@ (define-public rust-miniz-oxide-0.3
          (base32
           "198n4hfpq0qcxf275l6fpzh7b9cl7ck2xs6pjgpds74bazv9yrxa"))))
     (arguments
-     `(#:skip-build? #t
-       #:cargo-inputs (("rust-adler32" ,rust-adler32-1))))))
+     `(#:cargo-inputs (("rust-adler32" ,rust-adler32-1))))))
 
 (define-public rust-miniz-oxide-0.2
   (package
@@ -34877,7 +34875,8 @@ (define-public rust-miniz-oxide-0.2
         (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "17f92krv9hhsyc38prpfyn99m2hqhr4fgszpsla66a6gcrnpbhxn"))))))
+         "17f92krv9hhsyc38prpfyn99m2hqhr4fgszpsla66a6gcrnpbhxn"))))
+    (arguments `(#:skip-build? #t))))
 
 (define-public rust-miniz-oxide-c-api-0.2
   (package
-- 
2.37.1