GNU bug report logs - #56770
[PATCH] gnu: Add grimshot.

Previous Next

Package: guix-patches;

Reported by: Antero Mejr <antero <at> mailbox.org>

Date: Mon, 25 Jul 2022 20:55:02 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #34 received at 56770-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>, Antero Mejr <antero <at> mailbox.org>,
 56770-done <at> debbugs.gnu.org
Subject: Re: [bug#56770] LGTM: [PATCH v3] gnu: Add grimshot. (LGTM)
Date: Wed, 27 Jul 2022 20:42:45 +0200
Am Mittwoch, dem 27.07.2022 um 00:06 +0200 schrieb Maxime Devos:
> LGTM, with the caveat that I only looked at the package definition 
> during reviewing.
Well, I also built the package, so together this must mean it's fine,
right?  Either way, I trust you, so I pushed it.

> (Also, trying out a new convention for indicating that a patch
> appears ready: prefix the subject with LGTM)
IMHO one LGTM per header suffices.  I think the prefix is better than
the suffix because the latter will likely be truncated.

Cheers




This bug report was last modified 3 years and 19 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.