GNU bug report logs - #56770
[PATCH] gnu: Add grimshot.

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Antero Mejr <antero <at> mailbox.org>, 56770 <at> debbugs.gnu.org
Subject: [bug#56770] LGTM: [PATCH v3] gnu: Add grimshot. (LGTM)
Date: Wed, 27 Jul 2022 00:06:02 +0200

[Message part 1 (text/plain, inline)]

On 26-07-2022 22:48, Antero Mejr wrote:

> +(define-public grimshot
> +  (package
> +    (inherit sway)
> +    (name "grimshot")
> +    (source (origin
> +              (inherit (package-source sway))
> +              (snippet #~(delete-file "contrib/grimshot.1"))))
> +    (build-system copy-build-system)
> +    (arguments
> +     (list #:install-plan #~`(("grimshot" "bin/")
> +                              ("grimshot.1" "usr/share/man/man1/"))
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'chdir
> +                          (lambda _
> +                            (chdir "contrib")))
> +                        (add-after 'chdir 'patch-script-dependencies
> +                          (lambda* (#:key inputs #:allow-other-keys)
> +                            (substitute* "grimshot"
> +                              (("\\b(date|grim|jq|notify-send|slurp|swaymsg|wl-copy)\\b"
> +                                _ binary)
> +                               (search-input-file
> +                                inputs (string-append "bin/" binary))))))
> +                        (add-after 'patch-script-dependencies 'build-man-page
> +                          (lambda _
> +                            (with-input-from-file "grimshot.1.scd"
> +                              (lambda _
> +                                (with-output-to-file "grimshot.1"
> +                                  (lambda _
> +                                    (invoke "scdoc"))))))))))
> +    (native-inputs (list scdoc))
> +    (inputs (list coreutils
> +                  grim
> +                  jq
> +                  libnotify
> +                  slurp
> +                  sway
> +                  wl-clipboard))
> +    (synopsis "Screenshot utility for the Sway window manager")
> +    (description "Grimshot is a screenshot utility for @code{sway}.  It provides
> +an interface over @code{grim}, @code{slurp} and @code{jq}, and supports storing
> +the screenshot either directly to the clipboard using @code{wl-copy} or to a
> +file.")))

That's what I had in mind, thanks.

LGTM, with the caveat that I only looked at the package definition 
during reviewing.

To be clear, I only review things, someone else will have to commit this 
(assuming they agree).

(Also, trying out a new convention for indicating that a patch appears 
ready: prefix the subject with LGTM)

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.