From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Resent-From: Marcel van der Boom Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Jul 2022 19:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56766@debbugs.gnu.org Cc: Marcel van der Boom X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16587784927464 (code B ref -1); Mon, 25 Jul 2022 19:49:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Jul 2022 19:48:12 +0000 Received: from localhost ([127.0.0.1]:51497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oG43o-0001wI-3H for submit@debbugs.gnu.org; Mon, 25 Jul 2022 15:48:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:55226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oG43l-0001w1-Py for submit@debbugs.gnu.org; Mon, 25 Jul 2022 15:48:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG43l-00066n-Gu for guix-patches@gnu.org; Mon, 25 Jul 2022 15:48:09 -0400 Received: from read.hsdev.com ([209.250.245.235]:50726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG43i-0002Qa-Ul for guix-patches@gnu.org; Mon, 25 Jul 2022 15:48:09 -0400 Received: from hsdev.com (hawking.hsdev.com [213.125.12.142]) by read.hsdev.com (Postfix) with ESMTPA id 9F72020FBD; Mon, 25 Jul 2022 21:47:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hsdev.com; s=201906; t=1658778478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zNjIveHPv6FmvkLMlsWVafRuoHFJmJTu63bATmjspp4=; b=YKVfQ7VYy5qcJaUQQZucWqbpno00wVJxZcAoLwRiowah0Q/mVfI2C6R/JvifICHh6lbssn t8wfQRSqYBsvFXvV5wVSeNTz7TUyPopUtC1cJbzIo8R9j8I6ckbXcT7dtUyeBPhch+dHIk qec5QwQHUkjiE3fhpVgzZcP83yOi62M= Received: by hsdev.com (Postfix, from userid 1000) id 5A13B36A0264; Mon, 25 Jul 2022 21:47:58 +0200 (CEST) From: Marcel van der Boom Date: Mon, 25 Jul 2022 21:47:33 +0200 Message-Id: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.20 Received-SPF: pass client-ip=209.250.245.235; envelope-from=mrb@hsdev.com; helo=read.hsdev.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) ppc64 and arm do not raise exception and thus output and exit code for test is different. * gnu/packages/patches/exiv2-ppc64.patch: Modify test for ppc64 * gnu/packages/image.scm (exiv2): add `patches` field for source if target is ppc64 See: https://github.com/Exiv2/exiv2/issues/365 and https://github.com/Exiv2/exiv2/issues/933 upstream. --- gnu/packages/image.scm | 5 ++++- gnu/packages/patches/exiv2-ppc64.patch | 11 +++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/exiv2-ppc64.patch diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index d52d57b3b1..dc4bf76790 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -1342,7 +1342,10 @@ (define-public exiv2 (uri (string-append "https://www.exiv2.org/builds/exiv2-" version "-Source.tar.gz")) (sha256 - (base32 "1qm6bvj28l42km009nc60gffn1qhngc0m2wjlhf90si3mcc8d99m")))) + (base32 "1qm6bvj28l42km009nc60gffn1qhngc0m2wjlhf90si3mcc8d99m")) + (patches + (if (target-ppc64le?) + (list (search-patch "exiv2-ppc64.patch")))))) (build-system cmake-build-system) (arguments '(#:test-target "tests" diff --git a/gnu/packages/patches/exiv2-ppc64.patch b/gnu/packages/patches/exiv2-ppc64.patch new file mode 100644 index 0000000000..a74a7ac1b7 --- /dev/null +++ b/gnu/packages/patches/exiv2-ppc64.patch @@ -0,0 +1,11 @@ +--- /tests/bugfixes/github/test_CVE_2018_12265.py ++++ /tests/bugfixes/github/test_CVE_2018_12265.py +@@ -18,7 +18,6 @@ + Warning: Directory Image, entry 0x0201: Strip 0 is outside of the data area; ignored. + Warning: Directory Image, entry 0x0201: Strip 7 is outside of the data area; ignored. + Error: Offset of directory Thumbnail, entry 0x0201 is out of bounds: Offset = 0x00000000; truncating the entry +-$uncaught_exception $addition_overflow_message + """ + ] +- retval = [1] ++ retval = [0] base-commit: 212ca81895b2baa819ea11a308ad21880b84a546 -- 2.37.1 From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jul 2022 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marcel van der Boom , 56766@debbugs.gnu.org Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.16588584776957 (code B ref 56766); Tue, 26 Jul 2022 18:02:01 +0000 Received: (at 56766) by debbugs.gnu.org; 26 Jul 2022 18:01:17 +0000 Received: from localhost ([127.0.0.1]:54348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGOrt-0001o8-Bp for submit@debbugs.gnu.org; Tue, 26 Jul 2022 14:01:17 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:51500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGOrr-0001ns-CK for 56766@debbugs.gnu.org; Tue, 26 Jul 2022 14:01:16 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by michel.telenet-ops.be with bizsmtp id zu1C2700V20ykKC06u1Drb; Tue, 26 Jul 2022 20:01:13 +0200 Message-ID: <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> Date: Tue, 26 Jul 2022 20:01:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> From: Maxime Devos In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0dNgFSNYs0s9XFblehdDbRPL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1658858473; bh=p4VPAMnq/45V09iUnalxnr8mlLYtXy6rlY/UYvTFNkc=; h=Date:To:References:From:Subject:In-Reply-To; b=I+3LeIj/U87MhOFcK+6V+4P7RWC95Oe9aYn0ADRRS4++2zpp/r5n58/umn+z2FmVu 8J4c4j32ru2HlyxC5ztR8tkTivTztlE7WhhWCk95sDBetUPZ/ulxvq1RXnkySmm7Ph IHJ73rpzIt7chimS3hLHCeMk6bJQ/b/JEgq3zVHtTi09pECYdtIe+QBI4gyhqgx75H MmnRY/Mk6iAr4h5IbC66Y4oASR3rmHbCy2BGerQNsoRZGdYQp9cVhqWiwY2bxpPrjB jLjg3WcaUfLya/DGEWS28dwY9NwwRyESxA1hBKkOEz58MS9CL7zF/YHbJe3y2Ci9eI v4mU4pqfVfA2Q== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0dNgFSNYs0s9XFblehdDbRPL Content-Type: multipart/mixed; boundary="------------m8lyZbp0qOvuBPKIXi0VaeTW"; protected-headers="v1" From: Maxime Devos To: Marcel van der Boom , 56766@debbugs.gnu.org Message-ID: <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> Subject: Re: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> --------------m8lyZbp0qOvuBPKIXi0VaeTW Content-Type: multipart/mixed; boundary="------------GHUjGIMH2qMQ5fGsLIesBTgs" --------------GHUjGIMH2qMQ5fGsLIesBTgs Content-Type: multipart/alternative; boundary="------------qac42pprCZ49G4NllRfSh0zj" --------------qac42pprCZ49G4NllRfSh0zj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyNS0wNy0yMDIyIDIxOjQ3LCBNYXJjZWwgdmFuIGRlciBCb29tIHdyb3RlOg0KPiAr ICAgICAgIChwYXRjaGVzDQo+ICsgICAgICAgIChpZiAodGFyZ2V0LXBwYzY0bGU/KQ0KPiAr ICAgICAgICAgICAgKGxpc3QgKHNlYXJjaC1wYXRjaCAiZXhpdjItcHBjNjQucGF0Y2giKSkp KSkpDQoNClRoZSBzZWNvbmQgYnJhbmNoIG9mIHRoZSAnaWYnIGlzIG1pc3NpbmcgLS0gYXMt aXMsICp1bnNwZWNpZmllZCogaXMgdXNlZCANCndoZW4gKG5vdCAodGFyZ2V0LXBwYzY0bGU/ KSksIHdoaWNoIHdvbid0IHdvcmsuDQoNClRoZSAncGF0Y2hlcycgZmllbGQgaXMgZGVsYXll ZCwgbm90IHRodW5rZWQsIHNvIG9ubHkgdGhlIGZpcnN0IA0Kc3lzdGVtK3RhcmdldCBpdCBz ZWVzIHdpbGwgdGFrZSBlZmZlY3QuIFRoaXMgd2lsbCBicmVhayB0aGluZ3MgaWYgZm9yIA0K d2hhdGV2ZXIgcmVhc29uIHlvdSBjb21wdXRlIHRoZSBkZXJpdmF0aW9uIG9mIHRoZSBwYWNr YWdlIGZvciBtdWx0aXBsZSANCnN5c3RlbXMgaW4gdGhlIHNhbWUgcHJvY2Vzcy4NCg0KVG8g c29sdmUgdGhpbmdzLCBJIHJlY29tbWVuZDoNCg0KIDEuIEluZm9ybSB1cHN0cmVhbSB0aGF0 IHRoZSB0ZXN0IChvciB0aGUgY29kZSBpdCB0ZXN0cykgaXMgYnJva2VuIG9uDQogICAgcHBj NjRsZSwgc3VjaCB0aGF0IGEgYmV0dGVyIHRlc3QgY2FuIGJlIGRldmlzZWQgYW5kIGV2ZXJ5 b25lIChub3QNCiAgICBvbmx5IEd1aXgpIGJlbmVmaXRzLA0KIDIuIGFuZCBmb3Igbm93LCBt b2RpZnkgdGhlIHRlc3QgZmlsZSBpbiBhIHBoYXNlICh1c2luZyAnc3Vic3RpdHV0ZSonKQ0K ICAgIC0tIHBoYXNlcyBhcmUgdGh1bmtlZCBpbnN0ZWFkIG9mIGRlbGF5ZWQgb3IgZGlyZWN0 LCBzbyB0aGUgaXNzdWUNCiAgICBtZW50aW9uZWQgYWJvdmUgZG9lc24ndCBob2xkLg0KDQpH cmVldGluZ3MsDQpNYXhpbWUuDQoNCg== --------------qac42pprCZ49G4NllRfSh0zj Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 25-07-2022 21:47, Marcel van der Boom wrote:
+       (patches
+        (if (target-ppc64le?)
+            (list (search-patch "exiv2-ppc64.patch"))))))

The second branch of the 'if' is missing -- as-is, *unspecified* is used when (not (target-ppc64le?)), which won't work.

The 'patches' field is delayed, not thunked, so only the first system+target it sees will take effect. This will break things if for whatever reason you compute the derivation of the package for multiple systems in the same process.

To solve things, I recommend:

  1. Inform upstream that the test (or the code it tests) is broken on ppc64le, such that a better test can be devised and everyone (not only Guix) benefits,
  2. and for now, modify the test file in a phase (using 'substitute*') -- phases are thunked instead of delayed or direct, so the issue mentioned above doesn't hold.

Greetings,
Maxime.

--------------qac42pprCZ49G4NllRfSh0zj-- --------------GHUjGIMH2qMQ5fGsLIesBTgs Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------GHUjGIMH2qMQ5fGsLIesBTgs-- --------------m8lyZbp0qOvuBPKIXi0VaeTW-- --------------0dNgFSNYs0s9XFblehdDbRPL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuAr6AUDAAAAAAAKCRBJ4+4iGRcl7k8Q AP41tDvSOjumYCwFrMAgVFcKsIRuDzzXhF43Mpku3imObwEAluLxt6v0uKrATG2gCT/b4LvHxiwf TQER+lioA1cgOgs= =d2r5 -----END PGP SIGNATURE----- --------------0dNgFSNYs0s9XFblehdDbRPL-- From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jul 2022 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marcel van der Boom , 56766@debbugs.gnu.org Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.16588585377085 (code B ref 56766); Tue, 26 Jul 2022 18:03:02 +0000 Received: (at 56766) by debbugs.gnu.org; 26 Jul 2022 18:02:17 +0000 Received: from localhost ([127.0.0.1]:54353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGOsq-0001qB-Om for submit@debbugs.gnu.org; Tue, 26 Jul 2022 14:02:17 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:51500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGOsp-0001ns-Ap for 56766@debbugs.gnu.org; Tue, 26 Jul 2022 14:02:15 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by michel.telenet-ops.be with bizsmtp id zu2E2700Q20ykKC06u2E0o; Tue, 26 Jul 2022 20:02:15 +0200 Message-ID: <61a863e3-c862-a799-c7b1-ba0d56bd92d0@telenet.be> Date: Tue, 26 Jul 2022 20:02:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> From: Maxime Devos In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------jwKC7UE6Rou2yzeK4Xpaywgo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1658858535; bh=HDutCGSABXu36k9cirTqRCwaUS5nhQxe3dYTMXz8LQU=; h=Date:Subject:To:References:From:In-Reply-To; b=a8TvGQ2xuxb3Egi55J3gWGo0qqnEoMpYuRaX+34ZXikPxt+kjfD0nfpPJBfkGzl6D 6G4cFjFN4DEicYhcLoZpQYrg9F9xjpGJvWh+Sy6bdojrz2MUkFzLvgNRtY8V7hYUjf zv78LNFi8AkZbeQ8inKV6pG2GghA7sDZ11WI3HnRNCFh1tJ+O4wU/lLRLC1g30LzHu hiOu05tz23FzdsN60YaTfDrhDKYTbjuwqAvGvrhBL7d77z7gnLWFsh3yLb5omHEsXr 38caRzVtFjEguJ8AZZnNdxlmJituKssAA0IWTrii0MoNLTArVMBBR0NEKp0WFsi7kr fd/P00thnMcaQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------jwKC7UE6Rou2yzeK4Xpaywgo Content-Type: multipart/mixed; boundary="------------qwTxLLTHDku8rU659SjXpN55"; protected-headers="v1" From: Maxime Devos To: Marcel van der Boom , 56766@debbugs.gnu.org Message-ID: <61a863e3-c862-a799-c7b1-ba0d56bd92d0@telenet.be> Subject: Re: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> --------------qwTxLLTHDku8rU659SjXpN55 Content-Type: multipart/mixed; boundary="------------z5YAPjOnfyITFyQ7KsR53eYO" --------------z5YAPjOnfyITFyQ7KsR53eYO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyNS0wNy0yMDIyIDIxOjQ3LCBNYXJjZWwgdmFuIGRlciBCb29tIHdyb3RlOg0KPiBu ZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwLi5hNzRhN2FjMWI3DQo+ IC0tLSAvZGV2L251bGwNCj4gKysrIGIvZ251L3BhY2thZ2VzL3BhdGNoZXMvZXhpdjItcHBj NjQucGF0Y2gNCj4gQEAgLTAsMCArMSwxMSBAQA0KPiArLS0tIC90ZXN0cy9idWdmaXhlcy9n aXRodWIvdGVzdF9DVkVfMjAxOF8xMjI2NS5weQ0KPiArKysrIC90ZXN0cy9idWdmaXhlcy9n aXRodWIvdGVzdF9DVkVfMjAxOF8xMjI2NS5weQ0KPiArQEAgLTE4LDcgKzE4LDYgQEANCj4g KyBXYXJuaW5nOiBEaXJlY3RvcnkgSW1hZ2UsIGVudHJ5IDB4MDIwMTogU3RyaXAgMCBpcyBv dXRzaWRlIG9mIHRoZSBkYXRhIGFyZWE7IGlnbm9yZWQuDQo+ICsgV2FybmluZzogRGlyZWN0 b3J5IEltYWdlLCBlbnRyeSAweDAyMDE6IFN0cmlwIDcgaXMgb3V0c2lkZSBvZiB0aGUgZGF0 YSBhcmVhOyBpZ25vcmVkLg0KPiArIEVycm9yOiBPZmZzZXQgb2YgZGlyZWN0b3J5IFRodW1i bmFpbCwgZW50cnkgMHgwMjAxIGlzIG91dCBvZiBib3VuZHM6IE9mZnNldCA9IDB4MDAwMDAw MDA7IHRydW5jYXRpbmcgdGhlIGVudHJ5DQoNCg0KSUlVQywgImd1aXggbGludCIgaGFzIGEg bGludGVyIHRoYXQgdmVyaWZpZXMgdGhhdCB0aGUgcGF0Y2ggY29udGFpbnMgYSANCmxpbmsg dG8gdGhlIHVwc3RyZWFtIGlzc3VlLsKgIEl0IGlzIGFsc28gcmVxdWlyZWQgdG8gYWRkIGFu IGVudHJ5IHRvIA0KZ251L2xvY2FsLm1rLCBzdWNoIHRoYXQgaXQgaXMgYWRkZWQgdG8gcmVs ZWFzZSB0YXJiYWxscy4NCg0KR3JlZXRpbmdzLA0KTWF4aW1lLg0KDQo= --------------z5YAPjOnfyITFyQ7KsR53eYO Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------z5YAPjOnfyITFyQ7KsR53eYO-- --------------qwTxLLTHDku8rU659SjXpN55-- --------------jwKC7UE6Rou2yzeK4Xpaywgo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuAsJgUDAAAAAAAKCRBJ4+4iGRcl7i6/ AP9sPQn7kwaRjJylC6oN7n3VobNA7cut5YYdmTxwXP1wOwEAosb13fHSUxoaM4S+jx7aM7sf/79T YLSdFg2cfgcCMQs= =MIuC -----END PGP SIGNATURE----- --------------jwKC7UE6Rou2yzeK4Xpaywgo-- From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Resent-From: Marcel van der Boom Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jul 2022 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 56766@debbugs.gnu.org Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.165886112712409 (code B ref 56766); Tue, 26 Jul 2022 18:46:01 +0000 Received: (at 56766) by debbugs.gnu.org; 26 Jul 2022 18:45:27 +0000 Received: from localhost ([127.0.0.1]:54403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGPYc-0003E4-PX for submit@debbugs.gnu.org; Tue, 26 Jul 2022 14:45:27 -0400 Received: from read.hsdev.com ([209.250.245.235]:54666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGPYX-0003Dg-Bm for 56766@debbugs.gnu.org; Tue, 26 Jul 2022 14:45:25 -0400 Received: from hsdev.com (hawking.hsdev.com [213.125.12.142]) by read.hsdev.com (Postfix) with ESMTPA id 8B66B202EB; Tue, 26 Jul 2022 20:45:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=van-der-boom.nl; s=202103; t=1658861114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gSm3Nl6nkna/sADSszajAI5rtSWQbXVlrS3nXj5nIEo=; b=P1LTSZLRgg6rN1+rOI3sr6y4PtPGCk0/xDep9P56DLUfnlYPrYgoN2rdW9kXU4ncjiRvSR DjAHQ18elgedczZ/TrJtv9uc0z62M4dYWUX2WfOV9aaRfz1XHUIdXH9F4PyTVfNMFVB1TU 5CmkPrWWdl85ZpmVcVTyxkxnIdPn+7g= Received: from changeme.hsdev.com (localhost [127.0.0.1]) by hsdev.com (Postfix) with ESMTP id 55D1036A0261; Tue, 26 Jul 2022 20:45:14 +0200 (CEST) References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> User-agent: mu4e 1.8.6; emacs 29.0.50 From: Marcel van der Boom Date: Tue, 26 Jul 2022 20:38:51 +0200 In-reply-to: <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> Message-ID: <877d3zemrq.fsf@van-der-boom.nl> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -1.97 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed Thanks for the review, some notes/questions inline below. [Maxime Devos]: > The 'patches' field is delayed, not thunked, so only the first > system+target it sees will take effect. This will break things > if for whatever reason you compute the derivation of the package > for multiple systems in the same process. Where can I read up on 'delayed' vs 'thunked' to understand that concept? I have no idea what it is at the moment and the manual does not mention this. > To solve things, I recommend: > 1. Inform upstream that the test (or the code it tests) is > broken on > ppc64le, such that a better test can be devised and everyone > (not > only Guix) benefits, This has been done. Their reply, in short: ppc64 is not on their supported platforms list and they delegate the fix to others. marcel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE82U2v1mzEPiKRr69PyiQ+QAAY6AFAmLgNjkACgkQPyiQ+QAA Y6CRBQf+PVAvxQp71c1D9KfDsU8pIQbnWiQKqUXZtUYVasVhidW95G5nc33jLxzC xNUxJ/0vgjNvME85ZYjJcjmkA4LZLYP9KEZTDbWIHm9Mfu1qxRBzc1Ohw8GgrIdr 5Jhk6ODr4fv5YyrxjFERv5+WWSPYiSkRIWf58EBYLI8uEMElDs25YA2kC50yDPao XbfK3g1q0rmpyksOyjwOx+NQsPNqwLMtHiWyyBmya8zdkuJH4gV6BXABH+Qd/pNl 7uZD5wh67qfMs6E9/VetNEBsy+KPmloCqmBv3pXBo7RtYahlGCgam7wTgkgdaVwb yJxss5vTe8x5rvPVX1PqAMvoddzk+g== =mfNZ -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jul 2022 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marcel van der Boom Cc: 56766@debbugs.gnu.org Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.165886171913784 (code B ref 56766); Tue, 26 Jul 2022 18:56:02 +0000 Received: (at 56766) by debbugs.gnu.org; 26 Jul 2022 18:55:19 +0000 Received: from localhost ([127.0.0.1]:54419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGPiA-0003aG-Vi for submit@debbugs.gnu.org; Tue, 26 Jul 2022 14:55:19 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:59688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGPi7-0003a2-M8 for 56766@debbugs.gnu.org; Tue, 26 Jul 2022 14:55:17 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id zuvE2700120ykKC01uvE5M; Tue, 26 Jul 2022 20:55:14 +0200 Message-ID: <73c26ae4-d0f3-1dfb-99f0-1234b3020256@telenet.be> Date: Tue, 26 Jul 2022 20:55:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> <877d3zemrq.fsf@van-der-boom.nl> From: Maxime Devos In-Reply-To: <877d3zemrq.fsf@van-der-boom.nl> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------VRG65B9GGJFar09rOeOpOcNZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1658861714; bh=1VolS3nZ3jbujuuIgOe6nkqhDhaAhofNoTVju7lDEtM=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=aH9KVUz+awjqqu6DI+G5Nw5bHriMUgHq8rbACxBmKGiBHotpo7RuBihqGAnkspb9V uKkpvyrFLnsCZQyCL5wrdTc2FQr62z7h8RlzqqO8ZPhWRkdyWgNfo1eZF+20ZvsrAa LM1Ldnp9AMaSarXFa63o2qfuRxpp2wLBXvhV5KjvIhYvCWy46Kwycu9/NouYlxxXet vZrWivWTK6xQTVlqHNLCVvuq/6ZMlSaZUPZCe6DCuJ5V8F6YFChtaBWzO+pf8JhI4Q /cYCXGipwTzpxLt42jNtYZEDFRnSBJ0pRM1fzxIbq6SwME5JPoWuf8EBN0hlbtYvZO tQHJKDlPG5BcQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------VRG65B9GGJFar09rOeOpOcNZ Content-Type: multipart/mixed; boundary="------------TdlqGY0cP6m00Pz9w9QUHMdT"; protected-headers="v1" From: Maxime Devos To: Marcel van der Boom Cc: 56766@debbugs.gnu.org Message-ID: <73c26ae4-d0f3-1dfb-99f0-1234b3020256@telenet.be> Subject: Re: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> <9487ab96-82a7-8260-43bb-db3ac6b73688@telenet.be> <877d3zemrq.fsf@van-der-boom.nl> In-Reply-To: <877d3zemrq.fsf@van-der-boom.nl> --------------TdlqGY0cP6m00Pz9w9QUHMdT Content-Type: multipart/mixed; boundary="------------c9gRXxTJq3j96OR8mVyxmnpQ" --------------c9gRXxTJq3j96OR8mVyxmnpQ Content-Type: multipart/alternative; boundary="------------aP7pWBSyJ70xWj0QMcE7Fv5c" --------------aP7pWBSyJ70xWj0QMcE7Fv5c Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyNi0wNy0yMDIyIDIwOjM4LCBNYXJjZWwgdmFuIGRlciBCb29tIHdyb3RlOg0KPj4g VGhlICdwYXRjaGVzJyBmaWVsZCBpcyBkZWxheWVkLCBub3QgdGh1bmtlZCwgc28gb25seSB0 aGUgZmlyc3QgDQo+PiBzeXN0ZW0rdGFyZ2V0IGl0IHNlZXMgd2lsbCB0YWtlIGVmZmVjdC4g VGhpcyB3aWxsIGJyZWFrIHRoaW5ncyBpZiBmb3IgDQo+PiB3aGF0ZXZlciByZWFzb24geW91 IGNvbXB1dGUgdGhlIGRlcml2YXRpb24gb2YgdGhlIHBhY2thZ2UgZm9yIA0KPj4gbXVsdGlw bGUgc3lzdGVtcyBpbiB0aGUgc2FtZSBwcm9jZXNzLg0KPg0KPiBXaGVyZSBjYW4gSSByZWFk IHVwIG9uICdkZWxheWVkJyB2cyAndGh1bmtlZCcgdG8gdW5kZXJzdGFuZCB0aGF0IA0KPiBj b25jZXB0PyBJIGhhdmUgbm8gaWRlYSB3aGF0IGl0IGlzIGF0IHRoZSBtb21lbnQgYW5kIHRo ZSBtYW51YWwgZG9lcyANCj4gbm90IG1lbnRpb24gdGhpcy4gDQoNCkFGQUlDVCwgaXQgaXMg bm90IGRvY3VtZW50ZWQsIHRob3VnaCB5b3UgY291bGQgcmVhZCB0aGUgY29kZSBhdCAoZ3Vp eCANCnJlY29yZHMpLiBCYXNpY2FsbHk6DQoNCiogdGh1bmtlZCA9IGZpZWxkIHZhbHVlIGlz IHdyYXBwZWQgaW4gYSAobGFtYmRhICgpIHRoZS12YWx1ZSkuDQoNCiDCoCBUaGlzIGFsbG93 cyBmb3IgdGFyZ2V0LXNwZWNpZmljIGlucHV0cywgYXMgKGlucHV0cyAobGlzdCAoaWYgDQpJ dCdzLXRoaXMtYXJjaGl0ZWN0dXJlIHRoZXNlIHRob3NlKSkpIGlzIGludGVybmFsbHkgdHJh bnNsYXRlZCB0bw0KDQogwqAgKGlucHV0cyAobGFtYmRhICgpIChpZiBbLi4uXSBbLi4uXSBb Li4uXSkpKS4NCg0KIMKgIFRoYXQgd2F5LCB0aGUgaW5wdXRzIGFyZSBub3QgZGVjaWRlZCB3 aGVuIHRoZSBwYWNrYWdlIGlzIGJlaW5nIA0KZGVmaW5lZCwgYnV0IHdoZW4gaXQgaXMgY29t cGlsZWQgdG8gYSBwYXJ0aWN1bGFyIGFyY2hpdGVjdHVyZSBvbiBhIA0KcGFydGljdWxhciBh cmNoaXRlY3R1cmUgKG9yIG1vcmUgcHJlY2lzZWx5LCBhIGxpdHRsZSBiZWZvcmUgYnVpbGRp bmcsIGluIA0Kd2hhdCBpcyBjYWxsZWQgJ2xvd2VyaW5nJywgd2hpY2ggaXMgYSBiaXQgb2Yg YSBsb3ctbGV2ZWwgY29uY2VwdCBhbmQgDQpoZW5jZSBwcm9iYWJseSBub3Qgd2VsbC1rbm93 bikuDQoNCiogZGVsYXllZCA9IGZpZWxkIHZhbHVlIGlzIHdyYXBwZWQgaW4gYSAoZGVsYXkg dGhlLXZhbHVlKS4NCg0KIMKgwqAgRm9yIGRvY3VtZW50YXRpb24gb24gJ2RlbGF5Jywgc2Vl IHRoZSBtYW51YWwuIFRoaXMgaXMgdXNlZnVsIGZvciANCmF2b2lkaW5nIGNvbXB1dGF0aW9u IHVudGlsIGl0J3MgcmVhbGx5IG5lZWRlZCwgYnV0IHVubGlrZSAnbGFtYmRhJywgaXQgDQp3 aWxsIG9ubHkgYmUgY29tcHV0ZWQgb25jZSwgc28gb25seSB0aGUgZmlyc3QgdmFsdWUgb2Yg dGhlLXZhbHVlIGlzIA0KdGFrZW4gaW4gYWNjb3VudC4gQXMgc3VjaCwgdGhpcyB3b24ndCB3 b3JrIHdlbGwgd2hlbiB0YXJnZXQtc3BlY2lmaWMgDQp0aGluZ3MgYXJlIHJlcXVpcmVkLg0K DQpHcmVldGluZ3MsDQpNYXhpbWUuDQoNCg== --------------aP7pWBSyJ70xWj0QMcE7Fv5c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 26-07-2022 20:38, Marcel van der Boom wrote:
The 'patches' field is delayed, not thunked, so only the first system+target it sees will take effect. This will break things if for whatever reason you compute the derivation of the package for multiple systems in the same process.

Where can I read up on 'delayed' vs 'thunked' to understand that concept? I have no idea what it is at the moment and the manual does not mention this.

AFAICT, it is not documented, though you could read the code at (guix records). Basically:

* thunked =3D field value is wrapped in a (lambda () the-value).

=C2=A0 This allows for target-specific inputs, as (inputs (list (i= f It's-this-architecture these those))) is internally translated to

=C2=A0 (inputs (lambda () (if [...] [...] [...]))).

=C2=A0 That way, the inputs are not decided when the package is be= ing defined, but when it is compiled to a particular architecture on a particular architecture (or more precisely, a little before building, in what is called 'lowering', which is a bit of a low-level concept and hence probably not well-known).

* delayed =3D field value is wrapped in a (delay the-value).

=C2=A0=C2=A0 For documentation on 'delay', see the manual. This is= useful for avoiding computation until it's really needed, but unlike 'lambda', it will only be computed once, so only the first value of the-value is taken in account. As such, this won't work well when target-specific things are required.

Greetings,
Maxime.

--------------aP7pWBSyJ70xWj0QMcE7Fv5c-- --------------c9gRXxTJq3j96OR8mVyxmnpQ Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------c9gRXxTJq3j96OR8mVyxmnpQ-- --------------TdlqGY0cP6m00Pz9w9QUHMdT-- --------------VRG65B9GGJFar09rOeOpOcNZ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuA4kQUDAAAAAAAKCRBJ4+4iGRcl7rNX AP4s96KHZotqNbTNYasK5qaDpsQIJHPbef4Lc/v13eI3GwEAgW7WWlhmiNYlFEbbrOB+cL8/0W1R TL9t8yQndmpZ+wA= =kjPx -----END PGP SIGNATURE----- --------------VRG65B9GGJFar09rOeOpOcNZ-- From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jul 2022 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marcel van der Boom , 56766@debbugs.gnu.org Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.165886268115656 (code B ref 56766); Tue, 26 Jul 2022 19:12:01 +0000 Received: (at 56766) by debbugs.gnu.org; 26 Jul 2022 19:11:21 +0000 Received: from localhost ([127.0.0.1]:54424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGPxg-00044P-Nc for submit@debbugs.gnu.org; Tue, 26 Jul 2022 15:11:21 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:47092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGPxe-00044D-BZ for 56766@debbugs.gnu.org; Tue, 26 Jul 2022 15:11:19 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id zvBG2700920ykKC01vBGAb; Tue, 26 Jul 2022 21:11:16 +0200 Message-ID: <4f61b4a9-a299-dc9a-c817-a74909091a6c@telenet.be> Date: Tue, 26 Jul 2022 21:11:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> From: Maxime Devos In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------taE8ESYe5mvLXxV6xfsKC70q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1658862676; bh=zr1PaWt9Bz1rowKpfvVRI+3UGTNKxieVomxnd36TvmQ=; h=Date:To:References:From:Subject:In-Reply-To; b=RiCuUaROrq9Xi8S4qQobFqTaxkKg641/qtnDPjdTGOkGHZYHu0kgdIqTgYPWljbeW 2sbwoHzea+DZzme8wZ8mODpKwO64CtXG+fip4WdWvnXwY0i3T+ibMKOmpY/molz39l 6jHflO4dtC+VxMoYnXr5K2KNmw7sFwpa2QMWG/qFVGqqcZ2zdUXdDOCIbuEkY3GiCO OzFJ5PnUNmkDPC5Yxl/htpxwmfF+jZv802uL9mnzVzNR0f7Mnxjz1Av3IXvg5upwcm TBeRyvUjBbHH09ZyOVVMPZFwl6FCUDewpuXLCAFoq+kIwHC6aZgq+IgazZVeMzu5jM yBGkiksA66rxQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------taE8ESYe5mvLXxV6xfsKC70q Content-Type: multipart/mixed; boundary="------------Ir4czRRlsZaUM7n0vsuNUsi1"; protected-headers="v1" From: Maxime Devos To: Marcel van der Boom , 56766@debbugs.gnu.org Message-ID: <4f61b4a9-a299-dc9a-c817-a74909091a6c@telenet.be> Subject: Re: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> --------------Ir4czRRlsZaUM7n0vsuNUsi1 Content-Type: multipart/mixed; boundary="------------wOZ12EtA60d0rovVH47k5Hk0" --------------wOZ12EtA60d0rovVH47k5Hk0 Content-Type: multipart/alternative; boundary="------------gt2D0alcO4X4bEMUxyWgvPFg" --------------gt2D0alcO4X4bEMUxyWgvPFg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 Pj4gMS4gSW5mb3JtIHVwc3RyZWFtIHRoYXQgdGhlIHRlc3QgKG9yIHRoZSBjb2RlIGl0IHRl c3RzKSBpcyBicm9rZW4gb24NCj4+IMKgwqAgcHBjNjRsZSwgc3VjaCB0aGF0IGEgYmV0dGVy IHRlc3QgY2FuIGJlIGRldmlzZWQgYW5kIGV2ZXJ5b25lIMKgwqAgKG5vdA0KPj4gwqDCoCBv bmx5IEd1aXgpIGJlbmVmaXRzLA0KPg0KPiBUaGlzIGhhcyBiZWVuIGRvbmUuIFRoZWlyIHJl cGx5LCBpbiBzaG9ydDogcHBjNjQgaXMgbm90IG9uIHRoZWlyIA0KPiBzdXBwb3J0ZWQgcGxh dGZvcm1zIGxpc3QgYW5kIHRoZXkgZGVsZWdhdGUgdGhlIGZpeCB0byBvdGhlcnMuIA0KT0ss IGluIHRoYXQgY2FzZSAuLi4NCg0KT24gMjUtMDctMjAyMiAyMTo0NywgTWFyY2VsIHZhbiBk ZXIgQm9vbSB3cm90ZToNCj4gKy0tLSAvdGVzdHMvYnVnZml4ZXMvZ2l0aHViL3Rlc3RfQ1ZF XzIwMThfMTIyNjUucHkNCj4gKysrKyAvdGVzdHMvYnVnZml4ZXMvZ2l0aHViL3Rlc3RfQ1ZF XzIwMThfMTIyNjUucHkNCj4gK0BAIC0xOCw3ICsxOCw2IEBADQo+ICsgV2FybmluZzogRGly ZWN0b3J5IEltYWdlLCBlbnRyeSAweDAyMDE6IFN0cmlwIDAgaXMgb3V0c2lkZSBvZiB0aGUg ZGF0YSBhcmVhOyBpZ25vcmVkLg0KPiArIFdhcm5pbmc6IERpcmVjdG9yeSBJbWFnZSwgZW50 cnkgMHgwMjAxOiBTdHJpcCA3IGlzIG91dHNpZGUgb2YgdGhlIGRhdGEgYXJlYTsgaWdub3Jl ZC4NCj4gKyBFcnJvcjogT2Zmc2V0IG9mIGRpcmVjdG9yeSBUaHVtYm5haWwsIGVudHJ5IDB4 MDIwMSBpcyBvdXQgb2YgYm91bmRzOiBPZmZzZXQgPSAweDAwMDAwMDAwOyB0cnVuY2F0aW5n IHRoZSBlbnRyeQ0KPiArLSR1bmNhdWdodF9leGNlcHRpb24gJGFkZGl0aW9uX292ZXJmbG93 X21lc3NhZ2UNCj4gKyAiIiINCj4gKyAgICAgXQ0KPiArLSAgICByZXR2YWwgPSBbMV0NCj4g KysgICAgcmV0dmFsID0gWzBdDQoNCi4uLiB0aGlzIGlzIHlvdXIgcHJvcG9zZWQgZml4IGZv ciBwb3dlcnBjNjRsZSwgYnV0IGhvdyBkbyB3ZSBrbm93IA0Kd2hldGhlciBpdCBpcyBjb3Jy ZWN0PyBJcyB0aGlzIGp1c3QgcmV3cml0aW5nIHRoZSB0ZXN0IHVudGlsIGl0IHBhc3Nlcywg DQpoaWRpbmcgdGhlIHVuZGVybHlpbmcgb3ZlcmZsb3cgYnVnIHdoaWNoIGV2ZW4gaGFkIGFu IENWRSBzbyBwcm9iYWJseSANCnByZXR0eSBpbXBvcnRhbnQgdG8gbm90IGhpZGUgaXQgYW5k IGFjdHVhbGx5IGZpeCBpdCwgb3IgZG8gd2Uga25vdyBmb3IgYSANCmZhY3QgdGhhdCBvbiBw cGM2NGxlLCBhIHJldHZhbCA9IFswXSBpcyBjb3JyZWN0Pw0KDQpNYXliZSB0aGlzIGlzIGFu c3dlcmVkIGJ5Og0KDQo+IHBwYzY0IGFuZCBhcm0gZG8gbm90IHJhaXNlIGV4Y2VwdGlvbiBh bmQgdGh1cyBvdXRwdXQgYW5kIGV4aXQgY29kZSBmb3IgdGVzdCBpcyBkaWZmZXJlbnQuDQpi dXQgSSBkb24ndCBrbm93IGlmIHRoYXQncyB3b3JraW5nIGFyb3VuZCBzeW1wdG9tcyBvciBh ZGRyZXNzaW5nIHRoZSANCmNhdXNlLCBlLmcuIA0KaHR0cHM6Ly9naXRodWIuY29tL0V4aXYy L2V4aXYyL2lzc3Vlcy85MzMjaXNzdWVjb21tZW50LTg2MzMzMzAzMiBub3RpY2VkIA0Kc29t ZXRoaW5nIG9uIG9mZnNldHMgLS0gc3VtbWFyaXNlZCwgdGhpcyBpcyBub3QgYSBzdWZmaWNp ZW50bHkgDQpjb252aW5jaW5nIGV4cGxhbmF0aW9uIGZvciBtZS4NCg0KQWxzbywgc29tZWhv dyB0aGlzIHZlcnNpb24gb2YgdGhlIHBhY2thZ2UgYnVpbGRzIG9uIERlYmlhbiBzaWQsIHNv IG1heWJlIA0KRGViaWFuIGtub3dzIG1vcmUsIHRob3VnaCBJJ20gbm90IGZpbmRpbmcgYW55 dGhpbmcgcmVsZXZhbnQgaW4gdGhlIA0KRGViaWFuIHBhY2thZ2UgbXlzZWxmLg0KDQpHcmVl dGluZ3MsDQpNYXhpbWUuDQoNCg== --------------gt2D0alcO4X4bEMUxyWgvPFg Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

1. Inform upstream that the test (or the code it tests) is broken on
=C2=A0=C2=A0 ppc64le, such that a better test can be devised an= d everyone =C2=A0=C2=A0 (not
=C2=A0=C2=A0 only Guix) benefits,

This has been done. Their reply, in short: ppc64 is not on their supported platforms list and they delegate the fix to others.
OK, in that case ...

On 25-07-2022 21:47, Marcel van der Boom wrote:
+--- /tests/bugfixes/github/=
test_CVE_2018_12265.py
++++ /tests/bugfixes/github/test_CVE_2018_12265.py
+@@ -18,7 +18,6 @@
+ Warning: Directory Image, entry 0x0201: Strip 0 is outside of the data =
area; ignored.
+ Warning: Directory Image, entry 0x0201: Strip 7 is outside of the data =
area; ignored.
+ Error: Offset of directory Thumbnail, entry 0x0201 is out of bounds: Of=
fset =3D 0x00000000; truncating the entry
+-$uncaught_exception $addition_overflow_message
+ """
+     ]
+-    retval =3D [1]
++    retval =3D [0]

... this is your proposed fix for powerpc64le, but how do we know whether it is correct? Is this just rewriting the test until it passes, hiding the underlying overflow bug which even had an CVE so probably pretty important to not hide it and actually fix it, or do we know for a fact that on ppc64le, a retval =3D [0] is correct?

Maybe this is answered by:

ppc64 and arm do not raise=
 exception and thus output and exit code for test is different.
but I don't know if that's working around symptoms or addressing the cause, e.g. https://github.com/Exiv2/exiv2/= issues/933#issuecomment-863333032 noticed something on offsets -- summarised, this is not a sufficiently convincing explanation for me.

Also, somehow this version of the package builds on Debian sid, so maybe Debian knows more, though I'm not finding anything relevant in the Debian package myself.

Greetings,
Maxime.

--------------gt2D0alcO4X4bEMUxyWgvPFg-- --------------wOZ12EtA60d0rovVH47k5Hk0 Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------wOZ12EtA60d0rovVH47k5Hk0-- --------------Ir4czRRlsZaUM7n0vsuNUsi1-- --------------taE8ESYe5mvLXxV6xfsKC70q Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuA8VAUDAAAAAAAKCRBJ4+4iGRcl7gAX AP9cQYKKPPPQifTQhjkjnK4V0w1Rr3eh3PKSoJDKsERHawEA2SDaBDoWO5nvMMwgJA3cef6Za9Sm l0cHqI5dSweNbwU= =ESDr -----END PGP SIGNATURE----- --------------taE8ESYe5mvLXxV6xfsKC70q-- From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le Resent-From: Marcel van der Boom Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Jul 2022 21:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 56766@debbugs.gnu.org Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.165886965829607 (code B ref 56766); Tue, 26 Jul 2022 21:08:02 +0000 Received: (at 56766) by debbugs.gnu.org; 26 Jul 2022 21:07:38 +0000 Received: from localhost ([127.0.0.1]:54505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGRmE-0007hT-Gt for submit@debbugs.gnu.org; Tue, 26 Jul 2022 17:07:38 -0400 Received: from read.hsdev.com ([209.250.245.235]:56078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGRmA-0007hC-JZ for 56766@debbugs.gnu.org; Tue, 26 Jul 2022 17:07:37 -0400 Received: from hsdev.com (hawking.hsdev.com [213.125.12.142]) by read.hsdev.com (Postfix) with ESMTPA id 6500020FBD; Tue, 26 Jul 2022 23:07:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=van-der-boom.nl; s=202103; t=1658869648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ub93Y1KeEPpPLrQg6/oEb3C/LPerNqeg9LsZuZKKsUU=; b=zB8rL45sMGlmyCgv1YQPHNLOiMHCFKcMw4e/hTiTZZrqFlHtdY+IKWeCqYwIn4Qp49FT+i dvIByoFYj+5pUYPAprSyxJxP0Kg5ILijEpuIiE0PGWOJ/+fp2oqsG7/QmaJtafyVmiKDg5 TS1JXr8HWYN+akzGd5Iaj1k5vNTep+M= Received: from changeme.hsdev.com (localhost [127.0.0.1]) by hsdev.com (Postfix) with ESMTP id 0473F36A2995; Tue, 26 Jul 2022 23:07:28 +0200 (CEST) References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> <4f61b4a9-a299-dc9a-c817-a74909091a6c@telenet.be> User-agent: mu4e 1.8.6; emacs 29.0.50 From: Marcel van der Boom Date: Tue, 26 Jul 2022 21:34:00 +0200 In-reply-to: <4f61b4a9-a299-dc9a-c817-a74909091a6c@telenet.be> Message-ID: <8735eneg6o.fsf@van-der-boom.nl> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.10 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed [Maxime Devos] > Also, somehow this version of the package builds on Debian sid, > so maybe Debian knows more, though I'm not finding anything > relevant in the Debian package myself. true, and I quickly ran a debian:sid container to see what they did, but they chose the same solution. That is, the exiv2 binary from their package returns the error as well (without the exception raising). So, I guess they dont run the test suite then as there's no change in their packaging. It gave me enough confidence though to use it locally and try to package it up in guix the same way. But I agree it's rather unsatisfactory. marcel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE82U2v1mzEPiKRr69PyiQ+QAAY6AFAmLgV48ACgkQPyiQ+QAA Y6B2bggAq5jXEYmjXoe4EmqW1h2+m/6/vN11V/S0n1j0gnUwry15GpGDZSFI6rT2 uym3UAH11hVPE4b5G2NA/gSR2vIKxGqrHDbCAbRZEQ7IlW3Q/GimQq7n8asL0XwD SfqiOiQtq6SeR0rN9eaJaxnaxiR2pQjrJ8nL3RnFojJFf39F0FoPdvFYaNDtXIjv LF9eOPsUEELc7mVI6U4QsDYVuTBhrh5ds9cOGZBWzF47yDFJpC2o398y4uHT2pRA +fOiG9hB2SYpAixXcmZcCsysgqfct4P8ycYl9BfScHjl4OdATloQyv4284edYOYh 1IMuFoRUrpo6UWBuRc7GcwhBtZQUDA== =P2R3 -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] Adjust patch according to review References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> Resent-From: Marcel van der Boom Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 Jul 2022 07:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56766@debbugs.gnu.org Cc: Marcel van der Boom Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.16589078036366 (code B ref 56766); Wed, 27 Jul 2022 07:44:01 +0000 Received: (at 56766) by debbugs.gnu.org; 27 Jul 2022 07:43:23 +0000 Received: from localhost ([127.0.0.1]:54991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGbhT-0001ea-3s for submit@debbugs.gnu.org; Wed, 27 Jul 2022 03:43:23 -0400 Received: from read.hsdev.com ([209.250.245.235]:43508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGbhL-0001eE-0A for 56766@debbugs.gnu.org; Wed, 27 Jul 2022 03:43:21 -0400 Received: from hsdev.com (hawking.hsdev.com [213.125.12.142]) by read.hsdev.com (Postfix) with ESMTPA id DED582161E; Wed, 27 Jul 2022 09:43:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hsdev.com; s=201906; t=1658907787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=xpjc18l52QzxepM3scHzLJBDnhsoDP4XgPp3CeqTeYQ=; b=fQC0WBbxxVgLKzMyNLyi7QpDm8jbUsiYJVtYxuzVCnN5y5cRDm+BZ8NyVc5Ra5mxzby4KP jYSIltffWHHx3lQ1vAs7Z06AbFUXkjMNs9/hiETRTHVBmqZMAqoxAa8t0OO/UjHrpKliy6 R8C+iqLUnJPVoETA7o+mbWqne0k3wYI= Received: by hsdev.com (Postfix, from userid 1000) id 9C2D236A2995; Wed, 27 Jul 2022 09:43:07 +0200 (CEST) From: Marcel van der Boom Date: Wed, 27 Jul 2022 09:41:44 +0200 Message-Id: <4af56c93a8d990220918c65bc58c32f1c8c07aa3.1658907553.git.marcel@van-der-boom.nl> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.20 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) * gnu/packages/image.scm (exiv3): use substitution instead of patch --- gnu/packages/image.scm | 18 ++++++++++++------ gnu/packages/patches/exiv2-ppc64.patch | 11 ----------- 2 files changed, 12 insertions(+), 17 deletions(-) delete mode 100644 gnu/packages/patches/exiv2-ppc64.patch diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index dc4bf76790..9febb883b4 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -1342,13 +1342,10 @@ (define-public exiv2 (uri (string-append "https://www.exiv2.org/builds/exiv2-" version "-Source.tar.gz")) (sha256 - (base32 "1qm6bvj28l42km009nc60gffn1qhngc0m2wjlhf90si3mcc8d99m")) - (patches - (if (target-ppc64le?) - (list (search-patch "exiv2-ppc64.patch")))))) + (base32 "1qm6bvj28l42km009nc60gffn1qhngc0m2wjlhf90si3mcc8d99m")))) (build-system cmake-build-system) (arguments - '(#:test-target "tests" + `(#:test-target "tests" #:configure-flags (list "-DEXIV2_BUILD_UNIT_TESTS=ON" ;; darktable needs BMFF to support ;; CR3 files. @@ -1359,7 +1356,16 @@ (define-public exiv2 (lambda* (#:key outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (lib (string-append out "/lib"))) - (for-each delete-file (find-files lib "\\.a$")))))))) + (for-each delete-file (find-files lib "\\.a$"))))) + (add-after 'unpack 'adjust-ppc6-tests + (lambda _ + ,@(if (target-ppc64le?) + ;; Adjust test on ppc64 + ;; See: https://github.com/Exiv2/exiv2/issues/933 + '((substitute* "tests/bugfixes/github/test_CVE_2018_12265.py" + (("\\$uncaught_exception \\$addition_overflow_message\n") "") + (("retval = \\[1\\]") "retval = [0]"))) + '())))))) (propagated-inputs (list expat zlib)) (native-inputs diff --git a/gnu/packages/patches/exiv2-ppc64.patch b/gnu/packages/patches/exiv2-ppc64.patch deleted file mode 100644 index a74a7ac1b7..0000000000 --- a/gnu/packages/patches/exiv2-ppc64.patch +++ /dev/null @@ -1,11 +0,0 @@ ---- /tests/bugfixes/github/test_CVE_2018_12265.py -+++ /tests/bugfixes/github/test_CVE_2018_12265.py -@@ -18,7 +18,6 @@ - Warning: Directory Image, entry 0x0201: Strip 0 is outside of the data area; ignored. - Warning: Directory Image, entry 0x0201: Strip 7 is outside of the data area; ignored. - Error: Offset of directory Thumbnail, entry 0x0201 is out of bounds: Offset = 0x00000000; truncating the entry --$uncaught_exception $addition_overflow_message - """ - ] -- retval = [1] -+ retval = [0] base-commit: 212ca81895b2baa819ea11a308ad21880b84a546 prerequisite-patch-id: a7093ef8ccbab6d6dd7474a08f75970bcf3b9d4b -- 2.37.1 From unknown Fri Sep 12 16:03:27 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56766] [PATCH] gnu: exiv2: Fix test failure on ppc64-le References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> In-Reply-To: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> Resent-From: Marcel van der Boom Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 Aug 2022 07:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56766 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56766@debbugs.gnu.org Received: via spool by 56766-submit@debbugs.gnu.org id=B56766.165933916725556 (code B ref 56766); Mon, 01 Aug 2022 07:33:01 +0000 Received: (at 56766) by debbugs.gnu.org; 1 Aug 2022 07:32:47 +0000 Received: from localhost ([127.0.0.1]:39137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIPux-0006e7-1Y for submit@debbugs.gnu.org; Mon, 01 Aug 2022 03:32:47 -0400 Received: from read.hsdev.com ([209.250.245.235]:34298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIPut-0006dq-R3 for 56766@debbugs.gnu.org; Mon, 01 Aug 2022 03:32:45 -0400 Received: from hsdev.com (hawking.hsdev.com [213.125.12.142]) by read.hsdev.com (Postfix) with ESMTPA id 29FC82120D for <56766@debbugs.gnu.org>; Mon, 1 Aug 2022 09:32:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=van-der-boom.nl; s=202103; t=1659339157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=uOpQ9nI6AvMiTWgo2OAspWLR0DdD6VlsB6iijmxtHOg=; b=ZumMjMD2nOmUavl5dFbHW4RgrbJ6sEqu4gnJRBpKmTCeE1iYZ2e6MYb68jYp7RqqAKSBm8 VjR6LNcqNw70bI5E+k5dPhodJy+Y3gonQ9+IPqdIBwt6AfAFcBF/tI6kWD/J9pIJykog9z R3fDYF2hZ+PJP3j4IEf2ufwJRs4wVME= Received: from changeme.hsdev.com (localhost [127.0.0.1]) by hsdev.com (Postfix) with ESMTP id CC68B36A0271 for <56766@debbugs.gnu.org>; Mon, 1 Aug 2022 09:32:36 +0200 (CEST) User-agent: mu4e 1.8.6; emacs 29.0.50 From: Marcel van der Boom Date: Mon, 01 Aug 2022 09:32:10 +0200 Message-ID: <878ro8ctbf.fsf@van-der-boom.nl> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.20 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Anything else needed for this? From unknown Fri Sep 12 16:03:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Marcel van der Boom Subject: bug#56766: closed (Re: bug#56766: [PATCH] gnu: exiv2: Fix test failure on ppc64-le) Message-ID: References: <87ilncyxir.fsf_-_@gnu.org> <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> X-Gnu-PR-Message: they-closed 56766 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 56766@debbugs.gnu.org Date: Mon, 01 Aug 2022 12:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1659355922-4644-1" This is a multi-part message in MIME format... ------------=_1659355922-4644-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #56766: [PATCH] gnu: exiv2: Fix test failure on ppc64-le which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 56766@debbugs.gnu.org. --=20 56766: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56766 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1659355922-4644-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 56766-done) by debbugs.gnu.org; 1 Aug 2022 12:11:07 +0000 Received: from localhost ([127.0.0.1]:39538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIUGJ-0001Bi-CG for submit@debbugs.gnu.org; Mon, 01 Aug 2022 08:11:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIUGE-0001BA-Tz for 56766-done@debbugs.gnu.org; Mon, 01 Aug 2022 08:11:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47712) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIUG7-0004XT-TE; Mon, 01 Aug 2022 08:10:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ssloNdWNN9GPvTYn8GM2imflKyEiEWJbLuW57VdFKP8=; b=Xwc9JhNXocHZH4CyDu+/ jXbWwJZVLne7Oc4dwG6mi7Q9pDAgIfgQXDRinc6T9VDt+rnMf1vnKT0EVgybci/4rZm+sqIXsYuE+ IkLFPWGr9zwGBdocbw6kfvhPYE+k5rGXIYw0UrpVCD9hoop+qe6PKltiCn9zJB6lUCh/lSb3gdjZo ybNk75gw7YP8B7SAcfnT2IfH6t7i3kPaDxG1KUKEcSPRKVfx+F6X2FtSszed75IZ9I8jYWuryNi/4 t7lkEr6u3YK20r6HsztLcT4otxHFLYW7FtgNfKca4cEnIdI+BIny9dsz+VkS1rbjH8lPgYbep4cQp dbN+CHNd0Hy4Wg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38832 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIUG7-0006Tq-DT; Mon, 01 Aug 2022 08:10:55 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Marcel van der Boom Subject: Re: bug#56766: [PATCH] gnu: exiv2: Fix test failure on ppc64-le References: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> <4af56c93a8d990220918c65bc58c32f1c8c07aa3.1658907553.git.marcel@van-der-boom.nl> Date: Mon, 01 Aug 2022 14:10:52 +0200 In-Reply-To: <4af56c93a8d990220918c65bc58c32f1c8c07aa3.1658907553.git.marcel@van-der-boom.nl> (Marcel van der Boom's message of "Wed, 27 Jul 2022 09:41:44 +0200") Message-ID: <87ilncyxir.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56766-done Cc: 56766-done@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Marcel, I squashed the two patches into one, tweaked it to make the new build phase conditional as a whole, added it for aarch64-linux as well, added comments taken from your commit log, and tweaked the commit log. Thank you, and thanks Maxime for reviewing! Ludo=E2=80=99. ------------=_1659355922-4644-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Jul 2022 19:48:12 +0000 Received: from localhost ([127.0.0.1]:51497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oG43o-0001wI-3H for submit@debbugs.gnu.org; Mon, 25 Jul 2022 15:48:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:55226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oG43l-0001w1-Py for submit@debbugs.gnu.org; Mon, 25 Jul 2022 15:48:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG43l-00066n-Gu for guix-patches@gnu.org; Mon, 25 Jul 2022 15:48:09 -0400 Received: from read.hsdev.com ([209.250.245.235]:50726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oG43i-0002Qa-Ul for guix-patches@gnu.org; Mon, 25 Jul 2022 15:48:09 -0400 Received: from hsdev.com (hawking.hsdev.com [213.125.12.142]) by read.hsdev.com (Postfix) with ESMTPA id 9F72020FBD; Mon, 25 Jul 2022 21:47:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hsdev.com; s=201906; t=1658778478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zNjIveHPv6FmvkLMlsWVafRuoHFJmJTu63bATmjspp4=; b=YKVfQ7VYy5qcJaUQQZucWqbpno00wVJxZcAoLwRiowah0Q/mVfI2C6R/JvifICHh6lbssn t8wfQRSqYBsvFXvV5wVSeNTz7TUyPopUtC1cJbzIo8R9j8I6ckbXcT7dtUyeBPhch+dHIk qec5QwQHUkjiE3fhpVgzZcP83yOi62M= Received: by hsdev.com (Postfix, from userid 1000) id 5A13B36A0264; Mon, 25 Jul 2022 21:47:58 +0200 (CEST) From: Marcel van der Boom To: guix-patches@gnu.org Subject: [PATCH] gnu: exiv2: Fix test failure on ppc64-le Date: Mon, 25 Jul 2022 21:47:33 +0200 Message-Id: <2b700a6dc4b5b7dd09465c0ef7c04f73b055d463.1658777229.git.marcel@hsdev.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.20 Received-SPF: pass client-ip=209.250.245.235; envelope-from=mrb@hsdev.com; helo=read.hsdev.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Marcel van der Boom X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) ppc64 and arm do not raise exception and thus output and exit code for test is different. * gnu/packages/patches/exiv2-ppc64.patch: Modify test for ppc64 * gnu/packages/image.scm (exiv2): add `patches` field for source if target is ppc64 See: https://github.com/Exiv2/exiv2/issues/365 and https://github.com/Exiv2/exiv2/issues/933 upstream. --- gnu/packages/image.scm | 5 ++++- gnu/packages/patches/exiv2-ppc64.patch | 11 +++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/exiv2-ppc64.patch diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index d52d57b3b1..dc4bf76790 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -1342,7 +1342,10 @@ (define-public exiv2 (uri (string-append "https://www.exiv2.org/builds/exiv2-" version "-Source.tar.gz")) (sha256 - (base32 "1qm6bvj28l42km009nc60gffn1qhngc0m2wjlhf90si3mcc8d99m")))) + (base32 "1qm6bvj28l42km009nc60gffn1qhngc0m2wjlhf90si3mcc8d99m")) + (patches + (if (target-ppc64le?) + (list (search-patch "exiv2-ppc64.patch")))))) (build-system cmake-build-system) (arguments '(#:test-target "tests" diff --git a/gnu/packages/patches/exiv2-ppc64.patch b/gnu/packages/patches/exiv2-ppc64.patch new file mode 100644 index 0000000000..a74a7ac1b7 --- /dev/null +++ b/gnu/packages/patches/exiv2-ppc64.patch @@ -0,0 +1,11 @@ +--- /tests/bugfixes/github/test_CVE_2018_12265.py ++++ /tests/bugfixes/github/test_CVE_2018_12265.py +@@ -18,7 +18,6 @@ + Warning: Directory Image, entry 0x0201: Strip 0 is outside of the data area; ignored. + Warning: Directory Image, entry 0x0201: Strip 7 is outside of the data area; ignored. + Error: Offset of directory Thumbnail, entry 0x0201 is out of bounds: Offset = 0x00000000; truncating the entry +-$uncaught_exception $addition_overflow_message + """ + ] +- retval = [1] ++ retval = [0] base-commit: 212ca81895b2baa819ea11a308ad21880b84a546 -- 2.37.1 ------------=_1659355922-4644-1--