GNU bug report logs - #56679
28.1; whitespace-style cannot be configured for diff-mode via hook

Previous Next

Package: emacs;

Reported by: YE <yet <at> ego.team>

Date: Thu, 21 Jul 2022 14:47:01 UTC

Severity: normal

Found in version 28.1

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: 56679 <at> debbugs.gnu.org
Cc: yet <at> ego.team
Subject: bug#56679: 28.1; whitespace-style cannot be configured for diff-mode via hook
Date: Sat, 23 Jul 2022 02:15:39 +0200

YE via "Bug reports for GNU Emacs, the Swiss army knife of text editors"
<bug-gnu-emacs <at> gnu.org> writes:

> Or maybe adding a defcustom 'diff-whitespace-style' would be a proper
> solution here?

Since `diff-setup-whitespace' unconditionally sets whitespace-style from
a hardcoded value, this is the natural fix.

> I started working on such a patch but stuck disliking the probable
> need in the 'whitespace-style' large ':type' definition duplication.

I think you don't need a duplication.  You can reuse an existing type
definition by looking up the `custom-type` symbol property of an already
defined option.  See e.g. "lisp/eshell/em-cmpl.el" for a few example
definitions.

Michael.
This bug report was last modified 2 years and 354 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.