GNU bug report logs - #56659
29.0.50; nitpicking: eldoc-doc-buffer should use special-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56659 in the body.
You can then email your comments to 56659 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhiwei Chen <condy0919 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; nitpicking: eldoc-doc-buffer should use special-mode
Date: Wed, 20 Jul 2022 17:09:08 +0800

M-x eldoc-doc-buffer displays `eldoc--doc-buffer', the ElDoc
documentation buffer, where

#+begin_src elisp
(local-set-key "q" 'quit-window)
#+end_src

is used to imitate the behavior of special-mode. Further more, using
special-mode for `eldoc-doc-buffer' gives users the opportunity to
modify the keymap, add-hook, ... etc. For myself, an evil-mode user,
it's able to press q in normal state to quit the window since
special-mode has already been evilified. Currently, evil adds an advice
after `eldoc-doc-buffer' [1] as a workaround.

[1]: https://github.com/emacs-evil/evil-collection/blob/master/modes/eldoc/evil-collection-eldoc.el#L60-L61=

-- 
Zhiwei Chen

Message #8 received at 56659 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Zhiwei Chen <condy0919 <at> gmail.com>
Cc: 56659 <at> debbugs.gnu.org
Subject: Re: bug#56659: 29.0.50; nitpicking: eldoc-doc-buffer should use
 special-mode
Date: Sat, 23 Jul 2022 09:13:47 +0200

Zhiwei Chen <condy0919 <at> gmail.com> writes:

> is used to imitate the behavior of special-mode. Further more, using
> special-mode for `eldoc-doc-buffer' gives users the opportunity to
> modify the keymap, add-hook, ... etc. For myself, an evil-mode user,
> it's able to press q in normal state to quit the window since
> special-mode has already been evilified. Currently, evil adds an advice
> after `eldoc-doc-buffer' [1] as a workaround.

I've now fixed this in Emacs 29.

Message #13 received at 56659 <at> debbugs.gnu.org (full text, mbox):

From: Zhiwei Chen <condy0919 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56659 <at> debbugs.gnu.org
Subject: Re: bug#56659: 29.0.50; nitpicking: eldoc-doc-buffer should use
 special-mode
Date: Thu, 28 Jul 2022 11:54:10 +0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Zhiwei Chen <condy0919 <at> gmail.com> writes:
>
>> is used to imitate the behavior of special-mode. Further more, using
>> special-mode for `eldoc-doc-buffer' gives users the opportunity to
>> modify the keymap, add-hook, ... etc. For myself, an evil-mode user,
>> it's able to press q in normal state to quit the window since
>> special-mode has already been evilified. Currently, evil adds an advice
>> after `eldoc-doc-buffer' [1] as a workaround.
>
> I've now fixed this in Emacs 29.
>
>

Thanks.

-- 
Zhiwei Chen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.