GNU bug report logs - #56657
[PATCH] gnu: ranger: Add dependency file

Previous Next

Full log

Message #14 received at 56657 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: "Liliana Marie Prikler" <liliana.prikler <at> ist.tugraz.at>,
 <56657 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: ranger: Add dependency file
Date: Tue, 26 Jul 2022 16:43:06 +0900

On Thu Jul 21, 2022 at 8:50 AM +0200, Liliana Marie Prikler wrote:
> Rather than patching PATH, you should use substitute*
> to hardcode the reference.

Coming from Nix, I don't get why is it preferred.
Shouldn't users be able to override runtime dependencies at runtime,
e.g. via a custom wrapper script?

If that is the case, I suppose the correct wrapper would be

(wrap-program ...
  '("PATH" suffix ,(list (string-append file "/bin"))))

> Also, do write a ChangeLog style commit message.

Thanks, I probably missed this reading the contrib guide.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.