From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2022 20:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 56648@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165826342614243 (code B ref -1); Tue, 19 Jul 2022 20:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jul 2022 20:43:46 +0000 Received: from localhost ([127.0.0.1]:55248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDu4H-0003he-La for submit@debbugs.gnu.org; Tue, 19 Jul 2022 16:43:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:49866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDu4F-0003hW-WF for submit@debbugs.gnu.org; Tue, 19 Jul 2022 16:43:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDu4F-0006T0-N1 for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 16:43:43 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDu4D-0002BH-4o for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 16:43:42 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 25C914416C5 for ; Tue, 19 Jul 2022 16:43:39 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AB9694416C2 for ; Tue, 19 Jul 2022 16:43:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658263417; bh=d5ZXEBnue0mDYX3ok/xneFfmSJy+EdGpMRne5RsErTM=; h=From:To:Subject:Date:From; b=kp6FkORe2lKClY8f53TGSNK296F81Q+yFEUuQusfBbT8J1+ej+kNTr8Vi9rF0YR0N f08ardk27cdQWVOtRDIbtd3XljiAL6cH1oX2u/QbLv1xULF94qulfTr0YilFjderuO eNNlawrRJLOMbHHOzRwzzXevHuULunTL9VP05sgNxL7G/4es408kurlZzQeOijTLSH YAErim9YUOI58oDh1M2dov8JtHuOdkBCNUlV+tx4OJMfv/OE3b9fgEDUvoYSOhbCJe DcYWHzsaGD/MhWhuorH5JjMA+6Ksx8Nbu/pnb15w0zItOwpkDorpjVJxQaPnVIEpoz s5VqjII0x9XGA== Received: from alfajor (modemcable117.17-80-70.mc.videotron.ca [70.80.17.117]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9A70C1201B4 for ; Tue, 19 Jul 2022 16:43:37 -0400 (EDT) From: Stefan Monnier Date: Tue, 19 Jul 2022 16:43:27 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Package: Emacs Version: 29.0.50 I think we need something like `compiled-function-p`, i.e. a function which will return non-nil for both byte-code and native-code functions. Its definition would be (defun compiled-function-p (obj) "" (or (byte-code-function-p obj) (subr-native-elisp-p obj))) This is because `byte-code-function-p` shouldn't be changed to return non-nil for native-code functions (both because it would break a lot of code and because the name would be too confusing), but several uses of `byte-code-function-p` actually want to know "is this an (inefficient) source code function or not" (e.g. in unidata-gen.el, loadup.el, bytecomp.el, ...). Stefan From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: Acknowledgement (29.0.50; Need for `compiled-function-p`) Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jul 2022 05:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.16584664507386 (code B ref 56648); Fri, 22 Jul 2022 05:08:01 +0000 Received: (at 56648) by debbugs.gnu.org; 22 Jul 2022 05:07:30 +0000 Received: from localhost ([127.0.0.1]:39838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEksr-0001v3-SR for submit@debbugs.gnu.org; Fri, 22 Jul 2022 01:07:30 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEksp-0001un-Aj for 56648@debbugs.gnu.org; Fri, 22 Jul 2022 01:07:28 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 67C3544050C; Fri, 22 Jul 2022 01:07:21 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A9F0D440320; Fri, 22 Jul 2022 01:07:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658466430; bh=4W7CTcPvDLrckfMrPK8a3drwSyzV20I0lqiFxLEUdnc=; h=From:To:Subject:In-Reply-To:References:Date:From; b=Gyyd3ShfwDOaG1ypc04S6iNiEdMs5E4zYenLydPF05bBULCs0PXPcSpFS6mQUCy/K emGWf3VXVUjI3pTIv+5kNzQKdDadO7S8eYNydAmLC/bF1EN/9CNk1pdXBxk+DFkPjE CFh4S+AnYg2g44HH0iCuVeKkVSecN9eOVYc7FH0pvOFLby0S3zzZmjHo68GXzi80U2 EBLk5YWiGvjmzCwwQ5fRc0/cCWJrdM38XQQnE3UFuX+D4KqhxsymXGRiUWFE1v4Wif 3gnrBtgTYUrG8hJ239fU4D/IQtqNwA5lOPCkV1onU+7WDZ5Ans6bi9t8q1uNjnRJyZ g+Qfcxv0Z+D2w== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 779B51202CE; Fri, 22 Jul 2022 01:07:10 -0400 (EDT) From: Stefan Monnier In-Reply-To: (GNU bug Tracking System's message of "Tue, 19 Jul 2022 20:44:02 +0000") Message-ID: References: Date: Fri, 22 Jul 2022 01:07:09 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Here is a draft of a patch for that (no docs yet). Any comment/suggestion? Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=compiled-function.patch diff --git a/admin/unidata/unidata-gen.el b/admin/unidata/unidata-gen.el index 0a9fd5108ce..78dd1c37288 100644 --- a/admin/unidata/unidata-gen.el +++ b/admin/unidata/unidata-gen.el @@ -1083,8 +1083,8 @@ unidata-split-name (defun unidata--ensure-compiled (&rest funcs) (dolist (fun funcs) - (or (byte-code-function-p (symbol-function fun)) - (byte-compile fun)))) + (unless (compiled-function-p (symbol-function fun)) + (byte-compile fun)))) (defun unidata-gen-table-name (prop index &rest _ignore) (let* ((table (unidata-gen-table-word-list prop index 'unidata-split-name)) diff --git a/lisp/cedet/semantic/bovine.el b/lisp/cedet/semantic/bovine.el index 1e52b1f8504..1ab27e33403 100644 --- a/lisp/cedet/semantic/bovine.el +++ b/lisp/cedet/semantic/bovine.el @@ -143,14 +143,15 @@ semantic-bovinate-stream cvl nil ;re-init the collected value list. lte (car matchlist) ;Get the local matchlist entry. ) - (if (or (byte-code-function-p (car lte)) + ;; FIXME: Should this `or' be replaced with `functionp'? + (if (or (compiled-function-p (car lte)) (listp (car lte))) ;; In this case, we have an EMPTY match! Make ;; stuff up. (setq cvl (list nil)))) (while (and lte - (not (byte-code-function-p (car lte))) + (not (compiled-function-p (car lte))) (not (listp (car lte)))) ;; GRAMMAR SOURCE DEBUGGING! diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index 86a42b208e7..11d055e2059 100644 --- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -1060,9 +1060,9 @@ ;; (print "Let's clean up now!")) ;; foo ;; -;; Now `foo's advice is byte-compiled: +;; Now `foo's advice is compiled: ;; -;; (byte-code-function-p 'ad-Advice-foo) +;; (compiled-function-p 'ad-Advice-foo) ;; t ;; ;; (foo 3) @@ -1304,7 +1304,7 @@ ;; constructed during preactivation was used, even though we did not specify ;; the `compile' flag: ;; -;; (byte-code-function-p 'ad-Advice-fum) +;; (compiled-function-p 'ad-Advice-fum) ;; t ;; ;; (fum 2) @@ -1335,7 +1335,7 @@ ;; ;; A new uncompiled advised definition got constructed: ;; -;; (byte-code-function-p 'ad-Advice-fum) +;; (compiled-function-p 'ad-Advice-fum) ;; nil ;; ;; (fum 2) @@ -2124,9 +2124,9 @@ ad-advice-p (defsubst ad-compiled-p (definition) "Return non-nil if DEFINITION is a compiled byte-code object." - (or (byte-code-function-p definition) - (and (macrop definition) - (byte-code-function-p (ad-lambdafy definition))))) + (or (compiled-function-p definition) + (and (macrop definition) + (compiled-function-p (ad-lambdafy definition))))) (defsubst ad-compiled-code (compiled-definition) "Return the byte-code object of a COMPILED-DEFINITION." diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el index 5705b2a8fd7..0f4131a658d 100644 --- a/lisp/emacs-lisp/byte-opt.el +++ b/lisp/emacs-lisp/byte-opt.el @@ -2476,8 +2476,7 @@ byte-optimize-lapcode ;; itself, compile some of its most used recursive functions (at load time). ;; (eval-when-compile - (or (byte-code-function-p (symbol-function 'byte-optimize-form)) - (subr-native-elisp-p (symbol-function 'byte-optimize-form)) + (or (compiled-function-p (symbol-function 'byte-optimize-form)) (assq 'byte-code (symbol-function 'byte-optimize-form)) (let ((byte-optimize nil) (byte-compile-warnings nil)) diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 86681cf4dd4..2cccc85f9c3 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1393,7 +1393,7 @@ byte-compile-fdefinition (or (symbolp (symbol-function fn)) (consp (symbol-function fn)) (and (not macro-p) - (byte-code-function-p (symbol-function fn))))) + (compiled-function-p (symbol-function fn))))) (setq fn (symbol-function fn))) (let ((advertised (gethash (if (and (symbolp fn) (fboundp fn)) ;; Could be a subr. @@ -1405,7 +1405,7 @@ byte-compile-fdefinition (if macro-p `(macro lambda ,advertised) `(lambda ,advertised))) - ((and (not macro-p) (byte-code-function-p fn)) fn) + ((and (not macro-p) (compiled-function-p fn)) fn) ((not (consp fn)) nil) ((eq 'macro (car fn)) (cdr fn)) (macro-p nil) @@ -2957,11 +2957,11 @@ byte-compile (setq fun (cdr fun))) (prog1 (cond - ;; Up until Emacs-24.1, byte-compile silently did nothing when asked to - ;; compile something invalid. So let's tune down the complaint from an - ;; error to a simple message for the known case where signaling an error - ;; causes problems. - ((byte-code-function-p fun) + ;; Up until Emacs-24.1, byte-compile silently did nothing + ;; when asked to compile something invalid. So let's tone + ;; down the complaint from an error to a simple message for + ;; the known case where signaling an error causes problems. + ((compiled-function-p fun) (message "Function %s is already compiled" (if (symbolp form) form "provided")) fun) @@ -3538,7 +3538,7 @@ byte-compile-inline-lapcode (byte-compile-out-tag endtag))) (defun byte-compile-unfold-bcf (form) - "Inline call to byte-code-functions." + "Inline call to byte-code function." (let* ((byte-compile-bound-variables byte-compile-bound-variables) (fun (car form)) (fargs (aref fun 0)) @@ -5272,11 +5272,13 @@ display-call-tree ((not (consp f)) "") ((eq 'macro (car f)) - (if (or (byte-code-function-p (cdr f)) + (if (or (compiled-function-p (cdr f)) + ;; FIXME: Can this still happen? (assq 'byte-code (cdr (cdr (cdr f))))) " " " ")) ((assq 'byte-code (cdr (cdr f))) + ;; FIXME: Can this still happen? "") ((eq 'lambda (car f)) "") @@ -5525,9 +5527,7 @@ byte-compile-report-ops ;; itself, compile some of its most used recursive functions (at load time). ;; (eval-when-compile - (or (byte-code-function-p (symbol-function 'byte-compile-form)) - (subr-native-elisp-p (symbol-function 'byte-compile-form)) - (assq 'byte-code (symbol-function 'byte-compile-form)) + (or (compiled-function-p (symbol-function 'byte-compile-form)) (let ((byte-optimize nil) ; do it fast (byte-compile-warnings nil)) (mapc (lambda (x) diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 6646167b92b..ea3c23e7b54 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -3408,7 +3408,7 @@ cl--macroexp-fboundp (character . natnump) (char-table . char-table-p) (command . commandp) - (compiled-function . byte-code-function-p) + (compiled-function . compiled-function-p) (hash-table . hash-table-p) (cons . consp) (fixnum . fixnump) diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el index 6a193a56d2d..5ae9d8368f0 100644 --- a/lisp/emacs-lisp/macroexp.el +++ b/lisp/emacs-lisp/macroexp.el @@ -823,7 +823,7 @@ internal-macroexpand-for-load (eval-when-compile (add-hook 'emacs-startup-hook (lambda () - (and (not (byte-code-function-p + (and (not (compiled-function-p (symbol-function 'macroexpand-all))) (locate-library "macroexp.elc") (load "macroexp.elc"))))) diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el index 07443dabfef..10bd4bc6886 100644 --- a/lisp/emacs-lisp/pcase.el +++ b/lisp/emacs-lisp/pcase.el @@ -607,31 +607,38 @@ pcase-mutually-exclusive-predicates (symbolp . vectorp) (symbolp . stringp) (symbolp . byte-code-function-p) + (symbolp . compiled-function-p) (symbolp . recordp) (integerp . consp) (integerp . arrayp) (integerp . vectorp) (integerp . stringp) (integerp . byte-code-function-p) + (integerp . compiled-function-p) (integerp . recordp) (numberp . consp) (numberp . arrayp) (numberp . vectorp) (numberp . stringp) (numberp . byte-code-function-p) + (numberp . compiled-function-p) (numberp . recordp) (consp . arrayp) (consp . atom) (consp . vectorp) (consp . stringp) (consp . byte-code-function-p) + (consp . compiled-function-p) (consp . recordp) (arrayp . byte-code-function-p) + (arrayp . compiled-function-p) (vectorp . byte-code-function-p) + (vectorp . compiled-function-p) (vectorp . recordp) (stringp . vectorp) (stringp . recordp) - (stringp . byte-code-function-p))) + (stringp . byte-code-function-p) + (stringp . compiled-function-p))) (defun pcase--mutually-exclusive-p (pred1 pred2) (or (member (cons pred1 pred2) @@ -771,8 +778,8 @@ pcase--split-pred ((consp (cadr pat)) #'consp) ((stringp (cadr pat)) #'stringp) ((vectorp (cadr pat)) #'vectorp) - ((byte-code-function-p (cadr pat)) - #'byte-code-function-p)))) + ((compiled-function-p (cadr pat)) + #'compiled-function-p)))) (pcase--mutually-exclusive-p (cadr upat) otherpred)) '(:pcase--fail . nil)) ;; Since we turn (or 'a 'b 'c) into (pred (pcase--flip (memq '(a b c)))) diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index 8221f3017a2..7896babbb35 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -4169,8 +4169,7 @@ gnus ;; file. (unless (string-match "^Gnus" gnus-version) (load "gnus-load" nil t)) - (unless (or (byte-code-function-p (symbol-function 'gnus)) - (subr-native-elisp-p (symbol-function 'gnus))) + (unless (compiled-function-p (symbol-function 'gnus)) (message "You should compile Gnus") (sit-for 2)) (let ((gnus-action-message-log (list nil))) diff --git a/lisp/help-fns.el b/lisp/help-fns.el index dc64a09f3d8..7978108988b 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1009,7 +1009,7 @@ help-fns-function-description-header (help-fns--analyze-function function)) (file-name (find-lisp-object-file-name function (if aliased 'defun def))) - (beg (if (and (or (byte-code-function-p def) + (beg (if (and (or (compiled-function-p def) (keymapp def) (memq (car-safe def) '(macro lambda closure))) (stringp file-name) @@ -1044,7 +1044,7 @@ help-fns-function-description-header (t "Lisp function")))) ((or (eq (car-safe def) 'macro) ;; For advised macros, def is a lambda - ;; expression or a byte-code-function-p, so we + ;; expression or a compiled-function-p, so we ;; need to check macros before functions. (macrop function)) (concat beg "Lisp macro")) @@ -1538,8 +1538,8 @@ help-fns--var-safe-local (when safe-var (princ " This variable is safe as a file local variable ") (princ "if its value\n satisfies the predicate ") - (princ (if (byte-code-function-p safe-var) - "which is a byte-compiled expression.\n" + (princ (if (compiled-function-p safe-var) + "which is a compiled expression.\n" (format-message "`%s'.\n" safe-var)))))) (add-hook 'help-fns-describe-variable-functions #'help-fns--var-risky) diff --git a/lisp/loadup.el b/lisp/loadup.el index 21a87dbd77b..669470926fe 100644 --- a/lisp/loadup.el +++ b/lisp/loadup.el @@ -159,8 +159,7 @@ ;; Load-time macro-expansion can only take effect after setting ;; load-source-file-function because of where it is called in lread.c. (load "emacs-lisp/macroexp") -(if (or (byte-code-function-p (symbol-function 'macroexpand-all)) - (subr-native-elisp-p (symbol-function 'macroexpand-all))) +(if (compiled-function-p (symbol-function 'macroexpand-all)) nil ;; Since loaddefs is not yet loaded, macroexp's uses of pcase will simply ;; fail until pcase is explicitly loaded. This also means that we have to diff --git a/lisp/mh-e/mh-e.el b/lisp/mh-e/mh-e.el index a3a363e33ff..741de9cb88a 100644 --- a/lisp/mh-e/mh-e.el +++ b/lisp/mh-e/mh-e.el @@ -389,11 +389,11 @@ mh-version (insert "MH-E " mh-version "\n\n") ;; MH-E compilation details. (insert "MH-E compilation details:\n") - (let* ((compiled-mhe (byte-code-function-p (symbol-function 'mh-version))) + (let* ((compiled-mhe (compiled-function-p (symbol-function 'mh-version))) (gnus-compiled-version (if compiled-mhe (mh-macro-expansion-time-gnus-version) "N/A"))) - (insert " Byte compiled:\t\t" (if compiled-mhe "yes" "no") "\n" + (insert " Compiled:\t\t" (if compiled-mhe "yes" "no") "\n" " Gnus (compile-time):\t" gnus-compiled-version "\n" " Gnus (run-time):\t" (mh-run-time-gnus-version) "\n\n")) ;; Emacs version. diff --git a/lisp/subr.el b/lisp/subr.el index 510a77dbc8d..a3066cf96fd 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -4019,6 +4019,12 @@ macrop (or (eq 'macro (car def)) (and (autoloadp def) (memq (nth 4 def) '(macro t))))))) +(defun compiled-function-p (object) + "Return non-nil if OBJECT is a function that has been compiled. +Does not distinguish between functions implemented in machine code +or byte-code." + (or (subrp object) (byte-code-function-p))) + (defun field-at-pos (pos) "Return the field at position POS, taking stickiness etc into account." (let ((raw-field (get-char-property (field-beginning pos) 'field))) diff --git a/test/lisp/international/ucs-normalize-tests.el b/test/lisp/international/ucs-normalize-tests.el index 27a4e70c78e..774a3ea7ec9 100644 --- a/test/lisp/international/ucs-normalize-tests.el +++ b/test/lisp/international/ucs-normalize-tests.el @@ -246,7 +246,7 @@ ucs-normalize-part1 ucs-normalize-tests--rule1-failing-for-partX ucs-normalize-tests--rule1-holds-p ucs-normalize-tests--rule2-holds-p)) - (or (byte-code-function-p (symbol-function fun)) + (or (compiled-function-p (symbol-function fun)) (byte-compile fun))) (let ((ucs-normalize-tests--chars-part1 (make-char-table 'ucs-normalize-tests t))) (setq ucs-normalize-tests--part1-rule1-failed-lines --=-=-=-- From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: Acknowledgement (29.0.50; Need for `compiled-function-p`) References: Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2022 02:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.165854496212852 (code B ref 56648); Sat, 23 Jul 2022 02:56:02 +0000 Received: (at 56648) by debbugs.gnu.org; 23 Jul 2022 02:56:02 +0000 Received: from localhost ([127.0.0.1]:42858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF5JB-0003LA-R8 for submit@debbugs.gnu.org; Fri, 22 Jul 2022 22:56:02 -0400 Received: from shell1.rawbw.com ([198.144.192.42]:48235 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF5J7-0003Kq-8H for 56648@debbugs.gnu.org; Fri, 22 Jul 2022 22:55:59 -0400 Received: from alto (135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 26N2tnl1039333 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 22 Jul 2022 19:55:54 -0700 (PDT) (envelope-from mkupfer@alum.berkeley.edu) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-133.dsl.dynamic.sonic.net [135.180.174.133] (may be forged) claimed to be alto From: Mike Kupfer In-Reply-To: Your message of "Fri, 22 Jul 2022 01:07:09 -0400." X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <18445.1658544949.1@alto> Date: Fri, 22 Jul 2022 19:55:49 -0700 Message-ID: <18446.1658544949@alto> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) +(defun compiled-function-p (object) + "Return non-nil if OBJECT is a function that has been compiled. +Does not distinguish between functions implemented in machine code +or byte-code." + (or (subrp object) (byte-code-function-p))) Doesn't byte-code-function-p require an argument? mike From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2022 04:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.165855061922741 (code B ref 56648); Sat, 23 Jul 2022 04:31:01 +0000 Received: (at 56648) by debbugs.gnu.org; 23 Jul 2022 04:30:19 +0000 Received: from localhost ([127.0.0.1]:42875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF6mR-0005ui-Dw for submit@debbugs.gnu.org; Sat, 23 Jul 2022 00:30:19 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oF6mN-0005uJ-On for 56648@debbugs.gnu.org; Sat, 23 Jul 2022 00:30:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9s1vD0ZofrOHSS1AH61xYiJIPQMeRFOv2Mj/TU9W8pE=; b=FUol7nBngtuWmDiYsOUR7xcW0R 7KNNAsuYwR6bi7ddhimKTRNJE9SPsddZoowQipqxl7SFbuAXawwQc5VoO1Fi5NQsF65TnR9ucycpN Uu5bz6izI+zcaE/NELSPEQpDn8zQnwJO4kENVEWlAmU0vgPxZJYJFBsHT7PdgpmaTUgw=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oF6mD-0006em-8k; Sat, 23 Jul 2022 06:30:07 +0200 From: Lars Ingebrigtsen In-Reply-To: (Stefan Monnier's message of "Tue, 19 Jul 2022 16:43:27 -0400") References: X-Now-Playing: Alice Coltrane's _A Monastic Trio_: "Lord, Help Me To Be" Date: Sat, 23 Jul 2022 06:30:03 +0200 Message-ID: <871quc8n90.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > This is because `byte-code-function-p` shouldn't be changed to return > non-nil for native-code functions (both because it would break a lot of > code and because the name would be too confusing), b [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > This is because `byte-code-function-p` shouldn't be changed to return > non-nil for native-code functions (both because it would break a lot of > code and because the name would be too confusing), but several uses of > `byte-code-function-p` actually want to know "is this an (inefficient) > source code function or not" (e.g. in unidata-gen.el, > loadup.el, bytecomp.el, ...). Makes sense to me. But since the use case is "is this one of those slow source code functions?" then why not reverse the logic and call it `uncompiled-function-p'? From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: Acknowledgement (29.0.50; Need for `compiled-function-p`) Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2022 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mike Kupfer Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.16585843128355 (code B ref 56648); Sat, 23 Jul 2022 13:52:02 +0000 Received: (at 56648) by debbugs.gnu.org; 23 Jul 2022 13:51:52 +0000 Received: from localhost ([127.0.0.1]:43827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFFXs-0002Ah-8j for submit@debbugs.gnu.org; Sat, 23 Jul 2022 09:51:52 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFFXp-0002AP-V8 for 56648@debbugs.gnu.org; Sat, 23 Jul 2022 09:51:50 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 465AD10027D; Sat, 23 Jul 2022 09:51:44 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D0C42100120; Sat, 23 Jul 2022 09:51:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658584302; bh=mgEy9VSAlgqNsmLsvJTLEWTkpb/ydk1MLp6MqGrvm7s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iq7uFKIi3+F6RpSfBq4lXCj993gLEwCryBd3Nl2Gz+nys2Woo+Fg6brePrJQs11lX xSnZpOsH+bHKesP+Y16jupqaGc/Dl9xD+7VnfJnvaixJZSmJ//rTUsz7lEgh9nChiT XABTAPgv55wO5pLXXew/hL9vO8gddRTLf3Ho5lugOdNB9k6kij8sNqemVLK1un7Y+v xbe0w9nOTqDIad/sUc/G6P2TrR4CeW38ioyGUmZGfC3YDS329QAykx/QhC7pjll2zN mEgE+UaEZjlFkJivfAC2oslDxXuZfBHTzwuM4NaFtS6SbPFJiahgrRuQMG2NfBDeL3 TgdqXSmuo79QA== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AFE1C1201E4; Sat, 23 Jul 2022 09:51:42 -0400 (EDT) From: Stefan Monnier In-Reply-To: <18446.1658544949@alto> (Mike Kupfer's message of "Fri, 22 Jul 2022 19:55:49 -0700") Message-ID: References: <18446.1658544949@alto> Date: Sat, 23 Jul 2022 09:51:41 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mike Kupfer [2022-07-22 19:55:49] wrote: > Doesn't byte-code-function-p require an argument? Nah... arguments are overrated! And besides, we already have so many of them on emacs-devel, do we really need more? Stefan "thanks!" From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2022 00:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.16586224703044 (code B ref 56648); Sun, 24 Jul 2022 00:28:02 +0000 Received: (at 56648) by debbugs.gnu.org; 24 Jul 2022 00:27:50 +0000 Received: from localhost ([127.0.0.1]:46566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFPTK-0000n0-56 for submit@debbugs.gnu.org; Sat, 23 Jul 2022 20:27:50 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFPTG-0000mk-4b for 56648@debbugs.gnu.org; Sat, 23 Jul 2022 20:27:48 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0E137441A67; Sat, 23 Jul 2022 20:27:40 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D6120441A56; Sat, 23 Jul 2022 20:27:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658622458; bh=+JPOcfqXgtnzKawmhtckNWuqKRR9L+Bb6rFs2P2xjJg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JLvmYSjAZ3YCDAdO+r4GiaYw+YthxVhR/B+3igUVaxIK2XV44Z1LcI6zgQI4nWTSi iMOISli7bGllsCj+y1gzS0zrMMUaHxkDlnuxZBM4ia9MATnea0gUD0c4QyXGIP94ZS 5AusV5w1FbHAzV91vKnuypjbLqnSCiRfndqwRiLU+dvoi2Qobndec04byGXTWIhUls QK/BFj/x1g0YeOc4saiiwhGUlCIGrNVIljTZB9ma1f3FEDzGamoXKw7kTiWfSJDe90 4ilcuiJQTf4dBYnDixNlo6pShxkDZQF309AyrqHD7/3OsI3WNFfq6m6zWd8i0oT0Ky B1tneGfMjPrmA== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A5D73120201; Sat, 23 Jul 2022 20:27:38 -0400 (EDT) From: Stefan Monnier In-Reply-To: <871quc8n90.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 23 Jul 2022 06:30:03 +0200") Message-ID: References: <871quc8n90.fsf@gnus.org> Date: Sat, 23 Jul 2022 20:27:37 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-07-23 06:30:03] wrote: > Stefan Monnier writes: >> This is because `byte-code-function-p` shouldn't be changed to return >> non-nil for native-code functions (both because it would break a lot of >> code and because the name would be too confusing), but several uses of >> `byte-code-function-p` actually want to know "is this an (inefficient) >> source code function or not" (e.g. in unidata-gen.el, >> loadup.el, bytecomp.el, ...). > > Makes sense to me. But since the use case is "is this one of > those slow source code functions?" then why not reverse the logic and > call it `uncompiled-function-p'? I can think of 2 reasons: A) `compiled-function-p` exists in Common-Lisp. B) It would require redoing some of the work I've just done because (uncompiled-function-p X) != (not (compiled-function-p X)) when X is not a function, so it's not just a simple search&replace. -- Stefan From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2022 09:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.16586545717145 (code B ref 56648); Sun, 24 Jul 2022 09:23:02 +0000 Received: (at 56648) by debbugs.gnu.org; 24 Jul 2022 09:22:51 +0000 Received: from localhost ([127.0.0.1]:46861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFXp5-0001rB-2x for submit@debbugs.gnu.org; Sun, 24 Jul 2022 05:22:51 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFXp3-0001qz-EP for 56648@debbugs.gnu.org; Sun, 24 Jul 2022 05:22:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=21cGIReD7xTCe4v6tbtgBsCiv6HrofBNZiYxN90b1T0=; b=IEn3w2tVHW48/a1fdFb8a5PaEd djkWu/qAoUkOxXFJtuR7QufmfETekgfoUJqzWBpbF7z4o9tiKY7+UYypwi7/J/eKEol27mbZK3l+p iQ2eLFSD9soum/qBzaYyjoQYQGBBzxS7MbqgBuv1rBa4rjWjUIZNfEqWa73vkfaCcfEk=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFXou-0005OI-AP; Sun, 24 Jul 2022 11:22:42 +0200 From: Lars Ingebrigtsen In-Reply-To: (Stefan Monnier's message of "Sat, 23 Jul 2022 20:27:37 -0400") References: <871quc8n90.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJFBMVEUwdskudspHfMsw etAuedCak9NlhM7Yo9cZccw1cbdQeKn///93HEaEAAAAAWJLR0QLH9fEwAAAAAd0SU1FB+YHGAkH HH/VAFgAAAGbSURBVDjLpVI7TsNAEJ0hRrQz0YY+NwDZB/DKcwEKkjoFikSFkFBuQB0KGo7gUzIf O/4EV6wly+s37735AehhAmTiyYHhLADISwxellrT4EP934cGYHOAAjkzNQj69KQKNu8kFl1lkyJN 1XiFwP1pqymkRtCkCOzdFIXUzf6NkBsxmoAqIYLeRPLumUTKyr5LjVcjWJWl1Li72zqQk1RhAIVR Hl8+D5hMKnP2PhkCNeDtzZbEQiwrtXbgp23b79eW2MwCGKrfH/TqBMmarjNAvzenJ7T/ipACzA4g 4fGkDPXIYv/YKjFnxuMHu1JWE1QhM1GAeL21TiWRlNnjOaQYqQN8HjZrB6CfuqToFXVDofFwqYao bw5wB5B7cIjlGHk/eY8fz/wLvMDQsXfKAZg1jbcqSXic5wsnk+0B35dRuuAZdZX/vYjT3aULwdoe WYkg2oJcbCI15FU1RHccjKYCzJBYJNPHKcPu1DV/ClCsGOAc8E5H42YMT1j1rghd0VfesZfUbcdw zoBDsTPg0h/47xkPbprWAuDmve8vj6FHl3JHDHgAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDct MjRUMDk6MDc6MjgrMDA6MDB8fKDyAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA3LTI0VDA5OjA3 OjI4KzAwOjAwDSEYTgAAAABJRU5ErkJggg== X-Now-Playing: King Crimson's _Beat_: "Neurotica" Date: Sun, 24 Jul 2022 11:22:38 +0200 Message-ID: <87edyayie9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > A) `compiled-function-p` exists in Common-Lisp. > > B) It would require redoing some of the work I've just done because > > (uncompiled-function-p X) != (not (compiled-function-p X)) > > when X is n [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > A) `compiled-function-p` exists in Common-Lisp. > > B) It would require redoing some of the work I've just done because > > (uncompiled-function-p X) != (not (compiled-function-p X)) > > when X is not a function, so it's not just a simple search&replace. Makes sense. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 10:14:56 2022 Received: (at control) by debbugs.gnu.org; 4 Aug 2022 14:14:57 +0000 Received: from localhost ([127.0.0.1]:54146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJbcm-0001Cd-KL for submit@debbugs.gnu.org; Thu, 04 Aug 2022 10:14:56 -0400 Received: from mail-vs1-f49.google.com ([209.85.217.49]:35664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJbck-0001CR-Gl for control@debbugs.gnu.org; Thu, 04 Aug 2022 10:14:55 -0400 Received: by mail-vs1-f49.google.com with SMTP id k129so21238601vsk.2 for ; Thu, 04 Aug 2022 07:14:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=m3MGhnV8MDCGm5zWcUzJo5J857rf7EhZ6CPUmkNfYfs=; b=cB+PB16hJgrB6c29oU9mheU0kqEkc0Apn1OaDuXblaaDUKaqjhtfzFXomWwO45av5m 6TXAtI61s7qxnBUrn1xbM39mG9vmxhrmJSgJ2qVbUrubetNiLE6YZLZXyxa0xVvKkCDI Nak6FOg74Er+flL0EA0FY2eKIv8z+j1t5A6DiJ1VHn6f6qag6DVrPjnaUng1P6lYJ/VX /kfwa35Di9YRIwpm7Mg34G8UW6tZaxczFdcFgjlyrfymoPG9nIl60lyrbXLLu6Qp5Rgo 4oXdl+yhe/5GBOCQf/DkQCvZRKOjzNRvUXn38n7z4oCxn64jhafg/IGhxZS8oQadF257 52LQ== X-Gm-Message-State: ACgBeo0hsbKvQwZgfZV8oje2a/m0UGALGN0PCB5gVjTQcdha7QyRS+NK oNBivt42T6J6DGSIJo3v82+dZKvxLPNGInqwXI6x/2Xi X-Google-Smtp-Source: AA6agR5p7n7LJ81teKgNxKbQbDqRtB6OVkbGcGI2dnKvTokxjG0WgfQMXj0Vi3S23vNqvw7JtbUxb7h74T5PQPMVcJE= X-Received: by 2002:a05:6102:5094:b0:388:6903:5f09 with SMTP id bl20-20020a056102509400b0038869035f09mr905447vsb.46.1659622474273; Thu, 04 Aug 2022 07:14:34 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 4 Aug 2022 14:14:33 +0000 X-Hashcash: 1:21:220804:control@debbugs.gnu.org::Ehr49jPG625M0s9i:Ad1I From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 4 Aug 2022 14:14:33 +0000 Message-ID: Subject: control message for bug #56648 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) severity 56648 wishlist quit From unknown Fri Aug 15 20:55:28 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefan Monnier Subject: bug#56648: closed (Re: bug#56648: 29.0.50; Need for `compiled-function-p`) Message-ID: References: X-Gnu-PR-Message: they-closed 56648 X-Gnu-PR-Package: emacs Reply-To: 56648@debbugs.gnu.org Date: Sun, 14 Aug 2022 16:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1660494662-21906-1" This is a multi-part message in MIME format... ------------=_1660494662-21906-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #56648: 29.0.50; Need for `compiled-function-p` which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 56648@debbugs.gnu.org. --=20 56648: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56648 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1660494662-21906-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 56648-done) by debbugs.gnu.org; 14 Aug 2022 16:30:41 +0000 Received: from localhost ([127.0.0.1]:39669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGVc-0005Qx-QH for submit@debbugs.gnu.org; Sun, 14 Aug 2022 12:30:41 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGVa-00057N-49 for 56648-done@debbugs.gnu.org; Sun, 14 Aug 2022 12:30:39 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 86836100134; Sun, 14 Aug 2022 12:30:32 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4D9C510008C; Sun, 14 Aug 2022 12:30:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660494630; bh=fUvxl4SmLe+yZtDoWKpKzBQpOeUoVta2jwne7lkRcwo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZDGlq4HTAV1NLY+tO3e0zRgbcItCCxvL/aujKFCsEqLBobuGqAIvgAcgqoJ51H2R1 1qPh4SUefuRJTgFqZXNf6PJW1fKLhhIDGOEWJSP39UxBcWbybN3XwOkMpjPP2jtC4Z fU5+xWGHlDdrMShv7IvCQzpOnpXybQtGHCTgPDpCnvmZOxQ9igAx/MlOxP/ZZ3sPIx Owjh3zV369kyLYoXCjIPGtN9bpJtReATPVeJZ9J3+Gcbt9uapmbXyP7+HOEhbc2wFa /pBYeNuO4XYDrWlfzS+FlC3XVh1qCcfYFaDdCqfSFNGY6qmWnKjrrubTtxgKonXSlj 6UbUj2xWVBZDg== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 014D912039E; Sun, 14 Aug 2022 12:30:29 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#56648: 29.0.50; Need for `compiled-function-p` In-Reply-To: <87edyayie9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 24 Jul 2022 11:22:38 +0200") Message-ID: References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> Date: Sun, 14 Aug 2022 12:30:20 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56648-done Cc: 56648-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Pushed to `master` with some tweaks and doc, Stefan ------------=_1660494662-21906-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Jul 2022 20:43:46 +0000 Received: from localhost ([127.0.0.1]:55248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDu4H-0003he-La for submit@debbugs.gnu.org; Tue, 19 Jul 2022 16:43:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:49866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDu4F-0003hW-WF for submit@debbugs.gnu.org; Tue, 19 Jul 2022 16:43:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDu4F-0006T0-N1 for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 16:43:43 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDu4D-0002BH-4o for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 16:43:42 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 25C914416C5 for ; Tue, 19 Jul 2022 16:43:39 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AB9694416C2 for ; Tue, 19 Jul 2022 16:43:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1658263417; bh=d5ZXEBnue0mDYX3ok/xneFfmSJy+EdGpMRne5RsErTM=; h=From:To:Subject:Date:From; b=kp6FkORe2lKClY8f53TGSNK296F81Q+yFEUuQusfBbT8J1+ej+kNTr8Vi9rF0YR0N f08ardk27cdQWVOtRDIbtd3XljiAL6cH1oX2u/QbLv1xULF94qulfTr0YilFjderuO eNNlawrRJLOMbHHOzRwzzXevHuULunTL9VP05sgNxL7G/4es408kurlZzQeOijTLSH YAErim9YUOI58oDh1M2dov8JtHuOdkBCNUlV+tx4OJMfv/OE3b9fgEDUvoYSOhbCJe DcYWHzsaGD/MhWhuorH5JjMA+6Ksx8Nbu/pnb15w0zItOwpkDorpjVJxQaPnVIEpoz s5VqjII0x9XGA== Received: from alfajor (modemcable117.17-80-70.mc.videotron.ca [70.80.17.117]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9A70C1201B4 for ; Tue, 19 Jul 2022 16:43:37 -0400 (EDT) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Need for `compiled-function-p` Date: Tue, 19 Jul 2022 16:43:27 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Package: Emacs Version: 29.0.50 I think we need something like `compiled-function-p`, i.e. a function which will return non-nil for both byte-code and native-code functions. Its definition would be (defun compiled-function-p (obj) "" (or (byte-code-function-p obj) (subr-native-elisp-p obj))) This is because `byte-code-function-p` shouldn't be changed to return non-nil for native-code functions (both because it would break a lot of code and because the name would be too confusing), but several uses of `byte-code-function-p` actually want to know "is this an (inefficient) source code function or not" (e.g. in unidata-gen.el, loadup.el, bytecomp.el, ...). Stefan ------------=_1660494662-21906-1-- From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: monnier@iro.umontreal.ca, 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.166049489822321 (code B ref 56648); Sun, 14 Aug 2022 16:35:02 +0000 Received: (at 56648) by debbugs.gnu.org; 14 Aug 2022 16:34:58 +0000 Received: from localhost ([127.0.0.1]:39692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGZm-0005nw-2D for submit@debbugs.gnu.org; Sun, 14 Aug 2022 12:34:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGZj-0005nU-5T for 56648@debbugs.gnu.org; Sun, 14 Aug 2022 12:34:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47590) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNGZd-0004Da-Vg; Sun, 14 Aug 2022 12:34:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ycTVwOWUjr5SyLFpgN0npvsTwyB1b/AZnwN0q68QWW8=; b=amIlGkaODJeZ y9hdiOtfLZcilSQ00i9ivYpmfW7YLudytCCDD37Tsv9Sxd+Vlc9vkh+N3vesVo6Avt5RjR0WQLzYB XHY2rqzfqoGLFqRL06gHMXVS/MxbZPocAygujfZQQSLo9BRiRrmSo7aq4vEh0c5LlLycC/yDWgtfE UseXhs20WPC6iySsCFoXJ+K4uXukxlKICDz6oPdLDW4Z9eQC2BdTA/gTxpTK27K5TZMyDx1bigND7 p7l/Gl+8B2LK7fGY0yWQC91SO43iYvC5a/55BZ+OSE3D7pSRPe9e4zlUwY6GOAUf4wpXyV/Ij/TCk Ucw2aSRX78GJg0ZBGh+zIg==; Received: from [87.69.77.57] (port=4851 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNGZc-0005VQ-C6; Sun, 14 Aug 2022 12:34:49 -0400 Date: Sun, 14 Aug 2022 19:34:32 +0300 Message-Id: <83k07akcmf.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Resent-To: bug-gnu-emacs@gnu.org > Cc: 56648-done@debbugs.gnu.org > Date: Sun, 14 Aug 2022 12:30:20 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Pushed to `master` with some tweaks and doc, Which completely breaks the "normal" build, sigh... From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Stefan Monnier , 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.166049564523610 (code B ref 56648); Sun, 14 Aug 2022 16:48:01 +0000 Received: (at 56648) by debbugs.gnu.org; 14 Aug 2022 16:47:25 +0000 Received: from localhost ([127.0.0.1]:39738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGlp-00068k-5S for submit@debbugs.gnu.org; Sun, 14 Aug 2022 12:47:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGlk-00068U-Kx for 56648@debbugs.gnu.org; Sun, 14 Aug 2022 12:47:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rXYgUZ8UFnW1qn/tyD1WqZbCF4M1XkgpC318VWUCtyI=; b=Wu/CMpvh7NcwgNU/ydSnHzd80i LjZuqE7+9l2oDG4GlKAw1dYezlV4s/NxKhoVXaumyIxXK26RaB75hIxw0RNy8M+vtAVrXdBkdbj/1 6n9bjhZh+TWEIbKSzC4uvvvO0TPUErwpBJtS1uE2TFeKBcXWNofe56iw9jGCU+AbXHc8=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNGlZ-0006NE-NY; Sun, 14 Aug 2022 18:47:12 +0200 From: Lars Ingebrigtsen In-Reply-To: <83k07akcmf.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Aug 2022 19:34:32 +0300") References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> <83k07akcmf.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWUscuaNVM2Jiyo Ejb///9dW0siAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YIDhAuN3P6YZ4AAAG7SURBVDjLfZQBtuMg CEXR2YDoBpRsoOj+9zbvoUnbf/4MPU3UG0B4JiIipZhI7xilnHgVWs9FukkuADnlnDAGUYD+AEwz fwmrD+glgmQJj8FQPfWKe4Ac4OSgj5Te4U6Qi0VA+4cBXBN/qWadC9eiEeCmLSYEa9s0udZtc9gz Xl+gtzdYsj48PsCU5WbtAUwyLULhbgMDhrrWxJrXA2pPa1WC/A5Vpblq0x02fYHly2WDPwy0E3pM irS45qfY89QNItS13nFn0gDyFIKWxFORHAATi1gA79IlwDTUidq+gRx31CwJnqqxQRyTk5lCMWFl t6j50SMUZFyvG2SEUHazWv/SHC5nx6pH87HjphsUgMjXIrDkcfroAOyOy9577jeoYp7HKuhJgEfd KtlRCXsd4DknlXU4/ZsL2kuFsQqNBX1/sfqoPPE4tBfq3CBEoXeqywe2dIBvDwtwRKyyn4a9+gGu oSBarbqVlUgeRYUIS0U5Jdke7WzFt0PkuM4JqrdsaA7eOAIcQD0g9pSkIjs9LrrcwAvlE63I7kMb 906FcLhDvpGoglPsW0H9kHLNafa/1/lYjy/GL+CH/QU/UY8GVwShVwAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMi0wOC0xNFQxNjo0Njo1NCswMDowMER4IioAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjIt MDgtMTRUMTY6NDY6NTQrMDA6MDA1JZqWAAAAAElFTkSuQmCC X-Now-Playing: Talking Heads's _Remain In Light_: "Listening Wind" Date: Sun, 14 Aug 2022 18:47:08 +0200 Message-ID: <87wnbag4c3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Which completely breaks the "normal" build, sigh... Works for me after a bootstrap. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > Which completely breaks the "normal" build, sigh... Works for me after a bootstrap. From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 16:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.166049577323981 (code B ref 56648); Sun, 14 Aug 2022 16:50:01 +0000 Received: (at 56648) by debbugs.gnu.org; 14 Aug 2022 16:49:33 +0000 Received: from localhost ([127.0.0.1]:39743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGnt-0006Ei-JQ for submit@debbugs.gnu.org; Sun, 14 Aug 2022 12:49:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGnr-0006EW-M0 for 56648@debbugs.gnu.org; Sun, 14 Aug 2022 12:49:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47776) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNGnm-0006HX-D2; Sun, 14 Aug 2022 12:49:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MktnRFSwGoyArLqJHcW+I2WRP7CaMDo/DgxidaHHsco=; b=nV4CpCAg+l2N U6MNYrhWBJGOYKOcI5nnMvALwTem9Dm0BWHSTCgzcqoo9n1jOjprL7EYlZIzGiBCfIVyRCCWe4aMf QdDzITwSTFNvjGs1ksiKjsBpvqLhxk2sCafQdBE45V/SuOAyf2ctUPAvDz7KExOkLm0E8O7tDduRi QXXSqzyLV3uIMStUOdzSxWejupNLOPF2bQS4lQXs/dKO7OpdP+VSnGJc3aNdp/t6YfRTzs5IfA+Tt nQrefEqbw2qt8m7bJSpLbqYdUUqEU9KsqzByBdW+uPj+lU54VWRmBnQMzzffGuX9BkeCCUWfNTBTD fof2aXWqYBt7yZ8tgopSow==; Received: from [87.69.77.57] (port=1766 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNGnl-0005Xp-RH; Sun, 14 Aug 2022 12:49:26 -0400 Date: Sun, 14 Aug 2022 19:49:09 +0300 Message-Id: <83ilmukby2.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > +(defun compiled-function-p (object) > + "Return non-nil if OBJECT is a function that has been compiled. > +Does not distinguish between functions implemented in machine code > +or byte-code." > + (or (subrp object) (byte-code-function-p object))) What happened to this part from bytecomp.el: > - (or (byte-code-function-p (symbol-function 'byte-compile-form)) > - (subr-native-elisp-p (symbol-function 'byte-compile-form)) > - (assq 'byte-code (symbol-function 'byte-compile-form)) <<<<<<<<<<<<< > + (or (compiled-function-p (symbol-function 'byte-compile-form)) From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: monnier@iro.umontreal.ca, 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.166049605624499 (code B ref 56648); Sun, 14 Aug 2022 16:55:01 +0000 Received: (at 56648) by debbugs.gnu.org; 14 Aug 2022 16:54:16 +0000 Received: from localhost ([127.0.0.1]:39765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGsS-0006N4-9f for submit@debbugs.gnu.org; Sun, 14 Aug 2022 12:54:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNGsR-0006Ms-71 for 56648@debbugs.gnu.org; Sun, 14 Aug 2022 12:54:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNGsL-00074E-Vh; Sun, 14 Aug 2022 12:54:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8hKK4t05cFsUDeBLkliUfPLiZM7rtogZpJaKbnTc1y0=; b=ZpDkIEcoawHA eV/81tIzIbW+KmFdqzI0KPDwDU68J5sQGMlDs4V40moXQT9ra5LjC5/J2dY9cIHEqPOXl7yEvmFaG ePR3LF7Tp2CG428sZBHwfmb1q2S0+yOrCUnt1jT7rm/I2A3Ip0ye6YHpfyoggw+GoRwdH0ed54Em+ 6+mNwWXIu+yQIkzZBImzG4ePwliE6e+g4e55l8Trcukt6r6nvjrh3dFsWXBFHYu72QmdgF4GTSLcq MeqvnLGtZIbJ/e53Pd5mZNXHRNtShd508V3QZ9eOK2jEtlCZJ3rs3uzwTy9kK2ID3eP9u1m3+10+u eQxDE2PEDnJB+rMEAeU0Kg==; Received: from [87.69.77.57] (port=2066 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNGsL-0005zZ-Ek; Sun, 14 Aug 2022 12:54:09 -0400 Date: Sun, 14 Aug 2022 19:53:54 +0300 Message-Id: <83czd2kbq5.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87wnbag4c3.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 14 Aug 2022 18:47:08 +0200) References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> <83k07akcmf.fsf@gnu.org> <87wnbag4c3.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Stefan Monnier , 56648@debbugs.gnu.org > Date: Sun, 14 Aug 2022 18:47:08 +0200 > > Eli Zaretskii writes: > > > Which completely breaks the "normal" build, sigh... > > Works for me after a bootstrap. bootstrap != "normal build" I never bootstrap, because I keep old executables around, for easier bisecting. I didn't need to bootstrap in this case, either, just a couple of annoying manual actions. From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.166049806327571 (code B ref 56648); Sun, 14 Aug 2022 17:28:02 +0000 Received: (at 56648) by debbugs.gnu.org; 14 Aug 2022 17:27:43 +0000 Received: from localhost ([127.0.0.1]:39806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNHOp-0007Ad-5e for submit@debbugs.gnu.org; Sun, 14 Aug 2022 13:27:43 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNHOm-0007AP-AQ for 56648@debbugs.gnu.org; Sun, 14 Aug 2022 13:27:41 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BA0E38071D; Sun, 14 Aug 2022 13:27:34 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A0ECF8051A; Sun, 14 Aug 2022 13:27:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660498053; bh=CPA300bOFo2tmQMbAi6iHdR5giR2np+8zI/kFUbOcTU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lFybyFrONgRdANPSQ1EfGp6gUqaqo5MNKncBavMRhrJytvXYepufrxbMKjOAImqv5 EL5K5J32xbEgTr/wHdpaj9R8wrV8RkarlQCEY/fqG6BhwjFLAtN7Dih6x4UMkl2+cZ jBO1MYFL62CjlaUTeiPnU0CmlVTA9Nl94/FxWVG8wpAr+EeNh/tYCeeZdIO5I9ppNb bDqeFAm4NxubGR5V+3vH6Bu6bB9L2lJ22gKAGWrJeBDJX7XRlZOfbi1xYwyC3jQoMs CQUP2arcEE9hcEmQ1c280QmJFHOjs4EXmpw5CTz0vqrUypMPeQfcM5kKa8oPQGZQqe e1+yBqmz8rM+Q== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 770CD120195; Sun, 14 Aug 2022 13:27:33 -0400 (EDT) From: Stefan Monnier In-Reply-To: <83k07akcmf.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Aug 2022 19:34:32 +0300") Message-ID: References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> <83k07akcmf.fsf@gnu.org> Date: Sun, 14 Aug 2022 13:27:31 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii [2022-08-14 19:34:32] wrote: >> Pushed to `master` with some tweaks and doc, > Which completely breaks the "normal" build, sigh... Hmm... works for me, so I guess the devil is in the quotes? Stefan From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 17:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.166049952830072 (code B ref 56648); Sun, 14 Aug 2022 17:53:01 +0000 Received: (at 56648) by debbugs.gnu.org; 14 Aug 2022 17:52:08 +0000 Received: from localhost ([127.0.0.1]:39845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNHmS-0007ox-A3 for submit@debbugs.gnu.org; Sun, 14 Aug 2022 13:52:08 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNHmQ-0007oT-Fl for 56648@debbugs.gnu.org; Sun, 14 Aug 2022 13:52:07 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3A6C0100134; Sun, 14 Aug 2022 13:52:00 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 155E010008C; Sun, 14 Aug 2022 13:51:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660499519; bh=v3Nr754vnHa/88H3cOnb6cvAln7AgGj/p3nAaHik0A4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=i2KK2KHnXenZlR9f0mLsvnkYS61/IG19l0QAlQxtKxNh3Ig2Zv0TErwA3AzJkibO8 bkcvWqGj89trsjr57OnDgkqOkPyHSzeOfrdUzwdN8tLdI2HUed3fUExPrmP2m3aPQo 753tRl2lfgbRR8tvZdpRDAqs/khA3ymOG8tqJb7CX8Tl33DCSc0Ja7+pRptU3I0FK4 TYs23yJYbDKJx6k5Cgi0VJuEEU71M+1+9Qc1cTLrADmB/x7AQ9HeBRx4V3eKNd5ygM e5jqwDFIqZ161nxgIf95zZ8cRdZzOtNEbm4lsPktKzH4r1ExiShT1G+u1LwYSlPZD6 KolS8SW2QNC4g== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C73C412051F; Sun, 14 Aug 2022 13:51:58 -0400 (EDT) From: Stefan Monnier In-Reply-To: <83ilmukby2.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Aug 2022 19:49:09 +0300") Message-ID: References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> <83ilmukby2.fsf@gnu.org> Date: Sun, 14 Aug 2022 13:51:57 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> - (or (byte-code-function-p (symbol-function 'byte-compile-form)) >> - (subr-native-elisp-p (symbol-function 'byte-compile-form)) >> - (assq 'byte-code (symbol-function 'byte-compile-form)) <<<<<<<<<<<<< According to my reading of the code, this `assq` can never return non-nil. I think it was a left-over from many years ago when the byte-compiler cuold generated code of the form (lambda (..) (byte-code ...)). Strictly speaking we still occasionally generate such (byte-code ...) thingies, but only in cases that don't apply here (e.g. it's not applied for functions, see `byte-compile-out-toplevel`). Stefan From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.166050023131258 (code B ref 56648); Sun, 14 Aug 2022 18:04:01 +0000 Received: (at 56648) by debbugs.gnu.org; 14 Aug 2022 18:03:51 +0000 Received: from localhost ([127.0.0.1]:39882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNHxm-000886-S2 for submit@debbugs.gnu.org; Sun, 14 Aug 2022 14:03:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNHxk-00087s-FZ for 56648@debbugs.gnu.org; Sun, 14 Aug 2022 14:03:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNHxf-0008VQ-9N; Sun, 14 Aug 2022 14:03:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YIsf3OMYqhJbA4f0E3NTi36II20Zm3hV9Tl60VUDwRk=; b=XUbFXma20PIB NfVxM+zkJaecFkXs5pc3i7Li2AKXLOO1UfOuD4VH8hh8W3tCpWgfnewKOqFFtiFT47/3x7NEBSxej zVIl9Ie8Tj00dAW7saVEN2jDkf8TBt0Ge/8bvfa+fROrAXVSd3PwpW4/19OMImnp3imW2csUfUJum aptFOnjYHQLk+yrEIwxOuiHLgm/oRtdDhiwCvhLFjZoVReke/wKuhus6HplfnHAJtF40bxZujAine V49nldWg3P3QkMVUvyhbPiT/8felAHyqNBiIECOf7w213ZQNDmLWFEvlzBCR7MvVtn9i8MmHInBQE 0vC8G93pc96uhMnyj4IYdA==; Received: from [87.69.77.57] (port=2364 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNHxW-00068o-EW; Sun, 14 Aug 2022 14:03:42 -0400 Date: Sun, 14 Aug 2022 21:03:18 +0300 Message-Id: <835yiuk8ih.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Monnier on Sun, 14 Aug 2022 13:51:57 -0400) References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> <83ilmukby2.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: 56648@debbugs.gnu.org > Date: Sun, 14 Aug 2022 13:51:57 -0400 > > >> - (or (byte-code-function-p (symbol-function 'byte-compile-form)) > >> - (subr-native-elisp-p (symbol-function 'byte-compile-form)) > >> - (assq 'byte-code (symbol-function 'byte-compile-form)) <<<<<<<<<<<<< > > According to my reading of the code, this `assq` can never return > non-nil. Too bad the commit log message didn't say that, then. Imagine someone 5 or 10 years from now trying to understand the fine points of that changeset... From unknown Fri Aug 15 20:55:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56648: 29.0.50; Need for `compiled-function-p` Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 02:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 56648@debbugs.gnu.org Received: via spool by 56648-submit@debbugs.gnu.org id=B56648.166053098116294 (code B ref 56648); Mon, 15 Aug 2022 02:37:02 +0000 Received: (at 56648) by debbugs.gnu.org; 15 Aug 2022 02:36:21 +0000 Received: from localhost ([127.0.0.1]:40176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNPxl-0004Ek-6v for submit@debbugs.gnu.org; Sun, 14 Aug 2022 22:36:21 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNPxj-0004EX-3b for 56648@debbugs.gnu.org; Sun, 14 Aug 2022 22:36:20 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id ACC9C44133F; Sun, 14 Aug 2022 22:36:13 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7A0DF441344; Sun, 14 Aug 2022 22:36:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660530972; bh=5CW4BS3ILg4mluiG7JoljOL3Xh9CRo/QEQ6zyEiRFXo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=T+5mT3DLNtCqzxp4WEu7+H8YvzwyEs38W+46ABu3of67DuCrobrGy8xkLbgWlaTxL aPgU+Piac4UmDtjFxSuYfQPZ2Y9g5UgjOF2fPXjyaeW2buRoqUqnig0u2BSPafuVtE ypWDGE91+xYra/NALuoiKnch6YWH4U1vT5lUza7UpzjF4nz/3lA0FyuIFBBvhE/kYl xRJBUh9zR19UGwgl7KGKQvwQhPf1FTkf/WOzVdAgag/kZylu4Eydz9xNJBvfFiUw17 D7t+isRBpJnrKlR7yZ0L4wa5n7mGA5dETpAQbOGiG4NzLEI0vPunljLm+hmr/RlVtN Zw9BtaVadrk+w== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2BA221204A2; Sun, 14 Aug 2022 22:36:12 -0400 (EDT) From: Stefan Monnier In-Reply-To: <835yiuk8ih.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Aug 2022 21:03:18 +0300") Message-ID: References: <871quc8n90.fsf@gnus.org> <87edyayie9.fsf@gnus.org> <83ilmukby2.fsf@gnu.org> <835yiuk8ih.fsf@gnu.org> Date: Sun, 14 Aug 2022 22:36:04 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> >> - (or (byte-code-function-p (symbol-function 'byte-compile-form)) >> >> - (subr-native-elisp-p (symbol-function 'byte-compile-form)) >> >> - (assq 'byte-code (symbol-function 'byte-compile-form)) <<<<<<<<<<<<< >> >> + (or (compiled-function-p (symbol-function 'byte-compile-form)) >> >> According to my reading of the code, this `assq` can never return >> non-nil. > > Too bad the commit log message didn't say that, then. Imagine someone > 5 or 10 years from now trying to understand the fine points of that > changeset... If (assq 'byte-code (symbol-function 'byte-compile-form)) returns non-nil, it means that the `byte-compile-form` function has been byte-compiled by the Emacs-18 byte-compiler (the byte-code-function type was only introduced in Emacs-19). So `compiled-function-p` *should* replace all 3 cases. IOW I believe the above diff is "obviously right" and the question is whether `compiled-function-p` should be changed to return non-nil for functions of the form (lambda (...) (byte-code ...)), i.e. those functions generated by Emacs-18's byte-compiler. I hope we don't need to keep that backward compatibility, tho ;-) Stefan