GNU bug report logs - #56641
Deprecate `lsh`

Previous Next

Package: emacs;

Reported by: Mattias Engdegård <mattiase <at> acm.org>

Date: Tue, 19 Jul 2022 13:39:01 UTC

Severity: normal

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#56641: closed (Deprecate `lsh`)
Date: Sat, 23 Jul 2022 10:33:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 23 Jul 2022 12:32:24 +0200
with message-id <4C2D62F6-0581-4E0D-8C2A-AC5235C976A5 <at> acm.org>
and subject line Re: bug#56641: Deprecate `lsh`
has caused the debbugs.gnu.org bug report #56641,
regarding Deprecate `lsh`
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
56641: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56641
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mattias Engdegård <mattiase <at> acm.org>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Subject: Deprecate `lsh`
Date: Tue, 19 Jul 2022 15:38:29 +0200
The function `lsh` works almost like `ash` but is much slower, cannot be constant-folded by the compiler, and above all has confusing semantics for historical reasons. Using `lsh` instead of `ash` is always a mistake.

For these reasons we should deprecate `lsh`. It is not important to remove it as soon as possible, but to dissuade people from accidentally using it in their code.



[Message part 3 (message/rfc822, inline)]
From: Mattias Engdegård <mattiase <at> acm.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56641-done <at> debbugs.gnu.org, Wilson Snyder <wsnyder <at> wsnyder.org>
Subject: Re: bug#56641: Deprecate `lsh`
Date: Sat, 23 Jul 2022 12:32:24 +0200
There is now a compiler warning about calls to `lsh`.

Although we usually defer changes in verilog-mode.el to the maintainer for keeping in sync with the upstream version, I made the necessary (trivial) adjustments to keep warnings away.



This bug report was last modified 2 years and 302 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.