GNU bug report logs - #56638
[PATCH] gnu: Add asli.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#56638: closed ([PATCH] gnu: Add asli.)
Date: Fri, 08 Sep 2023 17:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 08 Sep 2023 19:16:32 +0200
with message-id <87cyys37rj.fsf <at> inria.fr>
and subject line Re: bug#56638: [PATCH] gnu: Add asli.
has caused the debbugs.gnu.org bug report #56638,
regarding [PATCH] gnu: Add asli.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
56638: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56638
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Paul A. Patience" <paul <at> apatience.com>
To: guix-patches <at> gnu.org
Cc: "Paul A. Patience" <paul <at> apatience.com>
Subject: [PATCH] gnu: Add asli.
Date: Tue, 19 Jul 2022 07:59:45 +0000

* gnu/packages/graphics.scm (asli): New variable.
---
 gnu/packages/graphics.scm | 67 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index c193be1efb..bae1ba1f99 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -31,6 +31,7 @@
 ;;; Copyright © 2022 John Kehayias <john.kehayias <at> protonmail.com>
 ;;; Copyright © 2022 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2022 Tobias Kortkamp <tobias.kortkamp <at> gmail.com>
+;;; Copyright © 2022 Paul A. Patience <paul <at> apatience.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2120,3 +2121,69 @@ (define-public azpainter
 @end itemize
 ")
     (license license:gpl3+)))
+
+(define-public asli
+  (package
+    (name "asli")
+    (version "0.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/tpms-lattice/ASLI")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "02hwdavpsy3vmivd6prp03jn004ykrl11lbkvksy5i2zm38zbknr"))
+       (modules '((guix build utils)))
+       (snippet
+        ;; Remove bundled libraries except ALGLIB, TetGen and yaml-cpp, which
+        ;; are statically linked, and KU Leuven's mTT, which is an obscure
+        ;; (i.e., unfindable by searching online for “mTT KU Leuven”), BSD-3
+        ;; licensed, header-only library.
+        ;;
+        ;; AdaptTools and mmg are missing from Guix, but anyway they are
+        ;; unused because mmg support is disabled (-DMMG_MESH=OFF).
+        #~(begin
+            (delete-file-recursively "libs/AdaptTools")
+            (delete-file-recursively "libs/CGAL")
+            (delete-file-recursively "libs/eigen")
+            (delete-file-recursively "libs/mmg")))))
+    (build-system cmake-build-system)
+    (native-inputs
+     ;; Header-only library
+     (list cgal))
+    (inputs
+     (list boost
+           eigen
+           gmp
+           mpfr
+           tbb-2020))
+    (arguments
+     (list #:tests? #f                  ; No tests
+           #:configure-flags
+           #~(list "-DCGAL_ACTIVATE_CONCURRENT_MESH_3=ON"
+                   "-DMMG_MESH=OFF"     ; Build fails when enabled (the default)
+                   (string-append "-DEIGEN3_INCLUDE_DIR="
+                                  #$(this-package-input "eigen")
+                                  "/include/eigen3"))
+           #:phases
+           #~(modify-phases %standard-phases
+               (replace 'install        ; No install phase
+                 (lambda _
+                   (with-directory-excursion "../source/bin"
+                     (install-file "ASLI" (string-append #$output "/bin"))
+                     ;; The manual is included in the repository.
+                     ;; Building it requires -DASLI_DOC=ON, but this is marked
+                     ;; as unsupported (presumably for users).
+                     (install-file "docs/ASLI [User Manual].pdf"
+                                   (string-append #$output "/share/doc/"
+                                                  #$name "-" #$version))))))))
+    (home-page "http://www.biomech.ulg.ac.be/ASLI/")
+    (synopsis "Create lattice infills with varying unit cell type, size and feature")
+    (description "ASLI (A Simple Lattice Infiller) is a command-line tool that
+allows users to fill any 3D geometry with a functionally graded lattice.  The
+lattice infill is constructed out of unit cells, described by implicit
+functions, whose type, size and feature can be varied locally to obtain the
+desired local properties.")
+    (license license:agpl3+)))
--
2.37.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 56638-done <at> debbugs.gnu.org
Subject: Re: bug#56638: [PATCH] gnu: Add asli.
Date: Fri, 08 Sep 2023 19:16:32 +0200

Hi Paul,

"Paul A. Patience" <paul <at> apatience.com> skribis:

> Thanks for the shasum; it allowed me to discover the problem.
> There are trailing spaces in the original CMakeLists.txt, which also
> appear in the patch.
> When sending the patch inline, these spaces are trimmed.
> (The spaces are highlighted in Magit, so I was aware of them, but I
> didn't realize they would be trimmed somewhere in the email pipeline.)
>
> I will attach the patch file separately, and also a tarred version just
> in case.
> So you can verify that you have the right one, here's my shasum:
>
> $ sha256sum gnu/packages/patches/asli-use-system-libs.patch
> fb1531a4f71e95354af6927175f67b90f39250604aa6859d9def4778027f1810  gnu/packages/patches/asli-use-system-libs.patch

Perfect; pushed as 05f44bbeb40686599827cbe0df7fcc80122fe152.

Thank you and apologies for taking so much time!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.