Subject: [bug#56638] [PATCH] gnu: Add asli.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 29 Aug 2022 23:21:43 +0200

Hi Paul,

Did you have a chance to look into this?

Thanks in advance,
Ludo’.

Ludovic Courtès <[email-masked]> skribis:

> Hi Paul,
>
> "Paul A. Patience" <[email-masked]> skribis:
>
>> * gnu/packages/graphics.scm (asli): New variable.
>> * gnu/packages/patches/asli-use-system-libs.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Register patch.
>
> The source derivation fails to build for me:
>
> File CMakeLists.txt is read-only; trying to patch anyway
> patching file CMakeLists.txt
> Hunk #2 FAILED at 172.
> Hunk #3 succeeded at 240 (offset 1 line).
> Hunk #4 succeeded at 253 (offset 1 line).
> 1 out of 4 hunks FAILED -- saving rejects to file CMakeLists.txt.rej
>
>> diff --git a/gnu/packages/patches/asli-use-system-libs.patch b/gnu/packages/patches/asli-use-system-libs.patch
>> new file mode 100644
>> index 0000000000..d8234fd608
>> --- /dev/null
>> +++ b/gnu/packages/patches/asli-use-system-libs.patch
>> @@ -0,0 +1,70 @@
>> +diff --git a/CMakeLists.txt b/CMakeLists.txt
>> +index b11c5ba..702423e 100755
>
> Also, as suggested by ‘guix lint’, please add a comment at the top
> stating what this does and what the upstream status is (if it’s been
> submitted), at least something like:
>
>   Tweak build system to use system dependencies instead of those that
>   are bundled.
>
> Could you please send an updated patch?
>
> Thanks!
>
> Ludo’.