GNU bug report logs - #56603
[PATCH] Ensure that directories exist when copying files from archive

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56603 in the body.
You can then email your comments to 56603 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Ensure that directories exist when copying files from archive
Date: Sat, 16 Jul 2022 20:50:38 +0530

[Message part 1 (text/plain, inline)]

Tags: patch

If a zip file is of the following contents,

    a/some-text.txt
    a/b/some-other.txt

and you mark all files and extract them to the directory /tmp/test/, the current copy
command bugs out since `write-to-region' complains about /tmp/test/a/ and
/tmp/test/a/b/ not existing.

If you tried to extract a single file a/some-text.txt after answer /tmp/
to the prompt, the C command fails due to the above reason.

This patch creates the relevant directories if they don't exist.  But
perhaps the patch should be more robust?  I.e., if /tmp/test/a was a
file, then it should error?

In GNU Emacs 29.0.50 (build 21, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2022-07-16 built on astatine
Repository revision: 9a5b52dace4cb0fe6b99205911d9b2f2487a4a83
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json
 --without-xaw3d --without-gconf --without-libsystemd --without-cairo'

[0001-Ensure-that-directories-exist-when-copying-files-fro.patch (text/patch, attachment)]

Message #8 received at 56603 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 56603 <at> debbugs.gnu.org
Subject: Re: bug#56603: [PATCH] Ensure that directories exist when copying
 files from archive
Date: Sun, 17 Jul 2022 11:23:15 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> This patch creates the relevant directories if they don't exist.  But
> perhaps the patch should be more robust?  I.e., if /tmp/test/a was a
> file, then it should error?

We'll get an error from that make-directory call, and I think that's
sufficient, so I've pushed your patch to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 56603 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56603 <at> debbugs.gnu.org
Subject: Re: bug#56603: [PATCH] Ensure that directories exist when copying
 files from archive
Date: Sun, 17 Jul 2022 15:28:02 +0530

[ஞாயிறு ஜூலை 17, 2022] Lars Ingebrigtsen wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
>> This patch creates the relevant directories if they don't exist.  But
>> perhaps the patch should be more robust?  I.e., if /tmp/test/a was a
>> file, then it should error?
>
> We'll get an error from that make-directory call, and I think that's
> sufficient, so I've pushed your patch to Emacs 29.

Thanks

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.