GNU bug report logs - #56579
[PATCH] gnu: admin: Add fail2ban 0.11.2.

Previous Next

Full log

View this message in rfc822 format

From: muradm <mail <at> muradm.net>
To: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
Cc: "56579 <at> debbugs.gnu.org" <56579 <at> debbugs.gnu.org>
Subject: [bug#56579] [PATCH] gnu: admin: Add fail2ban 0.11.2.
Date: Sun, 17 Jul 2022 19:13:48 +0300

[Message part 1 (text/plain, inline)]

Hi, I think you are commenting on initial versions.
Please refer to last v5, which is quite crafted.

Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech> writes:

> Hello muradm!
>
>>+    (arguments
>>+     '(#:phases (modify-phases %standard-phases
>
> I think you can benefit a little bit from using G-Expressions 
> here:
>
> (arguments
>   (list #:phases
>         #~(modify-phases %modify-phases
>             ...)))
>
> For example:
>
>>+                      (let* ((awk (assoc-ref inputs "gawk"))
>>+                             (awk (string-append awk 
>>"/bin/awk"))
>
> Could be replaced by:
>
> (let* ((awk (string-append #$gawk "/bin/awk"))))
>
> Applies to others too. Could save some vertical space.
>
> —
> Jean-Pierre De Jesus DIAZ

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.