GNU bug report logs - #56579
[PATCH] gnu: admin: Add fail2ban 0.11.2.

Previous Next

Package: guix-patches;

Reported by: muradm <mail <at> muradm.net>

Date: Fri, 15 Jul 2022 18:18:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #20 received at 56579 <at> debbugs.gnu.org (full text, mbox):

From: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
To: "mail <at> muradm.net" <mail <at> muradm.net>,
 "56579 <at> debbugs.gnu.org" <56579 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: admin: Add fail2ban 0.11.2.
Date: Sun, 17 Jul 2022 13:48:07 +0000

Hello muradm!

>+    (arguments
>+     '(#:phases (modify-phases %standard-phases

I think you can benefit a little bit from using G-Expressions here:

(arguments
  (list #:phases
        #~(modify-phases %modify-phases
            ...)))

For example:

>+                      (let* ((awk (assoc-ref inputs "gawk"))
>+                             (awk (string-append awk "/bin/awk"))

Could be replaced by:

(let* ((awk (string-append #$gawk "/bin/awk"))))

Applies to others too. Could save some vertical space.

—
Jean-Pierre De Jesus DIAZ
This bug report was last modified 2 years and 293 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.