From unknown Fri Jul 11 15:19:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#5657 <5657@debbugs.gnu.org> To: bug#5657 <5657@debbugs.gnu.org> Subject: Status: `vc-git-annotate-extract-revision-at-line' returns incorrect pathname Reply-To: bug#5657 <5657@debbugs.gnu.org> Date: Fri, 11 Jul 2025 22:19:03 +0000 retitle 5657 `vc-git-annotate-extract-revision-at-line' returns incorrect p= athname reassign 5657 emacs submitter 5657 =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec severity 5657 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 28 09:59:37 2010 Received: (at submit) by debbugs.gnu.org; 28 Feb 2010 14:59:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NlkcL-0003Cy-6L for submit@debbugs.gnu.org; Sun, 28 Feb 2010 09:59:37 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nlkad-0003Bb-LF for submit@debbugs.gnu.org; Sun, 28 Feb 2010 09:57:52 -0500 Received: from mx10.gnu.org ([199.232.76.166]:60989) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NlkaY-0008Uo-Or for submit@debbugs.gnu.org; Sun, 28 Feb 2010 09:57:46 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NlkaX-0006tA-Em for submit@debbugs.gnu.org; Sun, 28 Feb 2010 09:57:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:46512) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NlkaX-0006t4-AI for submit@debbugs.gnu.org; Sun, 28 Feb 2010 09:57:45 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NlkaW-0005Cy-Lk for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2010 09:57:44 -0500 Received: from [140.186.70.92] (port=58931 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlkaV-0005Ca-N9 for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2010 09:57:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NlkaV-0003sU-Pj for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2010 09:57:44 -0500 Received: from mail-fx0-f222.google.com ([209.85.220.222]:35755) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NlkaV-0003sN-LE for bug-gnu-emacs@gnu.org; Sun, 28 Feb 2010 09:57:43 -0500 Received: by fxm22 with SMTP id 22so1659497fxm.26 for ; Sun, 28 Feb 2010 06:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:mail-followup-to:mime-version:content-type :content-disposition:content-transfer-encoding:user-agent; bh=rYqQLIPRhIdflIMbzefpj93aMQAF5hoQsHIQFr6C7Mk=; b=ubgOG61P+mYcoCc9a8f33t2JAlZF3akT0U1McuwajDfybAtQyZg0KErRHh2jZbDIvt FBljsyzLHF/uT5aqVzejYhi/UXZLPwOPDnbTPfKJbCMx2aYCGlAGcjyrBrEShEvZvzUt LEQNv3ebCn+VspEWz9I92+f49ZVaOrPR4DbIs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:content-transfer-encoding :user-agent; b=r8mIBVoY96v+p0cxVEUM5vySvRe8jkrkkIsqQs4ABCAdQ5uN0Yvt6TXEDM0t7txZYC yfy1FZyfnyWZqonhm3aEpTuf5aD5JckUey8jkGJPJPQYgFvCw5oo7Bz5+OoknXrpKFvX NyiUp2w9JU3ICI6/C7HK59V1kyAq/ZJxeSoHU= Received: by 10.223.17.155 with SMTP id s27mr3657089faa.13.1267369060905; Sun, 28 Feb 2010 06:57:40 -0800 (PST) Received: from localhost ([88.103.132.186]) by mx.google.com with ESMTPS id y15sm3709856fkd.8.2010.02.28.06.57.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 28 Feb 2010 06:57:39 -0800 (PST) Date: Sun, 28 Feb 2010 15:57:58 +0100 From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= To: bug-gnu-emacs@gnu.org Subject: `vc-git-annotate-extract-revision-at-line' returns incorrect pathname Message-ID: <20100228145758.GB16169@headley> Mail-Followup-To: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= , bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.20 (2009-08-27) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 28 Feb 2010 09:59:35 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Hello, I spotted this when running `vc-annotate-show-diff-revision-at-line', which called the above-mentioned fuction in this case. Incorrect path is returned when not called from the repository root, because the value of `default-directory' (used by `expand-file-name') will be different (i.e. the current directory deeper in the tree, instead of the root dir). The patch below (based on the latest Git master) fixes it. Regards, Štěpán Němec --- a/lisp/vc-git.el +++ b/lisp/vc-git.el @@ -668,7 +668,9 @@ or BRANCH^ (where \"^\" can be repeated)." (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?") (let ((revision (match-string-no-properties 1))) (if (match-beginning 2) - (cons revision (expand-file-name (match-string-no-properties 3))) + (cons revision (expand-file-name + (match-string-no-properties 3) + (vc-git-root default-directory))) revision))))) ;;; TAG SYSTEM From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 07 09:19:19 2010 Received: (at 5657) by debbugs.gnu.org; 7 Mar 2010 14:19:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NoHKB-0000py-IH for submit@debbugs.gnu.org; Sun, 07 Mar 2010 09:19:19 -0500 Received: from mail-fx0-f228.google.com ([209.85.220.228]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NoHK9-0000pt-1m for 5657@debbugs.gnu.org; Sun, 07 Mar 2010 09:19:17 -0500 Received: by fxm28 with SMTP id 28so4732914fxm.39 for <5657@debbugs.gnu.org>; Sun, 07 Mar 2010 06:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:user-agent :date:message-id:mime-version:content-type; bh=RfbuISobiI3cXWvxwTY4hecRNRODDhIz1SHka571Vwg=; b=D3+02766ohpOIYxweIwhEnmW1sn6UgpSVfjPGBZR3/aj+nbGlyqWKak4OYUL+t9v/V SswwXWvlIKGH2y7inJyY8RvfU1m5uVu4V3ECaWTidsr6/0IjLv4jiTDyXkOTRKsqeJWO O7zQqUxeYNAW7OUVGgn6yYPEdv4Z2jCcf38sg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:user-agent:date:message-id:mime-version :content-type; b=HHEdUnGAFnbyHwrcyj6jOx4zCxUeTHwYXT6MEiW9FXaLMgNHKa6oNy8cJWnW10AdIx O1bfvucP7xNYic/TshkFE+nkKExGVu+mXxNJye9FAK1oPupmk1LYihozFQSeDTzyk+er DUppS1ZbeTaxmkiT2m8NaU32XA6Ip4foztqs8= Received: by 10.223.15.133 with SMTP id k5mr4252928faa.39.1267971551563; Sun, 07 Mar 2010 06:19:11 -0800 (PST) Received: from localhost ([88.103.132.186]) by mx.google.com with ESMTPS id 2sm7121562fks.42.2010.03.07.06.19.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 07 Mar 2010 06:19:10 -0800 (PST) From: stepnem@gmail.com (=?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?=) To: 5657@debbugs.gnu.org Subject: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) Date: Sun, 07 Mar 2010 15:19:17 +0100 Message-ID: <87hbosxli2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 5657 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) PING [Any reason not to act on this?] From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 07 09:46:14 2010 Received: (at 5657) by debbugs.gnu.org; 7 Mar 2010 14:46:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NoHkE-00012R-5H for submit@debbugs.gnu.org; Sun, 07 Mar 2010 09:46:14 -0500 Received: from pantheon-po25.its.yale.edu ([130.132.50.119]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NoHkC-00012M-Si for 5657@debbugs.gnu.org; Sun, 07 Mar 2010 09:46:13 -0500 Received: from furry (adsl-99-58-201-129.dsl.wlfrct.sbcglobal.net [99.58.201.129]) (authenticated bits=0) by pantheon-po25.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o27Ek6ng030778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 7 Mar 2010 09:46:07 -0500 Received: by furry (Postfix, from userid 1000) id 92BE056CC01; Sun, 7 Mar 2010 09:46:03 -0500 (EST) From: Chong Yidong To: stepnem@gmail.com Subject: Re: bug#5657: References: <20100228145758.GB16169@headley> <87hbosxli2.fsf@gmail.com> Date: Sun, 07 Mar 2010 09:46:03 -0500 In-Reply-To: <87hbosxli2.fsf@gmail.com> (stepnem@gmail.com =?utf-8?B?Iig=?= =?utf-8?B?xaF0xJtww6FuIG7Em21lYykiJ3M=?= message of "Sun, 07 Mar 2010 15:19:17 +0100") Message-ID: <87k4torxzo.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 5657 Cc: 5657@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) stepnem@gmail.com "(=C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec)" writes: > PING > [Any reason not to act on this?] I've just checked it in. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 07 09:46:42 2010 Received: (at control) by debbugs.gnu.org; 7 Mar 2010 14:46:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NoHkg-00012e-CK for submit@debbugs.gnu.org; Sun, 07 Mar 2010 09:46:42 -0500 Received: from pantheon-po25.its.yale.edu ([130.132.50.119]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NoHke-00012Z-N5 for control@debbugs.gnu.org; Sun, 07 Mar 2010 09:46:40 -0500 Received: from furry (adsl-99-58-201-129.dsl.wlfrct.sbcglobal.net [99.58.201.129]) (authenticated bits=0) by pantheon-po25.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o27EkY0H030832 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 7 Mar 2010 09:46:35 -0500 Received: by furry (Postfix, from userid 1000) id 1FBD956CC01; Sun, 7 Mar 2010 09:46:34 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 5657 Date: Sun, 07 Mar 2010 09:46:34 -0500 Message-ID: <87lje4i3zp.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) close 5657 thanks From unknown Fri Jul 11 15:19:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 05 Apr 2010 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator