From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 15:22:13 2022 Received: (at submit) by debbugs.gnu.org; 14 Jul 2022 19:22:13 +0000 Received: from localhost ([127.0.0.1]:38923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oC4Pb-0003Iq-70 for submit@debbugs.gnu.org; Thu, 14 Jul 2022 15:22:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:58138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oC4PW-0003If-Fs for submit@debbugs.gnu.org; Thu, 14 Jul 2022 15:22:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC4PW-0005DS-BN for guix-patches@gnu.org; Thu, 14 Jul 2022 15:22:06 -0400 Received: from araneo.si ([2001:15c0:2110:3400::2]:44826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC4PU-0005UP-L9 for guix-patches@gnu.org; Thu, 14 Jul 2022 15:22:06 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 89201200 for ; Thu, 14 Jul 2022 19:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20180623; bh=7rz4RIbX8y30JuyjFT4DY/E1MuU=; b=EEc+ZYGuAaMPoDb8 VSWB/byQOGgY8O0K2mjjBl0iUsbQiLRNvP/hileZamurNbjP2DssgcldNQzc9Ruo IzrkDhy9LzY6vTgmyevIqxuw82+iHI/y3OK3Fqdi1ty3t9+OKE4V/7RuaslzwUQU FxK/isF3omNQasjZKcK79y7JZjAXGQ9ScgDUOaXgeDZu8pwwdXzBF07N8uPy+spw umsvLY8sK8qNGq1zkRR7NcOViU4tS1cJ/7JOXu4HNpLaiGfzwE821elArVp0OBXU K2NwWtKG5yuDFNlVcNPoDMm2fwgakL0nzjGCTPWKoYyE+1QoKFBoNtYgkvrFf6P/ 4gOJbA== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 70c4296b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 14 Jul 2022 19:21:59 +0000 (UTC) From: Timotej Lazar To: guix-patches@gnu.org Subject: [PATCH] gnu: tests: Fix guix-data-service test. Date: Thu, 14 Jul 2022 21:21:38 +0200 Message-Id: <20220714192137.23039-1-timotej.lazar@araneo.si> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:15c0:2110:3400::2; envelope-from=timotej.lazar@araneo.si; helo=araneo.si X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Timotej Lazar X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Since revision 32, guix-data-service starts immediately but returns an HTTP error code until initialization is complete. Adjust the test accordingly, and remove the increased startup time limit. * gnu/services/guix.scm (guix-data-service): Use default #:pid-file-timeout. * gnu/tests/guix.scm (guix-data-service): Retry the http-get test several times to give the service time to initialize. --- gnu/services/guix.scm | 2 -- gnu/tests/guix.scm | 19 +++++++++++++------ 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/gnu/services/guix.scm b/gnu/services/guix.scm index 338e027245..dac1e5841a 100644 --- a/gnu/services/guix.scm +++ b/gnu/services/guix.scm @@ -652,8 +652,6 @@ (define (guix-data-service-shepherd-services config) #:user #$user #:group #$group #:pid-file "/var/run/guix-data-service/pid" - ;; Allow time for migrations to run - #:pid-file-timeout 120 #:environment-variables `(,(string-append "GUIX_LOCPATH=" #$glibc-utf8-locales "/lib/locale") diff --git a/gnu/tests/guix.scm b/gnu/tests/guix.scm index a4c3e35e5d..ce62f74b60 100644 --- a/gnu/tests/guix.scm +++ b/gnu/tests/guix.scm @@ -222,14 +222,21 @@ (define marionette ((pid) (number? pid)))))) marionette)) + ;; The service starts immediately but replies with status 500 until + ;; initialization is complete, so keep trying for a while. + (define* (try-http-get attempts) + (let ((status (let-values (((response text) + (http-get #$(simple-format + #f "http://localhost:~A/healthcheck" + forwarded-port)))) + (response-code response)))) + (if (or (= status 200) (<= attempts 1)) + status + (begin (sleep 10) (try-http-get (- attempts 1)))))) + (test-equal "http-get" 200 - (let-values - (((response text) - (http-get #$(simple-format - #f "http://localhost:~A/healthcheck" forwarded-port) - #:decode-body? #t))) - (response-code response))) + (try-http-get 10)) (test-end)))) -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 17:26:45 2022 Received: (at 56563) by debbugs.gnu.org; 14 Jul 2022 21:26:45 +0000 Received: from localhost ([127.0.0.1]:39021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oC6M8-0006Ye-Jh for submit@debbugs.gnu.org; Thu, 14 Jul 2022 17:26:45 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:36939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oC6Ls-0006YB-8X for 56563@debbugs.gnu.org; Thu, 14 Jul 2022 17:26:43 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 11403320094D; Thu, 14 Jul 2022 17:26:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 14 Jul 2022 17:26:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= bonfacemunyoki.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1657833981; x= 1657920381; bh=OUzTcqywb9CaWNu+45Xe2dp1uQC1DdF7Ic1HnQVX5cE=; b=F F6dIZdf60Z+gU0CDqiqhlM1vHup4xbCYYnUdXc0+tbfaI3rBLoCTjd4g8zFlBKrH wd/7UHJc80xgrDSrvYdbTPKjS/JYOiyg0vrkL6xruYnQrPd1YLo5U+JcpOQg5EF1 1/xUY74G+R+2RyfQ4ljaEiSX8WD/8qBB7AfHdRcGaBDN5SIlr7jLki81po/nFdB0 on6kiEAux8n5ghhKGGyKWDuwKVspWKvyLGNXJsJvTZlkHFGpbEuiBLdU4MOSGzye ipYrbxXYz2CC6oHUGokMgjFAbfiJKPm4TN41SZwZ851UfGe8VhA2yDtR0tr+1C0n ai10g7bbkZZ2AGdVmO95Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657833981; x=1657920381; bh=OUzTcqywb9CaWNu+45Xe2dp1uQC1 DdF7Ic1HnQVX5cE=; b=tq0tx7xSGG73qMtyAtqURg+kqUNG9h9NQnjR2FcgpYGL pxnu4BoIvEzDGH/MCFXodLhDHk52UO3Hx/Lyv47/XbHU2JlEa2jb3eaABKOfeClW fGGJ9oySWcwgE776KAGGBxRcX7BJqlOCTfR93BvFhMT3WqSZ3kmqcdjQKqzH/f3R CwlrSKy0ZuSFDZmDTFiVcf6CWf9DWZV/+fxd5XGaN5Wg8r7KE4P8DuBzQ7Jzc/lT 52X9lpfxiL2byRAhoQ6G10Xll3aO8ChQYVmTsMNr8oVutsLzNtyzS+kZJYmLu60i ySE4RVJxXwkrvsYspS+febwY0kCl0iUc1dONq1B6sg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejledgudeifecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufhfffgjkfgfgggtsehgtderredtredtnecuhfhrohhmpefouhhn hihokhhiucfmihhlhihunhhgihcuoehmvgessghonhhfrggtvghmuhhnhihokhhirdgtoh hmqeenucggtffrrghtthgvrhhnpeegkeevfefgjedtvdekvdfflefgheeugfejgeffffej udeikedvheejleeuveefteenucffohhmrghinhepghhnuhhpghdrnhgvthenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmvgessghonhhfrggt vghmuhhnhihokhhirdgtohhm X-ME-Proxy: Feedback-ID: ib8a1471e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Jul 2022 17:26:20 -0400 (EDT) From: Munyoki Kilyungi To: Timotej Lazar Subject: Re: [bug#56563] [PATCH] gnu: tests: Fix guix-data-service test. References: <20220714192137.23039-1-timotej.lazar@araneo.si> Date: Fri, 15 Jul 2022 00:26:16 +0300 In-Reply-To: <20220714192137.23039-1-timotej.lazar@araneo.si> (Timotej Lazar's message of "Thu, 14 Jul 2022 21:21:38 +0200") Message-ID: <86v8rze687.fsf@bonfacemunyoki.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56563 Cc: 56563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Timotej Lazar anaandika: [...] > + ;; The service starts immediately but replies with status 500 = until > + ;; initialization is complete, so keep trying for a while. > + (define* (try-http-get attempts) Minor nitpick. This function definition does not take any optional or key-word arguments AFAICT, so it should be a "define" instead :) > + (let ((status (let-values (((response text) > + (http-get #$(simple-format > + #f "http://localhos= t:~A/healthcheck" > + forwarded-port)))) > + (response-code response)))) > + (if (or (=3D status 200) (<=3D attempts 1)) > + status > + (begin (sleep 10) (try-http-get (- attempts 1)))))) > + > (test-equal "http-get" > 200 > - (let-values > - (((response text) > - (http-get #$(simple-format > - #f "http://localhost:~A/healthcheck" forw= arded-port) > - #:decode-body? #t))) > - (response-code response))) > + (try-http-get 10)) >=20=20 > (test-end)))) =2D-=20 (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJKBAEBCAA0FiEE1PCesRAXfgPCji/h9buuHgOSJT8FAmLQifgWHG1lQGJvbmZh Y2VtdW55b2tpLmNvbQAKCRD1u64eA5IlPz6cD/9dJFwY8/Zklw27JijEv4NeldAK NBRfQBovPBfHUJzCP0kLDVzHWn0PfIvNCQRw8Xn2b5gdCMsjcMvDCxabt0bRcjQi YF/iu/W2QDcKbQH2GSwLeOZgqSqLbiHNf0kTkvsiJJc9KusEC8HjjOyDhntgwGkP uKmpg1vLz+095uF5Qjf2hn1lGNfi67N4UVWYTq2oTKY+IHV0H1+jqNqgt0FM/Y4e xNw7zOpdx4VwIbcl7NaGCzQBWH3UkDpGWz+nY6BI2MnUWZQ3hA604dNbgDEcdUzC kaGAyORkFu9qelNuUFJQRUoZGvmRdUaW63Kx2o2t1Nf34PV2iC78PnRTrjO+XiAD nK5GVOB8DjeSR6J80ZUifM48+9LBdqH4VSJATPaQWlMCWH2RarST6dUKhrxTCael J/WhzM7q+HThVoVMd79d9YcR4Fkzi65NX0DAXxgwbjAyotG93nWvkIudc2tNbixe Lz/bEraeomE2HgxMFQPMbQE1xSX4/Ia6C1XZ9J8RdQz+Y1IJBsesj9M66NCo4SsL +dH+XzuJ2ykFGKuMpU7SoryBv3x0QfB+UHPhMo0YA4h9qSdQgioPFtWzc69/Ke4g mn3IWLk0SjAcI64I9dep/1cOH+LgBQdNnNq9U+efRfC5f/D6ZR2dbrE6xQCIcdiq +0jUrqx6Aty6FTwTNw== =rH/u -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 01:52:39 2022 Received: (at 56563) by debbugs.gnu.org; 15 Jul 2022 05:52:39 +0000 Received: from localhost ([127.0.0.1]:39240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCEFj-0002tG-4s for submit@debbugs.gnu.org; Fri, 15 Jul 2022 01:52:39 -0400 Received: from araneo.si ([90.157.193.204]:43784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCEFh-0002t6-4K for 56563@debbugs.gnu.org; Fri, 15 Jul 2022 01:52:38 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id d8669a7e; Fri, 15 Jul 2022 05:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=20180623; bh=QqjY6jJ1 L0VA/pBQymI7ltNfsqE=; b=TDsM9tj6UkPG62c0ckyVQHnYXGeIDsD9umflNFFa o0aokJmlZ7SReeLITPJjdsyHsLzk94ttQ5o92L/fBSViBTkotZmdSbWAjjmovBL/ vEDF0QfiGy4IPQaz+lg6uAEM55jKwjUN3QO5nL9M3ekHKSoSYkcS74xnehMronxJ zH2zsRkO+UwyUm/DR/J0xGMXdlJNb3x5oAdjItt1GBoq7HVzLnCO//GdCImA86Zi Qp1x37GsnuX+dvqd9DsZOpxJ68UlBHtESc405Vcg1ocI1ThsxFFDuvme/WgcmHId olyorLhT/HW6+aPUaR1l5uRwnBomOysf2a+6N9b9zZfKNA== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 314f5c44 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 15 Jul 2022 05:52:34 +0000 (UTC) From: Timotej Lazar To: Munyoki Kilyungi Subject: Re: [bug#56563] [PATCH] gnu: tests: Fix guix-data-service test. In-Reply-To: <86v8rze687.fsf@bonfacemunyoki.com> References: <20220714192137.23039-1-timotej.lazar@araneo.si> <86v8rze687.fsf@bonfacemunyoki.com> Date: Fri, 15 Jul 2022 07:52:33 +0200 Message-ID: <877d4eexcu.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56563 Cc: 56563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Munyoki Kilyungi [2022-07-15 00:26:16+0300]: > Timotej Lazar anaandika: >> + (define* (try-http-get attempts) > > Minor nitpick. This function definition does not > take any optional or key-word arguments AFAICT, so > it should be a "define" instead :) It used to but then I changed my mind. :) Nice catch, I=E2=80=99ll send an update. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 01:56:43 2022 Received: (at 56563) by debbugs.gnu.org; 15 Jul 2022 05:56:43 +0000 Received: from localhost ([127.0.0.1]:39245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCEJe-0002yr-Nh for submit@debbugs.gnu.org; Fri, 15 Jul 2022 01:56:43 -0400 Received: from araneo.si ([90.157.193.204]:43798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCEJc-0002yj-Jp for 56563@debbugs.gnu.org; Fri, 15 Jul 2022 01:56:41 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id 99011bd6 for <56563@debbugs.gnu.org>; Fri, 15 Jul 2022 05:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20180623; bh=py/Lm6wBUMnMFYclW0DqLji77RQ=; b=XxLPEPS21/4PJHtp Wxir6E9P22Dv/kBFvucgvosgeQdQYNykJZn9IOAq8sUc6Bm3y4xK0UsxSrio4qvO 5adihfT2H2lx7poVpXzMDLwV9UQTrHoN652qFSnefZdyVCueHQVpgXUOFKOFDOaC buxVWBlZXpciKUEZH2ADTWG6FWbesX/Soaa63ELmhD5htJ3NMvqOTvz1366R2zlW 6mWGHk9/qxf6acZRiFlZJtSgmLGlnMVHIQqLHQ1X2RCidL+LUCjA7BjcMU95UA4Z kdTBzJJoCfUwkDfMenzM0QcW1F4i1KhpElIvs9FQy8UgNyv9Ru8R3EC4weSHLHgs dRTpkA== Received: by araneo.si (OpenSMTPD) with ESMTPSA id d0d4b2d2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 15 Jul 2022 05:56:39 +0000 (UTC) From: Timotej Lazar To: 56563@debbugs.gnu.org Subject: [PATCH v2] gnu: tests: Fix guix-data-service test. Date: Fri, 15 Jul 2022 07:56:06 +0200 Message-Id: <20220715055604.4803-1-timotej.lazar@araneo.si> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56563 Cc: Timotej Lazar X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Since revision 32, guix-data-service starts immediately but returns an HTTP error code until initialization is complete. Adjust the test accordingly, and remove the increased startup time limit. * gnu/services/guix.scm (guix-data-service): Use default #:pid-file-timeout. * gnu/tests/guix.scm (guix-data-service): Retry the http-get test several times to give the service time to initialize. --- gnu/services/guix.scm | 2 -- gnu/tests/guix.scm | 19 +++++++++++++------ 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/gnu/services/guix.scm b/gnu/services/guix.scm index 338e027245..dac1e5841a 100644 --- a/gnu/services/guix.scm +++ b/gnu/services/guix.scm @@ -652,8 +652,6 @@ (define (guix-data-service-shepherd-services config) #:user #$user #:group #$group #:pid-file "/var/run/guix-data-service/pid" - ;; Allow time for migrations to run - #:pid-file-timeout 120 #:environment-variables `(,(string-append "GUIX_LOCPATH=" #$glibc-utf8-locales "/lib/locale") diff --git a/gnu/tests/guix.scm b/gnu/tests/guix.scm index a4c3e35e5d..02221f4364 100644 --- a/gnu/tests/guix.scm +++ b/gnu/tests/guix.scm @@ -222,14 +222,21 @@ (define marionette ((pid) (number? pid)))))) marionette)) + ;; The service starts immediately but replies with status 500 until + ;; initialization is complete, so keep trying for a while. + (define (try-http-get attempts) + (let ((status (let-values (((response text) + (http-get #$(simple-format + #f "http://localhost:~A/healthcheck" + forwarded-port)))) + (response-code response)))) + (if (or (= status 200) (<= attempts 1)) + status + (begin (sleep 10) (try-http-get (- attempts 1)))))) + (test-equal "http-get" 200 - (let-values - (((response text) - (http-get #$(simple-format - #f "http://localhost:~A/healthcheck" forwarded-port) - #:decode-body? #t))) - (response-code response))) + (try-http-get 10)) (test-end)))) -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 04:35:46 2022 Received: (at 56563) by debbugs.gnu.org; 15 Jul 2022 08:35:46 +0000 Received: from localhost ([127.0.0.1]:39340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCGna-00076a-BN for submit@debbugs.gnu.org; Fri, 15 Jul 2022 04:35:46 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:59049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCGnX-00076H-Re for 56563@debbugs.gnu.org; Fri, 15 Jul 2022 04:35:44 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4179D32009EA; Fri, 15 Jul 2022 04:35:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 15 Jul 2022 04:35:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= bonfacemunyoki.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1657874134; x= 1657960534; bh=jwuEq9BcRVzLjXvVar0rIAFBtYj0Pr8QAQQoEGioxn0=; b=n 8rN6vrlh37jYPEi4KWDwlxmYiIozMAxZ+ikyYjtRn04pAVhOXBQLJ8fCaO9lxHaD VbsDPWwaHPleHWP9Ryl83yWutGktJD6cyyX4638pEKJsmHeHn18NkSZlQrokhcAH 32I6K5mLRhQDUziWaQ+Dqes22jHgvuByw7249CyNxBLOy+9ZSo0QreJVf/9sSGbf j7fzUmme4kc3yq3/aR810mAdY1NDieRmMkvBBTaabUlNw9+PkN+2zdbyhgBmw1+M vIyLMH33HEMWuhtzDXUFbGdeewEn4NtgPTfpytxnJNMS9VcVJKQ4zfr5lPkjwwfo 7hFyIPPybczcXaVIFD62g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657874134; x=1657960534; bh=jwuEq9BcRVzLjXvVar0rIAFBtYj0 Pr8QAQQoEGioxn0=; b=Gx+4rDQXZ02aw0DZA2DK9/84GbrZp2eaYT/M4+Zb/Y0k +VOZg74GDRbdhZHyKPG/rluXViJ2xfWeYQJ3G/Xnp1RHh9M0eYBHWtZcimiGqVVO CmECJDwunv+qN7fWho5poAEmKVwtqEVPMw3NYxX4AZYq77QKEL7dttaA3sRYn8xX Us9BRbvFugm95aTnKex4ZwO2mn5SQOsQ8eYjiFhlrraw9GKu00Ln+IbzPUzlrZKK ZckRQBFPp3CawPPUpRxPrhop8elPLRGnNlaW+NOXMZNbx0Hr20/hv76i7qzWP9Qh fInWRMJklt1p96/9UTJWFY+f82XGm9W56igMrpErrA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekuddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehgtderredttdejnecuhfhrohhmpefouhhnhiho khhiucfmihhlhihunhhgihcuoehmvgessghonhhfrggtvghmuhhnhihokhhirdgtohhmqe enucggtffrrghtthgvrhhnpedvgfegffefleetiedtteeuiedtleevvdeiteejgfevjeei keekveetuefgjeehueenucffohhmrghinhepghhnuhhpghdrnhgvthenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmvgessghonhhfrggtvghm uhhnhihokhhirdgtohhm X-ME-Proxy: Feedback-ID: ib8a1471e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Jul 2022 04:35:33 -0400 (EDT) From: Munyoki Kilyungi To: Timotej Lazar Subject: Re: [bug#56563] [PATCH] gnu: tests: Fix guix-data-service test. In-Reply-To: <877d4eexcu.fsf@araneo.si> References: <20220714192137.23039-1-timotej.lazar@araneo.si> <86v8rze687.fsf@bonfacemunyoki.com> <877d4eexcu.fsf@araneo.si> Date: Fri, 15 Jul 2022 11:35:30 +0300 Message-ID: <868rou22p9.fsf@susa.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56563 Cc: 56563@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Timotej Lazar anaandika: > Munyoki Kilyungi [2022-07-15 00:26:16+0300]: >> Timotej Lazar anaandika: >>> + (define* (try-http-get attempts) >> >> Minor nitpick. This function definition does not >> take any optional or key-word arguments AFAICT, so >> it should be a "define" instead :) > > It used to but then I changed my mind. :) Nice catch, I=E2=80=99ll send an > update. Thanks! Cool \m/\m/. =2D-=20 (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJKBAEBCAA0FiEE1PCesRAXfgPCji/h9buuHgOSJT8FAmLRJtIWHG1lQGJvbmZh Y2VtdW55b2tpLmNvbQAKCRD1u64eA5IlPwN/D/42Rz5SbiFeOrd3/N/nT10miN48 tYBVBCHNYcWIe4c15jxCOIuRmT6zEoBY7e7PBLdahI5TcuyUi/0TOBNpicNYWm5m tq7IgCKUkjQauxC2M3bpyuluMns43BXX0J1un40+T6i9g5CDn8pLdpwg4dU3R0Q8 RyHmnYDzi24nDAaSiYszUqLl4dy+LKBhDsUPKQVtawRIvfRWlJ3wsUmMA7y6Hzz5 naktNdHhgmm4cgKEXvP7xXnRvraXEme+jGp35MJGsv7u6FK8N5vg9jaJnFGlF2Ob X4+l2JKmz25gvuBg/vilQNcEib6OzRxijrlkym0h4z60o9yXS1kyI9AkIP9IQ5l6 45fE0bWdgHst0korUgjj5ERmisGxdP04axCq+1oSJf8ntcKPp6UoWbpYOqElRgYI TmVw/MTslt22NyBuRlgiTEtkdSttn3nEuwZShWACOq5iWWj6yNdqjwfdaT97K/b2 VKxPFobKwf/UpDOhkPovzGMia5k0XBmhkOcgIpQ8dxakya8G7li7A7dIlPUUlK0r xtvCPYT7FmokK7tpQ+m/kRv4Mm3QU7UvOEbIyPNEZBmVN8dC9rm1Toh0Bbhnnpty PLPzLraWlBueRHOWgXe56JE2trgPRyduQZT5RyQMw0a91+4poJJlC//L75ka1sZR Puo+aGnEdGaXbtZy4g== =BVFq -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 15 05:07:44 2022 Received: (at 56563-done) by debbugs.gnu.org; 15 Jul 2022 09:07:44 +0000 Received: from localhost ([127.0.0.1]:39371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCHIW-0007yf-8F for submit@debbugs.gnu.org; Fri, 15 Jul 2022 05:07:44 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCHIU-0007yW-EZ for 56563-done@debbugs.gnu.org; Fri, 15 Jul 2022 05:07:42 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 8992C27BBE9; Fri, 15 Jul 2022 10:07:41 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id e6f5c150; Fri, 15 Jul 2022 09:07:41 +0000 (UTC) References: <20220714192137.23039-1-timotej.lazar@araneo.si> <20220715055604.4803-1-timotej.lazar@araneo.si> User-agent: mu4e 1.6.10; emacs 28.1 From: Christopher Baines To: Timotej Lazar Subject: Re: [bug#56563] [PATCH v2] gnu: tests: Fix guix-data-service test. Date: Fri, 15 Jul 2022 10:06:20 +0100 In-reply-to: <20220715055604.4803-1-timotej.lazar@araneo.si> Message-ID: <87y1wug2w5.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56563-done Cc: 56563-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Timotej Lazar writes: > Since revision 32, guix-data-service starts immediately but returns an HTTP > error code until initialization is complete. Adjust the test accordingly, and > remove the increased startup time limit. > > * gnu/services/guix.scm (guix-data-service): Use default #:pid-file-timeout. > * gnu/tests/guix.scm (guix-data-service): Retry the http-get test several > times to give the service time to initialize. > --- > gnu/services/guix.scm | 2 -- > gnu/tests/guix.scm | 19 +++++++++++++------ > 2 files changed, 13 insertions(+), 8 deletions(-) > Thanks Timotej, I've pushed this as a15b769c2f81034884ef0ae7fa8c1cea8df45c56. I've also updated the data service so that it responds with a 503 for the healthcheck when starting up, rather than a 500, as that's a bit nicer. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmLRLltfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdPbw/9HDnl6wkmN67NnYGgsWeSMwEXr2V1AQgV /7c8HAQ0G6eVs+nzaxystgOXcTApVdeEAgshSil4v2bnaqHezA8U4Nd9gL+hZYFO /DeNsuO0X3G9HOf7dJQzJlcb6thCSfssdPbm5lVnVZYfN7xPd7y2/RA9CndS38p3 RrDfcPZdwWLhRjxrosrRab+9cAZVN1ir5qR3fcmSBi9VhB1C4WxASa3SB7ak+d7N IiZhYqrpMNJL5c53Lel9Rtp8m9ykTZTRe4Tmz6E22LvgDO73lEWJL6qCnoNY/BSs t0702lvhvWeU8pMqNrFwb6z32ZY6dtftBLcPo9gFWMsOOrjiEbO5Ym+utnAzGWtO v7Yz5+MTuiBYaW2CiRhnITuxaBfPtqYpyu4oFvSfPLh8Hf5ICxZwOY933+RWpwrO 7pDUH0UlLGiMudJIZdF9q+wQ4ZPUBWWp0SJ4ofCTOhzxV9nyL9eQClsDsPJ2zeVS hPGS1FpG6yUf43wAhEJrsAmC3dY2qR+ZIsKdNSK24HPphZ2b1xXEszFWpo+MD047 jZYasYHiyNRwiyItD37S9e8VBjzpzihxkGg7L7/2yt6/zQTuQfWr8y/AX+LgAvTI ClbEUIU4jymgYLsQ+ZXL6VW8GkVP3fnL69vc2szrxjkRgr6kCbcpmdF74izBBKQ9 ll5Y/fxLjeM= =RAim -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 17 23:49:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 12 Aug 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator