GNU bug report logs - #56561
29.0.50; Infloop in try_window

Previous Next

Full log

Message #35 received at 56561 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: luangruo <at> yahoo.com
Cc: mwd <at> md5i.com, 56561 <at> debbugs.gnu.org
Subject: Re: bug#56561: 29.0.50; Infloop in try_window
Date: Fri, 15 Jul 2022 18:56:51 +0300

> Cc: mwd <at> md5i.com, 56561 <at> debbugs.gnu.org
> Date: Fri, 15 Jul 2022 18:37:50 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> On third thought, why do we even call try_window there?  The original
> code needed try_window because it then used the glyph matrix it
> produces to calculate the size of the tooltip.  But we've dumped that
> code, and we nowadays use window-text-pixel-size instead, which
> emulates the display internally anyway.  So I think we should simply
> delete the call to try_window from x-show-tip, and be done.  At least
> on master.

No, that's wrong: we call update_single_window there, and that
requires a window with a desired matrix set up correctly.  So yes, the
call to try_window is still needed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.