GNU bug report logs - #56561
29.0.50; Infloop in try_window

Previous Next

Full log

Message #113 received at 56561 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: mwd <at> md5i.com, 56561 <at> debbugs.gnu.org
Subject: Re: bug#56561: 29.0.50; Infloop in try_window
Date: Mon, 18 Jul 2022 15:37:22 +0300

> From: Po Lu <luangruo <at> yahoo.com>
> Cc: mwd <at> md5i.com,  56561 <at> debbugs.gnu.org
> Date: Mon, 18 Jul 2022 08:57:08 +0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks.  The patch below is what I had in mind.  WDYT?
> 
> It works fine (though we should make the change in all the *fns.[cm]
> files).

Sure, what I posted was only a proof of concept.

> But I don't see the strict requirement for this change:
> 
> >    DEFVAR_LISP ("x-max-tooltip-size", Vx_max_tooltip_size,
> >  	       doc: /* SKIP: real doc in xfns.c.  */);
> > -  Vx_max_tooltip_size = Fcons (make_fixnum (80), make_fixnum (40));
> > +  Vx_max_tooltip_size = Qnil;
> >  
> >    DEFVAR_LISP ("x-no-window-manager", Vx_no_window_manager,
> >  	       doc: /* SKIP: real doc in xfns.c.  */);

This makes it easier to distinguish between the default value and a
non-default value.  I also don't see any reason to have the default
both as a cons cell and as hard-coded values.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.