GNU bug report logs - #56557
[PATCH] k3b: Fix build

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Subject: bug#56557: closed (Re: bug#56557: [PATCH] k3b: Fix build)
Date: Mon, 18 Jul 2022 13:55:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56557: [PATCH] k3b: Fix build

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56557 <at> debbugs.gnu.org.

-- 
56557: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56557
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Thomas Danckaert <post <at> thomasdanckaert.be>
Cc: 56557-done <at> debbugs.gnu.org
Subject: Re: bug#56557: [PATCH] k3b: Fix build
Date: Mon, 18 Jul 2022 15:54:02 +0200

Hi Thomas,

Long time no see, welcome back!  :-)

Thomas Danckaert <post <at> thomasdanckaert.be> skribis:

>>From 7adc6413918b633c9879d08a8fce531d67416f85 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert <at> gmail.com>
> Date: Thu, 14 Jul 2022 14:21:17 +0200
> Subject: [PATCH 1/2] gnu: k3b: Fix build.
>
> * gnu/packages/kde-multimedia.scm (k3b)[phases]: Add phase fix-cmake-taglib in
> order to use correct Taglib include and library variables.

[...]

>>From 30b789b945a02e075d151a082bf30bf9fad3d006 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert <at> gmail.com>
> Date: Thu, 14 Jul 2022 14:44:23 +0200
> Subject: [PATCH 2/2] gnu: k3b: Add inputs bash-minimal and cdrtools.
>
> * gnu/packages/kde-multimedia.scm (k3b)[inputs]: Add
> bash-minimal (wrap-program is used), add cdrtools.

Applied both, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: guix-patches <at> gnu.org
Subject: [PATCH] k3b: Fix build
Date: Thu, 14 Jul 2022 16:08:34 +0200 (CEST)

[Message part 4 (text/plain, inline)]

Hi reviewers,

k3b doesn't build anymore on current master due to a mix-up of CMake 
variables.  This patch fixes that.

It's probably a temporary issue because latest versions of k3b have 
updated CMakeLists, but updating to a newer k3b also requires 
updating all KDE Frameworks to version 5.88.  So I hope we can 
include the present fix for now.

It's been a while, hope this patch satisfies the requirements :-)

Sincerely,

Thomas

[0001-gnu-k3b-Fix-build.patch (text/x-patch, inline)]

From 7adc6413918b633c9879d08a8fce531d67416f85 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert <at> gmail.com>
Date: Thu, 14 Jul 2022 14:21:17 +0200
Subject: [PATCH 1/2] gnu: k3b: Fix build.

* gnu/packages/kde-multimedia.scm (k3b)[phases]: Add phase fix-cmake-taglib in
order to use correct Taglib include and library variables.
---
 gnu/packages/kde-multimedia.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/kde-multimedia.scm b/gnu/packages/kde-multimedia.scm
index 752f6b499c..bdbf325f15 100644
--- a/gnu/packages/kde-multimedia.scm
+++ b/gnu/packages/kde-multimedia.scm
@@ -373,6 +373,16 @@ (define-public k3b
                  (("\"(dvdcss)\"" _ library)
                   (string-append "\"" libdvdcss "/lib/" library "\""))))
              #t))
+         (add-before 'configure 'fix-cmake-taglib
+           (lambda _
+             ;; Use the CMake variables provided by FindTaglib from
+             ;; extra-cmake-modules, instead of bundled FindTaglib.cmake:
+             (substitute*
+                 '("plugins/decoder/mp3/CMakeLists.txt"
+                   "plugins/decoder/flac/CMakeLists.txt"
+                   "plugins/project/audiometainforenamer/CMakeLists.txt")
+               (("TAGLIB_INCLUDES") "Taglib_INCLUDE_DIRS")
+               (("TAGLIB_LIBRARIES") "Taglib_LIBRARIES"))))
          (add-after 'qt-wrap 'wrap-path
            (lambda* (#:key inputs outputs #:allow-other-keys)
              ;; Set paths to backend programs.
-- 
2.36.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.