From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 10:13:54 2022 Received: (at submit) by debbugs.gnu.org; 14 Jul 2022 14:13:54 +0000 Received: from localhost ([127.0.0.1]:38531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBzbG-00038S-AV for submit@debbugs.gnu.org; Thu, 14 Jul 2022 10:13:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:39912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBzbE-00038K-Dl for submit@debbugs.gnu.org; Thu, 14 Jul 2022 10:13:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oBzbC-0005jz-EU for guix-patches@gnu.org; Thu, 14 Jul 2022 10:13:51 -0400 Received: from mail-108-mta61.mxroute.com ([136.175.108.61]:40319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oBzb7-0003Zz-LN for guix-patches@gnu.org; Thu, 14 Jul 2022 10:13:48 -0400 Received: from filter006.mxroute.com ([140.82.40.27] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta61.mxroute.com (ZoneMTA) with ESMTPSA id 181fd0a41c10000261.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 14 Jul 2022 14:08:36 +0000 X-Zone-Loop: 0cc479e1a0a561501a8e1ed12cf03558b3be5f638326 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thomasdanckaert.be; s=x; h=Content-Transfer-Encoding:Content-Type: Mime-Version:From:Subject:To:Message-Id:Date:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ohMTDcP5sdvj61OyZA2gtbA12X1h8l2B9CiKFelpIVM=; b=i08Av1U28TDEPFKTfulY59DVdp kS0aWOSJR3dtOxfOyDZbC1GwocImsgNljMMzwBkjaZg0OoQ6POws/rjhDtMZw85Kjz+0SmSmG/tOH iOx8qd1rw5RKG4xWWdNBd+p8BnzpLPpT4TrExrr1ovDDaXJoXuz3p9JpZvNH3hwsiP47u9kECCfsh C/K+luz03c/ET1mcHanukOucXSSpVB/gY2vl39p9xng/RolxamHT8n/BBBycViIS4qAUubzBiwlan DbLCTiC0nxIbSB70ezEaGkvOYy19ryk+Re1sL2964lxCLYnz7UJ+sFLK6TMZMKkMU5i6kK48VHJzZ oD1PpnsA==; Date: Thu, 14 Jul 2022 16:08:34 +0200 (CEST) Message-Id: <20220714.160834.663497267256384758.post@thomasdanckaert.be> To: guix-patches@gnu.org Subject: [PATCH] k3b: Fix build From: Thomas Danckaert Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Thu_Jul_14_16_08_34_2022_941)--" Content-Transfer-Encoding: 7bit X-AuthUser: post@thomasdanckaert.be Received-SPF: pass client-ip=136.175.108.61; envelope-from=post@thomasdanckaert.be; helo=mail-108-mta61.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) ----Next_Part(Thu_Jul_14_16_08_34_2022_941)-- Content-Type: Text/Plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Hi reviewers, k3b doesn't build anymore on current master due to a mix-up of CMake variables. This patch fixes that. It's probably a temporary issue because latest versions of k3b have updated CMakeLists, but updating to a newer k3b also requires updating all KDE Frameworks to version 5.88. So I hope we can include the present fix for now. It's been a while, hope this patch satisfies the requirements :-) Sincerely, Thomas ----Next_Part(Thu_Jul_14_16_08_34_2022_941)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-gnu-k3b-Fix-build.patch" >From 7adc6413918b633c9879d08a8fce531d67416f85 Mon Sep 17 00:00:00 2001 From: Thomas Danckaert Date: Thu, 14 Jul 2022 14:21:17 +0200 Subject: [PATCH 1/2] gnu: k3b: Fix build. * gnu/packages/kde-multimedia.scm (k3b)[phases]: Add phase fix-cmake-taglib in order to use correct Taglib include and library variables. --- gnu/packages/kde-multimedia.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/kde-multimedia.scm b/gnu/packages/kde-multimedia.scm index 752f6b499c..bdbf325f15 100644 --- a/gnu/packages/kde-multimedia.scm +++ b/gnu/packages/kde-multimedia.scm @@ -373,6 +373,16 @@ (define-public k3b (("\"(dvdcss)\"" _ library) (string-append "\"" libdvdcss "/lib/" library "\"")))) #t)) + (add-before 'configure 'fix-cmake-taglib + (lambda _ + ;; Use the CMake variables provided by FindTaglib from + ;; extra-cmake-modules, instead of bundled FindTaglib.cmake: + (substitute* + '("plugins/decoder/mp3/CMakeLists.txt" + "plugins/decoder/flac/CMakeLists.txt" + "plugins/project/audiometainforenamer/CMakeLists.txt") + (("TAGLIB_INCLUDES") "Taglib_INCLUDE_DIRS") + (("TAGLIB_LIBRARIES") "Taglib_LIBRARIES")))) (add-after 'qt-wrap 'wrap-path (lambda* (#:key inputs outputs #:allow-other-keys) ;; Set paths to backend programs. -- 2.36.1 ----Next_Part(Thu_Jul_14_16_08_34_2022_941)---- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 10:19:41 2022 Received: (at 56557) by debbugs.gnu.org; 14 Jul 2022 14:19:41 +0000 Received: from localhost ([127.0.0.1]:38545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBzgq-0003Im-Rj for submit@debbugs.gnu.org; Thu, 14 Jul 2022 10:19:41 -0400 Received: from mail-108-mta192.mxroute.com ([136.175.108.192]:34229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oBzgp-0003IW-AA for 56557@debbugs.gnu.org; Thu, 14 Jul 2022 10:19:40 -0400 Received: from filter006.mxroute.com ([140.82.40.27] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta192.mxroute.com (ZoneMTA) with ESMTPSA id 181fd143b7b0000261.001 for <56557@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 14 Jul 2022 14:19:30 +0000 X-Zone-Loop: 3ef7ac3331e1720c0eda6bfb5f843306e5d5067e8407 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thomasdanckaert.be; s=x; h=Content-Transfer-Encoding:Content-Type: Mime-Version:From:Subject:To:Message-Id:Date:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TURAluiv7ru4WKB0yYmQdtVWeTFFuqEYGnc5ZSwU9GM=; b=JYxUJaCPyCeHlnksLWTtScLU3Q nfByInUYDSG4LE1NLTKvdK0xyxl/hyfA2+/en4guMN0Y4QG2hguF8ULHXb8EeAwF4t++9XRcL2si7 hchWXT6/feUIE9jWBhX0YIIOu5kAR6NtqMoGNzsjSmQHqoJjHTKKep5ZFddDSdxT0n0PmKu08SLm8 BRVzQRftthjm168nZmgs/qP42g72cuVl2b6vDUaiTjPjNab6wCQONHf1snMmtgT389VL37HQJDV9L ZK3EDTJLuoy6a61sqmef/yEMdKcyPeD+PxVNQBnWxrcJjv+jf+igPqxJlm0VPEQlklxzZOna8hzEx clhTBgGw==; Date: Thu, 14 Jul 2022 16:19:25 +0200 (CEST) Message-Id: <20220714.161925.1632085644911299362.post@thomasdanckaert.be> To: 56557@debbugs.gnu.org Subject: [PATCH] gnu: k3b: Add inputs bash-minimal and cdrtools. From: Thomas Danckaert Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Thu_Jul_14_16_19_25_2022_076)--" Content-Transfer-Encoding: 7bit X-AuthUser: post@thomasdanckaert.be X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56557 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ----Next_Part(Thu_Jul_14_16_19_25_2022_076)-- Content-Type: Text/Plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Small improvement as a follow-up. guix lint complained about the missing bash-minimal. Thomas ----Next_Part(Thu_Jul_14_16_19_25_2022_076)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0002-gnu-k3b-Add-inputs-bash-minimal-and-cdrtools.patch" >From 30b789b945a02e075d151a082bf30bf9fad3d006 Mon Sep 17 00:00:00 2001 From: Thomas Danckaert Date: Thu, 14 Jul 2022 14:44:23 +0200 Subject: [PATCH 2/2] gnu: k3b: Add inputs bash-minimal and cdrtools. * gnu/packages/kde-multimedia.scm (k3b)[inputs]: Add bash-minimal (wrap-program is used), add cdrtools. --- gnu/packages/kde-multimedia.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gnu/packages/kde-multimedia.scm b/gnu/packages/kde-multimedia.scm index bdbf325f15..265dcef625 100644 --- a/gnu/packages/kde-multimedia.scm +++ b/gnu/packages/kde-multimedia.scm @@ -29,6 +29,7 @@ (define-module (gnu packages kde-multimedia) #:use-module (guix gexp) #:use-module (gnu packages) #:use-module (gnu packages audio) + #:use-module (gnu packages bash) #:use-module (gnu packages compression) #:use-module (gnu packages cdrom) #:use-module (gnu packages docbook) @@ -390,12 +391,14 @@ (define-public k3b `("PATH" ":" prefix ,(map (lambda (input) (string-append (assoc-ref inputs input) "/bin")) - '("cdrdao" "dvd+rw-tools" "libburn" "sox")))) + '("cdrdao" "cdrtools" "dvd+rw-tools" "libburn" "sox")))) #t))))) (native-inputs (list extra-cmake-modules pkg-config kdoctools)) (inputs - (list cdrdao + (list bash-minimal + cdrdao + cdrtools dvd+rw-tools ffmpeg flac -- 2.36.1 ----Next_Part(Thu_Jul_14_16_19_25_2022_076)---- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 18 09:54:21 2022 Received: (at 56557-done) by debbugs.gnu.org; 18 Jul 2022 13:54:21 +0000 Received: from localhost ([127.0.0.1]:49584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDRCX-0005oT-GM for submit@debbugs.gnu.org; Mon, 18 Jul 2022 09:54:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDRCS-0005oA-1f for 56557-done@debbugs.gnu.org; Mon, 18 Jul 2022 09:54:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDRCK-0002Tg-Kz; Mon, 18 Jul 2022 09:54:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AAoLGBXxeTqYBomAurnhJfyp5MJ0RySxxl2OUYuuS4U=; b=qvRAwDetwr32/3kYSMEy v2CNWlvCGjjGsEZ7s66zuCc6fKxJyfm+hLSESlt5SZtB7y+/8MDA72YdyfefJesj99GEQSfqXA8jV r2wqNYkhCkoSQbKs0vh9IPi7c4eDGInYVSqrPe8jQq+qbCOSY25Djpj4u1uGEJgGqHo6ToCnuPH48 9wzQsTxoQ+uGkbdhuX5UNt5jFhTDgoxtMlb6VVvTjU1UI1/2LQRs6ApVj7Tul39u57f3/tezzAEp+ kfF+UnC9QeZ1nJP5zyom2+iDwKO7U4bIil53sCu+8ku0E+fzbmTvTa9kt9kgBh6DwJg2H7syw52oC cHm36Yjxe8+sjQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41548 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDRCG-0006XD-SF; Mon, 18 Jul 2022 09:54:06 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Thomas Danckaert Subject: Re: bug#56557: [PATCH] k3b: Fix build References: <20220714.160834.663497267256384758.post@thomasdanckaert.be> Date: Mon, 18 Jul 2022 15:54:02 +0200 In-Reply-To: <20220714.160834.663497267256384758.post@thomasdanckaert.be> (Thomas Danckaert's message of "Thu, 14 Jul 2022 16:08:34 +0200 (CEST)") Message-ID: <87tu7ey1ad.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56557-done Cc: 56557-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Thomas, Long time no see, welcome back! :-) Thomas Danckaert skribis: >>>From 7adc6413918b633c9879d08a8fce531d67416f85 Mon Sep 17 00:00:00 2001 > From: Thomas Danckaert > Date: Thu, 14 Jul 2022 14:21:17 +0200 > Subject: [PATCH 1/2] gnu: k3b: Fix build. > > * gnu/packages/kde-multimedia.scm (k3b)[phases]: Add phase fix-cmake-tagl= ib in > order to use correct Taglib include and library variables. [...] >>>From 30b789b945a02e075d151a082bf30bf9fad3d006 Mon Sep 17 00:00:00 2001 > From: Thomas Danckaert > Date: Thu, 14 Jul 2022 14:44:23 +0200 > Subject: [PATCH 2/2] gnu: k3b: Add inputs bash-minimal and cdrtools. > > * gnu/packages/kde-multimedia.scm (k3b)[inputs]: Add > bash-minimal (wrap-program is used), add cdrtools. Applied both, thanks! Ludo=E2=80=99. From unknown Sun Jun 22 11:49:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 16 Aug 2022 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator