GNU bug report logs - #56554
[PATCH] * lisp/image.el (put-image): Fix typo.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56554 in the body.
You can then email your comments to 56554 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] * lisp/image.el (put-image): Fix typo.
Date: Thu, 14 Jul 2022 19:39:15 +0530

[Message part 1 (text/plain, inline)]

Tags: patch

This fixes a typo in put-image.

BTW, even with this patch applied, I still can't access the keys in
image-map: I think it is because one cannot place the point on the
image?  Is this intended?  If yes, can we change mm-inline-image to use
insert-image instead (it currently uses put-image)?  Thanks.

In GNU Emacs 29.0.50 (build 11, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2022-07-14 built on astatine
Repository revision: d37ba6f259b972aa44c66ecb76210e03a3084183
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-sound=alsa --with-x-toolkit=lucid --with-json
 --without-xaw3d --without-gconf --without-libsystemd --without-cairo'

[0001-lisp-image.el-put-image-Fix-typo.patch (text/patch, attachment)]

Message #8 received at 56554 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 56554 <at> debbugs.gnu.org
Subject: Re: bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo.
Date: Thu, 14 Jul 2022 19:34:29 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> This fixes a typo in put-image.

Thanks; pushed to Emacs 29.

> BTW, even with this patch applied, I still can't access the keys in
> image-map: I think it is because one cannot place the point on the
> image?  Is this intended?  If yes, can we change mm-inline-image to use
> insert-image instead (it currently uses put-image)?  Thanks.

Yup; makes sense.  I'll get fixing...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 56554 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 56554 <at> debbugs.gnu.org
Subject: Re: bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo.
Date: Thu, 14 Jul 2022 19:40:22 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> BTW, even with this patch applied, I still can't access the keys in
>> image-map: I think it is because one cannot place the point on the
>> image?  Is this intended?  If yes, can we change mm-inline-image to use
>> insert-image instead (it currently uses put-image)?  Thanks.
>
> Yup; makes sense.  I'll get fixing...

Now done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 56554 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56554 <at> debbugs.gnu.org
Subject: Re: bug#56554: [PATCH] * lisp/image.el (put-image): Fix typo.
Date: Thu, 14 Jul 2022 23:13:33 +0530

[வியாழன் ஜூலை 14, 2022] Lars Ingebrigtsen wrote:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>>> BTW, even with this patch applied, I still can't access the keys in
>>> image-map: I think it is because one cannot place the point on the
>>> image?  Is this intended?  If yes, can we change mm-inline-image to use
>>> insert-image instead (it currently uses put-image)?  Thanks.
>>
>> Yup; makes sense.  I'll get fixing...
>
> Now done.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.