Subject: bug#56541: closed (Re: bug#56541: [PATCH] system: Add -I, --list-installed option.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 18 Jul 2022 13:32:01 +0000

Your bug report

#56541: [PATCH] system: Add -I, --list-installed option.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
56541: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56541
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#56541: [PATCH] system: Add -I, --list-installed option.
From: Ludovic Courtès <[email-masked]>
To: Antero Mejr <[email-masked]>
Cc: [email-masked]
Date: Mon, 18 Jul 2022 15:31:37 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Antero Mejr <[email-masked]> skribis:

> * guix/scripts/system.scm: New flag -I, --list-installed.
> * doc/guix.texi (Invoking Guix System): Add information for
> --list-installed flag.

Applied with the same kind of cosmetic changes as for ‘guix home’.

Thanks,
Ludo’.

Subject: [PATCH] system: Add -I, --list-installed option.
From: Antero Mejr <[email-masked]>
To: [email-masked]
Date: Wed, 13 Jul 2022 15:01:22 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* guix/scripts/system.scm: New flag -I, --list-installed.
* doc/guix.texi (Invoking Guix System): Add information for
--list-installed flag.
---
Depends on patch 56238:
https://issues.guix.gnu.org/56428

 doc/guix.texi           | 12 ++++++++
 guix/scripts/system.scm | 61 +++++++++++++++++++++++++++++------------
 2 files changed, 55 insertions(+), 18 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index fc3a2d962d..3f3b480f4e 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -37647,6 +37647,13 @@ bootloader boot menu:
 Describe the running system generation: its file name, the kernel and
 bootloader used, etc., as well as provenance information when available.
 
+The @code{--list-installed} flag is available, with the same
+syntax that is used in @command{guix package --list-installed}
+(@pxref{Invoking guix package}).  When the flag is used,
+the description will include a list of packages that are currently
+installed in the system profile, with optional filtering based on a
+regular expression.
+
 @quotation Note
 The @emph{running} system generation---referred to by
 @file{/run/current-system}---is not necessarily the @emph{current}
@@ -37674,6 +37681,11 @@ generations that are up to 10 days old:
 $ guix system list-generations 10d
 @end example
 
+The @code{--list-installed} flag may also be specified, with the same
+syntax that is used in @command{guix package --list-installed}.  This
+may be helpful if trying to determine when a package was added to the
+system.
+
 @end table
 
 The @command{guix system} command has even more to offer!  The following
diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
index b9084a401c..91a0a5302b 100644
--- a/guix/scripts/system.scm
+++ b/guix/scripts/system.scm
@@ -50,7 +50,8 @@ (define-module (guix scripts system)
   #:use-module (guix channels)
   #:use-module (guix scripts build)
   #:autoload   (guix scripts package) (delete-generations
-                                       delete-matching-generations)
+                                       delete-matching-generations
+                                       list-installed)
   #:autoload   (guix scripts pull) (channel-commit-hyperlink)
   #:autoload   (guix graph) (export-graph node-type
                              graph-backend-name lookup-backend)
@@ -480,7 +481,8 @@ (define (shepherd-service-node-type services)
 ;;;
 
 (define* (display-system-generation number
-                                    #:optional (profile %system-profile))
+                                    #:optional (profile %system-profile)
+                                    #:key (list-installed-regex #f))
   "Display a summary of system generation NUMBER in a human-readable format."
   (define (display-channel channel)
     (format #t     "    ~a:~%" (channel-name channel))
@@ -544,23 +546,34 @@ (define-values (channels config-file)
         (format #t (G_ "  configuration file: ~a~%")
                 (if (supports-hyperlinks?)
                     (file-hyperlink config-file)
-                    config-file))))))
-
-(define* (list-generations pattern #:optional (profile %system-profile))
+                    config-file)))
+      (when list-installed-regex
+        (format #t (G_ "  packages:\n"))
+        (pretty-print-table (list-installed
+                             list-installed-regex
+                             (list (string-append generation "/profile")))
+                            #:left-pad 4)))))
+
+(define* (list-generations pattern #:optional (profile %system-profile)
+                           #:key (list-installed-regex #f))
   "Display in a human-readable format all the system generations matching
 PATTERN, a string.  When PATTERN is #f, display all the system generations."
   (cond ((not (file-exists? profile))             ; XXX: race condition
          (raise (condition (&profile-not-found-error
                             (profile profile)))))
         ((not pattern)
-         (for-each display-system-generation (profile-generations profile)))
+         (for-each (cut display-system-generation <>
+                        #:list-installed-regex list-installed-regex)
+                   (profile-generations profile)))
         ((matching-generations pattern profile)
          =>
          (lambda (numbers)
            (if (null-list? numbers)
                (exit 1)
                (leave-on-EPIPE
-                (for-each display-system-generation numbers)))))))
+                (for-each (cut display-system-generation <>
+                               #:list-installed-regex list-installed-regex)
+                          numbers)))))))
 
 
 ;;;
@@ -1032,6 +1045,11 @@ (define (show-help)
                          use BACKEND for 'extension-graphs' and 'shepherd-graph'"))
   (newline)
   (display (G_ "
+  -I, --list-installed[=REGEXP]
+                         for 'describe' and 'list-generations', list installed
+                         packages matching REGEXP"))
+  (newline)
+  (display (G_ "
   -h, --help             display this help and exit"))
   (display (G_ "
   -V, --version          display version information and exit"))
@@ -1135,6 +1153,9 @@ (define %options
          (option '("graph-backend") #t #f
                  (lambda (opt name arg result)
                    (alist-cons 'graph-backend arg result)))
+         (option '(#\I "list-installed") #f #t
+                 (lambda (opt name arg result)
+                   (alist-cons 'list-installed (or arg "") result)))
          %standard-build-options))
 
 (define %default-options
@@ -1322,25 +1343,29 @@ (define-syntax-rule (with-store* store exp ...)
     ;; The following commands do not need to use the store, and they do not need
     ;; an operating system configuration file.
     ((list-generations)
-     (let ((pattern (match args
+     (let ((list-installed-regex (assoc-ref opts 'list-installed))
+           (pattern (match args
                       (() #f)
                       ((pattern) pattern)
                       (x (leave (G_ "wrong number of arguments~%"))))))
-       (list-generations pattern)))
+       (list-generations pattern #:list-installed-regex list-installed-regex)))
     ((describe)
      ;; Describe the running system, which is not necessarily the current
      ;; generation.  /run/current-system might point to
      ;; /var/guix/profiles/system-N-link, or it might point directly to
      ;; /gnu/store/…-system.  Try both.
-     (match (generation-number "/run/current-system" %system-profile)
-       (0
-        (match (generation-number %system-profile)
-          (0
-           (leave (G_ "no system generation, nothing to describe~%")))
-          (generation
-           (display-system-generation generation))))
-       (generation
-        (display-system-generation generation))))
+     (let ((list-installed-regex (assoc-ref opts 'list-installed)))
+       (match (generation-number "/run/current-system" %system-profile)
+         (0
+          (match (generation-number %system-profile)
+            (0
+             (leave (G_ "no system generation, nothing to describe~%")))
+            (generation
+             (display-system-generation
+              generation #:list-installed-regex list-installed-regex))))
+         (generation
+          (display-system-generation
+           generation #:list-installed-regex list-installed-regex)))))
     ((search)
      (apply (resolve-subcommand "search") args))
     ((edit)
-- 
2.36.1