GNU bug report logs - #56538
29.0.50; [PATCH] Colored highlight in Lucid backend

Previous Next

Full log

View this message in rfc822 format

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 56538 <at> debbugs.gnu.org
Subject: bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend
Date: Thu, 14 Jul 2022 15:17:54 +0200

[Message part 1 (text/plain, inline)]

Po Lu <luangruo <at> yahoo.com> writes:

[...]

> We have the same general pattern (random_gc = random_opposite_gc) in
> most of the X code, so it is redundant IMHO.  But I won't insist.

Ok.  I can remove this comment then.

[...]

> Yes, that isn't expected to work, because Cairo is broken.  Also, you
> can't build Emacs with both Xft and Cairo, since they're mutually
> exclusive.

😅 sorry. So then "Xft + cairo" is just "cairo".

> Could you please describe how the colors are "not quite right"?

Here is how it look here™ on a PseudoColor Xephyr.  This is Cairo with a
bitmap font:

[sshot-pseudo-cairo.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

This Xft with the same font:

[sshot-pseudo-xft.png (image/png, inline)]

[Message part 5 (text/plain, inline)]

And for the record, here are the same with a vector font:

[sshot-pseudo-cairo-vector.png (image/png, inline)]

[sshot-pseudo-xft-vector.png (image/png, inline)]

[Message part 8 (text/plain, inline)]

[...]

> Here and elsewhere new functions are added, the argument list should be
> reformatted to not place each argument on its own line.

FWIW, draw_shadow_rectangle, draw_shadow_rhombus… are already like that.

I'll do it but what are your recommandations?  Split at fill-colum +
indent?  Leave the old ones untouched?
-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.