GNU bug report logs - #56538
29.0.50; [PATCH] Colored highlight in Lucid backend

Previous Next

Full log

Message #11 received at 56538 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 56538 <at> debbugs.gnu.org
Subject: Re: bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend
Date: Thu, 14 Jul 2022 11:42:06 +0200

[Message part 1 (text/plain, inline)]

Po Lu <luangruo <at> yahoo.com> writes:

Hi Po and thanks for your comments,

[...]

>> +      /* XXX the following permutation is on purpose */
>
> This comment seems redundant.

I have attached a new version of my patch taking your remarks into
account but I did not remove this comment.  I think it could be useful
to understand that "top_gc = something_bottom_gc" is not a typo here.

I have also done the following testing with Xft/cairo/PseudoColor
combinations:

|-------------+-----------------+-----------------+-----------------+---------------------|
|             | Xft + cairo     | Xft only        | cairo only      | None                |
|-------------+-----------------+-----------------+-----------------+---------------------|
| X Truecolor | ok              | ok              | ok              | ok but with a       |
|             |                 |                 |                 | default tiny face   |
|-------------+-----------------+-----------------+-----------------+---------------------|
| Xephyr      | ok but color    | ok but color    | ok but color    | ok, colors ok, but  |
| Pseudocolor | not quite right | not quite right | not quite right | with a default tiny |
|             | around each     | around menu     | around each     | face [fn:2]         |
|             | glyph [fn:1]    | labels [fn:2]   | glyph [fn:1]    |                     |
|-------------+-----------------+-----------------+-----------------+---------------------|

* Footnotes
[fn:1] Aside from the Lucid widget, the emacs buffer is completly
blank.

[fn:2] This time the emacs buffer is here. tool-bar icons are ugly.

[0001-Colored-menu-highlight-in-Lucid-backend.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.