Subject: Re: bug#56538: 29.0.50; [PATCH] Colored highlight in Lucid backend

From: Po Lu <[email-masked]>
Date: Fri, 15 Jul 2022 20:58:46 +0800

Manuel Giraud <[email-masked]> writes:

> Here is a new version of this patch.  What's new:
>
>      - fix some comments
>      
>      - format arguments list on both new functions and the one I have
>        modified their arguments
>        
>      - add some forgot freeing in `release_shadow_gcs'

Thanks.  One (late) last comment on the documentation:

> +@item highlightForeground
> +Foreground color for a highlighted menu item.
> +@item highlightBackground
> +Background color for a highlighted menu item.

Shouldn't this say "the menu item highlighted by the mouse"?  Otherwise,
what "highlighted" means is not exactly clear.

> +** New X resources: "highlightForeground" and "highlightBackground"
> +Only in the Lucid build, this controls colors used for highlighted
> +menu item widget.

And here, shouldn't "widget" be in plural?