GNU bug report logs - #56491
[PATCH] Don't create file rmail-loaddefs.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56491 in the body.
You can then email your comments to 56491 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Don't create file rmail-loaddefs.el
Date: Sun, 10 Jul 2022 17:28:58 -0700

[Message part 1 (text/plain, inline)]

Severity: wishlist

It seems like the rmail-loaddefs.el file is not really used for
anything?  Maybe we could just remove it, as in the attached.

[0001-Don-t-create-unused-file-rmail-loaddefs.el.patch (text/x-diff, attachment)]

Message #8 received at 56491 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56491 <at> debbugs.gnu.org
Subject: Re: bug#56491: [PATCH] Don't create file rmail-loaddefs.el
Date: Mon, 11 Jul 2022 11:59:37 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> It seems like the rmail-loaddefs.el file is not really used for
> anything?  Maybe we could just remove it, as in the attached.

The two commands in rmail-loaddefs.el/undigest.el are only used from
rmail buffers, I guess?  But just removing the autoload cookies would be
wrong (because then people can't say `M-x unforward-rmail-message') --
perhaps rmail.el should autoload the two commands.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 56491 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56491 <at> debbugs.gnu.org
Subject: Re: bug#56491: [PATCH] Don't create file rmail-loaddefs.el
Date: Mon, 11 Jul 2022 04:37:38 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> The two commands in rmail-loaddefs.el/undigest.el are only used from
> rmail buffers, I guess?  But just removing the autoload cookies would be
> wrong (because then people can't say `M-x unforward-rmail-message') --
> perhaps rmail.el should autoload the two commands.

This file is not required from anywhere, so I don't see what changes if
we remove the autoload cookies.  What am I missing?

Message #14 received at 56491 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56491 <at> debbugs.gnu.org
Subject: Re: bug#56491: [PATCH] Don't create file rmail-loaddefs.el
Date: Mon, 11 Jul 2022 13:40:52 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> This file is not required from anywhere, so I don't see what changes if
> we remove the autoload cookies.  What am I missing?

Oh, I missed that.  Then I guess this is just a file that was missed
when the rest of the rmail-loaddefs things were removed -- so the
correct fix here is to just remove

;; Local Variables:
;; generated-autoload-file: "rmail-loaddefs.el"
;; End:

but leave the ;;;###autoload cookies as is.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 56491-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56491-done <at> debbugs.gnu.org
Subject: Re: bug#56491: [PATCH] Don't create file rmail-loaddefs.el
Date: Mon, 11 Jul 2022 05:10:00 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> the correct fix here is to just remove
>
> ;; Local Variables:
> ;; generated-autoload-file: "rmail-loaddefs.el"
> ;; End:
>
> but leave the ;;;###autoload cookies as is.

OK, makes sense.  Now done on master (commit d9732425a6).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.