From unknown Tue Jun 24 13:53:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56479 <56479@debbugs.gnu.org> To: bug#56479 <56479@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] simple fix on xlwmenu Reply-To: bug#56479 <56479@debbugs.gnu.org> Date: Tue, 24 Jun 2025 20:53:03 +0000 retitle 56479 29.0.50; [PATCH] simple fix on xlwmenu reassign 56479 emacs submitter 56479 Manuel Giraud severity 56479 wishlist tag 56479 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 04:41:33 2022 Received: (at submit) by debbugs.gnu.org; 10 Jul 2022 08:41:33 +0000 Received: from localhost ([127.0.0.1]:36241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oASVR-0002XL-5N for submit@debbugs.gnu.org; Sun, 10 Jul 2022 04:41:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:48404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oASVP-0002XC-A5 for submit@debbugs.gnu.org; Sun, 10 Jul 2022 04:41:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oASVO-0000RH-GN for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 04:41:31 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:38098) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oASVK-0008W9-UQ for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 04:41:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=iKrHhGlu0tioRUD0 zDVqkI4gxahV3u9Q2r2RkRWULw8=; h=date:subject:to:from; d=ledu-giraud.fr; b=ERa5xF9blIG1spRaNjIvvFk6Qfbyx4oESGE6KPC61MBkdlQgf3 lndnO8fzA6lud77/6DNWnarqxWyL1oDPfodZ8U1+dvDyaazIMwkvkgmz1+yybIHa/DLd3/ TBVpVaS05Dyeran+8Pnd7SN4/dMU5YGPhQWR9/BCyfpNJTmvQp6wIyvvajRQykfemyjSAp gx+TjQA/h/R2D8GD5bsLHAzQFIBN62ZV2tvMNNDX7kfHRU07uz1GUM8bkJ88Eg962WQe+h EcCVc9A1xJg2wqqBmxSr8XawVrZQD8qiaVooR+TJiyOfav3IzCa+HK9FjDFdJV35wLo6V8 w26yWDsgd/eQ== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id e556a552 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 10 Jul 2022 10:41:23 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 29.0.50; [PATCH] simple fix on xlwmenu Date: Sun, 10 Jul 2022 10:41:21 +0200 Message-ID: <87sfn9uzpq.fsf@elite.giraud> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi, I was working on patch for xlwmenu and found this. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lwlib-xlwmenu.c-make_shadow_gcs-Remove-a-a-pattern.patch >From 11b5ee379e17a205ccb509079fe5b605b7c089b3 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Fri, 8 Jul 2022 14:15:49 +0200 Subject: [PATCH] ; * lwlib/xlwmenu.c (make_shadow_gcs): Remove "a = a" pattern. --- lwlib/xlwmenu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lwlib/xlwmenu.c b/lwlib/xlwmenu.c index eba85631bd..68f49e646d 100644 --- a/lwlib/xlwmenu.c +++ b/lwlib/xlwmenu.c @@ -1753,13 +1753,9 @@ make_shadow_gcs (XlwMenuWidget mw) if (mw->menu.top_shadow_color == -1) mw->menu.top_shadow_color = mw->core.background_pixel; - else - mw->menu.top_shadow_color = mw->menu.top_shadow_color; if (mw->menu.bottom_shadow_color == -1) mw->menu.bottom_shadow_color = mw->menu.foreground; - else - mw->menu.bottom_shadow_color = mw->menu.bottom_shadow_color; if (mw->menu.top_shadow_color == mw->core.background_pixel || mw->menu.top_shadow_color == mw->menu.foreground) -- 2.36.1 --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 1, x86_64-unknown-openbsd7.1, X toolkit, cairo version 1.17.6, Xaw scroll bars) of 2022-07-10 built on elite.giraud Repository revision: 11b5ee379e17a205ccb509079fe5b605b7c089b3 Repository branch: mgi/ui Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: OpenBSD elite.giraud 7.1 GENERIC.MP#579 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=athena --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: gnus-dired-mode: t global-git-commit-mode: t magit-auto-revert-mode: t icomplete-mode: t display-time-mode: t shell-dirtrack-mode: t global-so-long-mode: t repeat-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/transient-20220527.2213/transient hides /home/manuel/emacs/share/emacs/29.0.50/lisp/transient Features: (shadow sort mail-extr emacsbug vc-git vc-dispatcher vc-svn whitespace gnus-dired magit-patch face-remap magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode git-commit log-edit pcvs-util add-log magit-core magit-autorevert autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section dash compat-27 compat-26 compat paredit edmacro icomplete time battery exwm-randr xcb-randr exwm-config exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server stimmung-themes modus-operandi-theme modus-themes osm bookmark mingus libmpdee transmission diary-lib diary-loaddefs color calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load mu4e mu4e-org mu4e-main mu4e-view mu4e-view-gnus mu4e-view-common mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions ido rfc2368 smtpmail mu4e-mark mu4e-proc mu4e-utils doc-view filenotify jka-compr image-mode exif mu4e-lists mu4e-message flow-fill mule-util hl-line mu4e-vars mu4e-meta supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file url-dired svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt cl-extra help-mode speedbar ezimage dframe eieio-base pcase timezone org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol rx org-keys oc org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs visual-basic-mode cl web-mode disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp tramp-loaddefs trampver tramp-integration cus-edit cus-load wid-edit files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp format-spec slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline pp comint ansi-color ring hyperspec thingatpt slime-autoloads dired-aux dired-x dired dired-loaddefs so-long notifications dbus xml repeat easy-mmode tex-site hyperbole-autoloads magit-autoloads git-commit-autoloads magit-section-autoloads dash-autoloads rust-mode-autoloads stimmung-themes-autoloads with-editor-autoloads info compat-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 548790 40292) (symbols 48 54597 4) (strings 32 169093 9002) (string-bytes 1 5652960) (vectors 16 97410) (vector-slots 8 1267584 34078) (floats 8 516 279) (intervals 56 768 126) (buffers 992 14)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 06:25:56 2022 Received: (at 56479) by debbugs.gnu.org; 10 Jul 2022 10:25:56 +0000 Received: from localhost ([127.0.0.1]:36273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAU8S-0005M4-H9 for submit@debbugs.gnu.org; Sun, 10 Jul 2022 06:25:56 -0400 Received: from sonic314-20.consmr.mail.ne1.yahoo.com ([66.163.189.146]:41262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAU8P-0005Lp-OU for 56479@debbugs.gnu.org; Sun, 10 Jul 2022 06:25:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657448747; bh=4DweXRErdPYYBgpWC1euowW/y5Fd5Aw0I6UckSF1XOI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=FmxVHzr1H+FGCxWfj/RBqcYvju3/XPu1wYfAySxEeKVu3CBWwV6uA2fxqYAHY6inwi2ARKjJmEhN8jAHqyTA9AB0bSYcxQI7yvIHQWhxs99YbeGxn4SfPqDj8ctPnjN/s6Q3JA8VGDt2ziyKImUktjfowV3iE/9G1clNFcBmiAmImCw1QHYpHCws6dIFKsQDAlmGoWrIKoN7TXW4BU1i+s951iqnMGmtexLKWOhhw3+gfhDkUelLQe1rUDVyx6tuf1yZ34E1tMLJgYBPkqXlRsi+FR8/OwVzluClOqvY9RkvJt93BT9jragLjQXZje3TRFolgODk1rW5aAARymIPqw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657448747; bh=JKP6aHhh7/wZILFCQVSBq8aj4TddazhRKfpctzHpTu0=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=nU5CuZ9KaMGptBI9I75ea/+L3w4VzgqLadUAfktBc7rQNO6Hm3dS6rhFuc0s4DTkI1QxH31Ix80XP4kgS4zGgQk+P3G1yzTzdKZQqNNhB3aY3j9+SDUJuPL0fqViZ8Pe3UHF5EjGJ6gkhnPXPkLF2iJaHhAQGbli4BK08Z+KDj6i8O89QTYeB/4ljyUU+YSQ/IbDEOoVk88w59/fDvAQx8w2rH0vTFec6NHFNAUsLqAwi/G5qe8XoAySK4cJPUCuCY41HHidkHiCK6cB9Ri5wtnL84wZJ+h125O+FofULnrY49IhWagIm5tALFtRkhI0I/zioR0bHHHtbtRp9HCr3A== X-YMail-OSG: RdEjMvsVM1n7QYKSHT64vCd7zq_nlgx6u2X3I4xy.b.QDzfePq5vTO0bevF20zT 6kJk.OdDvxG9CqaACpGUlSL2fETT7WOozZ4yM5k_0Mr.b3B68awijE0eCGEDEX6Kvk.B6UxwQfUN .dryFP7vUOnj7GbsZ2qjzM2DXj50atb5X18xCvHRvVXUaBHnW3WQxXDlcI07iBzLSMTxPhcDB.vO wTCWSxqZT7xDdcoJSDTBAldAw0qNRWL4p3KDtkUkUnnzsxY3Vkn0_52wvMrdbAdEKIQCABwXwCCM ddLZStgjQsn0GIqhG9BL6ZkDPSMRbzRkEzbP7g81_Yea0EQ4eWc3T4Ab2LbHuUGaLISdNtKirFFX .Uf.WzW5lexG0OKeS.G_9wzwvgG1pjjx4pWMN.xmUE_Hdfc5qgLU9oFVdC_B7V5XvAMJREK3MYjU _ImUGx.IQeJeZiwpizBnadKm8_3ZnYzcYBY__.WI_dSNIPB_9d3SEdYK9IJVdxDIQ_5QzhN7Goet iyJ4Hfg4z6rjbuYtWcL_jn0fv22Iepi1046I5zShQbo5huhe5tN0ZqPQ2hZzKE9nLdPheiNgYE3L TU6GA1.4m8sNYYlFowbhYNasoUTQH3BOxbEFnWuZb6.YazE905JeDPqFihGHwlutPOJR9jkLbUAF 6Xu7gHaCecKPRK.NJ8c7t9k6fL6CJt4XoZVZ4OJstKpKks.vVnc67SCRhzROHMBFaOXzs1fpuOb0 3sNgRgcapEbQ0tclmupO2IVUWYTh0Km5.YHFmA7GNH8Xb_ZhuXAaBwssv4K2AWR_.65nvM2HE2Fu WluN_GTjd7n36xyqMig.PF5zRgkaShdjfh9XinT4Cg6sX8s02MQPnh_VIC.H6vFVtPwGncHwgCEJ 4jydgNdmRRkIuw5bUZ7vpH6qnNSYafvBbgO46D8_x7IpEka5sCbX7SC3hD2dipGJXtPCuZyRAScT jm3zkUUyGgjKNkQt8IZjJTPnuE7A7JCpIUACxpzsObfGHwTmqgtBXGt8whw4UKHJ_pGGc_QDHaeM fTuUs2BYeIQ0dQ3O9vu6QiHtIpSBQfcZr.XebmO6xkoTKzT9g9dz5TUTfgpzeFtyYzhWLVzym1zM mq1dXgnj3U7KbWHiKyQyhVt92PMCLm7Z4MKoRZj2J4lNfjrJ6OhkGk6Fx5H_Lxxzr9RPE8v5pn9H NfvfdXwwzRd2.4zrHPglFQm1vKa9ICII1Tuh4u4PDJ.l3tITLMHL7iATrb.old6DUhoeMOOj2rr6 yBjuqU2EfWhqBzwteNIOyiws42AObcKuaEN4NUGdIckVbN2KRm9dWeVTw6hp2OkAwby5tWobdiKT O2v4ZGw.QKBnVVkTAz.rWQal065ZmymjG5U.J.MeOozU32VEVL0mziy6DvDwUR1oebFb5v5KAHvt WYkQuilwZWCQHywPvYoDm8iItDJy5tTQbuxMxc.wcPnk9bfXLR3tt1AfATPloKtfjf2ezMVTAgJm 3Ph099pOpfF05o5dP0rYJCtFNLj3_yJcq1.8OXc_9dgI7alqUKbBsFXiLtNeSP_ySgKWaeCKOZvK ZFUZwakgpelpaUxcy1__aSIrUhVVSDl.BrfMkd3z8Fm9KOSu82gvhUO1nIj6krPYdtoJIWefMX7P ynfTzzdDI4AzBQO5NJZ5cM7on2HhGMvFqR7w6KMmruUStqHuAJfGpUXKXMByBrazNwPdas_JTuvi hI5AMuxnJQZSmWAxGcWh7EAN6LYNBVSbTla7ZpVYahBH68zrBe5DTPyCDkhIx8h.Dm6erTuE1Y_N 0UY8dn4ImVEaiWvHxJNK6sPaSduArxkzWknyqc7ZKZUn8idtoC6rXefRxLKtPmxlQTAFALzY5x6N LYcHyjVlloFbcZQ1JsHfJS3UecRXI0h9kEBianpbhP7ewVowyKMBnt3pVlMlkX_wCT2xUqpOZKzL 48oHmBGBhshGI9JdHyVpYqwcNDSQ0fTeyKO0JviMJ_nsHPtzMgctF5vtooF9sR0HykgmdZo2SUVs U6BQl8ZNyDJV6E4uRVZU7zhBCwqASdijOeNDgHBPKKnMbkAqqwvaNmtjcMC7XpqrAj6lmYHN7HYP 3wQZ0xZiqUitmCWls8tiTaUJCccEvQ6qx6oqEE36hk2c.2I5dHvFfNJtmkdWi82MghXIFzN7cl6F 7nlTxKw8IOU_FzxAFjyTSMw3MxkC2wz2ZVUp7Qx9nR5NPB3u28G7pHWwHBQInhsvzZU2xItlTNIi NLyMGCHwLZAl4j9H6TV5rWazr53LVWCoqqjP4roJueZ7rbhYrRKO2UkEK8mlEhg-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Sun, 10 Jul 2022 10:25:47 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-5klrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID bbb6f1922fdeecbf079dcd25c6441b05; Sun, 10 Jul 2022 10:25:42 +0000 (UTC) From: Po Lu To: Manuel Giraud Subject: Re: bug#56479: 29.0.50; [PATCH] simple fix on xlwmenu References: <87sfn9uzpq.fsf@elite.giraud> Date: Sun, 10 Jul 2022 18:25:38 +0800 In-Reply-To: <87sfn9uzpq.fsf@elite.giraud> (Manuel Giraud's message of "Sun, 10 Jul 2022 10:41:21 +0200") Message-ID: <87pmid1cyl.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 207 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56479 Cc: 56479@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud writes: > I was working on patch for xlwmenu and found this. Thanks. Does our policy of avoiding "superfluous" whitespace changes apply to this kind of code as well? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 06:48:41 2022 Received: (at 56479) by debbugs.gnu.org; 10 Jul 2022 10:48:41 +0000 Received: from localhost ([127.0.0.1]:36317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAUUT-00062W-HB for submit@debbugs.gnu.org; Sun, 10 Jul 2022 06:48:41 -0400 Received: from mail-pj1-f41.google.com ([209.85.216.41]:46952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAUUS-000621-HO for 56479@debbugs.gnu.org; Sun, 10 Jul 2022 06:48:40 -0400 Received: by mail-pj1-f41.google.com with SMTP id t5-20020a17090a6a0500b001ef965b262eso2520570pjj.5 for <56479@debbugs.gnu.org>; Sun, 10 Jul 2022 03:48:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=6lP5DQ+Q6Il//9BAswTgdpAGugzH4Vt3zICewiiIhG8=; b=6bIrxiSR3NktnLtlECpQqUoQJFCFyRbD9g36unZT1wO/Tl/P61BuKCU10CjQ7cce7Q LbOVNlvQ4KPmM+gTt9FaWSW/tUv4Y0RR6kw6BGWsGM9YyzKQUdnw2KVCe0PmUIJM8gco zQuhYzn7V2clhT6CdUo3ME+gaaXZSGAg7DE3451Wjj1Qds+JkKeBRowl7zp/b7VOxAoJ pHuTOQXS+fXwPdGPe0dSF2173Fhg19CY+m5AuKsN5jVsJFspZVJGgtZXZes6o39/jW6e gpOHrk4afL9sOC75jM5bPX58e8qTFvKeoMS+vZtoUO3jgy+F6iM1jowEBwBATQOliyyd cutA== X-Gm-Message-State: AJIora/OwjSda1KPVQ/bNsfguGLJN57F2x5ia6pcyihlTo+ZYcXy0zvn 4MYNBcukaxjnMm9EHES12BrUFjrW4FdUatljO4aT9QzU X-Google-Smtp-Source: AGRyM1tHRRFc/wHYcEE0geVHhJ5W41pOm1LW3ppmMnqcskIbrJIIgfkkTdw489v9rs5NV8/3QzN8iRPMuxTCf0k5lRc= X-Received: by 2002:a17:902:db11:b0:16c:3e90:12e5 with SMTP id m17-20020a170902db1100b0016c3e9012e5mr3158019plx.73.1657450114884; Sun, 10 Jul 2022 03:48:34 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Jul 2022 03:48:34 -0700 From: Stefan Kangas In-Reply-To: <87pmid1cyl.fsf@yahoo.com> (Po Lu's message of "Sun, 10 Jul 2022 18:25:38 +0800") References: <87sfn9uzpq.fsf@elite.giraud> <87pmid1cyl.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sun, 10 Jul 2022 03:48:34 -0700 Message-ID: Subject: Re: bug#56479: 29.0.50; [PATCH] simple fix on xlwmenu To: Po Lu Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 56479 Cc: 56479@debbugs.gnu.org, Manuel Giraud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Po Lu writes: > Does our policy of avoiding "superfluous" whitespace changes apply to > this kind of code as well? The patch is just removing code, so I don't see how it would make e.g. "git blame" harder to use. So I'd say "no". From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 06:48:35 2022 Received: (at control) by debbugs.gnu.org; 10 Jul 2022 10:48:35 +0000 Received: from localhost ([127.0.0.1]:36311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAUUN-000620-6F for submit@debbugs.gnu.org; Sun, 10 Jul 2022 06:48:35 -0400 Received: from mail-pj1-f53.google.com ([209.85.216.53]:41839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAUUL-00061f-Nw for control@debbugs.gnu.org; Sun, 10 Jul 2022 06:48:34 -0400 Received: by mail-pj1-f53.google.com with SMTP id o31-20020a17090a0a2200b001ef7bd037bbso2550660pjo.0 for ; Sun, 10 Jul 2022 03:48:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=3qQX85gvoOt0r3fm1ackRVIQC6ShM5cYRBw/bnRieWg=; b=i7ZXHN6hynlb5oxnX2AXfJ729HA0j1zkOJSoyTMfVhbs5Vvywo9w1DylKx2rGttIoy 9ZI4c1xK4O8QrRmHG4q9mffZuQ9JuJx8eNwPJzFhY7pFbVOvqJBy/e+Oqt0zXaGqomwz kb7UjQlBHAuGwSTerYus5scP2z8uHUzaiu6AS5m+yxSXVkRPpmWbhWWn9hGETuKmFAee LxV5L2dv9WCWjaHp4MQaclWDBLHjgatInmTI3tck6HuoTQM6bVHS27HIYk7Jb227QckW vGl5ZRrXrVfjjfP/y0D71rqqP52n7JWEpNHs5ZLbW7GMEhfrQvF3ZMo2tMrUWIhRIuWr PRoA== X-Gm-Message-State: AJIora8m7QkPuwHTRxfBdH/lK6Lhs8JkwgaLC6/iBy1Lr1k2RIJ0eoTP 90VZdEB5BwEq6dOvKeZbwz8ct1mu9hfeIQ0f+caHvuQg X-Google-Smtp-Source: AGRyM1uKJAO+renmvBZBY0VGNst7/ZoSRmqRsp1deH4L2xJoZN6PZOg6E3yB65EGtQ1qZ6lp9kpklaLmRC/Y0drYETU= X-Received: by 2002:a17:902:7c0d:b0:16b:7dd2:626c with SMTP id x13-20020a1709027c0d00b0016b7dd2626cmr12764821pll.152.1657450108065; Sun, 10 Jul 2022 03:48:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Jul 2022 03:48:27 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sun, 10 Jul 2022 03:48:27 -0700 Message-ID: Subject: control message for bug #56479 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) severity 56479 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 06:09:37 2022 Received: (at 56479) by debbugs.gnu.org; 11 Jul 2022 10:09:37 +0000 Received: from localhost ([127.0.0.1]:38351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAqMD-0003YC-Iv for submit@debbugs.gnu.org; Mon, 11 Jul 2022 06:09:37 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAqMB-0003Xu-BX for 56479@debbugs.gnu.org; Mon, 11 Jul 2022 06:09:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Vicv5jYhoC5z+S4j1OK2vv23qrKSQqbpRFl8RaITxNo=; b=J8BHeKvIv/xnd2/R7WECsADsxm LDTm4mjB9nizGFjnwBq8B1U7cbC3XIElirZcEIwLHaludWc0a1Tqwl3mny/hSw72Tm3mqy/0ceX/8 lGmKCH3vg9klXsFwW8kIHcPL1L09hxD/irL5jt1fCfKBgiRboiMAfYoSg5Ey91qM5PHo=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAqM2-0001aw-DH; Mon, 11 Jul 2022 12:09:28 +0200 From: Lars Ingebrigtsen To: Manuel Giraud Subject: Re: bug#56479: 29.0.50; [PATCH] simple fix on xlwmenu In-Reply-To: <87sfn9uzpq.fsf@elite.giraud> (Manuel Giraud's message of "Sun, 10 Jul 2022 10:41:21 +0200") References: <87sfn9uzpq.fsf@elite.giraud> X-Now-Playing: AR Kane's _Single Collection (1)_: "Green Hazed Daze" Date: Mon, 11 Jul 2022 12:09:25 +0200 Message-ID: <874jzo0xm2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Manuel Giraud writes: > I was working on patch for xlwmenu and found this. Thanks; pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56479 Cc: 56479@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Manuel Giraud writes: > I was working on patch for xlwmenu and found this. Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 06:09:40 2022 Received: (at control) by debbugs.gnu.org; 11 Jul 2022 10:09:41 +0000 Received: from localhost ([127.0.0.1]:38354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAqMG-0003YV-Pw for submit@debbugs.gnu.org; Mon, 11 Jul 2022 06:09:40 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAqMF-0003Y3-C1 for control@debbugs.gnu.org; Mon, 11 Jul 2022 06:09:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GD7nAf/q1pSjOgr3uhaPAUWdP07twh63HipCSDMCkHE=; b=fszeEeqQ193T2TgFvzi/YffFjB kKSwVI51VWyLugOYa1LB5YS6aeK22kUefQopnaNHC304qWiDCJQx88Q3Hc1E2wPmakvqxxxGdam5f cqFBd2oonll6BcuPSkocz3uXi8VBuyOcTJMeUd/pPfySQ3ibCepZKq/rZVVtYqJ+2+T8=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAqM7-0001b4-K4 for control@debbugs.gnu.org; Mon, 11 Jul 2022 12:09:33 +0200 Date: Mon, 11 Jul 2022 12:09:31 +0200 Message-Id: <8735f80xlw.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56479 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 56479 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 56479 29.1 quit From unknown Tue Jun 24 13:53:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 08 Aug 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator