From unknown Sat Jun 14 19:20:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jul 2022 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 56462@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16573760303530 (code B ref -1); Sat, 09 Jul 2022 14:14:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Jul 2022 14:13:50 +0000 Received: from localhost ([127.0.0.1]:35671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oABDR-0000us-P6 for submit@debbugs.gnu.org; Sat, 09 Jul 2022 10:13:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:48158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oABDQ-0000uj-2a for submit@debbugs.gnu.org; Sat, 09 Jul 2022 10:13:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oABDP-0007oz-U0 for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2022 10:13:47 -0400 Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]:44518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oABDO-00087I-3M for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2022 10:13:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1657376022; bh=f1fPTntxucv/FD9HBM/VbX/fJ1KHUuMijQlILsqFj4c=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=LrbBKEfm+0AigJfjHH3GKb+xn9fvhVRodDh3dJwCWPiYDq7uNM07lzZqf1IzqpOgt0qG60QmKAnQ0wm/lFASau4Qm/8+47Sn49y7cw8dM5e4udx9UIMDETQnKpLL6kXuQSZjXXT0lM9laA7YQj+kxec4OkWtDuTq5AuaifG8Ip5pLe2nyDqoLYyQ1Rwx5L38DRTNt6uD8ENHocO4iRox+bOb/VrQDbMoStB392cyokSjpGXdCrqXo53jTGIQJ1qOfrB6L31dvyTp8t4wWtvKuvwgw4PcFbnmjInGtOdZJj4MFtAih3oMNJuxq56s/UFaPhKMNdwIH3rOWh9yBYLPvw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657376022; bh=h2HAOPEC2SnJIJW/AXKpxPVy/QA9p2mZPuM4j9dcz0v=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=C++24Tkk1818noPpHkLltswKAocftuHn5kMhulk/bxsTz8kDpW0uxIRYg6RAsRDTgJKHXO197zekcXnESi0X2/ofUXuKsLOzjew86Mcb7ix4DPxAjzR3dgN3JBlLCPxHe6IQBTF6J1g6Ju7hVIJvQfW6Ab2vQ1eGMi7L+zgeGl2b6k7zxMh4NWLM2S1/bwQ+n/YU+kD+7li38lxEbhCk3CEP4FzlQoLs8QOfIEF3LshD1oXNP0KxTDfwQUtoRk5HGx3gDVjYYg7HNbEZr7pajIjdBFb3PD22yX1E5d+B183NCjEWn3IflsiVTex+UnXgIMLIP6sSGSjj3yXeGCSbIA== X-YMail-OSG: e9wEWNcVM1m_sErNAYwpaKUg5KgNGtT.A1lSmvDzFA.I1jqDu2f7feXBtUifYFW HYTeSHljZ4KOzKUhpK08EdzoExeMKGKa9M0vnpmrrDOCaD9jpKLj8cA9Qnpw7PXdQKAvfsde2B3A V8xuzQHIBVffQbjKPDy1yoxexPE0I1M5ytSYLnOKABor4aESUclqap_ILT7O54MtJgmjp4YITlkK 3gwtpxlDd5qx69K_uR9y8UtblOM1S81dPKuIA6viqYuCW5i_nTljGgWsnDx9KT_r.VG6VFj2I8k4 Gh0LWzB51UHv._WYJc8K6oybcZzu5fLM84dlzTpvFy.tKxd3nYhylQ98kftgK7U65C5nmR6lFMQY hlKSeAMZcldzdTW3.hbHF8l495vQpL1LADXiVFZ6295vbfWLxBJsJ5I9TUkpvaHrzuHoE7GDXEq5 1GavXxKakaanWxpz19QP6rH4lX3L5SQpxGW_.z6aIJ4zBzt6LhoutnrltHH9AaR_mejdQPkQC5_B G1yv5bvHSnT0IbRms7Ce6QGAO_as8lzm8jo3EX_6KtuwxQu.cgaOhdK5Me4RBm3rJjLQUwxj_pYM piDtTotPnOZCDMLR8M8okEX_PRWlvRfdoycT_HyEeC7C2qq9N_enfBiE941nhvUMvcqGiaOnAvGK zzH.3kX9RmQymoxlylbw9kCZN1cFJYMAFOM8aYWkg0y9lT12U3grR0beR_piElAgYHvktxzVH_1e w5.kgu0_MpSRkF6Jzu0LYdGKVUDkPf0Hn8DVCVd_5ct3.3AKDOw3LSdnaphkO0WxldmbKfW7lLCA pHL4zQxaHxY62wDeUkB1sIlBd5_vayhRdBXHcxYLq9fM_OalhvNgSbBXj_g8Q2TITijQBgEDMoBm w8em293qPtLu25gaKYrvBxdwPAvBAg6Ao6OSA9a266mMMOHTlVjQIi2rGiTbW5JByrvRxGFV.Rhn FO6RqEanQEJTwzc7xzAh4HTs5u2pHctlxVLpUTV2kNH1YN26bQN3sRHt4RWUVSHLQau6fTJHNHcH Qaf4rgAHb2C8Jy3VSxSYhq8Q0w1UyYNRsXfiv786WsW..GhG6tpFXqu1yDFD.KxwRERrTZl_X4Ya .0vEHDIEoRD3bGc2zvM1y7aS6K2T0Myt6V21E9g_i9pZA7WM3BeE6uzMYOD.YRKSm.CAU6mOkWC2 ezqswU11TrFaOsX2z843r36RIjIyqv8m.htdeSyQnUyWmM1RsxDlsJNIqV4w1UwXNyOvRoGr7sIr NJkIYwO.TzxrA7pPniu4R0pR.VXdY71juRR0gmhsZrjp4_45U_Af00xC8KpMy5etGwqumpk_y9AJ Eh1vJqZ5zRwAyxy52KV._gukeGgSFxd1VXw7QaPT8LcbVXGr2dIUcR_sD6cddxP6Xc1nvEOeQZJS EnKl.XxcuHaVg.Q1lgx8UK_XDmLfLqMcLRheRoASr.a7CqmxAyjfbaRW7XyCzzF08IEks5ZbIXi8 H2GQpwhuFvZZg_t2yV3.LavH3PRAK5r39wICn_dyAxoltt.jD46dR8fNVfVVwRd9wVC0g6BHjFuk zoxqAsswyBqaxN33PdgNeoF64SFdEXhGwCbQdbQaY8l2mvbgu5vlC7RX2iOdMuYUub3HI_xEjEES IxyJpwIpFlx9nnMLxZyyp4khLPzTG_fEQHPgOWNYznck2GvCC2C7211uwpvlVRbDwJcVDYWU0Rw3 Bx49AUr7e8cJFhWmdzHfVUz94g9K_qtVpKAeqXODsrpQ3zxKQRUulgao_ClsyrZpuRbMftCIvPYQ KLf7zhbT_croNC0Gv9PUBR9W4P7Cazi_H7RB35a6PpDJrJ_PuXScGJjnjefMIibtF8HH8twLi2lI nK2d88Vey6MQw5jiCzz3ZfF_ZwzjTe5cyBNdzuyXosrOjenNax_0BQlioRghDU4O_gObJk8Q_4J1 lBskKTZlCVnN_cLdaf5yw_Jf9XK6RoslZQJJoL.QA2QCKR133ew1zh_ChuC3hgAdwFO3sMRphqgi Khb7SoGX.J9446PTarYSGUIeuATxs4KMnh39WdKwxsmhpKJG3JXYU7UPj2_.ybcuy8.Wv8TseV9v txPjiHAsrGIP2oL7YM_NEX8PvVG0f3ymg4d3Aa1CqhsNC7rl7EZ_3IeV3TstoV.h6MdZE1mEZZXV ZJ3Wnopv94UKLXSMmGfi8RD5cn89VPsVJXeMfuXPnUipegvC2WzoGc1.JTi69Blb7Unm.Pq3HuWa hCJQVoxD4BJL826nunyUNjtzrAnUILNQzlMRn X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Sat, 9 Jul 2022 14:13:42 +0000 Received: by hermes--canary-production-ir2-74b4d6d794-lc6zr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 23047981090dd0634074fd1ae552ba00; Sat, 09 Jul 2022 14:13:40 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Date: Sat, 09 Jul 2022 16:13:39 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" References: X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 2131 Received-SPF: pass client-ip=77.238.177.82; envelope-from=mardani29@yahoo.es; helo=sonic305-20.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain I ran the Leaks tool with Emacs 29, and I've found a memory leak in the NS version of Emacs. Since commit c7b48b61d08f0b6a08584080badc60fe62ba1db1, in function ns_draw_relief, static local variables baseCol and lightCol are assigned to nil separately to their declaration. That has the subtle consequence that the further down calls to [baseCol release] and [lightCol release] become a no-op, so each time ns_draw_relief is called it leaks some instances of NSColor. The fix is to revert to the previous way those static variables were declared. I've attached a patch with the correction. With this fix, the leaks tool doesn't report the NSColor leaks anymore when I play around with Emacs 29. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-memory-leak-in-ns_draw_relief.patch >From acebb668e310da526f262f6a47090eddbb9c76a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Sat, 9 Jul 2022 15:54:07 +0200 Subject: [PATCH] Fix memory leak in ns_draw_relief * src/nsterm.m (ns_draw_relief): Assigning the static local variables baseCol and lightCol to nil leaks memory as of the second time ns_draw_relief is called, because the calls to [baseCol release] and [lightCol release] further down the function become a no-op. This bug was introduced in c7b48b61d08f0b6a08584080badc60fe62ba1db1. --- src/nsterm.m | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index 7f232e7292..dc55edf0eb 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -3486,13 +3486,11 @@ larger if there are taller display elements (e.g., characters of some sides not being drawn, and because the rect will be filled. -------------------------------------------------------------------------- */ { - static NSColor *baseCol, *lightCol, *darkCol; + static NSColor *baseCol = nil, *lightCol = nil, *darkCol = nil; NSColor *newBaseCol; NSRect inner; NSBezierPath *p; - baseCol = nil; - lightCol = nil; newBaseCol = nil; p = nil; -- 2.34.1 --=-=-=-- From unknown Sat Jun 14 19:20:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2022 02:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: 56462@debbugs.gnu.org Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.165741993626834 (code B ref 56462); Sun, 10 Jul 2022 02:26:01 +0000 Received: (at 56462) by debbugs.gnu.org; 10 Jul 2022 02:25:36 +0000 Received: from localhost ([127.0.0.1]:36092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAMdc-0006yj-62 for submit@debbugs.gnu.org; Sat, 09 Jul 2022 22:25:36 -0400 Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:42424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAMda-0006yT-0p for 56462@debbugs.gnu.org; Sat, 09 Jul 2022 22:25:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657419927; bh=kAReL0zYcqLi1JmWs2S59Cm9HTXsNCeoCFgg1/dmog0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=kOYLybu5eRPEEvQWGJOp3pzQqkiHBI4nLvrJMNLACU8BN4lGxumPRiKKHljl0sQ8nWOEdI171UJcuH6etVxOBdW/tuRrLp6230lpszwZkbwy+YZMwkAfVIoG2laLJ735SZQFWnohnKxaSFgZnbaDQNLMBwzbg4NUI02RrOwhSdbSToXT0EUSpMbzTXg1LTmurxoKGOqfSzeOTnTVGKxIUdeeyJiu7YIiF9mZGNF0OjhWL5UMvrgJ+IuLXAgzPFCUzhDqByGd5hLsODXTTEDEMVZgISbZm13n6l9WxwAOChnRPg0zM5r+uEoXCU9ARNoBkI9sWE32Bc+Nzfne/dBCtQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657419927; bh=5OiWMSruh3eX+xzw90MwdrZd4xxDGgUkrwKi6ET3kzw=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=um2Dn5zeWn37YDg79XUIl3cI6NbF++nic8SsatvSev3+f0HBQDCK0Cl7ZEizkK+cPCV6wMp9uzwt+XGUad/bhCEB08LzHekthuhId7ZrKR/EhQzTp5rpsvMOAD73aVrgspzy2zgoHzWqJy/dlO8G8LmFdq2T8gOlNwjGvAqrhyXAynt2USBGhE8053wTqVsKL8jvpNzRSc5priY6m6DA2nfl9y6br7Xn4eMfeJ4Hmwldu49NeyUJoC25FGfD7m2M+UrS2mFMX2AWAEIkGgeL373pXBPw8h5ilQXUEYAEBsvVb2DdWvm/hAcseaEkXRTvytTU1cKKYu1/PlU4TWD7eA== X-YMail-OSG: lSp0mfwVM1mYGoyIOUHIhstBI_gW4blXNNh8b_UBoaexmT9d7dIiuyZsPTkWbJI 6lq0DdHXk5Bw8yCyrk9iQwjBFyEqP0kPADfUpUesoUjo_vMbN23JW2RqDOQdbnl40phJSMdoVth6 1hZyUJWJn2yyIq05Fqc7xVKSbyBfat9zqVldzY3L2kifk9mtJHpajewN5I8SDoT6Z.SMUaDxqz5L NFj7BVAqIu57JWW4LSJqf7canAwSIHwKGsmY_sOggxcOLdaC5WP5T.ih8Y_E9PJtqdpYor8xHw12 n.pb3e7SA75Enk3peH68srWMi5duXnNhAs.LS_bWNDo51KJBiF9aTn6dolTrWQkrU91GXY9Ylsf8 lE185X5HD3eWc1YMVXYesOK0eHIUA.GsNhlPukNfqmaFdSr3.p832MDqLRkEfcvudSZ4uePgIbDp Xx1031f5UUcybkEqdj7V7uErs0Unmx5M3lzrIfSDOw1ZiKxSWynqKuTaT61UuT9_uOJpv5yKffi4 3w3AUa7dH2Vmjp3KKfVZMgwAmbosqd2XTw.1kf9cYWFubxHqoDlBtqWHqvV7fmP5B7EaEWEuO1Lm 2hKep3bUIAt8djEXQ_8Brqg1ormb4z5i_dF2HAgwTv.a9td8uDxCCUQBenoadhnc7vqVAcjEbjHh oKlFr5H9w8WsArlsxPg2F0aicO46cs4uMkxoaCBGIg1d0wjLfYVlNGFtjRSPbfaQpDb4Qenc_Dmv HLiV6PkCLMAtZD7RV_.SPvwgnV_wpe3I8xbYbpQcNkO0Ah27gcEHohBpnK2DMA.pDqx30I7fUisP 4TKtXm._NEaBzj6XOAysklMKWx9kv3KRYC0wTnYXu7Oe2DyW5hT3TZ00W11ti90lQowqpfn4Pylh .QkarbZAdx1Zw5GGGQOuhELyjEeqig1ENFxDt1gG3g2ag4Amo988dEDUAbCt4fWR_8ziCljyLoE. gaJeCHTRE0tK7IDnN7xmWqaxom3Y7vdAw78vzR7PZ4NrBDJO78tCpzmIg64lQN0yM7nHXk9rTacl FiKw5RCZHKORVMRb3n1Dyddco.znn5evRsLzBxUVcRw.5UVC23NTqoqDDx1Yajt.QYSay62Fqpcd awNm7xjGUNe3sJoY0ALnHd4N5tVMl8O6twwY77155Fgio5wczAilB5gTjQJiQ3wStOqe8swhelhA usKxNWhUAFmB4_JjEO590jeB.Ga.aQ273eF4hcI3QBkNk1TkFIfix96XTnSiDFQqol27lLbcO98h wzqOjGyuaXaBh9T7kCkQ3wVwH0bijeA0FkaEHI_Ek6H5J0YLg_FcWp8HRPalmjB_W6pB6wl3yHJX vSBjNfOpj41wIVtIy45sSgCYwGq3iSFdmWITBSfBWEehuCqCEPtOIW6_JMRWbr_bs274EtfXRqfj NOTSiTd88JSO2gtn_tvHpAOib9bBXPrF3GoKosWJvSsXqGt6qBRLLhPy.j0sPEUXpnHEtSSZspLX ExsQ7_wAO.lnq8skpA8TQu_7yvtlq3Z9_0DIDZJBW1_6VAlJDJlz09vlWWYXBWpmB7pPSS66P_FX balzglsAOiQS_B2yzJH7qSk9GHkKmJyMFE0WTjbXdiaa3jAd1iwPv5d4zoNqiYH4RdLvyBTxXS1A kuNosfNxlLb_2LTErsyBtYJ1tQ4YuoQPrLx5hNNWAzlmQ2IlDjipQKGOsdZu6SJleyfHFMSqQ7nG 2LDZL4qfzRp9Jw3.85b5LVoPYwkk16.leci4noYAM3C0n0EU.rgqdg0z77U5JNo5VQ_pX2sXX2f0 OV_cho4W8otC6dqdrOofHg50XV0RcWj2KDPWeIktk4dgH7WXPPW86hdirPE.pJZ7QY2Q91cp2MHt D8pH884g6AcNbL2IRWuIL65JfN1PiSKImcKtLfPrisgZtWKhfDgPBisspUjAUDaXCcRgaJ8f688u jvwjUSjmzcoSBlBgPghytofG3s85GCqxTstrrHP4C6QOWc.jYIvSJCzBIdTZvPhspV7_fF5J8EQs bThohnCnkQxeMyRt_UeIlpOl1XkdzHPy2hyQzHv8cew4aTJO4DGmHFC3XYDMSapzWc3.Sq6XgUl5 oTQi_UG_zZBstf7cECDY6yXdyZdY7g8i0A8lnlOiNWrb0G0IwxWHytio..a2Va4RBYM559A0Gjes tqMeVebZuJMwjSQRFK2oW6o51e7lnpb9llQ0FtEh0Zrew3qMau2cyOZul0KWHjSvCIpef0oQDR1F 4uInKLIJC4Kjnj8Zclc_TeogWyJ7s5igjwOSFKoUmwDioJt4hi_.MqOhL5cOmuqdv X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Sun, 10 Jul 2022 02:25:27 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-hh5lh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c964110a468857ee6d87810df6aecd97; Sun, 10 Jul 2022 02:25:22 +0000 (UTC) From: Po Lu References: Date: Sun, 10 Jul 2022 10:25:18 +0800 In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sat, 09 Jul 2022 16:13:39 +0200") Message-ID: <87tu7p1z75.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 976 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mart=C3=ADn writes: > I ran the Leaks tool with Emacs 29, and I've found a memory leak in the > NS version of Emacs. > > Since commit c7b48b61d08f0b6a08584080badc60fe62ba1db1, in function > ns_draw_relief, static local variables baseCol and lightCol are assigned > to nil separately to their declaration. That has the subtle consequence > that the further down calls to [baseCol release] and [lightCol release] > become a no-op, so each time ns_draw_relief is called it leaks some > instances of NSColor. > > The fix is to revert to the previous way those static variables were > declared. > > I've attached a patch with the correction. With this fix, the leaks > tool doesn't report the NSColor leaks anymore when I play around with > Emacs 29. Thanks. But I think the use of static variables there is rather ugly, and it would be much nicer if we replicated the `x_setup_relief_color' logic there. Do you want to work on that, or should I? From unknown Sat Jun 14 19:20:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2022 10:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Po Lu Cc: 56462@debbugs.gnu.org Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.165744947721790 (code B ref 56462); Sun, 10 Jul 2022 10:38:01 +0000 Received: (at 56462) by debbugs.gnu.org; 10 Jul 2022 10:37:57 +0000 Received: from localhost ([127.0.0.1]:36286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAUK5-0005fO-04 for submit@debbugs.gnu.org; Sun, 10 Jul 2022 06:37:57 -0400 Received: from sonic310-57.consmr.mail.ir2.yahoo.com ([77.238.177.30]:40108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAUK3-0005fB-Qg for 56462@debbugs.gnu.org; Sun, 10 Jul 2022 06:37:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1657449470; bh=OADT1D2xOaRBGHZ43UiFGSTI4aJOJmvZB5IcdWPY+qQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=gH4Ll3D9w3JvgKFWttJh1WCUoBoJK0eyy5bgTMhktNdmRrseEVj8wrndRx/86OixNxx9pRwvIwm2g8ea/YCYJvJnHKnfeXI/swZjZLztPspUlbWGvXAbImDLt2oQuitKvdHQu+0e5PsrG0VudfG6ZvX4dzFsYG+YAezYtFRp4ybhyZj6iw8V16yJSHvt2onI3p7wl09/FWD+a2LH8WtAFopDchpb4U1r6SvDRf7ozyORKINWiUfF5pKmLambBY4IM4h44zaPf8O52zwcktqmxJLm1CDWwhpwbGOBGaapYd2gn9zdHo2eDUY+rW0ZNICFEPpliNR97iTbS843xadUew== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657449470; bh=E8POWTufu1fm/y69VReUxH+taaTbIDSlMxd3Ryme/sX=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=dnpbO5sDbD7kGsww0uX42MpUfUiZtOe51jQCN8O7eeWuLu2Y+nK4UP/wYkPzhDGdac4rawLVm2+WKISvZR5mftqsAojtEe2xsg5p36/BUzPJs9DHFIEncG+vl6DmU48C7s6715KwHmTDTUX0XPTgSKy5p4Kok/l2ltVQypgZOjvltxd9n5TjaLPMoqJGwEneWIPQnVtSKboNd6E0/KiWFf4nHGZ43wMGLjyQMN8f/9e6iDXvMVCVZ92JOFv0gPzwUgarjxlk4/mGvbMYcMyK/hwy778EkBawwqftvfAhQpMydihlH23ml5IG1Z9405EA35YZLSQGTq3BU6uBP4DG8Q== X-YMail-OSG: sKNln4MVM1mzxLG1HmNW9zl5s9wdntFLvn4PyOFu6X5w1NkijbAIs7JP798Hzzb SMTXjvnI6m7E2tW_E_p.CS5nuVThzptB3_7KWkCGNf24qDb_aV_P57PlPBPaEBCFhILs_eb0QaEo cW7Oeygx_UROFBZxhMf2ZBdlhwlGizz_RRpj9L2ADK59.JlIKg7Npuy_Fwx_oxl.71RQ1gZsn696 RpERH4FyfjX73tES4nuUT2PjBoOiIt2uhlywkxc6WJ75AyvTWMx0tqTzNOlPDhlEkwFlL7ilfPNd haCyHkYdCNKmJPS7yi1cwLXrOJjVQCvxW.LZ_WTET2UfFyPhWlg6PRSlaIvEVurNbA1VGVGRB_GA qSw0GCjVC6_J_Yv.AgTELvV3oVzwsYPjLgToIQkG7zjF0rAEcwnyN14VPKEbgxEJPRq5HICs_D6W 7lpZeOq4HruuqzLzhtqR_EMVOL2wvvjacwJJUvFsNSlnE.Xfc2EydjuNj20d2Jcf3HhddtrBAJmc D75w.nyHjLb1EN62PXtD_CcBBOBO8GpGAtVO8JBK9mlkRgqbqWZS.euCOALNLmJChdiqk_z0TyEi wVX1ahySjyewyTQKYAmBZftD8Ia9G81hzrv3.HkU3aVkJ2x7TTi24tgN99vXPVoU4aOM8hw5mv86 yXZtqGfeNtpEbBs3vvltfu1Z9kxWi.9X9twUJxiSvz4JeuUaJWMXUOpIVNdAUgNyDOzPPrQ_B_v0 6kQTBXExQuq0xosmawxyjGLmbQ1N.lrHojEfIpkHZR3uFN7OtJ5qdKumHZb99cGbJRiRxYjsURus 1RUeSG3GLcdR2jU3Ah_HMJeVKltaVrOkb_fawsJFKnsAskECcPzOUucq51U4J3GplTupAj9Z6XsO LmbEeyJkHM3jex9Q3I4QRKq5goPojnPfDhg1O7GYWY_7Tu1EOceu5Y0IfUsmTnjIGXmVJFDlEalW Ia9u.bRdsnSYncHtbxHhjo5THrZ9nsOMVDpYAUCHeEH7sQ0Un.KO8KptEPV4Xy4WKYMvEjuqgv4i m_mTDlhHKAGFVmDqvaYsldHO9b.l6.3_WsMd4.4tJmYB1PazAHIGkE5VDPRcju.gkisl7stDArBM J2U2nClyGrwTCXpLmiQ23qgnnqG8RdPeoojjCDDp5Vv5wkR5NeqYKuoLVGteXmRMkHpMqkanmHcH NWTcJCIk0cFwg4xsuvfjwgn1QzDPISFGGKCsO5ehxFhfHfeVixMpqsg.v3JqwPDPtIkKdjsenfTB raa39LLo43H1mgiVLRgK1AgCLhbdlLIJB_OgLQ6sHtd_PcuzBJSxsAE28.TEtozUU3S7MPjstrZ4 Fz1qkETr4j0LTv1cLUXu4vbrFmQaSmMR98L0DNbGoRsj6vin8Axi7ghWlZINo1Zqv3F57eZymUys Z1FbXtr3d.A.05m2o82cdlWfJ_jeN_HW6Z16FTlj48HK29klGsfEIIKd44ZZFf2ZUZK4TeEbV._f 5t7tdGuBMSFVs5OFQm5Ik_.Qvg1DRbxH8ukH_CXDO9iFT23UMl7QJTFT8Y2BwuGqEUzKe0myHhYT DCnySJXutGmrlh99Of1j._zEc2GkxEn8rjsoTGaC5rhNKKhaflk4OKXaiJyJ6pM_gbJXKs9TJiPs aKkqnzTAMrc_loM3trXifSrwb0cpfIWmYvQXysEMzTuq0E3gG4WD9DPar5lOD8QpM4bc5Rykn72d Rgx_aIofgINHkymnaOCGnKatoujepLymIBInoZEg.6tmVk3pLuKyFKPEy_AAiCW4xyEtZbfWEERO s6MwgQvo5k91oGYlrQrGfPWo01f_AuC9dqXfs5qrbjpl8QOEyTJJNwhJJ8n7miRRAzTYnbfZEGZD LSplkUgQmtGu4PfBTdwj.k0uO7ICOgq6t5Q3_jOTtEoZ22HCbvcPqjmlRTVgVbQg_Rnofib3372l najlQDZHZgY4doF4cELJG4F_egq2.dw_0t4r0yg6owzxjxFzpspum0c2Ar52NidzZOVMMzxVZGBq vKb2JGrS1L5RSW8VComYZht13.fDEJgJJOOmWIh8niCX1.KfmYcaQ9Yg2Vw77RTtwBf.A3mpOA.b aOJdw.RlK6d2ubR51dBOTP8J2YPHy4BCGQeuIuaaKFF26CY_.zSWCMsYqLsbcxaAUbdjZPSWxAMU u53OfrlO_39fOISOrgisS_r1_1Wbuw5_aPcNF.W.jewtQBSDHVF5wVqW_HIW2H3J.wuWekokAMnZ B_z9n7zo8tTPxUHRxRKDE0JlwKCsm45m.HFAbj3bUba4ulsLSu9io8XLueGip5g-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Sun, 10 Jul 2022 10:37:50 +0000 Received: by hermes--canary-production-ir2-74b4d6d794-wvl67 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 73c95a8de31e559cff528b513f57479c; Sun, 10 Jul 2022 10:37:49 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= References: <87tu7p1z75.fsf@yahoo.com> Date: Sun, 10 Jul 2022 12:37:48 +0200 In-Reply-To: <87tu7p1z75.fsf@yahoo.com> (Po Lu's message of "Sun, 10 Jul 2022 10:25:18 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1071 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Po Lu writes: > Daniel Mart=C3=ADn writes: > >> I ran the Leaks tool with Emacs 29, and I've found a memory leak in the >> NS version of Emacs. >> >> Since commit c7b48b61d08f0b6a08584080badc60fe62ba1db1, in function >> ns_draw_relief, static local variables baseCol and lightCol are assigned >> to nil separately to their declaration. That has the subtle consequence >> that the further down calls to [baseCol release] and [lightCol release] >> become a no-op, so each time ns_draw_relief is called it leaks some >> instances of NSColor. >> >> The fix is to revert to the previous way those static variables were >> declared. >> >> I've attached a patch with the correction. With this fix, the leaks >> tool doesn't report the NSColor leaks anymore when I play around with >> Emacs 29. > > Thanks. But I think the use of static variables there is rather ugly, > and it would be much nicer if we replicated the `x_setup_relief_color' > logic there. > > Do you want to work on that, or should I? Thanks, I can give it a try. From unknown Sat Jun 14 19:20:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2022 20:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 56462@debbugs.gnu.org Cc: luangruo@yahoo.com X-Debbugs-Original-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Po Lu , 56462@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165748634521224 (code B ref -1); Sun, 10 Jul 2022 20:53:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jul 2022 20:52:25 +0000 Received: from localhost ([127.0.0.1]:37848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAduj-0005WG-9x for submit@debbugs.gnu.org; Sun, 10 Jul 2022 16:52:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:33152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAduh-0005W8-D9 for submit@debbugs.gnu.org; Sun, 10 Jul 2022 16:52:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAduh-0008BH-1q for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 16:52:23 -0400 Received: from sonic310-11.consmr.mail.ir2.yahoo.com ([77.238.177.32]:41503) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAdud-000389-P4 for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 16:52:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1657486334; bh=Uq6dCOcmi+IeL61enwJvPRyhC+mP3VTAzqwD2Ya0UjM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=pBmIvDZuJfCa5v0UFbuSZ5F03X9n5xXe+Ziy9mdtZqcRGkRRpeOcqH+U4jPRd/lj2i8EuxzHHtIeOpEcHhjoYlPqqjl/BnTc7y1Ou2sGk9CxJrgegii0H3zSqxIWdjnmxpv741qcDTwb8zOCSDuoVuQU9E5aJl2+Rx5hMgU+v5sZRHBN0Vc+u/Z09KtA40mRl5O/AJYkeTV/BuMbIXoehmz4DwT+sJVRZQxqHiL7xP0x8+5+8nJ7O3nojlknpXS72Id2v75h/G1i+Ri0T0ue6HpNVxqh8qxzimjrHsHVKczErKuuWNm6WNECWo7TLYfzElG+HditptmVAoLomeATkA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657486334; bh=nYYxb8tj0VkNc2VVfYFnMAo4CayGOjSKLiTexUoR/bP=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=pPxD6jDXL3FcwnV1pihqpPJf8HjfD3JbwK8/szKEsW2NqfrLswGdi7oYNWs7MAEjdrD9Q7ULzGimQKUac3ZBfi86EqdyE7YQbi6oJ32XMTHEHIyqDJa7qR8ruKC3WtVx/qIWNmzbkbyeG3bbF3lZcW0NZGBigNngzrVe22vXlSdDr+tzMwMySB6oofn708TG1v2pFBZ9M8Ez4V/w5jAurMBvbmgBsA+QlOd4XfzQbTbv96Frwne/jLmSkaYWNQI8vBinG1Qoe9Gp/mkFlPovjvPQDDsaucJOG/7iMVsQ8lwMvserUQZyOgw0Bs+ZgeBVCngAOMjWBsLyhvqZhpwDJg== X-YMail-OSG: Rg_vGnEVM1nNyQa0medCDiPTOn01t6MLYKQGlVVfKxCm.OckldZKoV9uxRsKfLt oJJ8GL90HiW6FUQnj5jxHnkKnYjUfSNUDlbqqOJVHIVv8HXUaB4y_DcD2s1ACX_UNo8qSyia0ReV 97Wms4uCwzWt7h6LBy7zc7ePP1WzViNgtIw_y8UTjbOEuj2GEV_6wZ7xP3gPKKBOCyNFsBbJOO8U .kwMZrhR4fjANSvi6W5fctZr3rQQMtBR6kUUwcFHnuYX1inxX2A5bGhi15wXSOYw4czciMy1eKAg vDjAaPpfn30pBmyITlv..vmhxtIzxDeTWvRfLXUsH9.F3n9tjAk7.PAMvO27Vp6uRi1QDn8VLY96 M0wRFtL4c5RKNNbMa4Qr.44XMLN3tvldMo6lhbQMUcrKJSmsU6vIBlidXRBIMg_BR5S0T.ehWMRf ipSV9xoK0Kw6eJSLY9gCFJs9TT92Aw7xPaelvXblKnRn_9YVFtNuqncrUrutq1Uue8iVDQ7CM1h3 9bhyOIavIweiS5OeI268fFirkYSAkqn0HG2bQQupS20.pLr0XijGCYRgdUBMNXuzO1rewmz4GdBo DzfMh3yAxm8tTlBwyGGy2vBWkDKWt828eOCNsRek26AoSkqpkAu4LmZVtu2ZmNrJYeew5RGfEpPn sn3Z5PHnTG.TzKhcHIwAf2ycuuUWAxZekf9K6d56BVGzJ3cB95l0vAQg7PVCQ6Rw0Al2tMM_8IaB 6RF_C0TJSYtt3yeAvI4L9jxKsTJzRx3ieta7xsOV5a.jnLAnrUteSP.YVxjpv_s5YQnZU4tFA2DL ZqSL67U5itk3yslyzjNp3VkGGGIaASuw14Vb62YvNYmqd._TwDF.w.VUvA4C6BRwAvWfETceFjiU 6K2vaQmhaQaCHAHNDOPEAeAD.O9vmPNye5fWqs068Jo8_QImOgzH.VI51l16FCdCeJE_ya.JCtvW XOHLYzeOM9.RH8ZmQhb54rm_lLctJVJWxKAsM.cU6BqnUUhXrlO7NLz153OTPClII_VKuJuMFT9u lIJlKgla3BVhlr0FPA96XJvRW4tsCZoaU4TF1ch2fGxEFGDXW20rEjLZbphONXsBxSN.qd8Uhy.h _ESp4n.R_z33VvLUZOVYtBvLSQJWGS1kXM11yZDUj6I2vqO8MMD_xc06OM4VHxwWqnohdqR3oXNB qTAi4dfNZa7yCfiwzrJGLpMDFKqLIwAyxHjn9Vpas2EI0VQoJfqI_OSO8ZcOmJ6WDW6HgcwBGFE7 evUtqDhK.myvoIpO57ffZ2mzruAwp9tHNDrARPBYiMu_nYvfkdPDpXakInsdNxqGHVRIDFAorw5N HR_xIf9pQ4uQ.tzm9.7g3QWi4MLZlQ1Dlerue2sSCmJQXmrkfPqhjKjo9aHuhAK7DyjyJ31k6Hc8 D8CequlCefr3Z_Qvt4vAhDK_TAZ6.RnAo2znLGIjKArhKm1usVJ7NYXp5va_LsHi2le6C1Jk9S85 g1My2c.hOnIH2udpGkeH8wO5b0CfHUKKUFHChuoE.bwJTD5K7i6oNr_wKy8dZqcq7PghKz0xCRNd x5MF4xA71kgbgRTmTTBA1I20T34yrrDptakD3dcmWwvI_BG7Wy2jnIgnLGU6_fb_aDuEywLa1Hu3 x51XEbjSScEkwmPCrQcz25d6dUzHCiWj6Ko.ZRRtCsKKu7p7qjGutT9DCAInz5klaU.prZd_k5I9 bTK4VbeSdOzFI3Uwd6KSHBwNy.fDEIY9zdpYgVqkQwHPLR01dc74y4KlYqpZjD_U700T65tk2IEa Hz_F6h8yxZvYNJ2Ytf.rEZ_tnt2dhXlE8tX7npepVR9bfrCiP.TVXcjtO7lbsZNKg.PagT0LNQ7h fANA2CbGLjO4o9VAo0C37aT.Ss8d2pQ5tvBemjvueFL77k0cewhZVFsr4.O23A2KSs5VOcdh2MNn sYeJQ4X2_evqZSLS2uF6XqOcW9y7cVpGly7PQHIQM4JJw2kF49vQN6NOgmV.fvt9SMytV.8fLBfP yHShtAANt0OvewpnbZFXIu0xt7SgBXP1fCXQBNRQoHSxgPr2AaJsWhTvuUzZXxYq6.Ss53rcoLN4 vW_52b91tvWc20m7AnQURK4jrGzYbZrgPsMZ50R4my7DJq1ZRVDWirjFDiMqZ2Z9_JKHHJw7oQI6 pEOrEytRmQXJviV.VZW7Zp0yOjq3tSfO9dPSx8xVsIT5Vlu_J02cnLOABvwEDPJ_zeSt1PvKogpy cppPvElD7mHEXTKP5WsM8u13nGJVfjuzOY.QYkzm2RlMSpPXFLsDCZHaavwX4IYx7vg-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Sun, 10 Jul 2022 20:52:14 +0000 Received: by hermes--canary-production-ir2-74b4d6d794-wvl67 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 99a352d967dda149c817c5ac624d693c; Sun, 10 Jul 2022 20:52:09 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= References: <87tu7p1z75.fsf@yahoo.com> Date: Sun, 10 Jul 2022 22:52:08 +0200 In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?= via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Sun, 10 Jul 2022 12:37:48 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 5468 Received-SPF: pass client-ip=77.238.177.32; envelope-from=mardani29@yahoo.es; helo=sonic310-11.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> >> Thanks. But I think the use of static variables there is rather ugly, >> and it would be much nicer if we replicated the `x_setup_relief_color' >> logic there. >> >> Do you want to work on that, or should I? > > Thanks, I can give it a try. Here's a patch where the static variables are now proper fields in the ns_output structure. Is that what you had in mind? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-memory-leak-in-ns_draw_relief.patch >From ebcf7ca3e8a2add11050be4c1d7e991e3c0f0a6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Sun, 10 Jul 2022 22:36:28 +0200 Subject: [PATCH] Fix memory leak in ns_draw_relief * src/nsterm.h (struct ns_output): New fields to store the relief colors. * src/nsterm.m (ns_setup_relief_colors): New function to keep the relief colors as part of the ns_output structure. (ns_draw_relief): Remove static local variables. Assigning them to nil caused a memory leak of NSColor instances (bug#56462). Call ns_setup_relief_colors instead. --- src/nsterm.h | 6 +++++ src/nsterm.m | 68 +++++++++++++++++++++++++++------------------------- 2 files changed, 42 insertions(+), 32 deletions(-) diff --git a/src/nsterm.h b/src/nsterm.h index 7a097b3248..2a4c7571a3 100644 --- a/src/nsterm.h +++ b/src/nsterm.h @@ -927,6 +927,9 @@ #define KEY_NS_SHOW_PREFS ((1<<28)|(0<<16)|14) NSColor *cursor_color; NSColor *foreground_color; NSColor *background_color; + NSColor *relief_background_color; + NSColor *light_relief_color; + NSColor *dark_relief_color; EmacsToolbar *toolbar; #else void *view; @@ -934,6 +937,9 @@ #define KEY_NS_SHOW_PREFS ((1<<28)|(0<<16)|14) void *cursor_color; void *foreground_color; void *background_color; + void *relief_background_color; + void *light_relief_color; + void *dark_relief_color; void *toolbar; #endif diff --git a/src/nsterm.m b/src/nsterm.m index 7f232e7292..8e0c4b84f0 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -3475,6 +3475,35 @@ larger if there are taller display elements (e.g., characters } } +/* Set up colors for the relief lines around glyph string S. */ + +static void +ns_setup_relief_colors (struct glyph_string *s) +{ + struct ns_output *di = FRAME_OUTPUT_DATA (s->f); + NSColor *color; + + if (s->face->use_box_color_for_shadows_p) + color = [NSColor colorWithUnsignedLong: s->face->box_color]; + else + color = [NSColor colorWithUnsignedLong: s->face->background]; + + if (s->hl == DRAW_CURSOR) + color = FRAME_CURSOR_COLOR (s->f); + + if (color == nil) + color = [NSColor grayColor]; + + if (color != di->relief_background_color) + { + [di->relief_background_color release]; + di->relief_background_color = [color retain]; + [di->light_relief_color release]; + di->light_relief_color = [[color highlightWithLevel: 0.4] retain]; + [di->dark_relief_color release]; + di->dark_relief_color = [[color shadowWithLevel: 0.4] retain]; + } +} static void ns_draw_relief (NSRect outer, int hthickness, int vthickness, char raised_p, @@ -3486,40 +3515,13 @@ larger if there are taller display elements (e.g., characters of some sides not being drawn, and because the rect will be filled. -------------------------------------------------------------------------- */ { - static NSColor *baseCol, *lightCol, *darkCol; - NSColor *newBaseCol; NSRect inner; - NSBezierPath *p; - - baseCol = nil; - lightCol = nil; - newBaseCol = nil; - p = nil; + NSBezierPath *p = nil; NSTRACE ("ns_draw_relief"); /* set up colors */ - - if (s->face->use_box_color_for_shadows_p) - newBaseCol = [NSColor colorWithUnsignedLong: s->face->box_color]; - else - newBaseCol = [NSColor colorWithUnsignedLong: s->face->background]; - - if (s->hl == DRAW_CURSOR) - newBaseCol = FRAME_CURSOR_COLOR (s->f); - - if (newBaseCol == nil) - newBaseCol = [NSColor grayColor]; - - if (newBaseCol != baseCol) /* TODO: better check */ - { - [baseCol release]; - baseCol = [newBaseCol retain]; - [lightCol release]; - lightCol = [[baseCol highlightWithLevel: 0.4] retain]; - [darkCol release]; - darkCol = [[baseCol shadowWithLevel: 0.4] retain]; - } + ns_setup_relief_colors (s); /* Calculate the inner rectangle. */ inner = outer; @@ -3542,7 +3544,9 @@ larger if there are taller display elements (e.g., characters if (bottom_p) inner.size.height -= hthickness; - [(raised_p ? lightCol : darkCol) set]; + struct ns_output *di = FRAME_OUTPUT_DATA (s->f); + + [(raised_p ? di->light_relief_color : di->dark_relief_color) set]; if (top_p || left_p) { @@ -3564,7 +3568,7 @@ larger if there are taller display elements (e.g., characters [p fill]; } - [(raised_p ? darkCol : lightCol) set]; + [(raised_p ? di->dark_relief_color : di->light_relief_color) set]; if (bottom_p || right_p) { @@ -3626,7 +3630,7 @@ larger if there are taller display elements (e.g., characters NSMaxY (outer) - 0.5)]; } - [darkCol set]; + [di->dark_relief_color set]; [p stroke]; if (vthickness > 1 && hthickness > 1) -- 2.34.1 --=-=-=-- From unknown Sat Jun 14 19:20:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: Alan Third , 56462@debbugs.gnu.org Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.165750423018205 (code B ref 56462); Mon, 11 Jul 2022 01:51:02 +0000 Received: (at 56462) by debbugs.gnu.org; 11 Jul 2022 01:50:30 +0000 Received: from localhost ([127.0.0.1]:38048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAiZC-0004jZ-LY for submit@debbugs.gnu.org; Sun, 10 Jul 2022 21:50:30 -0400 Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:44995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAiZA-0004jA-3c for 56462@debbugs.gnu.org; Sun, 10 Jul 2022 21:50:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657504222; bh=9GFFEfSiyg8ia0rH3WtToYmMzxYcpFFp+wAif+9k+5o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=QZwzFL9muvlkuPZU2P/0vhzHzx7DBKhk50sFL5HS4lrCZzf0z6hGFIDwB994PrtviYiGlGEYitZJ986oDqxFUwmvF/YzR6cecsnwmyHgr8E3Nbtw5LGinddLxfRbFikbmyaekseVzZOh0Qf6BKEgaBXCTMSO454vhnbpwmLeuDp0589X1Wn9XidjbjIwXIunyHOe9iTh39e/dH8AOz/ohd5QJ9rDsxiwCiHhWF9GqLPzRsUnfITpXAiDlxqvivLx3Wgi+NLPrBXAlmlcRgS7qMm2+7KG0VivEjRiLBUcuHT8r/6ihq8rthdcqzlvF3Nfz/nTZFnreSxNjAZZEtdfMg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657504222; bh=SHAEr6CcTAAKFxyldfL2qerKLVPiEL9U/eAoHOeXr1b=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=rJQBL3beb/XJRXVZ+LFc3SNuNvsFKQtln7g/u9/fgM6JhgsAxVHAdTbhwdeKjBVNE2PGzdPdv6z7B3+2ITxuO+6XLjnwMRHFJgYAv+re6k7+awUgGvrJBb8IEavENijrBMSIcuVuGy6fD8v6VsdB0xIpP0vldUF+mwVcCL4IwTUPwWmPpShTWcYZR20s3GfMRg+ntVmXpwE0drYslxaHEgCAQhIp9K6D1Iwu6NI0Oj8X+p7fsEUmhOhVXv4QwpfwcvwiGqBrasJrpsIFhi110ZLJWV1FsTeh2P63BRMG78SWcO3wgrQq0AwZpVN9lG9tjBB2wT7S3/UGRO8CqFraIg== X-YMail-OSG: .mw7OQcVM1kx6FuWrmI2dvZ6b1RFF2sNKQ0IROEPSHOyqTv0a63Cnxcq1DX2jS4 WyhxxIMv9SnNC43h53pAEXWI73RhUSPC97VSbqMzejfovCEiUgeDuSqoOcg3RfyxZqLCqXQ3vqKC 9JKgynv9xWgdq8LQpSxC8yepD4_.uqrWy8.Vxi7lgdLcDFxT3Za4V79BFTDGdhAA4FSvERXZWlMd Ihn54g8wwC2I984KhomyEQCMQqyC7kdlpYTy3dv7Z8qPgfFJ5A.g0JCjAkZNqFRHtawgdRw9BHui 7DvIm8UuwWMOBBgXqhGZUHFtv.ecbzNSXbJj0sy0ucsK5PooEnNdyvWUI5WppcIjg94cN2OkNI.O hjq7nMwIa1HleN9SIsLsxY4s2BYwxii_wUDBuVqxepFjIrOaCgZYQ9EF2yN4xCsHQx7G7AetTjKO NbzML.r61gOXS7lqThIzLz_DpjaBW5LkfKXZD5P6wFY.NVDKdEexqUoy1PTsPx.3WHE.5ZSghte9 XVEtE42kh1UJ5KW7yPwq2XjKHFvpcbaPRfw.zK_m63hl0jpCol1QBhgyD21.86Tn20y6tij5BI9V HUa76ad6KcWVWd6tqmnqefQvibFyf5gsV7vdOHWmFNG1MUM2Ub2Jq_9bVfXWq2xWFPi4WEKeMrO6 _VxlP_xECSZAVgJdlIGcxUAQYEZ8qIePS21CaRW3MqmKYNiEtzTKcNPtJZCLOp2QgmyEdylRn1wV t8Uel3yYiU5LsTKU.i9kopItXqapiAS8bT_YaBiGmkqorUDDQFSG9El95xkq4TlHbrq6Lcbvl4M2 3pHepdEO1hGUOR98y.9DhugCWy5BEQCNj0oFnNfBY4xdIE8G8Q7gyNHwPWtPKlvLazRwYWUnIHqj tQRnKQRZHOGagUhj1_wdq6QjSdUmNNgdGuYfH1p3qMJfseOlec9UL8pjKRLVNPd61EHzcO348F8N JKc2yFOSRwTw.47_Efyjdvl7BSXtLfgT560XxHjYvrXoagGsGhe7As5EVRZBy5Ze2T2PNEje9dNs oeXl8GdlzwimH.rXMb5AWu0ESjsE4KpD9Qk_dtDdej92n5FW_n.Ai3_5aFzH8zmi0o5PZfpLkmqG .iQdut_zmMWyOyZgoiALPKXC6tzdvFUYJvitniPvGS4Gf8rw6eQ9U5RbkOW4WPlkbVlgSzCc_Akn ed7szVV8o0LwPUc41qjz68O5tQY9t8kb7vpPhxqSOzvaJMLJh1QnU.46PpQSojR3JwDBV0jpDV8K b7euMZ2aYji1qQl0yM_YCanYmcxwbsx.cFGaSAiv4dpfW9xvfXeeM_sHv8SIBL.jBeGdRwNKLb9b 4dyvJZ7AY1GrhbXF7QWYgTizZ9SdfkJegoCBxR94Rzv8g5Dg4k9fMpI9CB4MyoZVrXfnrUJ05qOX gdIHPNN3rKXXFaU2xLXbtg_A_ZXcK7THyxM8xVR5iCVKR3llYT3GWmymduuIdKfotHY.Ff1aoK8p 6ph9Cd_rLxh_lxjqDMy4DvgD7sq.5chF2NuniXBFcwO1PC6KJCAmlkkyNS0cajgI.X_WBLoJyk7T iGVMlp3Zg1pso3Je..BPgBOOky3E7SqqFIl7sicab2LfGu5lSN.M2aC3wxi6osD3iJXhj47FNyEl BqZ5zxVIquVW_9Xpqc4et1nvgg7ozS1Neb490QrZwy_RUE8E507jIXgqY7N9mf13EJgj5LQ5gmjp Mgym0mQRhvx_qDRhu.xbBe6PAxYL0Ja5Jb4SFpiNuHXbna.0tOObduR0NoDlrG9FxTH1WAJR9210 LzlOOxAfSOu79X2oM5OGIwviyAfoSNNQ0cYHqJZquoDpL9Emr4Qa1UDQZCQ2YE27Z02tI0Asb3dm hpiVlT_rcJf8wdrIEsvpLa4QcQHdvjvr8WqSS49eGDoYvGDPfbMCh6x71ld83Som157icpny2_7Q ptbQwLDUQgSc.K8r3uU7SseUMaqAek7zv4rY6CGfLzxBxhr4eIogomra_kvIllQ9JXe8583_MmsV 7GB7rPwG3aZfzDaX6HPyjulenNLh5isj6fVnFI8sxQrgISBNKVFU7snWZnU7qOF2miqCoDTLF87S qa.EO6Aq81XGJbChxSsOjTjfNGOfuNTXF.rwjf5_Fl4XCtelxNvo9i_VViZJtq0Zhfj9w9Ij53oZ LoQumGzdUsx8w9f9PMDKe9a32mKg5K598ZqkMhEC3tEkirRDaB8g1B.YMk1t9H5MjIpaVUIjqXDC 32cP9foDLKbby...c9BI_6zqdaxng3YlBgAaboAxMup_qCIUKRX8OKLxp3.FoPQ-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Jul 2022 01:50:22 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-5klrh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 31d65b5fe73489dbf23fd7118eb496d0; Mon, 11 Jul 2022 01:50:16 +0000 (UTC) From: Po Lu References: <87tu7p1z75.fsf@yahoo.com> Date: Mon, 11 Jul 2022 09:50:11 +0800 In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sun, 10 Jul 2022 22:52:08 +0200") Message-ID: <878rp01kq4.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 667 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mart=C3=ADn writes: > Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >>> >>> Thanks. But I think the use of static variables there is rather ugly, >>> and it would be much nicer if we replicated the `x_setup_relief_color' >>> logic there. >>> >>> Do you want to work on that, or should I? >> >> Thanks, I can give it a try. > > Here's a patch where the static variables are now proper fields in the > ns_output structure. Is that what you had in mind? Yes, this would be great. Thanks. Alan might have some comments; if he doesn't, I'll install this now. From unknown Sat Jun 14 19:20:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 08:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Po Lu Cc: 56462@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.165752647023956 (code B ref 56462); Mon, 11 Jul 2022 08:02:01 +0000 Received: (at 56462) by debbugs.gnu.org; 11 Jul 2022 08:01:10 +0000 Received: from localhost ([127.0.0.1]:38192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAoLt-0006EK-Rb for submit@debbugs.gnu.org; Mon, 11 Jul 2022 04:01:10 -0400 Received: from outbound.soverin.net ([185.233.34.21]:42643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAoLo-0006Df-5X for 56462@debbugs.gnu.org; Mon, 11 Jul 2022 04:01:08 -0400 Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 4LhGXn4Q09zPP; Mon, 11 Jul 2022 08:00:57 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.99]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1657526457; bh=m7Um2mBXlAVJSADaIV/MhuesxyVxGpB0csVwVy6YG+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b0AoUw5OEJy/GIFIRQ4wUx2PBsCHSA91EHPLh49WS3nrHPmHI0q/zcEjkucm4h1S/ raXNaaUZ3dSD6XmtMZETRntrDE1lPxf1Mcx0RxCnaJG5iTSdQQVLhYoKSyGx1hUEUb CUTek+zNMVE9phIxsQz0ZVUAZ8yMVWa5kONZmRYVwG31OCPiB9XbjL37qWF1paqPrx dPYDZEv3GnwU+f6gnlfJqheOxuSQx4VZPKUoQLbj0qN4qGzPOe+wli16PC+wa5d5Jh YZYdMxsHKafhFt38mNimmj5EC78UDl8k5gZMET8BvB3HOZT6BfefpF9MA0/o0AqnTn LfYDKx4DiRsFA== Received: from alan by faroe.holly.idiocy.org with local (Exim 4.95) (envelope-from ) id 1oAoLr-000GYS-St; Mon, 11 Jul 2022 09:01:07 +0100 Date: Mon, 11 Jul 2022 09:01:07 +0100 From: Alan Third Message-ID: Mail-Followup-To: Alan Third , Po Lu , Daniel =?UTF-8?Q?Mart=C3=ADn?= , 56462@debbugs.gnu.org References: <87tu7p1z75.fsf@yahoo.com> <878rp01kq4.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878rp01kq4.fsf@yahoo.com> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jul 11, 2022 at 09:50:11AM +0800, Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Daniel Martín writes: > > > Daniel Martín via "Bug reports for GNU Emacs, the Swiss army knife of > > text editors" writes: > > > >>> > >>> Thanks. But I think the use of static variables there is rather ugly, > >>> and it would be much nicer if we replicated the `x_setup_relief_color' > >>> logic there. > >>> > >>> Do you want to work on that, or should I? > >> > >> Thanks, I can give it a try. > > > > Here's a patch where the static variables are now proper fields in the > > ns_output structure. Is that what you had in mind? > > Yes, this would be great. Thanks. > > Alan might have some comments; if he doesn't, I'll install this now. No, looks fine to me. -- Alan Third From unknown Sat Jun 14 19:20:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2022 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: 56462@debbugs.gnu.org Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.165753515224458 (code B ref 56462); Mon, 11 Jul 2022 10:26:01 +0000 Received: (at 56462) by debbugs.gnu.org; 11 Jul 2022 10:25:52 +0000 Received: from localhost ([127.0.0.1]:38401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAqbw-0006MQ-78 for submit@debbugs.gnu.org; Mon, 11 Jul 2022 06:25:52 -0400 Received: from sonic312-23.consmr.mail.ne1.yahoo.com ([66.163.191.204]:43311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAqbu-0006M9-A7 for 56462@debbugs.gnu.org; Mon, 11 Jul 2022 06:25:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657535144; bh=kWebO08RdHsXohVonEv7LqLLlFo1dcxaqFzAodBk6uo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Id/AbXM76b7uy76JhBVUoQbe7s89nP2mQKKKKkjab93LONUu2hbYwXMmUP3evH+ilpQiybDmnxkdo/gjrqnYGFT6hZSgEsVP5EcorHnPFVsp9WWfBzpLqUpukNoCkNw4cqK9oe7gbja56zZFqZMmiES6o3NgxCbYQC+r2gBxPrqFBqa81lOx8REPs1Gnnh4KiNUA+ntwuovE33OO5mAawHJpPFap6gVvC9fTpikFnFzLiEua/i+np4tdn7nosgBDZWh9cFcm4hfM0nn2/2afJ0EE5pHMA+QJWjLQzy8cvLH14v79RFBbWTTy+K+wtQyZPhTtes7FTG/Vuhn3AtRAXw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657535144; bh=MtfSe2VXeEW8EgQgdJM8wjZezdAURzfPq5vLry6aoNv=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=G9sBTTPE2tm5Pd8MKJUkYVmkhY5EuopRFBvEZga8aFNlHS3w3W333DEMIDsehccyLlNVv+zPebKi1brFRKEI7vjf/nMDgF4zKTbBAtzORb77andYPYeYlcxKf5g9BSv2PLf09rFMiffnRVYlTNA+Gpm3ukvjhtCWfTicHo94bWThkAjbn5l6A59qkIuvhQihKwVZSMgZPyE1qXBKhiLB5pktg8vBKkogM+ZLmTh96As3uvHNUeRazUcUD6iD5VFG1ZXno3A27iHWSbvZ05FDRQxK3ah2JSrcCtevq9HGkvW82einBAZ397FGl3S0l7eQA0YD3OEhG602FQ1LfNlQPQ== X-YMail-OSG: FQ8JT1IVM1khcNICTel5fHO8dgxfOimuDR9kgwlgVH2LD.7UlNY8u307hsPxdlU GdnYbCzDgPqeFGlYSglDMVATJyKDmwD7m_WXmsgg84hCS5kBR5kh6bNep4GaP7XEjIVhtLwuwi2e Gkoocv8K41AHV4Sded5KHwk3wq241jklOUqhbuFJSjH1bJXtljdV8zrDl0iHu4Q3SccX2gKfdQYF EXri4sZ5SuZZ9Eac0MtzSVR.lzb5hhN9G.SSjoDIwyPJDAfIBCRus0L7lVf7UOr5P2wyxub2_DhY SRiI91jb.SC_OWxIBWqlzIOTeoPCvICZjEX2lbYo24NheXL3QoQ.8B7MLG5rUEh3ue8uT1aYgZEJ W_nzPi2WvdTM_fePMe9XFD3iR7TYl8.48oj4S32ij5nyb8ToWlJdV0tW36eYFCNf0j_xB64Q3l2G glq_3GO7ygJj3yxOAYHw.iUOYz266.WM_MqJ9EYap0PH3XbsuPVwvoVUCJ1Ha9lUPVJxjS00wShB k2qH84.E.CLjNI7RpHIMttZDYKvQnFKHT.ejXLxkxnbln_KTAjzpXIZoVAUgZazJo.FJCLl0UGpf smIJl4DH6TsNW5Q7o5rlxWG_aEv5_Yw3v4xifSlewTdyuws6OwJLT4pN84t7GYAa6FkrBj16SKUw uMVk6bxugS2cEsyf0MhWrFxNpXcQ3XGule6OkqEkZd9zgvcXaVnwBb5q93L6pA8NSy4y8x6jKIO. _IYRF96syUCy8fyw9dFLBLKu74VFl1FjCJm5U7jP2cCUPoyQ.YtvH1sOKsTpHd1zpnAyUucO3rqa cJ7Phf4McNwKREDvgiETXAr0f9HOXTL5fJMw_Hp2SxeJcMQrgw8iYnSJpFlMf_Jv0DL79v2MFw68 WraqBultTSvRCtxqDQsCRfTflaPCbyjvnElIrRnhqmn_wdHq8CySSm6Cl63z5kkiIYyxuoTjIHHi VwA7bpAg1YG4o6MGYYsAbV8Io2laZxpsDFKZxE9uvLi3EtPn4xXCjJQb3pQZR2V8mbVuTt1l2bqN bqhRdeT.XfKD7nRNDAmW13KojGbs9XQRFJwLBea5O7jvw5XLsEc_QJ5AU_prdFHkY0Z5iJENmStS DgjlXqw9ILtEChvvnQ9OBt79uXwMXCEluNOaKWu7AdViWxSvkjp_VQUTC8MAFFyZvoREk6FYWKm. 3N.AxrUMEBOi3Zbkb89gW2mRwWwV5wx1ESxyFeAWSCgGquVvhg9XYr1MfmK_8A.WtUMiWZ8mUOo6 W.dpVSPRSRpgo_t1q94SkZZPsUksYEoGketNBaOgGaqZa20LM9Q8Gp6KnkCtoauKKtKB8l1fLLrc 0.AP5sODfudOyKyV0P.Esi_Z6KJkiKzG1uuxAI3rJ_w0qlaRuxbWgYk7CXqtp6Nx27xB1rvu2DUK TJi0cEfFZN7DiWig_5Z_iQbc.juvpYlUpDewB_sDyK79W4gReVBnxlEKANSLaI1oNWCpPCCSXlA6 u5THfCjCLPWF9j4ZCZ9ISWAS7jk7iCewG5oPoXRn4oGDpDDG95NejzdusVU6ws9RHU7AZeTpjdN7 a3K255NQ0mSNiIswjIBuqzfRuUvhfhG0aawaHanFIFygWmI1HiC4lCWWvxJmYcZTkrqwkYYnanuy VY1nwnx1YMLvmD.rvvHplB87J5Mv1Drq.lCIcfKYJY1N72Vz_GeJZdMuMSu6hRcdT3NOVu78mnj7 5shNxsWDUqiOkPSD78ABHDH2mnhuTQeDwyz05b7b5xd6o7IVEQMJh5p4_NY3jbf6VrovCXMn.r3k KA75Ok7W6fSrU5tZ01fgreWWFug__5iMbpE8Hk_A6cpQQILI2V5qw.qB4IoZuo1HXFq2.R8GVPNC wG3FGmbqd0_fr2AQCYEKkqSriTFjjsNSu48iZFYa8WwdhvZJRyx1OhP2iwq65uwcSC0qDUIUCNcf KX_NdxnU7EkxIcCz5ccq055vSRLN3EB7GPFbOsvJJN4a4hwgtNReoDAhLMtT1O6i2jyBZs.VnhhP ygl_GmHJABJsfVLwoyHv_Jx7Ak5w_u.mBrERMV0IO3t0xl4v48S7TeqzkIK1oso2FgoWnZRNqST8 FI_2NfnBX4wrmCEHsAGHtcjq.1IwewUvePwJss4yE1JXjFuMBb7d4Igj08_x_WtltNUOZGzLRbVR tZ3ruoj1ZB.t8AtT.PMbA4yC0d2lBldrCJ.jgueCKgEL4GZ2RGD4GzKQX8Kk02n.Y8az3kxlejv3 gwq9urtp7wEJCI4JGP2nHUlGDBDVQQ.kdY_qVbPD5dBcK6dTyeoQbfTom0WTI_Irk X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Mon, 11 Jul 2022 10:25:44 +0000 Received: by hermes--canary-production-sg3-67975bbd4b-qg7qj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 15bd29704b2839bf4bca6e26d291abfc; Mon, 11 Jul 2022 10:25:39 +0000 (UTC) From: Po Lu References: <87tu7p1z75.fsf@yahoo.com> Date: Mon, 11 Jul 2022 18:25:35 +0800 In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sun, 10 Jul 2022 22:52:08 +0200") Message-ID: <87k08kymhs.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 602 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mart=C3=ADn writes: > Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >>> >>> Thanks. But I think the use of static variables there is rather ugly, >>> and it would be much nicer if we replicated the `x_setup_relief_color' >>> logic there. >>> >>> Do you want to work on that, or should I? >> >> Thanks, I can give it a try. > > Here's a patch where the static variables are now proper fields in the > ns_output structure. Is that what you had in mind? Now installed, so I'm closing this bug. From unknown Sat Jun 14 19:20:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56462: 29.0.50; [PATCH] Memory leak in ns_draw_relief Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Sep 2022 19:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Po Lu Cc: 56462@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Received: via spool by 56462-submit@debbugs.gnu.org id=B56462.166240580915588 (code B ref 56462); Mon, 05 Sep 2022 19:24:01 +0000 Received: (at 56462) by debbugs.gnu.org; 5 Sep 2022 19:23:29 +0000 Received: from localhost ([127.0.0.1]:48934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVHgu-00043K-VN for submit@debbugs.gnu.org; Mon, 05 Sep 2022 15:23:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVHgt-000437-BE for 56462@debbugs.gnu.org; Mon, 05 Sep 2022 15:23:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OHec8sj46k6Gx5ll6NXCkJWec1282t5O80HnQxB9TZQ=; b=VWwNQFR63UU4NWKowVezEZ7GZh pa3gnh4ahZGyOwIj3GnLfOJz+RAMebO08hUcWl/yItXU7Q4yDXDftNZZceGhQPPSYe1IrCYmnfHE6 Nx1oSUNtJOY4NWw680qwlJEWGIu9/voz1/dKFY9vPDTmeQJz/pfQCSGHL+PONlUBFkdI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVHgl-0004dp-D8; Mon, 05 Sep 2022 21:23:21 +0200 From: Lars Ingebrigtsen In-Reply-To: <87k08kymhs.fsf@yahoo.com> (Po Lu's message of "Mon, 11 Jul 2022 18:25:35 +0800") References: <87tu7p1z75.fsf@yahoo.com> <87k08kymhs.fsf@yahoo.com> X-Now-Playing: Joni Mitchell's _Hejira_: "Amelia" Date: Mon, 05 Sep 2022 21:23:18 +0200 Message-ID: <87k06hzkux.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Po Lu writes: > Now installed, so I'm closing this bug. The bug report was still open, so I'm closing it now. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Po Lu writes: > Now installed, so I'm closing this bug. The bug report was still open, so I'm closing it now. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 05 15:23:33 2022 Received: (at control) by debbugs.gnu.org; 5 Sep 2022 19:23:33 +0000 Received: from localhost ([127.0.0.1]:48937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVHgz-00043d-8A for submit@debbugs.gnu.org; Mon, 05 Sep 2022 15:23:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVHgx-00043C-Iy for control@debbugs.gnu.org; Mon, 05 Sep 2022 15:23:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pUGtfZEUCfb9nmvKfB9ejkurx/03ndBuG4OLEXYhZg8=; b=MOkFN/Y4Ai+6VscNSPXdV614Y6 tKEceG5BqvG5BvFWI3kuaciw+P2EJMCT8B95+qiAnwll41T09zzzTa5U1heeLiAP2l5iUMiyB3IAl EsTEUddq6GO8d77s7rlajGlQj+TzzxjSx0TQV92eYxq9DSozzP0SIq/bpsZy1mVODgkQ=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVHgp-0004dy-VC for control@debbugs.gnu.org; Mon, 05 Sep 2022 21:23:26 +0200 Date: Mon, 05 Sep 2022 21:23:23 +0200 Message-Id: <87ilm1zkus.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56462 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 56462 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 56462 29.1 quit