From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 17:35:25 2022 Received: (at submit) by debbugs.gnu.org; 7 Jul 2022 21:35:25 +0000 Received: from localhost ([127.0.0.1]:58188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Z9g-0008I1-Ob for submit@debbugs.gnu.org; Thu, 07 Jul 2022 17:35:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:57490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Z9b-0008Hr-CC for submit@debbugs.gnu.org; Thu, 07 Jul 2022 17:35:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Z9a-0005uW-T2 for bug-guix@gnu.org; Thu, 07 Jul 2022 17:35:19 -0400 Received: from sofi-shared.hosting.energy ([2001:41d0:602:1f56::]:33702 helo=sofi.hosting.energy) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Z9Z-0000nJ-4B for bug-guix@gnu.org; Thu, 07 Jul 2022 17:35:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=pisemsky.com; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QFUSFXT3/h2OrP+bjw6Xo5rzaJo5jwypSoHEq26CjOM=; b=FjhHhb3WKDdo0EXYaj2w/kLjTp 3wybQHV5RguXenqbdV0n4wKG/GLxumConJeLdapV/hk02l/ZmduGI6osg2yP6RkZaI7Eh7iQSETEm 5sq1qXZvX9j3qH7EgMDixvojYJp3r9VPcHaTu9jfZBipftVhvYKUUgcXbnF90RUK8Qjw=; Received: from node-122-176-35-212.domolink.tula.net ([212.35.176.122] helo=alpha) by sofi.hosting.energy with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1o9Z9U-0007dm-GI for bug-guix@gnu.org; Fri, 08 Jul 2022 00:35:12 +0300 From: Evgeny Pisemsky To: bug-guix@gnu.org Subject: Gitolite home directory permissions Date: Fri, 08 Jul 2022 00:35:10 +0300 Message-ID: <87zghkehdd.fsf@pisemsky.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:41d0:602:1f56::; envelope-from=evgeny@pisemsky.com; helo=sofi.hosting.energy X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello! I wanted to serve public repositories from gitolite using git-daemon. I tried the following configuration of services: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 (define git-daemon =E2=94=82 (git-daemon-service =E2=94=82 #:config (git-daemon-configuration =E2=94=82 (base-path "/var/lib/gitolite/repositories")))) =E2=94=82=20 =E2=94=82 (define gitolite =E2=94=82 (service gitolite-service-type =E2=94=82 (gitolite-configuration =E2=94=82 (admin-pubkey user-key) =E2=94=82 (group "git-daemon") =E2=94=82 (rc-file (gitolite-rc-file =E2=94=82 (umask #o0027)))))) =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 However despite setting the umask the `/var/lib/gitolite' directory gets the `drwx------' permissions that makes it inaccessible for the git-daemon. If I set the group permissions manually and restart the git-daemon everything works fine until the next system reboot, which resets the permissions to the above value. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 08 04:10:54 2022 Received: (at 56444) by debbugs.gnu.org; 8 Jul 2022 08:10:55 +0000 Received: from localhost ([127.0.0.1]:58657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9j4g-0007G5-L3 for submit@debbugs.gnu.org; Fri, 08 Jul 2022 04:10:54 -0400 Received: from sofi-shared.hosting.energy ([146.59.29.125]:48749 helo=sofi.hosting.energy) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9j4c-0007Fg-3t for 56444@debbugs.gnu.org; Fri, 08 Jul 2022 04:10:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=pisemsky.com; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-ID:In-Reply-To:Date:References:Subject:To:From:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3xdNpFKm7DbnHEhNJLpMLd9pEPyeIZM1O9oWTo6McMY=; b=IdcPa7aH5Lh0k/NTzQsfNGU3eB 5W04zHcsUQIw3bukkiGZ21H/6Lw8JqoNfxPcFYtm3eiGSaAt+JA5cqFKHD/OzRefryJo0kzxnp1Il bGeOl3Bh5aRh76QHeT+ZBk7NO092QVfhz1FPd3TL8DB0v7McnXGji7ezAJqgN1Bm1N7c=; Received: from node-122-176-35-212.domolink.tula.net ([212.35.176.122] helo=alpha) by sofi.hosting.energy with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1o9j4V-0000fZ-ET for 56444@debbugs.gnu.org; Fri, 08 Jul 2022 11:10:43 +0300 From: Evgeny Pisemsky To: 56444@debbugs.gnu.org Subject: Re: bug#56444: Acknowledgement (Gitolite home directory permissions) References: <87zghkehdd.fsf@pisemsky.com> Date: Fri, 08 Jul 2022 11:10:42 +0300 In-Reply-To: (GNU bug Tracking System's message of "Thu, 07 Jul 2022 21:36:01 +0000") Message-ID: <87ilo8ja7x.fsf@pisemsky.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56444 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) After some digging I came up to the procedure `activate-users+groups' in the file `gnu/build/activation.scm' and found the following lines: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 ;; Always set ownership and permissions for home directories of s= ystem =E2=94=82 ;; accounts. If a service needs looser permissions on its home =E2=94=82 ;; directories, it can always chmod it in an activation snippet. =E2=94=82 (chown home (passwd:uid pwd) (passwd:gid pwd)) =E2=94=82 (chmod home #o700))) =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 So it looks like the case for gitolite activation procedure - it should chmod the home directory with respect to the umask value. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 19 09:32:43 2022 Received: (at 56444) by debbugs.gnu.org; 19 Aug 2022 13:32:44 +0000 Received: from localhost ([127.0.0.1]:57591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oP279-0002HR-BS for submit@debbugs.gnu.org; Fri, 19 Aug 2022 09:32:43 -0400 Received: from mail-io1-f43.google.com ([209.85.166.43]:34739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oP275-0002HD-T4 for 56444@debbugs.gnu.org; Fri, 19 Aug 2022 09:32:41 -0400 Received: by mail-io1-f43.google.com with SMTP id x64so3303280iof.1 for <56444@debbugs.gnu.org>; Fri, 19 Aug 2022 06:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc; bh=g6Tn43JHxEJUFGltLxhMKMyg3CGEyXSFtrlfjhsw6WQ=; b=kIYIrgsahKxb85EtFYAczzho3/mg+LiUJK7ltOhgdgY4KkB2xcDLa5Y0N1wt3cmvaG L/GXUMjmjIm22YANWOPsNCTBxS6NiQvHPGomfw+eQAgjckOuTmGmXgxmkEbzu3ADwTKI FTKpV7j3LgkTwruOZcjkIBX7DmUGS5nsUMfF8bdqnQiDYq0BjAVm1ps14M28Cgm9ETju dPC0UcUzL57Ul8RM9HwU4YZuYJf5tm9Q21+QGeIOQFiBNX36NJWY2D5IweETmwHxdwMd eOC7amYiBnZEpD+SyK/FoKmg/W+Yip8rmBPoNJoZvrqmRaXG/SDsktJvVK3ap7aRTU1M 2AdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc; bh=g6Tn43JHxEJUFGltLxhMKMyg3CGEyXSFtrlfjhsw6WQ=; b=YJfGKZYnKCtp7Q36ym/EOEGDxMqQNPxrg7I/BK0GDrQO7wMVqAMQsNUEPnXjPZ7WyI WdwNM3EufJGxV/14YIcV+tlwEZN2fuzSwa5JSfrjn+Rg4g2FZhAxp+V2bSno2lol3Fdm 3hmrc/lKRWAy0Gol4TsPHG3Q5pyJvGlxCq+xC0v3n9Jp/TNgwGkld4TqfPT3WB+CNnR3 G90x+0pZImMzM+xW6y/8zok8fN9PUxpntLQsmzAbNTn1D0yrBdVch5cQXcji/Dui+Yuv KAhMQCa2LuuVx+AJk5DzKPnkvrmwGuVvOr+Apm5GW3xfPnuVkElv+R3W+2yW08yN7L9Q W+Qg== X-Gm-Message-State: ACgBeo2HDPKgiBb+1eNScg76vOoNtrZzQaDuMWthsCU5E7U9yVZshbIa F2QVSdKa9PvrRliuDCOLd3MAy8ctqK20j8XIdHVybj6gaMY= X-Google-Smtp-Source: AA6agR4t3VYci6WT3/zhFyQzz3op7bSpAYceXuXATrgaqone29tSDloCFGkA7zUwWzUYX3zcfygbEB+kD86g8LYdkCM= X-Received: by 2002:a05:6638:24c2:b0:346:ce9e:3eff with SMTP id y2-20020a05663824c200b00346ce9e3effmr3654487jat.262.1660915952289; Fri, 19 Aug 2022 06:32:32 -0700 (PDT) MIME-Version: 1.0 From: "Thompson, David" Date: Fri, 19 Aug 2022 09:32:20 -0400 Message-ID: Subject: Patch to fix Gitolite home directory permissions To: 56444@debbugs.gnu.org Content-Type: multipart/mixed; boundary="00000000000056bcb705e6982154" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000056bcb705e6982154 Content-Type: multipart/alternative; boundary="00000000000056bcb505e6982152" --00000000000056bcb505e6982152 Content-Type: text/plain; charset="UTF-8" Hi Evgeny and whoever wants to do some code review, I have been experiencing this same issue for years now and have been manually chmod'ing /var/lib/gitolite every time I upgraded because I didn't understand what was happening. All this time I thought I had gitolite misconfigured, that maybe I didn't have its umask config set properly, but it was Guix all along! In this case that's great, because it makes the problem easy for me to fix. Patch attached. It works like a charm for my personal git server (https://git.dthompson.us), /var/lib/gitolite was 700 before a system reconfigure, and 750 afterwards. Big thanks to Evgeny for making a bug report and doing the research to identify the root cause! - Dave --00000000000056bcb505e6982152 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Evgeny and whoever wants to do some code review,

I have been experiencing this same issue for years = now and have been manually chmod'ing /var/lib/gitolite every time I upg= raded because I didn't understand what was happening.=C2=A0 All this ti= me I thought I had gitolite misconfigured, that maybe I didn't have its= umask config set properly, but it was Guix all along! In this case that= 9;s great, because it makes the problem easy for me to fix.=C2=A0 Patch att= ached.=C2=A0 It works like a charm for my personal git server (https://git.dthompson.us), /var/lib/gitolite w= as 700 before a system reconfigure, and 750 afterwards.

<= /div>
Big thanks to Evgeny for making a bug report and doing the resear= ch to identify the root cause!

- Dave
--00000000000056bcb505e6982152-- --00000000000056bcb705e6982154 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-services-gitolite-Relax-permissions-on-service-user-.patch" Content-Disposition: attachment; filename="0001-services-gitolite-Relax-permissions-on-service-user-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l70ibjca0 RnJvbSBmMzVjYjAxOGRmODQ5OGRiNDU2ODlkYzBlOTgwMGI5OTAwOGE5ZGVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBUaG9tcHNvbiA8ZHRob21wc29uMkB3b3JjZXN0ZXIu ZWR1PgpEYXRlOiBGcmksIDE5IEF1ZyAyMDIyIDA5OjIwOjA2IC0wNDAwClN1YmplY3Q6IFtQQVRD SF0gc2VydmljZXM6IGdpdG9saXRlOiBSZWxheCBwZXJtaXNzaW9ucyBvbiBzZXJ2aWNlIHVzZXIg aG9tZQogZGlyZWN0b3J5LgoKRml4ZXMgaHR0cHM6Ly9pc3N1ZXMuZ3VpeC5nbnUub3JnLzU2NDQ0 CgoqIGdudS9zZXJ2aWNlcy92ZXJzaW9uLWNvbnRyb2wuc2NtIChnaXRvbGl0ZS1hY3RpdmF0aW9u KTogTW9kaWZ5IHBlcm1pc3Npb25zCiAgb24gaG9tZSBkaXJlY3Rvcnkgc28gdGhhdCBnaXQgZ3Jv dXAgaGFzIHJlYWQgYWNjZXNzLgoKUmVwb3J0ZWQtYnk6IEV2Z2VueSBQaXNlbXNreSA8ZXZnZW55 QHBpc2Vtc2t5LmNvbT4KCkV4cGVyaWVuY2VkIGJ5IERhdmlkIFRob21wc29uIGZvciB5ZWFycywg d29uZGVyaW5nIHdoYXQgd2FzIHdyb25nLiBUaGFua3MgZm9yCmZpbmRpbmcgdGhlIHJvb3QgY2F1 c2UsIEV2Z2VueSEgOikKLS0tCiBnbnUvc2VydmljZXMvdmVyc2lvbi1jb250cm9sLnNjbSB8IDgg KysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9n bnUvc2VydmljZXMvdmVyc2lvbi1jb250cm9sLnNjbSBiL2dudS9zZXJ2aWNlcy92ZXJzaW9uLWNv bnRyb2wuc2NtCmluZGV4IGRlZmJkNjVjMzYuLjE3YTVmOWM4NjcgMTAwNjQ0Ci0tLSBhL2dudS9z ZXJ2aWNlcy92ZXJzaW9uLWNvbnRyb2wuc2NtCisrKyBiL2dudS9zZXJ2aWNlcy92ZXJzaW9uLWNv bnRyb2wuc2NtCkBAIC0zMzEsNiArMzMxLDE0IEBAIGFjY2VzcyB0byBleHBvcnRlZCByZXBvc2l0 b3JpZXMgdW5kZXIgQGZpbGV7L3Nydi9naXR9LiIKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoc3RyaXAtc3RvcmUtZmlsZS1uYW1lIGFkbWluLXB1YmtleSkpKSkKICAgICAgICAgICAg ICAgICAocmMtZmlsZSAjJChzdHJpbmctYXBwZW5kIGhvbWUgIi8uZ2l0b2xpdGUucmMiKSkpCiAK KyAgICAgICAgICAgOzsgYWN0aXZhdGUtdXNlcnMrZ3JvdXBzIGluIChnbnUgYnVpbGQgYWN0aXZh dGlvbikgc2V0cyB0aGUKKyAgICAgICAgICAgOzsgcGVybWlzc2lvbiBmbGFncyBvZiBob21lIGRp cmVjdG9yaWVzIHRvICNvNzAwIGFuZCBtZW50aW9ucyB0aGF0CisgICAgICAgICAgIDs7IHNlcnZp Y2VzIG5lZWRpbmcgbG9vc2VyIHBlcm1pc3Npb25zIHNob3VsZCBjaG1vZCBpdCBkdXJpbmcKKyAg ICAgICAgICAgOzsgc2VydmljZSBhY3RpdmF0aW9uLiAgV2UgYWxzbyB3YW50IHRoZSBnaXQgZ3Jv dXAgdG8gYmUgYWJsZSB0bworICAgICAgICAgICA7OyByZWFkIGZyb20gdGhlIGdpdG9saXRlIGhv bWUgZGlyZWN0b3J5LCBzbyBhIGNobW9kJ2luZyB3ZSB3aWxsCisgICAgICAgICAgIDs7IGdvIQor ICAgICAgICAgICAoY2htb2QgIyRob21lICNvNzUwKQorCiAgICAgICAgICAgIChzaW1wbGUtZm9y bWF0ICN0ICJndWl4OiBnaXRvbGl0ZTogaW5zdGFsbGluZyB+QVxuIiAjJHJjLWZpbGUpCiAgICAg ICAgICAgIChjb3B5LWZpbGUgIyRyYy1maWxlIHJjLWZpbGUpCiAgICAgICAgICAgIDs7IGVuc3Vy ZSBnaXRvbGl0ZSdzIHVzZXIgY2FuIHJlYWQgdGhlIGNvbmZpZ3VyYXRpb24KLS0gCjIuMjUuMQoK --00000000000056bcb705e6982154-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 08:41:33 2022 Received: (at 56444) by debbugs.gnu.org; 23 Aug 2022 12:41:33 +0000 Received: from localhost ([127.0.0.1]:42903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQTDh-0001Yo-KH for submit@debbugs.gnu.org; Tue, 23 Aug 2022 08:41:33 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:54844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQTDe-0001Yd-Dr for 56444@debbugs.gnu.org; Tue, 23 Aug 2022 08:41:24 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id B0hL2800320ykKC010hLza; Tue, 23 Aug 2022 14:41:20 +0200 Message-ID: Date: Tue, 23 Aug 2022 14:41:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: bug#56444: Patch to fix Gitolite home directory permissions Content-Language: en-US To: "Thompson, David" , 56444@debbugs.gnu.org References: <87zghkehdd.fsf@pisemsky.com> From: Maxime Devos In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------gssz0mjJ6f8Hyh0TulVxn8dR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661258480; bh=kDLw6WE+ovccQ1e0sYkzplj7y5R76AzIYxuWTsmKISA=; h=Date:Subject:To:References:From:In-Reply-To; b=aVqO0+z0CLcukQl30d+8n944CNpE9EuxB1kbTVK8/AbugSdCFMvNXrdLYGcVrzM6Q 3NExlxle1clqlj9rp8Q+ZbZh8sEuMvjv1l00nnYTUAykyzwabakN/EH1i2PI+3Cw22 6elDWdzygr41F2IfGnP1jfZEajcH3xoln2c+9wHp/eZ5XqTRthqgyjYDrU+9VpT17j ZbIdQBh4biL/Gg++Hbn79yAAL2Lu4OHsnLCU9QCxODWfcCAOM7IvhKUJrpIm5uhuiU T+rKqA01/CA2Hv2K5nLutTZ+ys0VGyH+9mUqoOYjK3/KvWUv6U9UGQRv3LuGVNmUQi dakAALGMQw6iA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------gssz0mjJ6f8Hyh0TulVxn8dR Content-Type: multipart/mixed; boundary="------------UT3VaB00lOfuFdpoHSx8wbYj"; protected-headers="v1" From: Maxime Devos To: "Thompson, David" , 56444@debbugs.gnu.org Message-ID: Subject: Re: bug#56444: Patch to fix Gitolite home directory permissions References: <87zghkehdd.fsf@pisemsky.com> In-Reply-To: --------------UT3VaB00lOfuFdpoHSx8wbYj Content-Type: multipart/mixed; boundary="------------BjANYs9vpedSwYdAePod2Z3X" --------------BjANYs9vpedSwYdAePod2Z3X Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAxOS0wOC0yMDIyIDE1OjMyLCBUaG9tcHNvbiwgRGF2aWQgd3JvdGU6DQo+IEhpIEV2 Z2VueSBhbmQgd2hvZXZlciB3YW50cyB0byBkbyBzb21lIGNvZGUgcmV2aWV3LA0KPg0KPiBJ IGhhdmUgYmVlbiBleHBlcmllbmNpbmcgdGhpcyBzYW1lIGlzc3VlIGZvciB5ZWFycyBub3cg YW5kIGhhdmUgYmVlbiANCj4gbWFudWFsbHkgY2htb2QnaW5nIC92YXIvbGliL2dpdG9saXRl IGV2ZXJ5IHRpbWUgSSB1cGdyYWRlZCBiZWNhdXNlIEkgDQo+IGRpZG4ndCB1bmRlcnN0YW5k IHdoYXQgd2FzIGhhcHBlbmluZy7CoCBBbGwgdGhpcyB0aW1lIEkgdGhvdWdodCBJIGhhZCAN Cj4gZ2l0b2xpdGUgbWlzY29uZmlndXJlZCwgdGhhdCBtYXliZSBJIGRpZG4ndCBoYXZlIGl0 cyB1bWFzayBjb25maWcgc2V0IA0KPiBwcm9wZXJseSwgYnV0IGl0IHdhcyBHdWl4IGFsbCBh bG9uZyEgSW4gdGhpcyBjYXNlIHRoYXQncyBncmVhdCwgDQo+IGJlY2F1c2UgaXQgbWFrZXMg dGhlIHByb2JsZW0gZWFzeSBmb3IgbWUgdG8gZml4LsKgIFBhdGNoIGF0dGFjaGVkLsKgIEl0 IA0KPiB3b3JrcyBsaWtlIGEgY2hhcm0gZm9yIG15IHBlcnNvbmFsIGdpdCBzZXJ2ZXIgDQo+ IChodHRwczovL2dpdC5kdGhvbXBzb24udXMpLCAvdmFyL2xpYi9naXRvbGl0ZSB3YXMgNzAw IGJlZm9yZSBhIHN5c3RlbSANCj4gcmVjb25maWd1cmUsIGFuZCA3NTAgYWZ0ZXJ3YXJkcy4N Cj4NCj4gQmlnIHRoYW5rcyB0byBFdmdlbnkgZm9yIG1ha2luZyBhIGJ1ZyByZXBvcnQgYW5k IGRvaW5nIHRoZSByZXNlYXJjaCB0byANCj4gaWRlbnRpZnkgdGhlIHJvb3QgY2F1c2UhDQo+ DQo+IC0gRGF2ZQ0KDQpEdXJpbmcgImd1aXggc3lzdGVtIHJlY29uZmlndXJlIiwgdGhlcmUg aXMgbm93IHdpbmRvdyB3aGVyZSB0aGUgDQpkaXJlY3RvcnkgdGVtcG9yYXJpbHkgaGFzIGlu Y29ycmVjdCBiaXRzIGFuZCBoZW5jZSBpZiBnaXRvbGl0ZSBpcyANCnJlc3RhcnRlZCBkdXJp bmcgdGhhdCB0aW1lIGl0IHdpbGwgcHJlc3VtYWJseSBmYWlsLsKgIENvdWxkIGEgDQonaG9t ZS1wZXJtaXNzaW9uLWJpdHMnIG9yIHN1Y2ggZmllbGQgYmUgYWRkZWQgaW5zdGVhZCB0byA8 dXNlci1hY2NvdW50PiANCnRvIG1ha2UgdGhpbmdzIGF0b21pYz8NCg0KR3JlZXRpbmdzLA0K TWF4aW1lLg0KDQo= --------------BjANYs9vpedSwYdAePod2Z3X Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------BjANYs9vpedSwYdAePod2Z3X-- --------------UT3VaB00lOfuFdpoHSx8wbYj-- --------------gssz0mjJ6f8Hyh0TulVxn8dR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwTK8AUDAAAAAAAKCRBJ4+4iGRcl7urW AQDLsdJe30jX/b3hHlC6Et/APH20WpgzpBcCFzxjDQH/+QD8CYR0hhBZ8RAZJ2ylDwSDB0oAU9Cn Hp3MnngP/3iW2QQ= =f+FH -----END PGP SIGNATURE----- --------------gssz0mjJ6f8Hyh0TulVxn8dR-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 10:46:14 2022 Received: (at 56444) by debbugs.gnu.org; 23 Aug 2022 14:46:14 +0000 Received: from localhost ([127.0.0.1]:44795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQVAT-00013D-SF for submit@debbugs.gnu.org; Tue, 23 Aug 2022 10:46:14 -0400 Received: from mail-lj1-f173.google.com ([209.85.208.173]:33581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQVAQ-00012z-Nj for 56444@debbugs.gnu.org; Tue, 23 Aug 2022 10:46:12 -0400 Received: by mail-lj1-f173.google.com with SMTP id u24so8146494lji.0 for <56444@debbugs.gnu.org>; Tue, 23 Aug 2022 07:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=6bFLfR/cYp1QnlZqD1pH4400HDGBMIbd43N/upMW0c4=; b=Ld49jW2vG9sBK/3AjXs/YvAsvzG8/YwPKSFnUXhk1Ff/ZaLBwfnWvA9itBDvkawgBK ofIAUBUAKuDep1QB+bkuBa0vXbzwI46jEiH9+tf40BAymsQ+re1nbbkOb/aeSvBTI7/5 MHMKdOWZXmyyyw4Wi8VKKZblucnrciU49H0z/1UP8jK0g3AxTQFzRQchmBmNmxodVOkL MD2bcFsSRaj+xJeC9Htbm35N0l+Vx8UPlNqdQiUc4P664hlUOjzQI7pFIeIJSj5J7TCP M9nxZ15I2n5Q/m+bpD9roAuy55YAr//Z72GcJIushFL1isjDUlA18Jt22NROUlsUUifj SYDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=6bFLfR/cYp1QnlZqD1pH4400HDGBMIbd43N/upMW0c4=; b=C1btLZbHdUsLqbISYzRszE+Ju6q9BIQDVnoVtlRsEdozoXchkMKwkFQtRwtK2RIfnm PjRQMBpwmOE4RFGOIdfyXwdpoQYXtpc4Z9jO/UTdvTtU8GEjbghii/qHyTw8VB6jDsoB LQOGvDuu9XHfWglppSblbqqcUWMsqPOWZdwR/YslZmv1WoMRtDXhvqkddwpmUU2M/RNq cQ4yMia9RTD1xlP5/oR6o1EcykCtjKTBZEV1NT6I8vCP7Tc8kNwfuqiUiyfI/QDXo6Jn oAHtMZQAhitlFcOqWtU5VWBQ/01KSGZJF9CQPDxgiYZdBmjAwUWAlLHt0FYg9sOh6m63 sFQQ== X-Gm-Message-State: ACgBeo1w/BYOD6I6Bu8MsITOu2lqdlYDA7R/K06TGJRr+I8Sdl9FAMEP WmZfyeEd2dwTf7nfTRQQP1o3auYXYSZMgxC44zm2FA== X-Google-Smtp-Source: AA6agR4wlgEhmRjbOPup+nOINKTeuG1SDYDDUD8NRDdTvod9H06t0b4HtDDDzo8Uj1wfVa9XTwTyGvmCREJYqXxCPV0= X-Received: by 2002:a2e:b711:0:b0:261:d3b3:706e with SMTP id j17-20020a2eb711000000b00261d3b3706emr1608315ljo.381.1661265964542; Tue, 23 Aug 2022 07:46:04 -0700 (PDT) MIME-Version: 1.0 References: <87zghkehdd.fsf@pisemsky.com> In-Reply-To: From: "Thompson, David" Date: Tue, 23 Aug 2022 10:45:53 -0400 Message-ID: Subject: Re: bug#56444: Patch to fix Gitolite home directory permissions To: Maxime Devos Content-Type: multipart/alternative; boundary="000000000000b1d5d205e6e99fb7" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b1d5d205e6e99fb7 Content-Type: text/plain; charset="UTF-8" Hi Maxime, On Tue, Aug 23, 2022, 8:41 AM Maxime Devos wrote: > > During "guix system reconfigure", there is now window where the > directory temporarily has incorrect bits and hence if gitolite is > restarted during that time it will presumably fail. Could a > 'home-permission-bits' or such field be added instead to > to make things atomic? > That would be a nice improvement to backlog now that such a use case has emerged. However, I think for our immediate needs this one line patch, while imperfect, solves a longstanding problem adequately. So how about merging it, closing this bug, and opening a new bug for the system level improvement? - Dave > --000000000000b1d5d205e6e99fb7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Maxime,

On Tue, Aug 23, 2022, 8:41 AM Maxim= e Devos <maximedevos@telenet.b= e> wrote:

During "guix system reconfigure", there is now window where the <= br> directory temporarily has incorrect bits and hence if gitolite is
restarted during that time it will presumably fail.=C2=A0 Could a
'home-permission-bits' or such field be added instead to <user-a= ccount>
to make things atomic?

That would be a nice improvement to backlog now that = such a use case has emerged. However, I think for our immediate needs this = one line patch, while imperfect, solves a longstanding problem adequately. = So how about merging it, closing this bug, and opening a new bug for the sy= stem level improvement?

= - Dave
--000000000000b1d5d205e6e99fb7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 08:50:14 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 12:50:14 +0000 Received: from localhost ([127.0.0.1]:60323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeDW-0005Eu-8E for submit@debbugs.gnu.org; Mon, 29 Aug 2022 08:50:14 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:43719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeDT-0005Ee-TF for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 08:50:12 -0400 Received: by mail-lf1-f45.google.com with SMTP id v26so755030lfd.10 for <56444@debbugs.gnu.org>; Mon, 29 Aug 2022 05:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=V6Ysap1gZfkG3I1HLCtRactRnM+uX6dkOC4F9mlCWjI=; b=4wmOiqA58NrcAxOFreLOosv3cBj2w57JdNHoATZ5d94JligqRxSrLzD9/ItXNCtFCu wbTIDOFC4vROgN0Tgb9xAJ5LesbiFsTIML4x2U2+Gqh5mCr4xnlaK4uda2Ue31gqryPM R3FQ1U9DwTwLsl+WjG9nac20GvOnEIN9jDU18Q+Azx/DDosXHMeKdEqrXGTzBj1cgRJn GWi3f6jXgrKgZborV23wryhSb7yWj/vroI2pRTVgQxv3+NSDwra4OMiZqH6K+8CIfCym kFnhX230eqIrib3OTz0EodAs2ymwgZDUmDdqWpP+kh7ZKJiM7+rD8CghQ9tYo651oOQZ RdCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=V6Ysap1gZfkG3I1HLCtRactRnM+uX6dkOC4F9mlCWjI=; b=Kb9qie6HS1PRICTboYDYCPGa8eRleBR1bgGF2h8cq0G3unMhIkRVa8k8CG3jiopjl1 HjhJqm1wy37l3sQCVOiKvakHiygraQLiyazzM21FmjDEEkjZUuoyI1D79naB8wiNmbPL TGt+06NiEXJQvOvIMJW90O+l844iiWKdx/3Y7/XkBZy5E4OsRlrG/QSDnQVfiCV0OfvJ 2jaghGjLGCwmDAb2GCB3u70yhShf0bjLdT5k+Jbg7jonotV0xCavq/zb+lHoEjBiStGu p2qFTDV38x+wKYNCH2PXVoQOb7qsL+wAD2jqalrjdrzoVSB2ue0NI74Fprov3PoMkuVF JWOA== X-Gm-Message-State: ACgBeo2/hwNSpxwbdn88LwfxxCXHjQcpyK2nw/rJm68y4jTWwxG6zbkP ux1vh5vov5jKlFlDHi8zCeSaye4vEFgVhN4MEpJwRg== X-Google-Smtp-Source: AA6agR6lwV5MZVqlortQJXmAPwtLLLekwKoAHi0sHm/9XrRMoBGkW/at/WAEJhFhzd62SWRA6orKzthEvUVkDitEGBk= X-Received: by 2002:a05:6512:b12:b0:492:daa9:75ea with SMTP id w18-20020a0565120b1200b00492daa975eamr7172515lfu.297.1661777405976; Mon, 29 Aug 2022 05:50:05 -0700 (PDT) MIME-Version: 1.0 References: <87zghkehdd.fsf@pisemsky.com> In-Reply-To: From: "Thompson, David" Date: Mon, 29 Aug 2022 08:49:54 -0400 Message-ID: Subject: Re: bug#56444: Patch to fix Gitolite home directory permissions To: Maxime Devos Content-Type: multipart/alternative; boundary="000000000000fabb0e05e760b322" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000fabb0e05e760b322 Content-Type: text/plain; charset="UTF-8" Hi again Maxime, What do you think of my proposal? Do any other maintainers care to chime in here? - Dave On Tue, Aug 23, 2022 at 10:45 AM Thompson, David wrote: > Hi Maxime, > > On Tue, Aug 23, 2022, 8:41 AM Maxime Devos wrote: > >> >> During "guix system reconfigure", there is now window where the >> directory temporarily has incorrect bits and hence if gitolite is >> restarted during that time it will presumably fail. Could a >> 'home-permission-bits' or such field be added instead to >> to make things atomic? >> > > That would be a nice improvement to backlog now that such a use case has > emerged. However, I think for our immediate needs this one line patch, > while imperfect, solves a longstanding problem adequately. So how about > merging it, closing this bug, and opening a new bug for the system level > improvement? > > - Dave > --000000000000fabb0e05e760b322 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi again Maxime,

What do you= think of my proposal?=C2=A0 Do any other maintainers care to chime in here= ?

- Dave

<= div dir=3D"ltr" class=3D"gmail_attr">On Tue, Aug 23, 2022 at 10:45 AM Thomp= son, David <dthompson2@worce= ster.edu> wrote:
Hi Maxime,
=
On Tue, Aug 23, 2022, 8:41 = AM Maxime Devos <maximedevos@telenet.be> wrote:

During "guix system reconfigure", there is now window where the <= br> directory temporarily has incorrect bits and hence if gitolite is
restarted during that time it will presumably fail.=C2=A0 Could a
'home-permission-bits' or such field be added instead to <user-a= ccount>
to make things atomic?

That would be a nice improvement to backlog now that = such a use case has emerged. However, I think for our immediate needs this = one line patch, while imperfect, solves a longstanding problem adequately. = So how about merging it, closing this bug, and opening a new bug for the sy= stem level improvement?

= - Dave
=C2=A0
--000000000000fabb0e05e760b322-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 08:52:51 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 12:52:51 +0000 Received: from localhost ([127.0.0.1]:60328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeG2-0005Ie-SQ for submit@debbugs.gnu.org; Mon, 29 Aug 2022 08:52:51 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:48166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeG0-0005IV-2f for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 08:52:49 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by xavier.telenet-ops.be with bizsmtp id DQse2800H20ykKC01QseZT; Mon, 29 Aug 2022 14:52:40 +0200 Message-ID: <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> Date: Mon, 29 Aug 2022 14:52:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: bug#56444: Patch to fix Gitolite home directory permissions Content-Language: en-US To: "Thompson, David" References: <87zghkehdd.fsf@pisemsky.com> From: Maxime Devos In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------uDThRSpKvZyC6D4Fg0IO1dxY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661777560; bh=JS7PNur7trZHupt2xvJCfKRIlV5lqRlMY+dVEPGWFmA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=D2cR6vhEpp0ZPXn4wO4gwbsLnrNmeHVzZyjOaNbfVKUSziEu7bG63jtFEWQUHRr8o XYS9y/f2DcOzlOkFQkGtdpDKIN+hdLET6ZmmF8Xw13aL1sPhKFQlJ0609sV9h3dDe0 Ft7wQuBR1lrLi2Z4NJAc2MqqiBL55/M1qI5ye72+wGCKlGjC/SPy7WHkpUAHP8hpha X+jEEIRzae+yyWU9SL7JXeU08Ro4EtksMFSRwAT2dXj+e1wZDLnLKCzYcmC2ZIAhyl N9hZnzGBfxD5b9q4UX3u6d/DjzfND+dHucrcNVA0Qn3qaw4zTAxlEwnYJmbFrEF8Af gBvveypLwMxEw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------uDThRSpKvZyC6D4Fg0IO1dxY Content-Type: multipart/mixed; boundary="------------IqMDe4jfI70k9AmOuraE0GUQ"; protected-headers="v1" From: Maxime Devos To: "Thompson, David" Cc: 56444@debbugs.gnu.org Message-ID: <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> Subject: Re: bug#56444: Patch to fix Gitolite home directory permissions References: <87zghkehdd.fsf@pisemsky.com> In-Reply-To: --------------IqMDe4jfI70k9AmOuraE0GUQ Content-Type: multipart/mixed; boundary="------------u5H1GK9epxkFttZF5ENFUWKL" --------------u5H1GK9epxkFttZF5ENFUWKL Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyOS0wOC0yMDIyIDE0OjQ5LCBUaG9tcHNvbiwgRGF2aWQgd3JvdGU6DQo+IEhpIGFn YWluIE1heGltZSwNCj4NCj4gV2hhdCBkbyB5b3UgdGhpbmsgb2YgbXkgcHJvcG9zYWw/wqAg RG8gYW55IG90aGVyIG1haW50YWluZXJzIGNhcmUgdG8gDQo+IGNoaW1lIGluIGhlcmU/DQo+ DQo+IC0gRGF2ZQ0KDQpCYWNrbG9nZ2VkIHRoaW5nIGhhdmUgYSB0ZW5kZW5jeSB0byBiZSBi YWNrbG9nZ2VkIGluZGVmaW5pdGVseSwgYW5kIG15IA0KcHJvcG9zYWwgZm9yIGEgaG9tZS1w ZXJtaXNzaW9ucy1iaXRzIHNlZW1zIHN0cmFpZ2h0Zm9yd2FyZCBhbmQgc2ltcGxlIHRvIA0K bWUsIHNvIEkgd291bGQgcmF0aGVyIG5vdCB0cmFkZSBhIGJ1ZyBmb3IgYW5vdGhlciBidWcg YnV0IHJhdGhlciBkbyBhIA0KcHJvcGVyIGZpeC4NCg0KR3JlZXRpbmdzLA0KTWF4aW1lLg0K --------------u5H1GK9epxkFttZF5ENFUWKL Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------u5H1GK9epxkFttZF5ENFUWKL-- --------------IqMDe4jfI70k9AmOuraE0GUQ-- --------------uDThRSpKvZyC6D4Fg0IO1dxY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwy2lgUDAAAAAAAKCRBJ4+4iGRcl7gXh APwNr76eeOZK3iQShcg26LSXYERevAqqATPZHIlpm0hrnAD6AwcL6g2xTts1KcdRTRmYikpRMZh6 sgfRGaxQkN+r1Qs= =A1Zj -----END PGP SIGNATURE----- --------------uDThRSpKvZyC6D4Fg0IO1dxY-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 08:58:11 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 12:58:11 +0000 Received: from localhost ([127.0.0.1]:60332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeLC-0005QN-It for submit@debbugs.gnu.org; Mon, 29 Aug 2022 08:58:10 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:37671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeLA-0005QA-LZ for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 08:58:09 -0400 Received: by mail-lj1-f171.google.com with SMTP id x10so7952370ljq.4 for <56444@debbugs.gnu.org>; Mon, 29 Aug 2022 05:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=vJZPJ+0eN6503yyJJVaxBxVoqGMEulv5dHGLEniUoWg=; b=LUjzmeXUbnhSv10vHM7I7rppgZQv7bABLSJHEc603iez8m34MGYRogEB0oczM3o8Hm lmNuseScxqzik0aMuQQgfuGdY82BTB07FJxD6W1Ly3DoJQzHrFFb0PCJAS7EEUsQLw12 tpUUWHNqq6Av34pk6UhvzDj+rwmW60KDfBoEutOkAg7qFy8Bdq0D/sQV5Q6ZbQbwgkKi ZC8wiccjazemP+nyHGe1ES6FpVnrZN0uHxGb7lUiGZCFDZIr/XJagzlqZm0XaQCL5D2n NGpHoiN56X4bG1P5YZtZq3M/dKlT7uiNyytyCjP5y5NcgSpMwIIxgh8bZ+gdT7i17kkq GKZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=vJZPJ+0eN6503yyJJVaxBxVoqGMEulv5dHGLEniUoWg=; b=nKaFD2V8voHZVYIVt7ywcAzuEfggYkAQhLhAWlcC3sYxix5J+kWF6vSlwpSS4ztc2U CTv79vYUWmaVFr1OY1r8lkYHrP9NicHSskwgpth7MSXUtpYbHUsgdqbtuGYc7nrzoIzT UaYNGfGMMerzdaQwzrL/5nI8BGDf7idIffehcrtC/IMtpwXR3RGS4Ewr56rJnJ7l70ut LWHdjZtrpGPIQUC7NiWeT0b+bn7qKQIjewShMo5CPOGcj3rH3+0lq7FW4obU6FylXRgT cnM/UycR7zprAmU6qZSVEKitTN1Og+POyhwm4F/8gzHWOT9gXMEo0cmcissVNF7cHdrH 8+4g== X-Gm-Message-State: ACgBeo38ZQSau7FQacSDJ4VOT6ysppTxYMzsCJR4QJ87eyyi8al6vhwf UqgifcsNO5XoNH8Ppbl/Q199ew5lyiToJmOslOuLJw== X-Google-Smtp-Source: AA6agR4h+15KkpMrdG57frSNPjxn1sUvqion2w7cJQa7V5hED21dFdKc2O0XmPw2WSZTB8Rj0m2V0RxYUO5urN+qNts= X-Received: by 2002:a05:651c:158c:b0:250:a23d:2701 with SMTP id h12-20020a05651c158c00b00250a23d2701mr6147738ljq.475.1661777882656; Mon, 29 Aug 2022 05:58:02 -0700 (PDT) MIME-Version: 1.0 References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> In-Reply-To: <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> From: "Thompson, David" Date: Mon, 29 Aug 2022 08:57:51 -0400 Message-ID: Subject: Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions To: Maxime Devos Content-Type: multipart/alternative; boundary="00000000000064529e05e760d054" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000064529e05e760d054 Content-Type: text/plain; charset="UTF-8" Hi Maxime, I disagree. I believe we shouldn't let perfect be the enemy of the good. I haven't sent patches to Guix in quite some time, but I've never felt roadblocked like this and it is concerning to me. Can any other maintainers please chime in here? - Dave On Mon, Aug 29, 2022 at 8:52 AM Maxime Devos wrote: > > On 29-08-2022 14:49, Thompson, David wrote: > > Hi again Maxime, > > > > What do you think of my proposal? Do any other maintainers care to > > chime in here? > > > > - Dave > > Backlogged thing have a tendency to be backlogged indefinitely, and my > proposal for a home-permissions-bits seems straightforward and simple to > me, so I would rather not trade a bug for another bug but rather do a > proper fix. > > Greetings, > Maxime. > --00000000000064529e05e760d054 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Maxime,

I disagree.=C2=A0= I believe we shouldn't let perfect be the enemy of the good.=C2=A0 I h= aven't sent patches to Guix in quite some time, but I've never felt= roadblocked like this and it is concerning to me.

=
Can any other maintainers please chime in here?

- Dave

On Mon, Aug 29, 2022 at 8:52 AM Maxime Devos <maximedevos@telenet.be> wrote:

On 29-08-2022 14:49, Thompson, David wrote:
> Hi again Maxime,
>
> What do you think of my proposal?=C2=A0 Do any other maintainers care = to
> chime in here?
>
> - Dave

Backlogged thing have a tendency to be backlogged indefinitely, and my
proposal for a home-permissions-bits seems straightforward and simple to me, so I would rather not trade a bug for another bug but rather do a
proper fix.

Greetings,
Maxime.
--00000000000064529e05e760d054-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 09:09:29 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 13:09:29 +0000 Received: from localhost ([127.0.0.1]:60358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeW9-0005jU-5w for submit@debbugs.gnu.org; Mon, 29 Aug 2022 09:09:29 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:57962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeW7-0005jK-Bh for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 09:09:28 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by andre.telenet-ops.be with bizsmtp id DR9P2800E20ykKC01R9P8W; Mon, 29 Aug 2022 15:09:25 +0200 Message-ID: <6f2e7dc5-ec09-b75d-24de-a7858cbd4b4b@telenet.be> Date: Mon, 29 Aug 2022 15:09:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: "Thompson, David" References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> From: Maxime Devos Subject: Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------1ng0fKn0PULirraxARrUbDC6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661778565; bh=HDbVu5o3I525b+smrpon4D3bnPDHOnWMZ0C+E9L0fTk=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=exQGYeOHqWn+4STp2bxXXzYAWID0Xn0ApcsOr1OLrpQYKWcSu+u9Hd0JEDfsmsi8m 4zybGiykEAa5Sn3y9uvtGnH2hY4aBoPAz/jeyu0EHlq9d/SOhxvv7WDJw2f2Pw6odi vWFAO5YeOUlFetT/f1R0cTWX4aertkKOZHegu60HDUyXNL3XcuZeykBXi3CFSWOWWB xNokQUucmMUXKtiwxbVOXcV+ybAArt3Cvikgf23zN3wD+kH35F1d1pVNPpHHDyeIYI z2CoJJf4+Q1eY/iFggDmcOGGGcx3TYIqJIq2nt68brFh+vlM6GzTR47uQPnw/d3Ozw oNpUv7pHyHNcw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------1ng0fKn0PULirraxARrUbDC6 Content-Type: multipart/mixed; boundary="------------96yVciiMI3qjWkPYkSO4VS0O"; protected-headers="v1" From: Maxime Devos To: "Thompson, David" Cc: 56444@debbugs.gnu.org Message-ID: <6f2e7dc5-ec09-b75d-24de-a7858cbd4b4b@telenet.be> Subject: Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> In-Reply-To: --------------96yVciiMI3qjWkPYkSO4VS0O Content-Type: multipart/mixed; boundary="------------DCJvzFfF0OL8E0gws4CGGY0x" --------------DCJvzFfF0OL8E0gws4CGGY0x Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyOS0wOC0yMDIyIDE0OjU3LCBUaG9tcHNvbiwgRGF2aWQgd3JvdGU6DQo+IEhpIE1h eGltZSwNCj4NCj4gSSBkaXNhZ3JlZS7CoCBJIGJlbGlldmUgd2Ugc2hvdWxkbid0IGxldCBw ZXJmZWN0IGJlIHRoZSBlbmVteSBvZiB0aGUgDQo+IGdvb2QuwqAgSSBoYXZlbid0IHNlbnQg cGF0Y2hlcyB0byBHdWl4IGluIHF1aXRlIHNvbWUgdGltZSwgYnV0IEkndmUgDQo+IG5ldmVy IGZlbHQgcm9hZGJsb2NrZWQgbGlrZSB0aGlzIGFuZCBpdCBpcyBjb25jZXJuaW5nIHRvIG1l Lg0KDQpJdCdzIGFsbW9zdCB0cml2aWFsIHRvIGltcGxlbWVudCAndGhlIHBlcmZlY3QnIGhl cmUsIGFsbW9zdCBubyBtb3JlIA0KZWZmb3J0IHRoYW4geW91ciBwYXJ0aWFsIHNvbHV0aW9u OyB0aGVyZSBpcyBubyAicGVyZmVjdCBlbmVteSBvZiB0aGUgDQpnb29kIiBzaXR1YXRpb24g aGVyZSAtLSAicGVyZmVjdCBlbmVteSBvZiB0aGUgZ29vZCIgb25seSBhcHBsaWVzIHdoZW4g DQoidGhlIHBlcmZlY3QiIGlzIHNpZ25pZmljYW50bHkgaGFyZGVyIC8gbW9yZSBlZmZvcnQg dGhhbiAidGhlIGdvb2QiLCBidXQgDQp0aGF0J3Mgbm90IHRoZSBjYXNlIGhlcmUuDQoNCkdp dmVuIHRoYXQgYSBwcm9wZXIgZml4IGlzIHZlcnkgZWFzeSwgc2ltcGxlIGFuZCBsb3ctZWZm b3J0IGFuZCANCmZ1cnRoZXJtb3JlLCBpdCBpcyBldmVuIGtub3duIHdoYXQgZm9ybSB0aGUg cHJvcGVyIGZpeCB3b3VsZCB0YWtlIChzZWU6IA0KZXh0cmEgZmllbGQsICsgYWRqdXN0IHBy b2NlZHVyZSBpbiAoZ251IGJ1aWxkIGFjdGl2YXRpb24pIHNsaWdodGx5KSwgDQp0aGVyZSBh cmVuJ3QgYW55IHJvYWRibG9ja3MgZXhjZXB0IGZvciBhbiBhcHBhcmVudCByZWZ1c2FsIGJ5 IHlvdSB0byANCmludmVzdCBhIGxpdHRsZSBleHRyYSBlZmZvcnQuDQoNCklmIHlvdSBnZW51 aW5lbHkgZmluZCBpdCBhY3R1YWxseSBoYXJkIHRvIGltcGxlbWVudCwgcGxlYXNlIHRlbGwg c28gYW5kIA0KSSBjYW4gZ2l2ZSB5b3Ugc29tZSBwb2ludGVycyBvbiB3aGF0IHByb2NlZHVy ZXMgYXBwZWFyIHRvIGJlIG5lZWQgdG8gYmUgDQptb2RpZmllZC4gQ3VycmVudGx5LCB5b3Vy IHJlc3BvbnNlIGFwcGVhcnMgdG8gYmUgbWFkZSBpbiBiYWQgZmFpdGggdCBtZS4NCg0KR3Jl ZXRpbmdzLA0KTWF4aW1lDQoNCg== --------------DCJvzFfF0OL8E0gws4CGGY0x Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------DCJvzFfF0OL8E0gws4CGGY0x-- --------------96yVciiMI3qjWkPYkSO4VS0O-- --------------1ng0fKn0PULirraxARrUbDC6 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwy6gwUDAAAAAAAKCRBJ4+4iGRcl7oFL AQDx4LxnzgEqSvmGZEKHJAr06S43djZ9UvI34cWkOq4XRQEAthmKspAafal759pVnXlSA2m9SqqQ aWbGtp0e6ZCVfw8= =3RXl -----END PGP SIGNATURE----- --------------1ng0fKn0PULirraxARrUbDC6-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 09:11:22 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 13:11:23 +0000 Received: from localhost ([127.0.0.1]:60363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeXy-0005mj-Kx for submit@debbugs.gnu.org; Mon, 29 Aug 2022 09:11:22 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:34844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSeXw-0005ma-IU for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 09:11:21 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by baptiste.telenet-ops.be with bizsmtp id DRBK2800220ykKC01RBKLh; Mon, 29 Aug 2022 15:11:19 +0200 Message-ID: <1178eeff-1c98-ebbc-3b29-95dc49debe33@telenet.be> Date: Mon, 29 Aug 2022 15:11:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions Content-Language: en-US To: "Thompson, David" References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> From: Maxime Devos In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------r7O8ioJqCA2Rgedqh2ktM4ZE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661778679; bh=HErg1k6Vd7Y3lEuBxfXrEkhUnm8Zo9rpRBxvubaj5ko=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=X3Z8ja2p3EIxNcRWODPSoPzaXeTfjJvZttY1zUdJRX29zJqjvUwB2p811Qfv0HRGU sDBhrSnMoRbk2Yg+TWI66EwBZpXGQf01SO1jj/kHZUJH68iBObVY8j7KoHhBWAT6LD 2fNcQFAoACGYIlG/AlbWBS0tYsOadcO/p5cmEKvSjEaXDusyq8/ZariyyuCMsq8n8r 7nXX6lI3j2ZNDqES8KV31Q8OailycR6NWKWbMZm+FJ67g7XE0//q+A1zsK4WQ1dA99 2j3Ykj4sOvh54AS3fmUHvpH/OVG+ICCMUs7Dyp4v0xDdwszpl8Br46iIbBXPG4XGhl FEQHsABK2f4zA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------r7O8ioJqCA2Rgedqh2ktM4ZE Content-Type: multipart/mixed; boundary="------------FM0OMcVpTSIEW1YXQYKWs6So"; protected-headers="v1" From: Maxime Devos To: "Thompson, David" Cc: 56444@debbugs.gnu.org Message-ID: <1178eeff-1c98-ebbc-3b29-95dc49debe33@telenet.be> Subject: Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> In-Reply-To: --------------FM0OMcVpTSIEW1YXQYKWs6So Content-Type: multipart/mixed; boundary="------------3kTmara9hRZWxXZXdVdj071A" --------------3kTmara9hRZWxXZXdVdj071A Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyOS0wOC0yMDIyIDE0OjU3LCBUaG9tcHNvbiwgRGF2aWQgd3JvdGU6DQo+IFsuLi5d DQo+IENhbiBhbnkgb3RoZXIgbWFpbnRhaW5lcnMgcGxlYXNlIGNoaW1lIGluIGhlcmU/DQoN ClRvIGNvcnJlY3QgYSBtaXN1bmRlcnN0YW5kaW5nLCBJJ20gbm90IGEgbWFpbnRhaW5lciwg YXQgbGVhc3QgaWYgeW91IA0KbWVhbnQgIm1haW50YWluZXIiIGluIHRoZSBzYW1lIHNlbnNl IGFzIHVzZWQgYXQgDQo8aHR0cHM6Ly9ndWl4LmdudS5vcmcvZW4vYmxvZy8yMDIyL2dudS1n dWl4LW1haW50YWluZXItcm90YXRpb24vPi4NCg0KR3JlZXRpbmdzLA0KTWF4aW1lDQoNCg0K --------------3kTmara9hRZWxXZXdVdj071A Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------3kTmara9hRZWxXZXdVdj071A-- --------------FM0OMcVpTSIEW1YXQYKWs6So-- --------------r7O8ioJqCA2Rgedqh2ktM4ZE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwy69wUDAAAAAAAKCRBJ4+4iGRcl7oiZ APsFpaqQiFUBT1Dz9J3aZNs339udbNBZ6dB27HXBCxHtXwD+PmBdCLXSfCnV1mJYipMSsIXpF7TE LFDcNh6qGefZKgs= =qAM6 -----END PGP SIGNATURE----- --------------r7O8ioJqCA2Rgedqh2ktM4ZE-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 09:19:55 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 13:19:55 +0000 Received: from localhost ([127.0.0.1]:60379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSegF-0008Am-B9 for submit@debbugs.gnu.org; Mon, 29 Aug 2022 09:19:55 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:49086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSegC-0008Ac-H3 for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 09:19:53 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by baptiste.telenet-ops.be with bizsmtp id DRKp2800520ykKC01RKpfh; Mon, 29 Aug 2022 15:19:51 +0200 Message-ID: <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> Date: Mon, 29 Aug 2022 15:19:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions Content-Language: en-US To: "Thompson, David" References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> From: Maxime Devos In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------XGL1lt9YSbFmRGzNmzD0JJxA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661779191; bh=omRCFO0r/PkFuhcxo4QGcFAK9ahwzdEk5zg+7AuEkCo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=UauVFgr9IlzMP8FJ1hSa6vAuUJ6vmO3gylCWvDlqM/8dhc1bn0A82IrgJxkX78fJB m1KQRmxsKAQj3VtByS3FtCdrP+g1+i0D+KItyDb1bh/Uyx44kmjV7m6VvdfXPVT+Dq K5ORWgLHLwnmT5uLbIr2cAtuRfQu1HDWvDHKGoyw1a/GiQfEH0ZzG1mYMOSH/GbNZ6 sK+3irrpYye7bExlckKzMn4p3GBVmWv9UE5F9uyRZEGfhyNfaSJCAtt3mI/vR5DKqj E/f30MaV7CTgsgxpbeIT1b68wZvl7ha+nBorMOFgQvDrXesZjBuolKzVUphZ7Ci15w mX56Muwn4Zm7w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------XGL1lt9YSbFmRGzNmzD0JJxA Content-Type: multipart/mixed; boundary="------------wmT0hRFX2DmoiDEMATD9kttL"; protected-headers="v1" From: Maxime Devos To: "Thompson, David" Cc: 56444@debbugs.gnu.org Message-ID: <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> Subject: Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> In-Reply-To: --------------wmT0hRFX2DmoiDEMATD9kttL Content-Type: multipart/mixed; boundary="------------47BprSMONX2QGfDfBwkMt787" --------------47BprSMONX2QGfDfBwkMt787 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjktMDgtMjAyMiAxNDo1NywgVGhvbXBzb24sIERhdmlkIHdyb3RlOg0KDQo+IEkgZGlz YWdyZWUuwqAgSSBiZWxpZXZlIHdlIHNob3VsZG4ndCBsZXQgcGVyZmVjdCBiZSB0aGUgZW5l bXkgb2YgdGhlIGdvb2QuDQoNCkkgZG9uJ3QgdGhpbmsgeW91ciBwYXRjaCBjb3VudHMgYXMg Imdvb2QiIGhlcmUgLS0gd2hpbGUgZml4aW5nIHRoZSBidWcgDQpjb3VudHMgYXMgImdvb2Qi LCB5b3UgYXJlIGF0IHRoZSBzYW1lIHRpbWUgaW50cm9kdWNpbmcgYSBuZXcgYnVnICh0aGUg DQpub24tYXRvbWljaXR5KSwgd2hpY2ggaXMgYmFkLsKgIFlvdSB3b3VsZCBoYXZlIHRvIHdl aWdoIHRoZSBnb29kbmVzcyBhbmQgDQp0aGUgYmFkbmVzcyB0byBlbmQgdXAgd2l0aCBhbiBv dmVyYWxsICJnb29kIiAob3IgbWF5YmUgImJhZCIsIGRlcGVuZGluZyANCm9uIHRoZSBjb25j bHVzaW9uKSwgYnV0IEknZCB0aGluayB0aGF0IHRoZSB0aW1lIHJlcXVpcmVkIHRvIGRvIHN1 Y2ggYSANCndlaWdoaW5nIGlzIGJldHRlciBzcGVudCBieSBkb2luZyBhIHRpbnkgYml0IG9m IGV4dHJhIGVmZm9ydCB0byANCmltcGxlbWVudCB0aGUgbmV3IGZpZWxkIChpdCBzaG91bGQg YmUgdmVyeSBsb3cgZWZmb3J0LCBzZWUgb3RoZXIgcmVzcG9uc2UpLg0KDQpHcmVldGluZ3Ms DQpNYXhpbWUuDQo= --------------47BprSMONX2QGfDfBwkMt787 Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------47BprSMONX2QGfDfBwkMt787-- --------------wmT0hRFX2DmoiDEMATD9kttL-- --------------XGL1lt9YSbFmRGzNmzD0JJxA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwy89QUDAAAAAAAKCRBJ4+4iGRcl7rbO AP4i/AvX3/4/YL9AQJTs/wiAmuqKHVyQqkxby/OKs5nxVQD/bMW4lx56fn+YK6QeS0DmQhmvtUQR XjokJHn7WVbPNgA= =tpG5 -----END PGP SIGNATURE----- --------------XGL1lt9YSbFmRGzNmzD0JJxA-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 09:31:18 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 13:31:18 +0000 Received: from localhost ([127.0.0.1]:60413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSerF-0008Tk-B6 for submit@debbugs.gnu.org; Mon, 29 Aug 2022 09:31:17 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:33531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSerD-0008TV-QI for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 09:31:16 -0400 Received: by mail-lf1-f45.google.com with SMTP id br21so5398347lfb.0 for <56444@debbugs.gnu.org>; Mon, 29 Aug 2022 06:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=cEgIJHmA9V0b0+Q4pr8vB2ZuUfDX8GL1P9hzxLOKG0Y=; b=sX/fjT0jfT58dbEAj4HlPPpGRvws1qexLx3OJvprjtU8swFuBeVgoCjKYIUiSg09Cs BZ6scz9tuAXwTedhJmUTaBOy2Y1AD5UZrIgkDQsmMlM5S/VdUFhyTa5aHTvVzUoSE5Zh CGT4c4M9BTC7MQ19h7z16a5zHgwK5LS9zO6iJBtCc43LSpRiPtDSJpSceEyf2m9804l6 TjxqOaYfvS4rsKXnkwK0R3+Mjyt1aFoP/fzcwsB0pxs182JXqsBeMCgJ0jitcmtzVzCz Cj4Gfut0nX/OIpk+flfxuGNa+f15cHZAEDWfUIEe/G6gRIVNgcFMSVkP+3JNvYrvdBoi /lXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=cEgIJHmA9V0b0+Q4pr8vB2ZuUfDX8GL1P9hzxLOKG0Y=; b=o7kfJithyZG4swR6tc8qzk/hVvIM44RGzeOeJDEGvgtl70uVgwRv4wYz9SsjuhZWts yAuPdkwllB8haOmYFGRruFSjoGtw/PCPXqfV2rThDDaePSWddm0G/Og2qGyyswWFDajf r1XOe/L10X40cIaBJOeRgdBxs+B1y90D3DmARE/XdqfWCbfnDXzlixe5N+GQJTUTlPPZ obZMndMwThDiC0L0miKjAc3+7z/etog9FdjHMBtumzztF5AsGp3cFN8c95tQV46dsKGL DZEvmHCAAOgkUyhMqd/oWeGbH3LByrPAhz6Qq1cK/oknluQvS8msdvGqp2JuQ8CyihWa 4pYg== X-Gm-Message-State: ACgBeo34WRUBYSrY0Tk0xlnS6gym+dtAG3UQDbLcb7fgP9hfmn2dYwd2 ir57qBKhelSqMSkd1bdXj22aLhM/UcCGOw+HfSWjDQ== X-Google-Smtp-Source: AA6agR7rOAyzuUoamebtO0PBcSStABLmQnMfPtYL4ni4rtvS0LgKwaN3mfJn8B7UtPmIonpPtdCFmldu/lrwZPi2FxI= X-Received: by 2002:ac2:5e8c:0:b0:494:6d14:f16e with SMTP id b12-20020ac25e8c000000b004946d14f16emr1414072lfq.316.1661779869644; Mon, 29 Aug 2022 06:31:09 -0700 (PDT) MIME-Version: 1.0 References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> In-Reply-To: <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> From: "Thompson, David" Date: Mon, 29 Aug 2022 09:30:58 -0400 Message-ID: Subject: Re: [EXT] Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions To: Maxime Devos Content-Type: multipart/alternative; boundary="000000000000d35cde05e76146f3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000d35cde05e76146f3 Content-Type: text/plain; charset="UTF-8" On Mon, Aug 29, 2022 at 9:19 AM Maxime Devos wrote: > On 29-08-2022 14:57, Thompson, David wrote: > > > I disagree. I believe we shouldn't let perfect be the enemy of the good. > > I don't think your patch counts as "good" here -- while fixing the bug > counts as "good", you are at the same time introducing a new bug (the > non-atomicity), which is bad. You would have to weigh the goodness and > the badness to end up with an overall "good" (or maybe "bad", depending > on the conclusion), but I'd think that the time required to do such a > weighing is better spent by doing a tiny bit of extra effort to > implement the new field (it should be very low effort, see other response). > My patch has a very limited scope of only changing the gitolite service. Your proposal has a much greater scope of modifying a core structure used for system configuration. The new bug you mention is only bad in a theoretical sense. In practice, the permission bits are misconfigured for a blip of time during system reconfiguration, which is a lot better than being misconfigured all the time which is the status quo. It's the difference between a gitolite that works nicely with cgit/gitweb and one that doesn't. I agree that it's a good goal to improve atomicity and I think making more general to allow for different permission bits on the home directory is a good idea, but I see it as one step removed from fixing this particular bug. My patch follows the recommended approach outlined in a comment in (gnu build activation) written by Ludovic in 2019: ;; Always set ownership and permissions for home directories of system ;; accounts. If a service needs looser permissions on its home ;; directories, it can always chmod it in an activation snippet. - Dave --000000000000d35cde05e76146f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, Aug 29, 2022 at 9:19 AM Maxime Devos <maximedevos@telenet.be> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">On 29-08-2022 14:57, Thomp= son, David wrote:

> I disagree.=C2=A0 I believe we shouldn't let perfect be the enemy = of the good.

I don't think your patch counts as "good" here -- while fixin= g the bug
counts as "good", you are at the same time introducing a new bug = (the
non-atomicity), which is bad.=C2=A0 You would have to weigh the goodness an= d
the badness to end up with an overall "good" (or maybe "bad&= quot;, depending
on the conclusion), but I'd think that the time required to do such a <= br> weighing is better spent by doing a tiny bit of extra effort to
implement the new field (it should be very low effort, see other response).=

My patch has a very limited scope of o= nly changing the gitolite service.=C2=A0 Your proposal has a much greater s= cope of modifying a core structure used for system configuration.=C2=A0 The= new bug you mention is only bad in a theoretical sense.=C2=A0 In practice,= the permission bits are misconfigured for a blip of time during system rec= onfiguration, which is a lot better than being misconfigured all the time w= hich is the status quo.=C2=A0 It's the difference between a gitolite th= at works nicely with cgit/gitweb and one that doesn't. I agree that it&= #39;s a good goal to improve atomicity and I think making <user-account&= gt; more general to allow for different permission bits on the home directo= ry is a good idea, but I see it as one step removed from fixing this partic= ular bug.=C2=A0 My patch follows the recommended approach outlined in a com= ment in (gnu build activation) written by Ludovic in 2019:

=C2=A0 =C2=A0 =C2=A0 ;; Always set ownership and permissions for h= ome directories of system
=C2=A0 =C2=A0 =C2=A0 ;; accounts.=C2=A0 If a s= ervice needs looser permissions on its home
=C2=A0 =C2=A0 =C2=A0 ;; dire= ctories, it can always chmod it in an activation snippet.
- Dave
--000000000000d35cde05e76146f3-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 09:44:29 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 13:44:29 +0000 Received: from localhost ([127.0.0.1]:60441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSf40-0000OF-Fm for submit@debbugs.gnu.org; Mon, 29 Aug 2022 09:44:29 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:48518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSf3x-0000O5-K9 for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 09:44:26 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by xavier.telenet-ops.be with bizsmtp id DRkN2800A20ykKC01RkN6i; Mon, 29 Aug 2022 15:44:24 +0200 Message-ID: <6229fb3c-5966-aa18-d691-3d31c7335315@telenet.be> Date: Mon, 29 Aug 2022 15:44:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: "Thompson, David" References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> From: Maxime Devos Subject: Re: [EXT] Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------zAbgOaazcGoTL00Cyawb1f6J" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661780664; bh=xDr1ep2b2evm5rtDrS8JrnSoGqlSVrqu4f3G2RnjV/4=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=bsTYzRg0CVp8BXmhHmvr7WOBkrDwAGCdJx7vIuZqhZDULNcTZTlxAIHq38tdJ6b2N uzoU4HFxDkaPlFs1ht50MSfdDt2j95nNvtJ/lx1oXDovKNGi9gtS+TMDUZBVktOmu/ 1H1WBkNSc72MB1Lb4Ppv+EezZ4OdQfgV0HDmvqSF7OfoUItLRMQYuyhK4Ggc12HpBa 74sDPhCezAS0nsr9T7I8IpCcI6x2sdyL2MRDTEwaFU+kgbF/gSbFH1CTIG9Y619kUj Pc3rb5NVFyI2iRXVKgTYSci1+FIAwjQm9KSn+ApSfN68j274p8fwKjJ74ABkem2NTY 75MArDo6rSX5Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------zAbgOaazcGoTL00Cyawb1f6J Content-Type: multipart/mixed; boundary="------------hW994d0Nv0SjUx58WlFeld7Q"; protected-headers="v1" From: Maxime Devos To: "Thompson, David" Cc: 56444@debbugs.gnu.org Message-ID: <6229fb3c-5966-aa18-d691-3d31c7335315@telenet.be> Subject: Re: [EXT] Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> In-Reply-To: --------------hW994d0Nv0SjUx58WlFeld7Q Content-Type: multipart/mixed; boundary="------------xuH0si8v0jA4ysPawXtL4pwW" --------------xuH0si8v0jA4ysPawXtL4pwW Content-Type: multipart/alternative; boundary="------------bsDNfb7hrTl0fiXdURqteMs4" --------------bsDNfb7hrTl0fiXdURqteMs4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyOS0wOC0yMDIyIDE1OjMwLCBUaG9tcHNvbiwgRGF2aWQgd3JvdGU6DQo+DQo+IE9u IE1vbiwgQXVnIDI5LCAyMDIyIGF0IDk6MTkgQU0gTWF4aW1lIERldm9zIDxtYXhpbWVkZXZv c0B0ZWxlbmV0LmJlPiANCj4gd3JvdGU6DQo+DQo+ICAgICBPbiAyOS0wOC0yMDIyIDE0OjU3 LCBUaG9tcHNvbiwgRGF2aWQgd3JvdGU6DQo+DQo+ICAgICA+IEkgZGlzYWdyZWUuwqAgSSBi ZWxpZXZlIHdlIHNob3VsZG4ndCBsZXQgcGVyZmVjdCBiZSB0aGUgZW5lbXkgb2YNCj4gICAg IHRoZSBnb29kLg0KPg0KPiAgICAgSSBkb24ndCB0aGluayB5b3VyIHBhdGNoIGNvdW50cyBh cyAiZ29vZCIgaGVyZSAtLSB3aGlsZSBmaXhpbmcgdGhlDQo+ICAgICBidWcNCj4gICAgIGNv dW50cyBhcyAiZ29vZCIsIHlvdSBhcmUgYXQgdGhlIHNhbWUgdGltZSBpbnRyb2R1Y2luZyBh IG5ldyBidWcgKHRoZQ0KPiAgICAgbm9uLWF0b21pY2l0eSksIHdoaWNoIGlzIGJhZC7CoCBZ b3Ugd291bGQgaGF2ZSB0byB3ZWlnaCB0aGUNCj4gICAgIGdvb2RuZXNzIGFuZA0KPiAgICAg dGhlIGJhZG5lc3MgdG8gZW5kIHVwIHdpdGggYW4gb3ZlcmFsbCAiZ29vZCIgKG9yIG1heWJl ICJiYWQiLA0KPiAgICAgZGVwZW5kaW5nDQo+ICAgICBvbiB0aGUgY29uY2x1c2lvbiksIGJ1 dCBJJ2QgdGhpbmsgdGhhdCB0aGUgdGltZSByZXF1aXJlZCB0byBkbyBzdWNoIGENCj4gICAg IHdlaWdoaW5nIGlzIGJldHRlciBzcGVudCBieSBkb2luZyBhIHRpbnkgYml0IG9mIGV4dHJh IGVmZm9ydCB0bw0KPiAgICAgaW1wbGVtZW50IHRoZSBuZXcgZmllbGQgKGl0IHNob3VsZCBi ZSB2ZXJ5IGxvdyBlZmZvcnQsIHNlZSBvdGhlcg0KPiAgICAgcmVzcG9uc2UpLg0KPg0KPg0K PiBNeSBwYXRjaCBoYXMgYSB2ZXJ5IGxpbWl0ZWQgc2NvcGUgb2Ygb25seSBjaGFuZ2luZyB0 aGUgZ2l0b2xpdGUgDQo+IHNlcnZpY2UuwqAgWW91ciBwcm9wb3NhbCBoYXMgYSBtdWNoIGdy ZWF0ZXIgc2NvcGUgb2YgbW9kaWZ5aW5nIGEgY29yZSANCj4gc3RydWN0dXJlIHVzZWQgZm9y IHN5c3RlbSBjb25maWd1cmF0aW9uLg0KSXQgaXMgYSBncmVhdGVyIHNjb3BlLCBidXQgaXQn cyBub3QgcmVhbGx5IG1vcmUgZWZmb3J0Lg0KPiBUaGUgbmV3IGJ1ZyB5b3UgbWVudGlvbiBp cyBvbmx5IGJhZCBpbiBhIHRoZW9yZXRpY2FsIHNlbnNlLsKgIEluIA0KPiBwcmFjdGljZSwg dGhlIHBlcm1pc3Npb24gYml0cyBhcmUgbWlzY29uZmlndXJlZCBmb3IgYSBibGlwIG9mIHRp bWUgDQo+IGR1cmluZyBzeXN0ZW0gcmVjb25maWd1cmF0aW9uLCB3aGljaCBpcyBhIGxvdCBi ZXR0ZXIgdGhhbiBiZWluZyANCj4gbWlzY29uZmlndXJlZCBhbGwgdGhlIHRpbWUgd2hpY2gg aXMgdGhlIHN0YXR1cyBxdW8uwqAgSXQncyB0aGUgDQo+IGRpZmZlcmVuY2UgYmV0d2VlbiBh IGdpdG9saXRlIHRoYXQgd29ya3MgbmljZWx5IHdpdGggY2dpdC9naXR3ZWIgYW5kIA0KPiBv bmUgdGhhdCBkb2Vzbid0LiBJIGFncmVlIHRoYXQgaXQncyBhIGdvb2QgZ29hbCB0byBpbXBy b3ZlIGF0b21pY2l0eSANCj4gYW5kIEkgdGhpbmsgbWFraW5nIDx1c2VyLWFjY291bnQ+IG1v cmUgZ2VuZXJhbCB0byBhbGxvdyBmb3IgZGlmZmVyZW50IA0KPiBwZXJtaXNzaW9uIGJpdHMg b24gdGhlIGhvbWUgZGlyZWN0b3J5IGlzIGEgZ29vZCBpZGVhLCBidXQgSSBzZWUgaXQgYXMg DQo+IG9uZSBzdGVwIHJlbW92ZWQgZnJvbSBmaXhpbmcgdGhpcyBwYXJ0aWN1bGFyIGJ1Zy4N Cg0KVGhlIHRpbWUgcmVxdWlyZWQgdG8gYW5hbHlzZSBpdCBhcyAianVzdCB0aGVvcmV0aWNh bCIgY291bGQgaGF2ZSBiZWVuIA0Kc3BlbnQgZG9pbmcgdGhlIHRpbnkgYml0IG9mIGV4dHJh IGVmZm9ydC4NCg0KVGhlb3JldGljYWwgYnVncyBsaWtlIHRoZXNlIGFyZSBlc3BlY2lhbGx5 IG5hc3R5LCBpZiB5b3UgZW5jb3VudGVyIHRoZW0gDQp0aGVyZSBpcyBvZnRlbiBub3QgYSBj bHVlIHdoYXQgdGhlIGNhdXNlIGlzIHVubGVzcyB5b3UgYWxyZWFkeSBrbm93IHdoYXQgDQp0 byBsb29rIGZvci4NCg0KPiDCoCBNeSBwYXRjaCBmb2xsb3dzIHRoZSByZWNvbW1lbmRlZCBh cHByb2FjaCBvdXRsaW5lZCBpbiBhIGNvbW1lbnQgaW4gDQo+IChnbnUgYnVpbGQgYWN0aXZh dGlvbikgd3JpdHRlbiBieSBMdWRvdmljIGluIDIwMTk6DQo+DQo+IMKgIMKgIMKgIDs7IEFs d2F5cyBzZXQgb3duZXJzaGlwIGFuZCBwZXJtaXNzaW9ucyBmb3IgaG9tZSBkaXJlY3Rvcmll cyBvZiANCj4gc3lzdGVtDQo+IMKgIMKgIMKgIDs7IGFjY291bnRzLsKgIElmIGEgc2Vydmlj ZSBuZWVkcyBsb29zZXIgcGVybWlzc2lvbnMgb24gaXRzIGhvbWUNCj4gwqAgwqAgwqAgOzsg ZGlyZWN0b3JpZXMsIGl0IGNhbiBhbHdheXMgY2htb2QgaXQgaW4gYW4gYWN0aXZhdGlvbiBz bmlwcGV0Lg0KDQpJJ3ZlIHJlZnV0ZWQgdGhhdCByZWNvbW1lbmRhdGlvbiAoYWxiZWl0IHdp dGhvdXQgZXhwbGljaXRseSBtZW50aW9uaW5nIA0KdGhhdCBwYXJhZ3JhcGgpLCB0aGF0IHBh cmFncmFwaCBpcyBhIGJ1Zywgc2VlIG15IHByZXZpb3VzIGNvbW1lbnRzIG9uIA0Kbm9uLWF0 b21pY2l0eS4gUGxlYXNlIHJlbW92ZSBpdCBpbiB0aGUgdjIgcGF0Y2guDQoNCkFzIHRoZXJl IGFwcGVhcnMgdG8gYmUgYSBsYWNrIG9mIHdpbGxpbmduZXNzIHRvIGludmVzdCB0aGUgdGlu aWVzdCBiaXQgDQpvZiBleHRyYSBlZmZvcnQgdG8gaW1wbGVtZW50IGEgcHJvcGVyIHBhdGNo LCBhbmQgZ2l2ZW4gdGhlIGxlbmd0aCBvZiANCnByZXZpb3VzIGRpc2N1c3Npb24sIEkgdGhp bmsgbXkgdGltZSB3aWxsIGJlIGJldHRlciBzcGVudCBjb250aW51aW5nIA0KZml4aW5nIHRo aW5ncyBpbiBHdWl4IHJhdGhlciB0aGFuIGFueSBmYWlsaW5nIGF0dGVtcHRzIGF0IGNvbnZp bmNpbmcgDQp5b3UuIEFzIHN1Y2gsIEknbGwgc3RvcCByZXNwb25kaW5nIHVudGlsIGEgdjIg b3IgcXVlc3Rpb25zIG9uIGhvdyB0byANCmltcGxlbWVudCBhIHYyLCBidXQgdGhhdCBjYW5u b3QgYmUgaW50ZXJwcmV0ZWQgYXMgbWUgYWdyZWVpbmcgd2l0aCB5b3UuDQoNCkdyZWV0aW5n cywNCk1heGltZQ0KDQo= --------------bsDNfb7hrTl0fiXdURqteMs4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 29-08-2022 15:30, Thompson, David wrote:

On Mon, Aug 29, 2022 at 9= :19 AM Maxime Devos <ma= ximedevos@telenet.be> wrote:
On 29-08-2022 14:57, Thompson, David wrote:

> I disagree.=C2=A0 I believe we shouldn't let perfect be = the enemy of the good.

I don't think your patch counts as "good" here -- while fixing the bug
counts as "good", you are at the same time introducing a new bug (the
non-atomicity), which is bad.=C2=A0 You would have to weigh t= he goodness and
the badness to end up with an overall "good" (or maybe "bad", depending
on the conclusion), but I'd think that the time required to do such a
weighing is better spent by doing a tiny bit of extra effort to
implement the new field (it should be very low effort, see other response).

My patch has a very limited scope of only changing the gitolite service.=C2=A0 Your proposal has a much greater scop= e of modifying a core structure used for system configuration.
It is a greater scope, but it's not really more effort.
The new bug you mention is only bad in a theoretical sense.=C2=A0 In practice, the permission bits are misconfigur= ed for a blip of time during system reconfiguration, which is a lot better than being misconfigured all the time which is the status quo.=C2=A0 It's the difference between a gitolite = that works nicely with cgit/gitweb and one that doesn't. I agree that it's a good goal to improve atomicity and I think making <user-account> more general to allow for different permission bits on the home directory is a good idea, but I see it as one step removed from fixing this particular bug.

The time required to analyse it as "just theoretical" could have been spent doing the tiny bit of extra effort.

Theoretical bugs like these are especially nasty, if you encounter them there is often not a clue what the cause is unless you already know what to look for.

=C2=A0 My patch follows the recommended approach outlined = in a comment in (gnu build activation) written by Ludovic in 2019:

=C2=A0 =C2=A0 =C2=A0 ;; Always set ownership and permissio= ns for home directories of system
=C2=A0 =C2=A0 =C2=A0 ;; accounts.=C2=A0 If a service needs lo= oser permissions on its home
=C2=A0 =C2=A0 =C2=A0 ;; directories, it can always chmod it i= n an activation snippet.

I've refuted that recommendation (albeit without explicitly mentioning that paragraph), that paragraph is a bug, see my previous comments on non-atomicity. Please remove it in the v2 patch.

As there appears to be a lack of willingness to invest the tiniest bit of extra effort to implement a proper patch, and given the length of previous discussion, I think my time will be better spent continuing fixing things in Guix rather than any failing attempts at convincing you. As such, I'll stop responding until a v2 or questions on how to implement a v2, but that cannot be interpreted as me agreeing with you.

Greetings,
Maxime

--------------bsDNfb7hrTl0fiXdURqteMs4-- --------------xuH0si8v0jA4ysPawXtL4pwW Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------xuH0si8v0jA4ysPawXtL4pwW-- --------------hW994d0Nv0SjUx58WlFeld7Q-- --------------zAbgOaazcGoTL00Cyawb1f6J Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwzCtgUDAAAAAAAKCRBJ4+4iGRcl7izv AQDyx6cmwJNmPS3kYkIRmyXpyfXCb3BXdBPFweO+wIkwiwD/d32Y9YRdr8/bD1z/73GSn3B+hoNv uyNhNsXM1OaziQ0= =1XFa -----END PGP SIGNATURE----- --------------zAbgOaazcGoTL00Cyawb1f6J-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 10:00:17 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 14:00:17 +0000 Received: from localhost ([127.0.0.1]:33297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSfJJ-0001Lu-65 for submit@debbugs.gnu.org; Mon, 29 Aug 2022 10:00:17 -0400 Received: from mail-lf1-f51.google.com ([209.85.167.51]:43617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSfJG-0001LZ-HP for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 10:00:15 -0400 Received: by mail-lf1-f51.google.com with SMTP id v26so1042270lfd.10 for <56444@debbugs.gnu.org>; Mon, 29 Aug 2022 07:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=vtFxHafL3UUzUkT90pLg2uHVWMU6in/b+w5XYsrSnR4=; b=FY3NLuHf5p6mbrSoXIJf+Z8oa+KT6x2ye72ucEh0BqhWkMshw9pMjyqo+aeMnrQ7X7 QlB/D7Dw6i+PLpGwQohu512lmhjkwIk4qGNIqcgd/sL1KIjaSFBctX07UckPCPkZLNCS n3j+Su/s2q79wxYdF7karvcgfOpqiDFfeIO5HZBMALTJmi9iE1v6vSI5Aj6QMmynyWjX 7udMv6ampPpDXbfkidzwOeWKkbQ4Fh4vL+igHpQY58jfAA6mqw74RUcW+8OWvZX1JtcJ MmuTqpnw5opOedz7nNXkm3coFuduwK7+FPuFiOhDx1N5IGlrdyobKxjKoMiljIB1rDhP 83BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=vtFxHafL3UUzUkT90pLg2uHVWMU6in/b+w5XYsrSnR4=; b=tndTW8TevsHT+Jw0AEWck4fIzu2NTmm7TRs9Z3WYLnNdyKJ6ODC+E0mz0e9eIDz/dO VqGVI+gZOphIHRyFEw8EpuHprZspTf3k6Y+qCVhkR36zxanAf+xm/9SqmoOOXCwN32Py JYi1sI+thWhCwTAy2NqBOvdGI+sM8G1UU25BpUsfkvjOXwZhsLkYgP+L1192GiAGWCZ8 gkaaXr2ghMsSueRUqMDgsBs3p4c/jCe1OcJNuzu2mE7qFmsbLz9zEx0P/ssT3Y6WT+yG ExRaCZlFDgFPLfIT6BSnzbXWmUnFqb9lMjvWzht+BQDYEBTiXM6nKzEpbzcNp+guxoR5 4vtA== X-Gm-Message-State: ACgBeo2bcWykK/SnsXeJWmhYalnCFz+mjWXsYgHZMveC1xj5rDnlcB6m HdIqv+1MHDcrGdqtIZmKvZ2AYdrqjuyFAcW12XKmUA== X-Google-Smtp-Source: AA6agR7BkcSNWhpPJPjxj1Q+OqC5AKybviI60ZzmqrXbFqxxRjvyV2+XLNlWzCUFcde3eMkgrZDKpSAzIYUQ+z5lwF0= X-Received: by 2002:ac2:5e8c:0:b0:494:6d14:f16e with SMTP id b12-20020ac25e8c000000b004946d14f16emr1450773lfq.316.1661781608405; Mon, 29 Aug 2022 07:00:08 -0700 (PDT) MIME-Version: 1.0 References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> <6229fb3c-5966-aa18-d691-3d31c7335315@telenet.be> In-Reply-To: <6229fb3c-5966-aa18-d691-3d31c7335315@telenet.be> From: "Thompson, David" Date: Mon, 29 Aug 2022 09:59:57 -0400 Message-ID: Subject: Re: [EXT] Re: [EXT] Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions To: Maxime Devos Content-Type: multipart/alternative; boundary="00000000000076beeb05e761ae1b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000076beeb05e761ae1b Content-Type: text/plain; charset="UTF-8" On Mon, Aug 29, 2022 at 9:44 AM Maxime Devos wrote: > As there appears to be a lack of willingness to invest the tiniest bit of > extra effort to implement a proper patch, and given the length of previous > discussion, I think my time will be better spent continuing fixing things > in Guix rather than any failing attempts at convincing you. As such, I'll > stop responding until a v2 or questions on how to implement a v2, but that > cannot be interpreted as me agreeing with you. > >From my perspective, there is a lack of willingness on your end to accept imperfect solutions that have low impact. In projects I maintain and in the professional world, I try to acknowledge the work someone has already done and accept patches/pull requests that are not ideal but solve real world problems. I'd be happy to do some follow-up work to make system-level improvements when I have the time to properly test a change that impacts literally everyone that uses the Guix distro, but it would have been great to have improved the gitolite service in the meantime. If/when I get around to doing this work, I'll send along a patch. To any other maintainer or core dev: If any of you wants to sign off on this patch as-is, I'll merge it. I have commit access. - Dave --00000000000076beeb05e761ae1b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Aug 29, 2022 at 9:44 AM Maxime Devos <maximedevos@telenet.be> wrote:
=20 =20 =20

As there appears to be a lack of willingness to invest the tiniest bit of extra effort to implement a proper patch, and given the length of previous discussion, I think my time will be better spent continuing fixing things in Guix rather than any failing attempts at convincing you. As such, I'll stop responding until a v2 or questions on how to implement a v2, but that cannot be interpreted as me agreeing with you.


From my perspective, there is a = lack of willingness on your end to accept imperfect solutions that have low= impact.=C2=A0 In projects I maintain and in the professional world, I try = to acknowledge the work someone has already done and accept patches/pull re= quests that are not ideal but solve real world problems.=C2=A0 I'd be h= appy to do some follow-up work to make system-level improvements when I hav= e the time to properly test a change that impacts literally everyone that u= ses the Guix distro, but it would have been great to have improved the gito= lite service in the meantime.=C2=A0 If/when I get around to doing this work= , I'll send along a patch.

To any other ma= intainer or core dev: If any of you wants to sign off on this patch as-is, = I'll merge it.=C2=A0 I have commit access.

- Dave
--00000000000076beeb05e761ae1b-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 17:38:01 2022 Received: (at 56444) by debbugs.gnu.org; 29 Aug 2022 21:38:01 +0000 Received: from localhost ([127.0.0.1]:34067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSmSH-00079Y-0I for submit@debbugs.gnu.org; Mon, 29 Aug 2022 17:38:01 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:36782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSmS7-000790-R2 for 56444@debbugs.gnu.org; Mon, 29 Aug 2022 17:37:55 -0400 Received: by mail-wr1-f41.google.com with SMTP id bu22so11432786wrb.3 for <56444@debbugs.gnu.org>; Mon, 29 Aug 2022 14:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc; bh=fpRWmjXCJogcK+tEqUR97m2260rJlNSahAhS56kOIS4=; b=Ltur44cXF859WDVasIMDQLmT91BJH24ZX6rrsHcTdUqiATkRZBg/QLWUMl09YIwd6N Z64ntMNoV3y3+AGP4G9fvRyantKti6etvG2z/n1h/d3t8KcAKgm2XeAYB7Fn3t6br/Rm MGWFdkzANgXM/ZXZazi1QF2DPjW2MOoCrqXg2QD7UhYqqXe15LhDVfAgdE8MzUz2fM5X /xESMmIggguo8Fz4XQOj66fKYcpyd7BNSz6txWiNpctDlpdWsfn/MYZ/5KbRh60N9rQD FuuA0G+boUhuq19787DnOqgw2aVSAo32UhxoPzXw8sWSEA2cw9HnU62uuOu020QGZp8d zrJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=fpRWmjXCJogcK+tEqUR97m2260rJlNSahAhS56kOIS4=; b=NNBk641jVr+4Wv245+xCSXBnttXffKccivppKT1xNZiB/0W+i3D1vCDIjC+ZznTsXm p9tMie7gfzuFY1coe+ttUs7X2f+atZWcuv0OREEjDO4EwY12Oa+9+gBnRQEdKkR1wsCm pjM8uYmJJibeUIWJeAeImeJbLhfm3kjouiPlA+Pa++dtfmn7k+MDnU0F5zxo6xM3N0Yp 8SjkkXOPNZQYi+xj5yS0eLS/Ltb/JZzG+bg4DwuVv9aipTKjwkNV/msbqHH+KEE1FWDx YjJzTJH3Ar7NUGviJjCNouLkayF9Rvr4HTrxQT9Tg+MJQ7hzfItTH4Mj0TMoZg2oQoDq uaeA== X-Gm-Message-State: ACgBeo38BEDBYKX50vHwgBVYeBMDcIIxFzZQP5Wl8d7ben9wIr658Civ JT81sYykdou+zH8kGv/HnymsFS46rnk= X-Google-Smtp-Source: AA6agR6usZqAHjSct8clZI/hhnM46gerDyzafQHD19PUeLyh5wj03koceCV+cNTSaqT3+xzX7K2eWg== X-Received: by 2002:adf:d0c1:0:b0:226:db47:da1c with SMTP id z1-20020adfd0c1000000b00226db47da1cmr3845846wrh.391.1661809065842; Mon, 29 Aug 2022 14:37:45 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id m13-20020a05600c3b0d00b003a83b066401sm9879122wms.31.2022.08.29.14.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 14:37:45 -0700 (PDT) From: zimoun To: "Thompson, David" , Maxime Devos Subject: Re: bug#56444: [EXT] Re: [EXT] Re: [EXT] Re: bug#56444: Patch to fix Gitolite home directory permissions In-Reply-To: References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> <6229fb3c-5966-aa18-d691-3d31c7335315@telenet.be> Date: Mon, 29 Aug 2022 23:05:59 +0200 Message-ID: <87ilmavjyg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi David, On lun., 29 ao=C3=BBt 2022 at 09:59, "Thompson, David" wrote: > To any other maintainer or core dev: If any of you wants to sign off on > this patch as-is, I'll merge it. I have commit access. I am not maintainer, Maxime neither AFAIK, and I am not a =E2=80=9Ccore dev= =E2=80=9C neither. For what it is worth, your patch LGTM; please push. The patch seems a pragmatic workaround waiting an implementation more robust as Maxime has proposed. Feel free to send here or open another submission for this upcoming =E2=80=9Cbetter=E2=80=9D fix. BTW, unrelated but Gitolite in Guix requires some love. If you have time, a look at bug#25957 [1] would be appreciated. :-) Cheers, simon 1: From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 30 11:20:40 2022 Received: (at 56444) by debbugs.gnu.org; 30 Aug 2022 15:20:40 +0000 Received: from localhost ([127.0.0.1]:37051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oT32e-0001NK-7A for submit@debbugs.gnu.org; Tue, 30 Aug 2022 11:20:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oT32a-0001N3-AH for 56444@debbugs.gnu.org; Tue, 30 Aug 2022 11:20:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47342) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT32U-0007qN-0l; Tue, 30 Aug 2022 11:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=DYyCIEW6Lq6HjSvtzvYNZrj3pTLEWF8WfBNq31WDxiw=; b=JL3VUic+XhFsT3TMHB0U 9KqWOgpfARqgI51wmaUVQrfdVwQ/gBkiXelU2JhyeYeM41w9+2/9I46AGnIq2zKzVYdzZoGZQmBzu I/xJeKIEtqMYgmrEFJJVO9+cx7MDxZTmP+j7JkgsEvjDk7SItgeijoapnFhhkFq1kw2zVg5OR5uf8 oTWzonbr7bLpi/U7DpBVkZ1avPCGJvNA64Kcvvy3lcovWLod46qnhoobv+LlXJy3TCjSumOGMiup0 rogcARoJJimvzuo4wml7p7sX7Ar2lHfb/5NpWLAoYXFzN45Q73rj0NzkzEmaHx4FJSaVQRNsnulT+ 9dSnLPr6gBb2dw==; Received: from [193.50.111.124] (port=48634 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT32T-0001on-5E; Tue, 30 Aug 2022 11:20:29 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "Thompson, David" Subject: Re: bug#56444: Gitolite home directory permissions References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> <6229fb3c-5966-aa18-d691-3d31c7335315@telenet.be> Date: Tue, 30 Aug 2022 17:20:26 +0200 In-Reply-To: (David Thompson's message of "Mon, 29 Aug 2022 09:59:57 -0400") Message-ID: <87edwxwyf9.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi there! Please let=E2=80=99s avoid guessing each other=E2=80=99s willingness to do = one thing or another. I agree with David that we should accept simple local fixes like this one, while keeping the =E2=80=9Cbetter solution=E2=80=9D in sight. It=E2= =80=99s a tradeoff, and the goal is to make sure we can all move forward. So I=E2=80=99m all for merging this Gitolite activation patch that David po= sted right away; I think you can go ahead, David. Adding =E2=80=98home-permission=E2=80=99 to as Maxime sugges= ted also sounds like a welcome improvement to me, but I think it=E2=80=99s fine to do that separately. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 30 12:40:27 2022 Received: (at 56444) by debbugs.gnu.org; 30 Aug 2022 16:40:27 +0000 Received: from localhost ([127.0.0.1]:37299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oT4Hq-0007te-Li for submit@debbugs.gnu.org; Tue, 30 Aug 2022 12:40:27 -0400 Received: from mail-lf1-f48.google.com ([209.85.167.48]:41762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oT4HU-0007sL-7h for 56444@debbugs.gnu.org; Tue, 30 Aug 2022 12:40:19 -0400 Received: by mail-lf1-f48.google.com with SMTP id m7so7389100lfq.8 for <56444@debbugs.gnu.org>; Tue, 30 Aug 2022 09:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=aftPR+s9n0NkvOds4UQHDgQ7IK0GWF63n6wWJ+nfhrM=; b=aol3tyzqhfTl1oV1XLZvF8TW/5g8u1fbnov93fVP5di/FgznUzq1p3VXOon9p6Tl7C WlHte7DEkXYkdCrI3kyxLxsfq5IjjMoRSfMPZclKGeqv3b2aoHVzIdys++jAgS4D89ei l1RB4sEG4pI5jirRTcQ+tmqhR/uyfm59OaFM11u7yV7kqkLD1gBtei9rIkypYebrTb6T CAaiPmlUrgLjUidwzbhQSNRuZLgZcSuu6tax2d97MJ/m/f2EBrhqQ1EEmkL4zjQnANmW 1/80Ma5FWNNoZpjsMiiu6dKlMGvZL33g72yU6p0eHK/tfn3ZwHkFz5gFFuyPiqW7lUPL me/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=aftPR+s9n0NkvOds4UQHDgQ7IK0GWF63n6wWJ+nfhrM=; b=JpCyOe2MGqj0Tmg8NLRzilrMSAgXBtSvtHELubNjFJV+wH+OKlLM1V3MTGPqp+yuLQ YILuzNows/ly8C9lA4qVi9r6K1L0zE2BA7caeotqauRm4zLeCJIQiKT4fnz6hRkaYGtx xvFXlttbS57QEc0H62Co0ijh3plfKEAthvN8e+BylLDT0uy2Rn6ZOr5i/uYDevIiFIIp OrhxJSvePCgwnxFaBl4jKfaQS4yAd5B57+aOXoqEet7gkbBK46N9kcaz31shSedjDSf7 XmjS4m7Z+qgBf24AeiUgFaA6UvFfiEQI4lQDBsOrFxqKsbwaEP3KwL4HjrRxc1pXRs3h bRfQ== X-Gm-Message-State: ACgBeo21xVApgnWbB17/Yb6k4hp5TsxxDh+R7ZDeNu8s4b7dNgLiPDPs 36d7DyA7PyAD2JQXrbKmLNOKfB7L1fr96348MNggDg== X-Google-Smtp-Source: AA6agR5TKkY2FAUJ8NQeeukvB+gJ/afCN09CjTkfKfemafKltAsPAHelncnSQbsptru6LFDb2zIQCrCjkWLtkXMwluE= X-Received: by 2002:a05:6512:3fc:b0:494:663f:c017 with SMTP id n28-20020a05651203fc00b00494663fc017mr4457110lfq.472.1661877598145; Tue, 30 Aug 2022 09:39:58 -0700 (PDT) MIME-Version: 1.0 References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> <6229fb3c-5966-aa18-d691-3d31c7335315@telenet.be> <87edwxwyf9.fsf_-_@gnu.org> In-Reply-To: <87edwxwyf9.fsf_-_@gnu.org> From: "Thompson, David" Date: Tue, 30 Aug 2022 12:39:47 -0400 Message-ID: Subject: Re: [EXT] Re: bug#56444: Gitolite home directory permissions To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: multipart/alternative; boundary="000000000000e5f77005e7780788" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org, 56444-done@debbugs.gnu.org, Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e5f77005e7780788 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ludo, On Tue, Aug 30, 2022 at 11:20 AM Ludovic Court=C3=A8s wrote: > Hi there! > > Please let=E2=80=99s avoid guessing each other=E2=80=99s willingness to d= o one thing or > another. > > I agree with David that we should accept simple local fixes like this > one, while keeping the =E2=80=9Cbetter solution=E2=80=9D in sight. It=E2= =80=99s a tradeoff, and > the goal is to make sure we can all move forward. > > So I=E2=80=99m all for merging this Gitolite activation patch that David = posted > right away; I think you can go ahead, David. > > Adding =E2=80=98home-permission=E2=80=99 to as Maxime sugg= ested also > sounds like a welcome improvement to me, but I think it=E2=80=99s fine to= do > that separately. > Patch pushed. I will follow up with a new bug report (and a patch later when I have some time to actually write code) to capture the improvements to so we can discuss any potential issues or gotchas that might come as a result. Thanks, - Dave --000000000000e5f77005e7780788 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ludo,

On Tue, Aug 30, 2022 at 11:20 AM Ludovic = Court=C3=A8s <ludo@gnu.org> wrote= :
Hi there!

Please let=E2=80=99s avoid guessing each other=E2=80=99s willingness to do = one thing or
another.

I agree with David that we should accept simple local fixes like this
one, while keeping the =E2=80=9Cbetter solution=E2=80=9D in sight.=C2=A0 It= =E2=80=99s a tradeoff, and
the goal is to make sure we can all move forward.

So I=E2=80=99m all for merging this Gitolite activation patch that David po= sted
right away; I think you can go ahead, David.

Adding =E2=80=98home-permission=E2=80=99 to <user-account> as Maxime = suggested also
sounds like a welcome improvement to me, but I think it=E2=80=99s fine to d= o
that separately.

Patch= pushed.

I will follow up with a new bug report (and= a patch later when I have some time to actually write code) to capture th= e improvements to <user-account> so we can discuss any potential issu= es or gotchas that might come as a result.

Thanks,=

- Dave
--000000000000e5f77005e7780788-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 30 14:31:18 2022 Received: (at 56444) by debbugs.gnu.org; 30 Aug 2022 18:31:18 +0000 Received: from localhost ([127.0.0.1]:37450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oT617-0004Wt-VW for submit@debbugs.gnu.org; Tue, 30 Aug 2022 14:31:18 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:59844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oT615-0004We-9Y for 56444@debbugs.gnu.org; Tue, 30 Aug 2022 14:31:16 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id 502A22C04EA2; Tue, 30 Aug 2022 20:31:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1661884268; bh=Pa6lDev7zRTsSfcM1xpeNO14doxG0TQLEWIVWNys9T4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=jWABpKIQyntacIOLPV4Sw/aq+AUsIu0gKjrNadIuf2AOEvJPr7RJcB70TTNskUef+ 7/4gm3t6/OYoAS6YeYvHujgkS5VoQ9KZ+ogPZDmTUg3cGu3K2qzo11m5RWbKE3PqaP W2Bsn0S3T/Wfa6AK7eRC0v10o1c8vveAFrobBqLi6GGxiCxEjpd7KhSG1zgVGFMDTj Ndbzzo5inl8orn1FrhMmj5CMNT0LlvVnyl7uG0h0levY4t4rf96w45rvJ3JRwkBJjQ mP/PuImVSwsGTIaPsKDUKzoOU8rPhILQiDEqyyLIwN/tBvFLF8ne2JK3Qr9F5xmiAR g2217mnKHNvow== X-Fuglu-Suspect: e72797ef319f4455995eac7ad13366d1 X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Tue, 30 Aug 2022 20:31:02 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 30 Aug 2022 20:31:02 +0200 From: david larsson To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: bug#56444: Gitolite home directory permissions In-Reply-To: <87edwxwyf9.fsf_-_@gnu.org> References: <87zghkehdd.fsf@pisemsky.com> <1967478a-3d68-a0c7-3a87-49762502232b@telenet.be> <31e8c6df-a9c9-7f16-69fb-e022d94c16ff@telenet.be> <6229fb3c-5966-aa18-d691-3d31c7335315@telenet.be> <87edwxwyf9.fsf_-_@gnu.org> Message-ID: <4cab77dc14a410c8a4b8252b72edb3ec@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 56444 Cc: 56444@debbugs.gnu.org, Maxime Devos , "Thompson, David" , bug-Guix X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On 2022-08-30 17:20, Ludovic Courtès wrote: > I agree with David that we should accept simple local fixes like this > one, while keeping the “better solution” in sight. It’s a tradeoff, > and > the goal is to make sure we can all move forward. FWIW: I think that writing comments like ;; KLUDGE: better to do X. etc. is a simple way to keep things in sight, and can or should be added before pushing patches when so is relevant. For those using emacs then with emacs-magit-todos you get all such TODO-things visible every time when checking ma(git) status from inside emacs., which is nice IMO. Regards, David Larsson From unknown Tue Aug 19 02:53:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 28 Sep 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator