GNU bug report logs - #56436
[PATCH] Avoid obsolete initial-input argument in net-utils.el

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Thu, 7 Jul 2022 14:42:01 UTC

Severity: wishlist

Tags: patch

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56436 in the body.
You can then email your comments to 56436 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#56436; Package emacs. (Thu, 07 Jul 2022 14:42:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 07 Jul 2022 14:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Avoid obsolete initial-input argument in net-utils.el
Date: Thu, 7 Jul 2022 17:41:28 +0300

[Message part 1 (text/plain, inline)]
Severity: wishlist

The prompting from the functions in net-utils.el is pretty bad, since it
uses the obsolete INITIAL-INPUT argument of `read-from-minibuffer'.

How about replacing it with using a proper default, as in the attached?

[0001-Avoid-obsolete-initial-input-argument-in-net-utils.e.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#56436; Package emacs. (Thu, 07 Jul 2022 18:20:02 GMT) Full text and rfc822 format available.

Message #8 received at 56436 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56436 <at> debbugs.gnu.org
Subject: Re: bug#56436: [PATCH] Avoid obsolete initial-input argument in
 net-utils.el
Date: Thu, 07 Jul 2022 20:18:52 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> The prompting from the functions in net-utils.el is pretty bad, since it
> uses the obsolete INITIAL-INPUT argument of `read-from-minibuffer'.
>
> How about replacing it with using a proper default, as in the attached?

Looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Reply sent to Stefan Kangas <stefan <at> marxist.se>:
You have taken responsibility. (Fri, 08 Jul 2022 09:05:01 GMT) Full text and rfc822 format available.
Notification sent to Stefan Kangas <stefan <at> marxist.se>:
bug acknowledged by developer. (Fri, 08 Jul 2022 09:05:02 GMT) Full text and rfc822 format available.

Message #13 received at 56436-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56436-done <at> debbugs.gnu.org
Subject: Re: bug#56436: [PATCH] Avoid obsolete initial-input argument in
 net-utils.el
Date: Fri, 8 Jul 2022 11:03:54 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Looks good to me.

Thanks, pushed to master as commit 989908eee8.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 05 Aug 2022 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 315 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.