From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 06 16:14:35 2022 Received: (at submit) by debbugs.gnu.org; 6 Jul 2022 20:14:35 +0000 Received: from localhost ([127.0.0.1]:55239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9BPs-0003QO-Fr for submit@debbugs.gnu.org; Wed, 06 Jul 2022 16:14:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:48474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Ay8-0002Wk-SY for submit@debbugs.gnu.org; Wed, 06 Jul 2022 15:45:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Ay8-0003GF-FC for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 15:45:52 -0400 Received: from smtp.umanwizard.com ([54.203.248.109]:25989) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9Ay6-0004Br-Nz for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 15:45:52 -0400 X-Fes-Received-For: bug-gnu-emacs@gnu.org X-Fes-Received-From: brennan@umanwizard.com Received: From [10.10.1.216] ([173.205.212.102]) By umanwizard.com ; 6 Jul 2022 19:45:47+0000 Message-ID: Date: Wed, 6 Jul 2022 15:45:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Brennan Vincent Subject: [PATCH] fix broken `imenu--create-keymap` when an item is nil Content-Language: en-US To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Fes-Encrypted: true X-Fes-Ehlo-Domain: [10.10.1.216] Received-SPF: pass client-ip=54.203.248.109; envelope-from=brennan@umanwizard.com; helo=smtp.umanwizard.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 06 Jul 2022 16:14:30 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --- lisp/imenu.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/imenu.el b/lisp/imenu.el index 040e373fb4..0a0931a647 100644 --- a/lisp/imenu.el +++ b/lisp/imenu.el @@ -464,7 +464,7 @@ imenu--create-keymap `(keymap ,title ,@(mapcar (lambda (item) - `(,(intern (car item)) ,(car item) + `(,(and (car item) (intern (car item))) ,(car item) ,@(cond ((imenu--subalist-p item) (imenu--create-keymap (car item) (cdr item) cmd)) -- 2.34.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 05:00:18 2022 Received: (at 56430) by debbugs.gnu.org; 7 Jul 2022 09:00:18 +0000 Received: from localhost ([127.0.0.1]:55751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9NMv-0004FM-PL for submit@debbugs.gnu.org; Thu, 07 Jul 2022 05:00:18 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9NMl-0004D7-FS for 56430@debbugs.gnu.org; Thu, 07 Jul 2022 05:00:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oKIjKjIhmb53IEn193Dp8j3oMNY+9Lu0BPNX92SiFug=; b=am29ShU7t1AoFVFLtZw4iGceGr V7aMLXJxRJ4QfO2p/VsRQL65VG1PBA7fGZwmKxlfss6qZNc5RfCNh+Rc9R+LLJJ/4SaF/gjcgC97B Rk9ztLDst1ngopNckxtc+bCnVYzokfLM+TOqzxjb+ZeC3lNtxNS99oHeu+1kWWnLY4fc=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9NMc-0006Gt-BO; Thu, 07 Jul 2022 11:00:00 +0200 From: Lars Ingebrigtsen To: Brennan Vincent Subject: Re: bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil In-Reply-To: (Brennan Vincent's message of "Wed, 6 Jul 2022 15:45:45 -0400") References: X-Now-Playing: Doubting Thomas's _Father Don't Cry_: "Turn A New Leaf" Date: Thu, 07 Jul 2022 10:59:57 +0200 Message-ID: <87mtdlguwi.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Brennan Vincent writes: > - `(, (intern (car item)) ,(car item) > + `(,(and (car item) (intern (car item))) ,(car item) > ,@(cond > ((imenu--subalist-p item) > (imenu--create-keymap (car item) (cdr item) cmd)) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56430 Cc: 56430@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Brennan Vincent writes: > - `(,(intern (car item)) ,(car item) > + `(,(and (car item) (intern (car item))) ,(car item) > ,@(cond > ((imenu--subalist-p item) > (imenu--create-keymap (car item) (cdr item) cmd)) In what cases is (car item) nil here? Isn't that a bug in the caller? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 05:00:13 2022 Received: (at control) by debbugs.gnu.org; 7 Jul 2022 09:00:13 +0000 Received: from localhost ([127.0.0.1]:55749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9NMr-0004F2-HI for submit@debbugs.gnu.org; Thu, 07 Jul 2022 05:00:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9NMp-0004Dg-Re for control@debbugs.gnu.org; Thu, 07 Jul 2022 05:00:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=epzlthN+nKAR0+YQvcIrAp3O4HPkbPfNX37tq1ugO98=; b=gTLznScsJcBRNxbQQnO5NKJmMC 2UFdZGqhc2wHfCRnPj36IeV14gyWg7GpTPti84Y0DSc1tihqsiGINeF+GmEeVQRKQV/pSA4U8EtO+ 2CO8Cz0WKSm97jezzcRHxG0tUYTg+aVetQLcvBLKpGg7gHaJ4MdXojvFzQyH33EVrIfk=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9NMh-0006H3-HC for control@debbugs.gnu.org; Thu, 07 Jul 2022 11:00:05 +0200 Date: Thu, 07 Jul 2022 11:00:02 +0200 Message-Id: <87let5guwd.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56430 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 56430 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 56430 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 11:01:43 2022 Received: (at 56430) by debbugs.gnu.org; 7 Jul 2022 15:01:43 +0000 Received: from localhost ([127.0.0.1]:57588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9T0e-0005jM-6H for submit@debbugs.gnu.org; Thu, 07 Jul 2022 11:01:43 -0400 Received: from smtp.umanwizard.com ([54.203.248.109]:20123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9SSw-0004kw-QN for 56430@debbugs.gnu.org; Thu, 07 Jul 2022 10:27:00 -0400 X-Fes-Received-For: 56430@debbugs.gnu.org X-Fes-Received-From: brennan@umanwizard.com Received: From [192.168.1.173] ([71.190.149.125]) By umanwizard.com ; 7 Jul 2022 14:26:39+0000 Message-ID: <4efdcf03-a006-fc5a-e724-c2eddeb3cd68@umanwizard.com> Date: Thu, 7 Jul 2022 10:26:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil Content-Language: en-US To: Lars Ingebrigtsen References: <87mtdlguwi.fsf@gnus.org> From: Brennan Vincent In-Reply-To: <87mtdlguwi.fsf@gnus.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Fes-Encrypted: true X-Fes-Ehlo-Domain: [192.168.1.173] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56430 X-Mailman-Approved-At: Thu, 07 Jul 2022 11:01:39 -0400 Cc: 56430@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I actually observed item itself being nil, not just (car item). It happens in imenu-update-menubar, because imenu--make-index-alist always produces (list nil) instead of just nil. The code is uncommented, so I don't know the original reason for that logic, which you can see here: https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/imenu.el#n434 This was working fine until imenu--create-keymap was updated to call intern, by your change on June 24th. The practical consequence I observed was that lsp-mode stopped working for Go. On 7/7/22 04:59, Lars Ingebrigtsen wrote: > Content preview: Brennan Vincent writes: > - `(,(intern > (car item)) ,(car item) > + `(,(and (car item) (intern (car item))) ,(car > item) > ,@(cond > ((imenu--subalist-p item) > (imenu--create-keymap (car > item) (cdr item) cmd)) > > Content analysis details: (-2.9 points, 5.0 required) > > pts rule name description > ---- ---------------------- -------------------------------------------------- > -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP > -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% > [score: 0.0000] > X-Fes-Encrypted: true > X-Fes-Ehlo-Domain: quimby.gnus.org > > Brennan Vincent writes: > >> - `(,(intern (car item)) ,(car item) >> + `(,(and (car item) (intern (car item))) ,(car item) >> ,@(cond >> ((imenu--subalist-p item) >> (imenu--create-keymap (car item) (cdr item) cmd)) > > In what cases is (car item) nil here? Isn't that a bug in the caller? > > -- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 14:02:55 2022 Received: (at 56430) by debbugs.gnu.org; 7 Jul 2022 18:02:55 +0000 Received: from localhost ([127.0.0.1]:57817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Vq2-0006Jd-RI for submit@debbugs.gnu.org; Thu, 07 Jul 2022 14:02:55 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Vq0-0006JP-J3 for 56430@debbugs.gnu.org; Thu, 07 Jul 2022 14:02:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J5c6pJYIeZPTZ9jzF46CrvgcIcbX7CUFk61Ena4DF30=; b=Uw5ZRrvI0Ce13woBPLc8hvdIRE GDQ+Aqj+vEYPi52tdVO6/UXYhazd2JzJIyZldh96FgRQaFwy6T7iVRE0x7Jw1yUlt/5YFoaFcY0BF lCdhcdnwst9bgxjIpAWWArZWdUjG5yoSb/yTpecymkyr/z5QE7KnxOG3Lx6RtGzmP710=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9Vps-0001zY-7N; Thu, 07 Jul 2022 20:02:46 +0200 From: Lars Ingebrigtsen To: Brennan Vincent Subject: Re: bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil In-Reply-To: <4efdcf03-a006-fc5a-e724-c2eddeb3cd68@umanwizard.com> (Brennan Vincent's message of "Thu, 7 Jul 2022 10:26:37 -0400") References: <87mtdlguwi.fsf@gnus.org> <4efdcf03-a006-fc5a-e724-c2eddeb3cd68@umanwizard.com> X-Now-Playing: Maeror Tri's _Mort Aux Vaches_: "(Mind) Alternation" Date: Thu, 07 Jul 2022 20:02:42 +0200 Message-ID: <87y1x4er7h.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Brennan Vincent writes: > I actually observed item itself being nil, not just (car item). Does the following simple change fix the problem, then? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56430 Cc: 56430@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Brennan Vincent writes: > I actually observed item itself being nil, not just (car item). Does the following simple change fix the problem, then? diff --git a/lisp/imenu.el b/lisp/imenu.el index 040e373fb4..dcd816cb7a 100644 --- a/lisp/imenu.el +++ b/lisp/imenu.el @@ -471,7 +471,7 @@ imenu--create-keymap (t (lambda () (interactive) (if cmd (funcall cmd item) item)))))) - alist))) + (seq-filter #'identity alist)))) (defun imenu--in-alist (str alist) "Check whether the string STR is contained in multi-level ALIST." -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 14:22:12 2022 Received: (at 56430) by debbugs.gnu.org; 7 Jul 2022 18:22:12 +0000 Received: from localhost ([127.0.0.1]:57864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9W8i-0000YR-Jr for submit@debbugs.gnu.org; Thu, 07 Jul 2022 14:22:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9W8g-0000YA-FG for 56430@debbugs.gnu.org; Thu, 07 Jul 2022 14:22:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w74NR489W5ioVrV7+w6eMyRBQ3aAm32PmhqMg4uZLgA=; b=a297zNgMZk6bgP7ziq4OUHipAR I/XiS6eWBhJ8t8Oh0BXaEZfMRckkhPH3nrVGVX47LshNHHDg3YvM3ARzdZXzkO/C/+G/yZ155Gfef ZARSgVgNVV1UkqvfzZJM2fGql6YZi5hOuTsNLpaBYwUZ8Q8N7iDYk2OVOqddu9Dpj/C0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9W8X-00029n-HO; Thu, 07 Jul 2022 20:22:04 +0200 From: Lars Ingebrigtsen To: Brennan Vincent Subject: Re: bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil In-Reply-To: <2ac26bde-ea5e-015c-e66a-ba1c090fa0a8@umanwizard.com> (Brennan Vincent's message of "Thu, 7 Jul 2022 14:18:16 -0400") References: <87mtdlguwi.fsf@gnus.org> <4efdcf03-a006-fc5a-e724-c2eddeb3cd68@umanwizard.com> <87y1x4er7h.fsf@gnus.org> <2ac26bde-ea5e-015c-e66a-ba1c090fa0a8@umanwizard.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEX8k6T5ipvXlp+n aHDJeoZmTEu0nZ////+CL0/NAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YHBxEiEfPYGQMAAAGwSURB VDjLrZNPeqMwDMXlTg8gUU/X4BD22IZ1wp8LQDhAnW98/yOMLUPqTtvVVHzZ8MuTzNMzAAARCqIK iQshlog/+lAJwGeQqT4DYkD/A2yaIPAfINdsdvkO1NxmjRKIJ2vc6ZqNKI/jNj6UqjKQBIVP5fIZ wSXR+Iw8FIVSyh2oysDgvHLeSj3VVg7je6sIem8nPZ0XqVceklq53vfeTMZ0tuuWKu6j5E/wfUC2 WrvwbLpihUDCotGN9m0Ay7aurbowAMIxdLDdoOzo78aay5VnAMJ868Ijh0F6NxJNMgEQv9fzbb69 WH0e/D24XCB7hVTEQ/Vj6PKiA0BZJgDJqHlrrXSn6N0ltcIEat1uv+IMhIrBYe1qzNZFsHsVvhIZ bGs3L87mQDD4Y7pxectAQMnyu7kWdZuDtFc/hn/X18cGo4JXF9/TKe6Z3WVF0Sg1mZiEO9IDhOH1 aIzlhFh4tBJRS9PEwXluxcdcHXl8Lb+I6BFJgrRzEW4g7nHEXc4A4WlXYbgAInq3twoCSHcitRF7 2uEIPnAvyADyMcRxk+AAgvIXGYBvwZf1g0B98/4vO7JvOoDAeUcAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjItMDctMDdUMTc6MzQ6MTcrMDA6MDDsc8MJAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA3 LTA3VDE3OjM0OjE3KzAwOjAwnS57tQAAAABJRU5ErkJggg== X-Now-Playing: Maeror Tri's _Mort Aux Vaches_: "(Mind) Expansion" Date: Thu, 07 Jul 2022 20:22:00 +0200 Message-ID: <87czegeqbb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Brennan Vincent writes: > Yes. That fixes the issue I was observing, too. My original motivation > was that the lsp-mode was failing to launch for Golang files on master. Thanks for testing; I've now pushed that change to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56430 Cc: 56430@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Brennan Vincent writes: > Yes. That fixes the issue I was observing, too. My original motivation > was that the lsp-mode was failing to launch for Golang files on master. Thanks for testing; I've now pushed that change to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 14:22:27 2022 Received: (at control) by debbugs.gnu.org; 7 Jul 2022 18:22:27 +0000 Received: from localhost ([127.0.0.1]:57867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9W8o-0000Yj-QZ for submit@debbugs.gnu.org; Thu, 07 Jul 2022 14:22:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9W8n-0000YP-G9 for control@debbugs.gnu.org; Thu, 07 Jul 2022 14:22:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IdqBePrsHGWQVD84z1KJ/jxa03xqGSI+NsO/bZchQUc=; b=iZyVB0VdfMN7fxUHqJUHYuOjkb LJ+dJ+rbKMpHqPmnLQwVym1C0RMzYPPwcKM1LVBqvaIBfvH8MEt4YVjyRm58vJzYrYmmGDU/vbPpL k+ChB93is9sz02WxU62p9m4jJn5+zge/o+aBVu7PvFIkUvEmc+H/O6ZLHreOBzhbGVe0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9W8f-00029z-O7 for control@debbugs.gnu.org; Thu, 07 Jul 2022 20:22:11 +0200 Date: Thu, 07 Jul 2022 20:22:09 +0200 Message-Id: <87bku0eqb2.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56430 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 56430 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 56430 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 14:58:40 2022 Received: (at 56430) by debbugs.gnu.org; 7 Jul 2022 18:58:40 +0000 Received: from localhost ([127.0.0.1]:57971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Whx-0003l4-Qe for submit@debbugs.gnu.org; Thu, 07 Jul 2022 14:58:40 -0400 Received: from smtp.umanwizard.com ([54.203.248.109]:12954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9W57-0000RF-FJ for 56430@debbugs.gnu.org; Thu, 07 Jul 2022 14:18:30 -0400 X-Fes-Received-For: 56430@debbugs.gnu.org X-Fes-Received-From: brennan@umanwizard.com Received: From [10.10.1.216] ([173.205.212.102]) By umanwizard.com ; 7 Jul 2022 18:18:18+0000 Message-ID: <2ac26bde-ea5e-015c-e66a-ba1c090fa0a8@umanwizard.com> Date: Thu, 7 Jul 2022 14:18:16 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil Content-Language: en-US To: Lars Ingebrigtsen References: <87mtdlguwi.fsf@gnus.org> <4efdcf03-a006-fc5a-e724-c2eddeb3cd68@umanwizard.com> <87y1x4er7h.fsf@gnus.org> From: Brennan Vincent In-Reply-To: <87y1x4er7h.fsf@gnus.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Fes-Encrypted: true X-Fes-Ehlo-Domain: [10.10.1.216] X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56430 X-Mailman-Approved-At: Thu, 07 Jul 2022 14:58:36 -0400 Cc: 56430@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yes. That fixes the issue I was observing, too. My original motivation was that the lsp-mode was failing to launch for Golang files on master. Both my diff and yours fix that problem. I have no strong opinion on which diff is better. On 2022-07-07 14:02, Lars Ingebrigtsen wrote: > Content preview: Brennan Vincent writes: > I actually > observed item itself being nil, not just (car item). Does the following simple > change fix the problem, then? > > Content analysis details: (-2.9 points, 5.0 required) > > pts rule name description > ---- ---------------------- -------------------------------------------------- > -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP > -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% > [score: 0.0000] > X-Fes-Encrypted: true > X-Fes-Ehlo-Domain: quimby.gnus.org > > Brennan Vincent writes: > >> I actually observed item itself being nil, not just (car item). > > Does the following simple change fix the problem, then? > > diff --git a/lisp/imenu.el b/lisp/imenu.el > index 040e373fb4..dcd816cb7a 100644 > --- a/lisp/imenu.el > +++ b/lisp/imenu.el > @@ -471,7 +471,7 @@ imenu--create-keymap > (t > (lambda () (interactive) > (if cmd (funcall cmd item) item)))))) > - alist))) > + (seq-filter #'identity alist)))) > > (defun imenu--in-alist (str alist) > "Check whether the string STR is contained in multi-level ALIST." > > > -- From unknown Thu Aug 14 21:50:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Aug 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator