GNU bug report logs - #5643
message-send-mail-function does not inherit from send-mail-function

Previous Next

Full log

View this message in rfc822 format

From: bug-gnu-emacs <at> gnu.org (Emacs bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: emacs-bug-tracker <at> debbugs.gnu.org
Subject: bug#5643: marked as done (message-send-mail-function does not
 inherit from send-mail-function)
Date: Fri, 26 Feb 2010 04:47:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 25 Feb 2010 23:46:08 -0500
with message-id <fuzl2w7gfj.fsf <at> fencepost.gnu.org>
and subject line Re: bug#5643: message-send-mail-function does not inherit from send-mail-function
has caused the Emacs bug report #5643,
regarding message-send-mail-function does not inherit from send-mail-function
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact bug-gnu-emacs <at> gnu.org
immediately.)


-- 
5643: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5643
Emacs Bug Tracking System
Contact bug-gnu-emacs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: message-send-mail-function does not inherit from send-mail-function
Date: Wed, 24 Feb 2010 13:44:36 -0500

Current trunk on GNU/Linux:

emacs -Q --eval "(progn (setq send-mail-function 'smtpmail-send-it) (require 'message))"

C-h v message-send-mail-function RET

    Its value is 
    message-send-mail-with-sendmail


The fact that message-send-mail-function does not respect the value of
send-mail-function at all is unhelpful. It will be especially
confusing for people upgrading from Emacs 23.1 who have customized
send-mail-function.

I suggest a patch like the following:

*** lisp/gnus/message.el	2010-02-24 03:12:54 +0000
--- lisp/gnus/message.el	2010-02-24 18:41:04 +0000
***************
*** 675,681 ****
  	   (error "Don't know how to send mail.  Please customize `message-send-mail-function'")))))
  
  ;; Useful to set in site-init.el
! (defcustom message-send-mail-function (message-send-mail-function)
    "Function to call to send the current buffer as mail.
  The headers should be delimited by a line whose contents match the
  variable `mail-header-separator'.
--- 675,686 ----
  	   (error "Don't know how to send mail.  Please customize `message-send-mail-function'")))))
  
  ;; Useful to set in site-init.el
! (defcustom message-send-mail-function
!   (case send-mail-function
!     (smtpmail-send-it 'message-smtpmail-send-it)
!     (feedmail-send-it 'feedmail-send-it)
!     (mailclient-send-it 'message-send-mail-with-mailclient)
!     (t (message-send-mail-function)))
    "Function to call to send the current buffer as mail.
  The headers should be delimited by a line whose contents match the
  variable `mail-header-separator'.
***************
*** 698,704 ****
  			       :tag "Use Mailclient package")
   		(function :tag "Other"))
    :group 'message-sending
!   :version "23.1" ;; No Gnus
    :initialize 'custom-initialize-default
    :link '(custom-manual "(message)Mail Variables")
    :group 'message-mail)
--- 703,709 ----
  			       :tag "Use Mailclient package")
   		(function :tag "Other"))
    :group 'message-sending
!   :version "23.2"
    :initialize 'custom-initialize-default
    :link '(custom-manual "(message)Mail Variables")
    :group 'message-mail)

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 5643-done <at> debbugs.gnu.org
Subject: Re: bug#5643: message-send-mail-function does not inherit from
	send-mail-function
Date: Thu, 25 Feb 2010 23:46:08 -0500

Glenn Morris wrote:

> I suggest a patch like the following:

I installed that because I think something like this is important for
tomorrow's (?) pretest. Comments welcome.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.