From unknown Sat Jun 21 10:37:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56408 <56408@debbugs.gnu.org> To: bug#56408 <56408@debbugs.gnu.org> Subject: Status: [PATCH] gnu: mia: Build against VTK 9. Reply-To: bug#56408 <56408@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:37:25 +0000 retitle 56408 [PATCH] gnu: mia: Build against VTK 9. reassign 56408 guix-patches submitter 56408 Felix Gruber severity 56408 normal tag 56408 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 15:40:11 2022 Received: (at submit) by debbugs.gnu.org; 5 Jul 2022 19:40:11 +0000 Received: from localhost ([127.0.0.1]:51740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8oOx-0006no-Jd for submit@debbugs.gnu.org; Tue, 05 Jul 2022 15:40:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:59828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8oOs-0006nG-SM for submit@debbugs.gnu.org; Tue, 05 Jul 2022 15:40:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8oOr-00039A-KG for guix-patches@gnu.org; Tue, 05 Jul 2022 15:39:58 -0400 Received: from mout01.posteo.de ([185.67.36.65]:37403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8oOp-0004nC-EM for guix-patches@gnu.org; Tue, 05 Jul 2022 15:39:57 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 21EF3240027 for ; Tue, 5 Jul 2022 21:39:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1657049992; bh=iBKqdAA2Sj5/Fd25Oj4MMfHdC5xrUdDwb7hf6/W3qxg=; h=From:To:Cc:Subject:Date:From; b=fbtW9QQzfrS2rmriFWOT5bTFdTZpOvhmT3obAzhUe5gBfp/eNoiIDqJg+6dgOSxfz ml7/k5rlL4Iu5m3OujxC7EzzKke6i3PqemgvUyzkAFzKgFkvFMMDXKpsw1w7JG8zF+ 5VzqQFwf1t0llNc7/qLFz8LCg7Q4GZ9pOKarScsZVugeJ2337DCKKoIcMMKrxkgH+x 7DQiZeyzd+dfwZmAKdbFSxBcvIL1i0an8tt9T2u/eXruNuMvBfpgcQmq3p3gdnuVrF hs9kMcnO2alryXSjx7QM1YFcfiY+oyiCdJTkuAI/fiz565enRTH3nGyj/uG757Otgt BstrSP5rbNujg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LctKz2Bvlz9rxL; Tue, 5 Jul 2022 21:39:51 +0200 (CEST) From: Felix Gruber To: guix-patches@gnu.org Subject: [PATCH] gnu: mia: Build against VTK 9. Date: Tue, 5 Jul 2022 19:39:48 +0000 Message-Id: <20220705193948.461428-1-felgru@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=felgru@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit Cc: Felix Gruber X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * gnu/packages/image-processing.scm (mia): Build against VTK 9. [inputs]: Remove vtk-7; add vtk. [source]: Add mia-vtk9.patch. * gnu/packages/patches/mia-vtk9.patch: New file. * gnu/local.mk: Add it. [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.6 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ambrevar.xyz (xyz)] -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * gnu/packages/image-processing.scm (mia): Build against VTK 9. [inputs]: Remove vtk-7; add vtk. [source]: Add mia-vtk9.patch. * gnu/packages/patches/mia-vtk9.patch: New file. * gnu/local.mk: Add it. --- gnu/local.mk | 1 + gnu/packages/image-processing.scm | 10 ++--- gnu/packages/patches/mia-vtk9.patch | 64 +++++++++++++++++++++++++++++ 3 files changed, 69 insertions(+), 6 deletions(-) create mode 100644 gnu/packages/patches/mia-vtk9.patch diff --git a/gnu/local.mk b/gnu/local.mk index faad6cc6b2..0a41b428d1 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1496,6 +1496,7 @@ dist_patch_DATA = \ %D%/packages/patches/meson-allow-dirs-outside-of-prefix.patch \ %D%/packages/patches/mhash-keygen-test-segfault.patch \ %D%/packages/patches/mia-fix-boost-headers.patch \ + %D%/packages/patches/mia-vtk9.patch \ %D%/packages/patches/mingw-w64-6.0.0-gcc.patch \ %D%/packages/patches/mingw-w64-dlltool-temp-prefix.patch \ %D%/packages/patches/mingw-w64-reproducible-gendef.patch \ diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm index 0c25b41dad..bcb1d7a2f6 100644 --- a/gnu/packages/image-processing.scm +++ b/gnu/packages/image-processing.scm @@ -13,7 +13,7 @@ ;;; Copyright © 2020 Pierre Neidhardt ;;; Copyright © 2020 Brendan Tildesley ;;; Copyright © 2021 Oleh Malyi -;;; Copyright © 2021 Felix Gruber +;;; Copyright © 2021, 2022 Felix Gruber ;;; Copyright © 2021 Andy Tai ;;; Copyright © 2021 Ekaitz Zarraga ;;; Copyright © 2021 Paul Garlick @@ -194,7 +194,8 @@ licences similar to the Modified BSD licence.")))) (sha256 (base32 "0qpcd3n26q52dpyibm11f5l6cgscdr54p2jish39gc3p1f5h3ws1")) - (patches (search-patches "mia-fix-boost-headers.patch")))) + (patches (search-patches "mia-fix-boost-headers.patch" + "mia-vtk9.patch")))) (build-system cmake-build-system) (arguments `(#:configure-flags @@ -221,10 +222,7 @@ licences similar to the Modified BSD licence.")))) nlopt openexr-2 python-lxml - ;; The build fails when using the regular VTK (currently at version - ;; 9), with error "addons/vtk/vtkvf.cc:23:10: fatal error: - ;; vtkStructuredPointsReader.h: No such file or directory". - vtk-7)) + vtk)) (native-inputs (list pkg-config python-wrapper)) diff --git a/gnu/packages/patches/mia-vtk9.patch b/gnu/packages/patches/mia-vtk9.patch new file mode 100644 index 0000000000..a8f1adab6c --- /dev/null +++ b/gnu/packages/patches/mia-vtk9.patch @@ -0,0 +1,64 @@ +This patch has been taken from +https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012689 +--- a/addons/vtk/CMakeLists.txt ++++ b/addons/vtk/CMakeLists.txt +@@ -20,9 +20,9 @@ + + IF(WITH_VTKIO) + if (STRICT_DEPENDECIES) +- FIND_PACKAGE(VTK REQUIRED COMPONENTS vtkIOImage vtkIOXML vtkIOLegacy) ++ FIND_PACKAGE(VTK REQUIRED COMPONENTS IOImage IOXML IOLegacy) + else (STRICT_DEPENDECIES) +- FIND_PACKAGE(VTK COMPONENTS vtkIOImage vtkIOXML vtkIOLegacy) ++ FIND_PACKAGE(VTK COMPONENTS IOImage IOXML IOLegacy) + endif (STRICT_DEPENDECIES) + IF(VTK_FOUND) + DEFINE_PROPERTY(GLOBAL PROPERTY HAVE_VTK_PROP BRIEF_DOCS "yeah" FULL_DOCS "yeah") +@@ -41,8 +41,17 @@ + SET(VTK_LINK_LIBS_3D ${SELECTED_VTK_LIBS} mia3d) + + PLUGIN_WITH_TEST_AND_PREFIX2("mesh" "io" vtkmesh "${VTK_LINK_LIBS_MESH}") ++ target_link_libraries(mesh-io-vtkmesh ${VTK_LIBRARIES}) ++ target_link_libraries(mesh-io-vtkmesh-common ${VTK_LIBRARIES}) ++ target_link_libraries(test-mesh-io-vtkmesh ${VTK_LIBRARIES}) + PLUGIN_WITH_TEST_AND_PREFIX2("3dvf" "io" vtkvf "${VTK_LINK_LIBS_3D}") ++ target_link_libraries(3dvf-io-vtkvf ${VTK_LIBRARIES}) ++ target_link_libraries(3dvf-io-vtkvf-common ${VTK_LIBRARIES}) ++ target_link_libraries(test-3dvf-io-vtkvf ${VTK_LIBRARIES}) + PLUGIN_WITH_TEST_AND_PREFIX2("3dimage" "io" vtkimage "${VTK_LINK_LIBS_3D}") ++ target_link_libraries(3dimage-io-vtkimage ${VTK_LIBRARIES}) ++ target_link_libraries(3dimage-io-vtkimage-common ${VTK_LIBRARIES}) ++ target_link_libraries(test-3dimage-io-vtkimage ${VTK_LIBRARIES}) + + ELSEIF(VTK_FOUND) + MESSAGE(MESSAGE "VTK not found, disabled") +--- a/addons/vtk/vtkmesh.cc ++++ b/addons/vtk/vtkmesh.cc +@@ -78,7 +78,8 @@ + // read all cells, if a cell is formed of more than 3 corners, then triangulate, + // if it hes less then 3 corners, ignore it (no wireframes supported here + auto triangles = CVtkMeshIO::PTrianglefield(new CVtkMeshIO::CTrianglefield ()); +- vtkIdType npts, *pts; ++ vtkIdType npts; ++ vtkIdType const *pts; + auto strips = mesh.GetStrips(); + + while (strips->GetNextCell(npts, pts)) { +@@ -183,7 +184,7 @@ + auto is = mesh.normals_begin(); + + for (auto i = 0; i < n_normals; ++i, ++is) { +- normals->GetTupleValue(i, &is->x); ++ normals->GetTypedTuple(i, &is->x); + cvdebug() << i << ": read normal " << *is << "\n"; + } + } +@@ -217,7 +218,7 @@ + auto is = mesh.color_begin(); + + for (auto i = 0; i < n_colors; ++i, ++is) +- colors->GetTupleValue(i, &is->x); ++ colors->GetTypedTuple(i, &is->x); + } + + PTriangleMesh CVtkMeshIO::do_load(string const& filename) const -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 17:20:18 2022 Received: (at 56408-done) by debbugs.gnu.org; 7 Jul 2022 21:20:18 +0000 Received: from localhost ([127.0.0.1]:58155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Yv4-0007rz-B4 for submit@debbugs.gnu.org; Thu, 07 Jul 2022 17:20:18 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Yv2-0007rr-9l for 56408-done@debbugs.gnu.org; Thu, 07 Jul 2022 17:20:16 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id DED5827BBE9; Thu, 7 Jul 2022 22:20:15 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 17b2be9a; Thu, 7 Jul 2022 21:20:15 +0000 (UTC) References: <20220705193948.461428-1-felgru@posteo.net> User-agent: mu4e 1.6.10; emacs 28.1 From: Christopher Baines To: Felix Gruber Subject: Re: [bug#56408] [PATCH] gnu: mia: Build against VTK 9. Date: Thu, 07 Jul 2022 22:19:46 +0100 In-reply-to: <20220705193948.461428-1-felgru@posteo.net> Message-ID: <877d4oliwg.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56408-done Cc: 56408-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Felix Gruber writes: > * gnu/packages/image-processing.scm (mia): Build against VTK 9. > [inputs]: Remove vtk-7; add vtk. > [source]: Add mia-vtk9.patch. > * gnu/packages/patches/mia-vtk9.patch: New file. > * gnu/local.mk: Add it. > --- > gnu/local.mk | 1 + > gnu/packages/image-processing.scm | 10 ++--- > gnu/packages/patches/mia-vtk9.patch | 64 +++++++++++++++++++++++++++++ > 3 files changed, 69 insertions(+), 6 deletions(-) > create mode 100644 gnu/packages/patches/mia-vtk9.patch Thanks Felix, I've pushed this as 45ed812da502344d58e8128515abd5b8ec6ca7a0. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmLHTg9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcPWw//e7XccsjJMJLqyJhzwN5AHadu+Bi/O+3A PJLIfpVTXzYutcgNbVvXAKfRIKveEY2M/YzOkDm4cbEVNSbDJdZf4NmKCn3xT7T6 pTD2SP3GgKgSlB3EDNJZDUcMaRElPHPE+KTEzP9QXZZkIkWby25kEzIYyzPXOZoC qKFper82WCV7DP1+SuOkZh+aVIbX9bOYnJmFGOIOq+8cPUs2gVEDe0fFjebrNO3j HS1NxNxCR1Waj+QBhXWjk7Fj2yoOIPIS0FOpkJl/uGXTHvIvEx/URC5Gij0kdyEG qr9iS7jUMYBr28uh0COpsO4KCSZMsdmr9CWgoOmxeq3kWwlNQGeuGIoZL6xZai/a kNSFODVNtWx2gvbuOlXKKi2HvVs6o8WCKJc4xgSpBsZ7fRmUfSlgfDtKOmtAlGaw 25DzULTTDyGGtAi3Bn3KuxRC1WUvgHRarDbNcs+3F0JEekZjbzp/r3AkgBZQ0D+s japX+ows6MxP6TMF858TqP2sYtkMzvu9d72iI7YllsC/gkCejZxaWUFl+k5sZGAR hl1MF9nOyLidSWyTzQhVtvHuJMDUQQFhm29o6O6hwwzr45KXTm2Jk8tD5HyJ7uH8 pedSErx8FT/ynbgHMncBSTR/QNuIHdHD/eFVSWzolh/TYEAzA0tnejxKhdDXhfQi xRDt5GKZ3F0= =vlIk -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 21 10:37:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Aug 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator