From unknown Sat Jul 26 15:31:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56398 <56398@debbugs.gnu.org> To: bug#56398 <56398@debbugs.gnu.org> Subject: Status: (guix git) fails to check out repos with nested submodules Reply-To: bug#56398 <56398@debbugs.gnu.org> Date: Sat, 26 Jul 2025 22:31:15 +0000 retitle 56398 (guix git) fails to check out repos with nested submodules reassign 56398 guix submitter 56398 Ludovic Court=C3=A8s severity 56398 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 11:02:59 2022 Received: (at submit) by debbugs.gnu.org; 5 Jul 2022 15:03:00 +0000 Received: from localhost ([127.0.0.1]:51243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8k4p-0007gC-It for submit@debbugs.gnu.org; Tue, 05 Jul 2022 11:02:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:59292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8k4k-0007fv-Oq for submit@debbugs.gnu.org; Tue, 05 Jul 2022 11:02:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8k4U-0007P7-IM for bug-guix@gnu.org; Tue, 05 Jul 2022 11:02:47 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:57808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8k4Q-0001mA-Ik for bug-guix@gnu.org; Tue, 05 Jul 2022 11:02:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=llkI03lP/YlvEjKODZLKf7Kvlt0Td+auIXwnVQTYl+M=; b=m5ubDxg4P/QdflIuBNwA1HTWFM9GV+9pIC9CYW3Dwb23jop/6SNuE5/E scRdiu4Az6I6ZkVZcQgW0NJKkRboePaC8UCnoByv72UXvWs1kkTfoUHys wHqUGjP+dndCMKaiTUeiaCKQrbifzwo/075ZvDUgja7mL41eGgZf3y60M 8=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.92,247,1650924000"; d="scan'208";a="44355158" Received: from unknown (HELO ribbon) ([193.50.110.235]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2022 17:02:31 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: bug-guix@gnu.org Subject: (guix git) fails to check out repos with nested submodules X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 17 Messidor an 230 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour de la Groseille X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 05 Jul 2022 17:02:31 +0200 Message-ID: <87sfnf4n7c.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=192.134.164.83; envelope-from=ludovic.courtes@inria.fr; helo=mail2-relais-roc.national.inria.fr X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, It seems that =E2=80=98update-cached-checkout=E2=80=99 fails to handle nest= ed Git submodules, when a submodule itself has submodules: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix refresh python-pytorch gnu/packages/machine-learning.scm:2872:13: python-pytorch would be upgraded= from 1.11.0 to 1.12.0 $ ./pre-inst-env guix refresh -u python-pytorch Backtrace: In ice-9/eval.scm: 619:8 19 (_ #(#(#))) In guix/ui.scm: 2238:7 18 (run-guix . _) 2201:10 17 (run-guix-command _ . _) In ice-9/boot-9.scm: 1752:10 16 (with-exception-handler _ _ #:unwind? _ # _) 1752:10 15 (with-exception-handler _ _ #:unwind? _ # _) In guix/store.scm: 659:37 14 (thunk) 2168:25 13 (run-with-store # =E2=80= =A6) In guix/scripts/refresh.scm: 560:16 12 (_ _) In srfi/srfi-1.scm: 634:9 11 (for-each # =E2=80=A6) In guix/scripts/refresh.scm: 309:22 10 (update-package _ # =E2=80=A6) In guix/upstream.scm: 475:10 9 (package-update/git-fetch _ _ #< pack=E2=80= =A6> =E2=80=A6) In guix/git.scm: 550:8 8 (latest-repository-commit # =E2=80=A6) 472:7 7 (update-cached-checkout _ #:ref _ #:recursive? _ # _ # _ =E2= =80=A6) In srfi/srfi-1.scm: 634:9 6 (for-each # =E2=80=A6) In guix/git.scm: 333:20 5 (_ _) In srfi/srfi-1.scm: 634:9 4 (for-each # =E2=80=A6) In guix/git.scm: 325:16 3 (_ _) In git/bindings.scm: 77:2 2 (raise-git-error _) In ice-9/boot-9.scm: 1685:16 1 (raise-exception _ #:continuable? _) 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: Git error: failed to resolve path '/home/ludo/.cache/guix/checkouts/orwu3gj= 6brdg2ui6r2tl5me7plucokpvqvgbhe2yuo6jc2tovvha/third_party/gloo/third-party/= googletest/.git': No such file or directory $ $ ls /home/ludo/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbh= e2yuo6jc2tovvha/third_party/gloo/third-party/ ls: cannot access '/home/ludo/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me= 7plucokpvqvgbhe2yuo6jc2tovvha/third_party/gloo/third-party/': No such file = or directory $ ls /home/ludo/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbh= e2yuo6jc2tovvha/third_party/gloo/ cmake/ CODE_OF_CONDUCT.md docs/ LICENSE tools/ CMakeLists.txt CONTRIBUTING.md gloo/ README.md $ ls /home/ludo/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbh= e2yuo6jc2tovvha/third_party/gloo/.gitmodules=20 /home/ludo/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbhe2yuo= 6jc2tovvha/third_party/gloo/.gitmodules --8<---------------cut here---------------end--------------->8--- Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 17:36:16 2022 Received: (at 56398) by debbugs.gnu.org; 7 Jul 2022 21:36:17 +0000 Received: from localhost ([127.0.0.1]:58193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9ZAR-0008Jh-0n for submit@debbugs.gnu.org; Thu, 07 Jul 2022 17:36:16 -0400 Received: from mx1.riseup.net ([198.252.153.129]:38748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9ZAL-0008Ik-RR for 56398@debbugs.gnu.org; Thu, 07 Jul 2022 17:36:09 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4Lf8q36TjLzDrb4; Thu, 7 Jul 2022 21:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1657229760; bh=Va6iI9E8Lt1PGzMku+WHG/3IP457iDcSj7A2kjYXS/8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fEWNi7JsK3lo4U2ifwWp5zn/QLToXXN7klZWwH1BapCkJbzB8DUAqPjMt042pvIEQ BTss9oOo46DM5f2b5SotbupOdY9KJRmUtzeCxq2p4Qs6W35r1zSg0gzLpmHZHSle6j FzuJE3tP0OkVV2h4nmY3iLSutKyBzB9lLGSv0MsA= X-Riseup-User-ID: 5027F1966ABED0C64320BBDF9FD705200C1FB2CE18D945D12A2F0DEB2DF50747 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4Lf8q25ZH4z1yQq; Thu, 7 Jul 2022 21:35:58 +0000 (UTC) Date: Thu, 7 Jul 2022 18:35:42 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: References: <87sfnf4n7c.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87sfnf4n7c.fsf@inria.fr> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! ter 05 jul 2022 às 17:02:31 (1657051351), ludovic.courtes@inria.fr enviou: > It seems that ‘update-cached-checkout’ fails to handle nested Git > submodules, when a submodule itself has submodules: I think this may be actually a bug upstream. When refreshing, guix is able to recursively upgrade submodules under 'thirdparty/fbgemm' just fine, but it fails on thirdparty/gloo because the path declared on its .gitmodules does not exist on the repository: --8<---------------cut here---------------start------------->8--- user@guix /src/guix.git$ cat ~/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbhe2yuo6jc2tovvha/third_party/gloo/.gitmodules [submodule "third-party/googletest"] path = third-party/googletest url = https://github.com/google/googletest.git user@guix /src/guix.git$ ls ~/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbhe2yuo6jc2tovvha/third_party/gloo/ cmake/ CMakeLists.txt CODE_OF_CONDUCT.md CONTRIBUTING.md docs/ gloo/ LICENSE README.md tools/ user@guix /src/guix.git$ cat ~/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbhe2yuo6jc2tovvha/third_party/fbgemm/.gitmodules [submodule "third_party/asmjit"] path = third_party/asmjit url = https://github.com/asmjit/asmjit.git [submodule "third_party/cpuinfo"] path = third_party/cpuinfo url = https://github.com/pytorch/cpuinfo [submodule "third_party/googletest"] path = third_party/googletest url = https://github.com/google/googletest user@guix /src/guix.git$ ls ~/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbhe2yuo6jc2tovvha/third_party/fbgemm/third_party/ asmjit/ asmjit.BUILD cpuinfo/ cpuinfo.BUILD googletest/ user@guix ~$ cat ~/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbhe2yuo6jc2tovvha/.git/modules/third_party/gloo/config [core] bare = false repositoryformatversion = 0 filemode = true logallrefupdates = true worktree = ../../../../third_party/gloo/ [remote "origin"] url = https://github.com/facebookincubator/gloo fetch = +refs/heads/*:refs/remotes/origin/* [branch "main"] remote = origin merge = refs/heads/main user@guix ~$ cat ~/.cache/guix/checkouts/orwu3gj6brdg2ui6r2tl5me7plucokpvqvgbhe2yuo6jc2tovvha/.git/modules/third_party/fbgemm/config [core] bare = false repositoryformatversion = 0 filemode = true logallrefupdates = true worktree = ../../../../third_party/fbgemm/ [remote "origin"] url = https://github.com/pytorch/fbgemm fetch = +refs/heads/*:refs/remotes/origin/* [branch "main"] remote = origin merge = refs/heads/main [submodule "third_party/asmjit"] url = https://github.com/asmjit/asmjit.git [submodule "third_party/cpuinfo"] url = https://github.com/pytorch/cpuinfo [submodule "third_party/googletest"] url = https://github.com/google/googletest --8<---------------cut here---------------end--------------->8--- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 22:45:58 2022 Received: (at 56398) by debbugs.gnu.org; 8 Jul 2022 02:45:58 +0000 Received: from localhost ([127.0.0.1]:58427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9e0A-0002Q3-31 for submit@debbugs.gnu.org; Thu, 07 Jul 2022 22:45:58 -0400 Received: from mx0.riseup.net ([198.252.153.6]:43690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9e04-0002Pn-Uw for 56398@debbugs.gnu.org; Thu, 07 Jul 2022 22:45:53 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4LfHhR1cHrz9t4C; Fri, 8 Jul 2022 02:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1657248343; bh=7bIbejM2FHSKQv20Yqvhpkf1Z30Fl0FXXyvCUjFT/50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PyOwHI7ctYnw1PXN7Wt+v2g9HH9i4xFbGrRiChnVN0hjUPD3/DZGL4lVNaVDJID3N 4Gx7DNnlWjpdj5/XGMXDW9o2lWe1fTmTNo6rhAcY6bVjY8lNm8oYP7Eyfbphf1J7Wh tJ5E4S+e064elkZM1hXNhIegBR0APfh6cNjGmxOE= X-Riseup-User-ID: D66EE8E4CE598F03B40CE082245A5EBB43FA5711F2306A9E91D9D348E7189FDD Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4LfHhQ1SKJz1yTJ; Fri, 8 Jul 2022 02:45:41 +0000 (UTC) Date: Thu, 7 Jul 2022 23:45:35 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: References: <87sfnf4n7c.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) qui 07 jul 2022 às 18:35:42 (1657229742), nandre@riseup.net enviou: > I think this may be actually a bug upstream. (...) I mean, we could change the submodule-update fetch-options to allow for repository initialization when it's absent, but does it make sense considering we would just remove it when building the package and use package inputs' version instead? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 08 04:26:51 2022 Received: (at 56398) by debbugs.gnu.org; 8 Jul 2022 08:26:51 +0000 Received: from localhost ([127.0.0.1]:58668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9jK7-0007yJ-2E for submit@debbugs.gnu.org; Fri, 08 Jul 2022 04:26:51 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:23566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9jK3-0007xs-Ma for 56398@debbugs.gnu.org; Fri, 08 Jul 2022 04:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=SU3XiAmgD9kDCvdAZilX9UP3UwmhxAaP4P2lRkTHprE=; b=He9O7DmUlrjG+EDEoM6H+kga0rsKD54uiA14TjrTFaQkgB0jylIl+WIa ob3BwYsl03YaB4hzV56Qpm4qIV4KuVjaQvh2uB7Kbyw6H0VUNSXNv2089 ohRIe77p55kr/X+yLizltQ2l02jaEnK0I6IG0/CoPPl7vkJFkiOJjtOoj I=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.92,255,1650924000"; d="scan'208";a="18871355" Received: from unknown (HELO ribbon) ([193.50.110.235]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 10:26:42 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Andr=C3=A9?= Batista Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules References: <87sfnf4n7c.fsf@inria.fr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?utf-8?Q?D=C3=A9cadi?= 20 Messidor an 230 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Parc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 08 Jul 2022 10:26:40 +0200 In-Reply-To: (=?utf-8?Q?=22Andr=C3=A9?= Batista"'s message of "Thu, 7 Jul 2022 18:35:42 -0300") Message-ID: <87pmigxb5r.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Andr=C3=A9 Batista skribis: > Hi! > > ter 05 jul 2022 =C3=A0s 17:02:31 (1657051351), ludovic.courtes@inria.fr e= nviou: >> It seems that =E2=80=98update-cached-checkout=E2=80=99 fails to handle n= ested Git >> submodules, when a submodule itself has submodules: > > I think this may be actually a bug upstream. When refreshing, guix is > able to recursively upgrade submodules under 'thirdparty/fbgemm' just > fine, but it fails on thirdparty/gloo because the path declared on > its .gitmodules does not exist on the repository: Oh indeed. The bug probably doesn=E2=80=99t have to do with nested submodu= les; it manifests when checking out that gloo repo: --8<---------------cut here---------------start------------->8--- scheme@(guix git)> (update-cached-checkout "https://github.com/facebookincu= bator/gloo" #:recursive? #t) ice-9/boot-9.scm:1685:16: In procedure raise-exception: Git error: failed to resolve path '/home/ludo/.cache/guix/checkouts/4pe5bqk= msmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/third-party/googletest/.git':= No such file or directory Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue. --8<---------------cut here---------------end--------------->8--- If we do this: --8<---------------cut here---------------start------------->8--- scheme@(guix git)> (define r (repository-open "/home/ludo/.cache/guix/check= outs/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/")) scheme@(guix git)> (define mod (submodule-lookup r "third-party/googletest"= )) scheme@(guix git)> mod $13 =3D # scheme@(guix git)> (submodule-update $13) ice-9/boot-9.scm:1685:16: In procedure raise-exception: Git error: failed to resolve path '/home/ludo/.cache/guix/checkouts/4pe5bqk= msmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/third-party/googletest/.git':= No such file or directory Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue. --8<---------------cut here---------------end--------------->8--- =E2=80=A6 the =E2=80=98submodule-update=E2=80=99 bit looks like this: --8<---------------cut here---------------start------------->8--- newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.gitmodules", {st_mode=3DS_IFREG|0644, st_= size=3D116, ...}, 0) =3D 0 access("/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2d= ciznz7shwawckb32sq/.gitmodules", F_OK) =3D 0 access("/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2d= ciznz7shwawckb32sq/.gitmodules", R_OK) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.gitmodules", {st_mode=3DS_IFREG|0644, st_= size=3D116, ...}, 0) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.gitmodules", {st_mode=3DS_IFREG|0644, st_= size=3D116, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.gitmodules", O_RDONLY|O_CLOEXEC) =3D 15 read(15, "[submodule \"third-party/googletest\"]\n\tpath =3D third-party/go= ogletest\n\turl =3D https://github.com/google/googletest.git\n", 116) =3D 1= 16 close(15) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.gitmodules", {st_mode=3DS_IFREG|0644, st_= size=3D116, ...}, 0) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/third-party/googletest", 0x7ffdd31497f0, 0= ) =3D -1 ENOENT (No such file or directory) access("/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2d= ciznz7shwawckb32sq/third-party/googletest/.git", F_OK) =3D -1 ENOENT (No su= ch file or directory) newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.git/HEAD", {st_mode=3DS_IFREG|0644, st_si= ze=3D21, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.git/HEAD", O_RDONLY|O_CLOEXEC) =3D 15 read(15, "ref: refs/heads/main\n", 21) =3D 21 close(15) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.git/refs/heads/main", {st_mode=3DS_IFREG|= 0644, st_size=3D41, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.git/refs/heads/main", O_RDONLY|O_CLOEXEC) =3D= 15 read(15, "950c0e23819779a9e0c70b861db4c52b31d1d1b2\n", 41) =3D 41 close(15) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.git/HEAD", {st_mode=3DS_IFREG|0644, st_si= ze=3D21, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.git/HEAD", O_RDONLY|O_CLOEXEC) =3D 15 read(15, "ref: refs/heads/main\n", 21) =3D 21 close(15) =3D 0 newfstatat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwz= vmnjlie6jyhx2dciznz7shwawckb32sq/.git/refs/heads/main", {st_mode=3DS_IFREG|= 0644, st_size=3D41, ...}, 0) =3D 0 openat(AT_FDCWD, "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnj= lie6jyhx2dciznz7shwawckb32sq/.git/refs/heads/main", O_RDONLY|O_CLOEXEC) =3D= 15 read(15, "950c0e23819779a9e0c70b861db4c52b31d1d1b2\n", 41) =3D 41 close(15) =3D 0 --8<---------------cut here---------------end--------------->8--- Thus, looking at =E2=80=98git_submodule_update=E2=80=99 in libgit2, it look= s as if this condition was true: (submodule_status & GIT_SUBMODULE_STATUS_WD_UNINITIALIZED) Hmm, thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 08 06:18:26 2022 Received: (at 56398) by debbugs.gnu.org; 8 Jul 2022 10:18:26 +0000 Received: from localhost ([127.0.0.1]:58890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9l46-00074S-8R for submit@debbugs.gnu.org; Fri, 08 Jul 2022 06:18:26 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:35324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9l42-00073q-6c for 56398@debbugs.gnu.org; Fri, 08 Jul 2022 06:18:24 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id C140062551; Fri, 8 Jul 2022 10:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bokr.com; s=easymail; t=1657275495; bh=Ot//mO7FxE2unjhl+eOkz0bIfDAHhWkTdXVIcYlTgss=; h=From:Date:To:Cc:Subject:References:In-Reply-To:From; b=aSELuduMtZ2+/I3poH14M+qMNVbB1i2IgwoA51JQMwltl4pua4StGUflmnMZMomgD Cd8a8vnBI9Jtz8Ue6eyN65heYzAR7Bp0T150iOWVhA+yEZuWm3ugYnEg5QD/7AIvvg 6XDUAJgUHoRuVO0nCgFU9cTZa6hcEzWlWevnrC58aMD8EaM+18jc/lZvGRLmZJgvaR rFLQmdt9r+2skifoiWpEKh9WctvVALxfOkvq427Vfc8xY6kFdhgR5g51TLW8RmdbTi hvfAtPww3oZzHgF/+tNpl0dHeP2WRcLlH/+pACd3YOqiqyOZPg9u7u7LI/2lFGAMRa /pZBQ8oAbWQYQ== X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hPS5L1h6r4le; Fri, 8 Jul 2022 10:18:15 +0000 (UTC) Received: from localhost (m83-185-37-249.cust.tele2.se [83.185.37.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id F307D62550; Fri, 8 Jul 2022 10:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bokr.com; s=easymail; t=1657275495; bh=Ot//mO7FxE2unjhl+eOkz0bIfDAHhWkTdXVIcYlTgss=; h=From:Date:To:Cc:Subject:References:In-Reply-To:From; b=aSELuduMtZ2+/I3poH14M+qMNVbB1i2IgwoA51JQMwltl4pua4StGUflmnMZMomgD Cd8a8vnBI9Jtz8Ue6eyN65heYzAR7Bp0T150iOWVhA+yEZuWm3ugYnEg5QD/7AIvvg 6XDUAJgUHoRuVO0nCgFU9cTZa6hcEzWlWevnrC58aMD8EaM+18jc/lZvGRLmZJgvaR rFLQmdt9r+2skifoiWpEKh9WctvVALxfOkvq427Vfc8xY6kFdhgR5g51TLW8RmdbTi hvfAtPww3oZzHgF/+tNpl0dHeP2WRcLlH/+pACd3YOqiqyOZPg9u7u7LI/2lFGAMRa /pZBQ8oAbWQYQ== From: bokr@bokr.com Date: Fri, 8 Jul 2022 12:17:59 +0200 To: =?utf-8?B?QW5kcsOp?= Batista Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: <20220708101759.GA6315@LionPure> References: <87sfnf4n7c.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56398 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, On +2022-07-07 23:45:35 -0300, André Batista wrote: > qui 07 jul 2022 às 18:35:42 (1657229742), nandre@riseup.net enviou: > > I think this may be actually a bug upstream. (...) > > I mean, we could change the submodule-update fetch-options to allow > for repository initialization when it's absent, but does it make > sense considering we would just remove it when building the package > and use package inputs' version instead? > Have you seen this[1] re nested git tricks? [1]: i.e., are you sure not to be used by some such attack? (article was over a year ago, so there must be more on related git problems by now?) -- Regards, Bengt Richter From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 07:44:25 2022 Received: (at 56398) by debbugs.gnu.org; 4 Aug 2022 11:44:25 +0000 Received: from localhost ([127.0.0.1]:51459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZH6-0006sK-NA for submit@debbugs.gnu.org; Thu, 04 Aug 2022 07:44:25 -0400 Received: from mx1.riseup.net ([198.252.153.129]:56346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZH1-0006s1-8B for 56398@debbugs.gnu.org; Thu, 04 Aug 2022 07:44:23 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4Lz6MK47B6zDrfd; Thu, 4 Aug 2022 11:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1659613453; bh=in3Y79DmsWshf+9Xk9adtSKmgitRdEsUMnXhffZNNtI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dM8z9l0aGP0rqRjQAcvyCWyqUgV3/ghWk74oHov5xsJgK+h2xzIM7bsEA27xTtXac vLfLOuvCoWK8jZaBCaoId5I9FHWQyJlyDEVpXmh4FXFaaxRh4Dut6YQfKMw4GQS1Yp XfpttlS4Jcb1/k3g/yTDD3zTFcri2vRO0fFOHI6s= X-Riseup-User-ID: 6D476C40040550CD79FAE87EE0C6A1EB71A55AC55DA168EF2F0B908BA410E5AE Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4Lz6MJ25Zfz214k; Thu, 4 Aug 2022 11:44:12 +0000 (UTC) Date: Thu, 4 Aug 2022 08:43:49 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="u4zcwAmZBclUJiwX" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87pmigxb5r.fsf@inria.fr> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --u4zcwAmZBclUJiwX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi and I'm sorry for the delay.. sex 08 jul 2022 às 10:26:40 (1657286800), ludovic.courtes@inria.fr enviou: > If we do this: > > --8<---------------cut here---------------start------------->8--- > scheme@(guix git)> (define r (repository-open "/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/")) > scheme@(guix git)> (define mod (submodule-lookup r "third-party/googletest")) > scheme@(guix git)> mod > $13 = # > scheme@(guix git)> (submodule-update $13) > ice-9/boot-9.scm:1685:16: In procedure raise-exception: > Git error: failed to resolve path '/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/third-party/googletest/.git': No such file or directory Nice trick! > (...) > access("/home/ludo/.cache/guix/checkouts/4pe5bqkmsmcros5oviwzvmnjlie6jyhx2dciznz7shwawckb32sq/third-party/googletest/.git", F_OK) = -1 ENOENT (No such file or directory) > (...) > > Thus, looking at ‘git_submodule_update’ in libgit2, it looks as if this > condition was true: > > (submodule_status & GIT_SUBMODULE_STATUS_WD_UNINITIALIZED) > > Hmm, thoughts? Well, I guess ENOENT != GIT_ENOTFOUND and, in that case, I think we are better off gracefully failing to update it than trying to "branch" our local repo. The patch below tests for the directory's existence before proceding with the update. With this patch applied I've managed to refresh pytorch, its submodules and got the following code: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm index b19af8a1d5..174ba3d39b 100644 --- a/gnu/packages/machine-learning.scm +++ b/gnu/packages/machine-learning.scm @@ -2871,7 +2871,7 @@ (define-public xnnpack (define-public python-pytorch (package (name "python-pytorch") - (version "1.12.0") + (version "82782") (source (origin (method git-fetch) (uri (git-reference @@ -2881,7 +2881,7 @@ (define-public python-pytorch (file-name (git-file-name name version)) (sha256 (base32 - "0pdqi91qzgyx947zv4pw2fdj9vpqvdhfzw1ydjd4mpqm8g5njgnz")) + "0zshqfqv3lcwyym3l8zx675chnhpxn14c4nr1c2b7ci1zis785va")) (patches (search-patches "python-pytorch-system-libraries.patch" "python-pytorch-runpath.patch")) (modules '((guix build utils))) --8<---------------cut here---------------end--------------->8--- Where "82782" is a ciflow/trunk reference to commit 700dba518be03ee0c0d6389162b5907a13838f49. I've also thought of filtering the submodules list and passing the resulting list instead, but came to conclude that it would clutter the code instead of simplifying it. I hope that helps! --- --u4zcwAmZBclUJiwX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline; filename="git-scm.patch" Content-Transfer-Encoding: 8bit >From 10bbb79f87f3728c347e33a101add8cb740e9469 Mon Sep 17 00:00:00 2001 In-Reply-To: <56398@debbugs.gnu.org> References: <56398@debbugs.gnu.org> From: =?UTF-8?q?Andr=C3=A9=20Batista?= Date: Thu, 4 Aug 2022 08:07:35 -0300 Subject: [PATCH] guix: git: Gracefully handle missing submodules when updating. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: debbugs@gnu.org Fixes . Reported by Ludovic Courtès . * guix/git.scm (update-submodules): Check if submodule directory exists before trying to update it. --- guix/git.scm | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/guix/git.scm b/guix/git.scm index 631bf577d3..d6a82fb86c 100644 --- a/guix/git.scm +++ b/guix/git.scm @@ -320,20 +320,22 @@ (define* (update-submodules repository (fetch-options #f)) "Update the submodules of REPOSITORY, a Git repository object." (for-each (lambda (name) - (let ((submodule (submodule-lookup repository name))) + (let* ((submodule (submodule-lookup repository name)) + (directory (string-append + (repository-working-directory repository) + "/" (submodule-path submodule)))) (format log-port (G_ "updating submodule '~a'...~%") name) - (submodule-update submodule - #:fetch-options fetch-options) - - ;; Recurse in SUBMODULE. - (let ((directory (string-append - (repository-working-directory repository) - "/" (submodule-path submodule)))) - (with-repository directory repository - (update-submodules repository - #:fetch-options fetch-options - #:log-port log-port))))) + (if (file-exists? directory) + ((lambda () + (submodule-update submodule + #:fetch-options fetch-options) + + ;; Recurse in SUBMODULE. + (with-repository directory repository + (update-submodules repository + #:fetch-options fetch-options + #:log-port log-port))))))) (repository-submodules repository))) (define-syntax-rule (false-if-git-not-found exp) -- 2.36.0 --u4zcwAmZBclUJiwX-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 07:59:34 2022 Received: (at 56398) by debbugs.gnu.org; 4 Aug 2022 11:59:34 +0000 Received: from localhost ([127.0.0.1]:51474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZVk-0007I2-5g for submit@debbugs.gnu.org; Thu, 04 Aug 2022 07:59:34 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:37626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZVf-0007Hl-Gu for 56398@debbugs.gnu.org; Thu, 04 Aug 2022 07:59:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=Gmsh83OdmU1ENN/ERJOjdOjfIiTPTkqO/bQ97Ns2YIQ=; b=Sk3hCZoRn+sPHKNZZZnd0TLNlWuF1zsWTfUk45nHSYxTbUDIT94wSRqr Y2GteSIXWGqkEtXPPbl+WeD4fGd/GLCz6fzY7IlkoBeFTP6YrmOqm3zud R0QZK00eNTNomfUwTzXR/t5X4vlmg9upTLLFmu2hTcKYcVlC+c1oAmjH6 A=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.93,215,1654552800"; d="scan'208";a="20780720" Received: from unknown (HELO ribbon) ([193.50.111.124]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2022 13:59:21 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Andr=C3=A9?= Batista Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 17 Thermidor an 230 de la =?utf-8?Q?R=C3=A9v?= =?utf-8?Q?olution=2C?= jour du Lin X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 04 Aug 2022 13:59:20 +0200 In-Reply-To: (=?utf-8?Q?=22Andr=C3=A9?= Batista"'s message of "Thu, 4 Aug 2022 08:43:49 -0300") Message-ID: <87h72smd7r.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Andr=C3=A9 Batista skribis: > Well, I guess ENOENT !=3D GIT_ENOTFOUND and, in that case, I think we > are better off gracefully failing to update it than trying to "branch" > our local repo. The patch below tests for the directory's existence > before proceding with the update. With this patch applied I've managed > to refresh pytorch, its submodules and got the following code: But you got a wrong hash I presume, because submodule weren=E2=80=99t actua= lly checked out, right? > + (if (file-exists? directory) > + ((lambda () > + (submodule-update submodule > + #:fetch-options fetch-options) The problem is that it papers over an actual libgit2 bug. I think we should instead report it upstream. Do you feel like doing it? I guess we=E2=80=99d need to give them the C version of the three-line snippet I gave earlier. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 08:02:14 2022 Received: (at 56398) by debbugs.gnu.org; 4 Aug 2022 12:02:14 +0000 Received: from localhost ([127.0.0.1]:51482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZYM-0007OR-BG for submit@debbugs.gnu.org; Thu, 04 Aug 2022 08:02:14 -0400 Received: from mx1.riseup.net ([198.252.153.129]:59448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZYJ-0007OC-9b for 56398@debbugs.gnu.org; Thu, 04 Aug 2022 08:02:12 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4Lz6lx339YzDrhy; Thu, 4 Aug 2022 12:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1659614525; bh=S7tfGprI5rDtdAuYWg5keY30jhVZoKLcMaVqRcQTheY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cWla+LzzHGasTsp9tXsXohN3utH+2HpZRaEYhAzcuYZ6o13wggd890+cDI0x9vS4+ QnzF34AsCslVddEVy0jrUBUBEe6T/afNS9HADPwaV90X1yuOck+gUKK5k7m6HshyjE Uwhz0QZd7X4ketRVNYdktwxyaqchm/T5USSPClgM= X-Riseup-User-ID: 6B40686D12ED805322046FA366C0FB1598EE06A75705642504641C8AC58F47AA Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4Lz6ls3MnDz1yWd; Thu, 4 Aug 2022 12:02:01 +0000 (UTC) Date: Thu, 4 Aug 2022 09:01:21 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: bokr@bokr.com Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: References: <87sfnf4n7c.fsf@inria.fr> <20220708101759.GA6315@LionPure> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220708101759.GA6315@LionPure> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: Ludovic =?iso-8859-1?Q?Court=E8s?= , 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Bengt! sex 08 jul 2022 às 12:17:59 (1657293479), bokr@bokr.com enviou: > Have you seen this[1] re nested git tricks? > > [1]: No, I had missed that, thanks for pointing that out! > i.e., are you sure not to be used by some such attack? However I think this git issue is orthogonal to the current one. First, inits, clones and checkouts are key git features, so it's up to git to make sure its subcommands will not execute code by mistake. Second, to exploit it, the attacker would have to make themselves very visible by maintaining a public malicious repo which would be bound to be flagged. And lastly, guile-git uses libgit2, which is a different beast that actually auto initializes submodules when updating, contrary to my mistaken assumption to which you've replied. I thought initialization implied directory creation, but it actually doesn't. Cheers! From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 16:11:33 2022 Received: (at 56398) by debbugs.gnu.org; 5 Aug 2022 20:11:33 +0000 Received: from localhost ([127.0.0.1]:60629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK3fQ-0000f4-Mp for submit@debbugs.gnu.org; Fri, 05 Aug 2022 16:11:33 -0400 Received: from mx1.riseup.net ([198.252.153.129]:43250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK3fL-0000eo-72 for 56398@debbugs.gnu.org; Fri, 05 Aug 2022 16:11:31 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4LzxZ13PvmzDqq7; Fri, 5 Aug 2022 20:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1659730281; bh=/NpUKsMng68hPcjH+NUgYL4HWhjEr3Q8BDqSektQysg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=btMqGEvlBV5VX5TB+p3zfZfzy6ZqojlyNOSXioBme0xgZJu6QcVCw/fmUPRfDVpVr DTsVyAfeaiQzdxqBhJbBWdRAK9GgVnoiA5pdk8uNFxYMvfTX4giLyY084jz01Ui5Yh LxIQZCwwlkI7BfdUcFNUMJkVEX0bsEFHnGt+3mVE= X-Riseup-User-ID: C70D26318FB68A91AF912CA1BE6529FCFF2C184E76996D27A9FAF09CE8740F5D Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4LzxZ01YkCz1yWm; Fri, 5 Aug 2022 20:11:20 +0000 (UTC) Date: Fri, 5 Aug 2022 17:10:50 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> <87h72smd7r.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h72smd7r.fsf@inria.fr> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) qui 04 ago 2022 às 13:59:20 (1659632360), ludovic.courtes@inria.fr enviou: > But you got a wrong hash I presume, because submodule weren’t actually > checked out, right? The submodule was not checked out, sure, but is it the wrong hash considering it's also not present on the remote repo? > The problem is that it papers over an actual libgit2 bug. Does it though? I'm trying to wrap my head over this, but I'm somewhat unsure that this isn't the intended - expected? - behaviour on this case: I've cloned gloo and issued 'git submodule status' and it returns nothing. I've also issued 'git submodule update --init --recursive' and it also does nothing. The documentation for git-submodule init[1] says "Initialize the submodules recorded in the index (which were _added and commited_ elsewhere)..." and it also says on 'add' subcommand "Add the given repo as a submodule at the given path to the changeset to be commited next to the current project..." The documentation for gitsubmodules[2] says that submodules can take the following forms: - a .git directory, a working directory, a gitlink and a .gitmodules; or - a working directory with an embedded .git directory (...) The description for libgit2's git_submodule_init (which would've been called if the error was GIT_ENOTFOUND and we were initializing it) only says "Copy submodule info into .git/config", which coincides with what 'git submodule init' does. There is also a git_submodule_add_setup routine which can be called to emulate what 'git submodule add' would've done. Finally, libgit2 provides a git_submodule_repo_init routine which would "set up the subrepository for a submodule in preparation for clone", instead of just copying the submodule info into .git/config as git_submodule_init does. So, I'm inclined to think that this is not a bug on libgit2, but a result of gloo having misconfigured its submodule and it's not surprising that 'git_submodule_update' is erroring out. If so, any program using this library should decide what to do with the returned error, right? > I think we should instead report it upstream. Do you feel like doing > it? I guess we’d need to give them the C version of the three-line > snippet I gave earlier. > > WDYT? "Feel like doing it" is a stretch, but I'll gladly do it so that at least we will know that they've considered this scenario and, if they agree with you, we and other users may have a proper fix. Let's see if I can conjure some C incantation. Cheers! [1] https://git-scm.com/docs/git-submodule [2] https://git-scm.com/docs/gitsubmodules From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 18:40:35 2022 Received: (at 56398) by debbugs.gnu.org; 5 Aug 2022 22:40:35 +0000 Received: from localhost ([127.0.0.1]:60689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK5ze-0004QW-SX for submit@debbugs.gnu.org; Fri, 05 Aug 2022 18:40:35 -0400 Received: from mx1.riseup.net ([198.252.153.129]:53094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK5zd-0004QF-Ep for 56398@debbugs.gnu.org; Fri, 05 Aug 2022 18:40:34 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4M00t31XJnzDqPB; Fri, 5 Aug 2022 22:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1659739227; bh=HMlfzZLdIvufHJKRj6uc/fNjiqZyI9FlqNBhLmK5Kg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iE4UOnDkFiXOU/onieqK2KLDRcABvgWIufOt2IxYUt0r9LFzQl+maaZoYabIRVDGs lucAqMen0YyKHq2LHuNQpacSNtHg0nu9NB7JFDlZvB5plyUH8zmtBt520Bf8rMITmR tCZ4frVZRU67ngBPNZvMMt4roIlDGC04/JSs+G5g= X-Riseup-User-ID: B3CA2C84A70F9E69985F194E8CD2A2B34F0A0AE570AB8CFE7F21801018585360 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4M00t20vR5z1yQc; Fri, 5 Aug 2022 22:40:25 +0000 (UTC) Date: Fri, 5 Aug 2022 19:40:17 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> <87h72smd7r.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) sex 05 ago 2022 às 17:10:50 (1659730250), nandre@riseup.net enviou: > Does it though? I'm trying to wrap my head over this, but I'm somewhat > unsure that this isn't the intended - expected? - behaviour on this > case: > (...) > So, I'm inclined to think that this is not a bug on libgit2, but a > result of gloo having misconfigured its submodule and it's not > surprising that 'git_submodule_update' is erroring out. If so, any > program using this library should decide what to do with the returned > error, right? On further thinking, I guess I see what you mean: there's not much to be done in such a case and it would be better if libgit2 would silently fail, mimicking what git itself does, otherwise this logic would need to be reproduced everywhere else for no reason whatsoever. Sorry for the noise! From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 24 10:17:25 2022 Received: (at 56398) by debbugs.gnu.org; 24 Nov 2022 15:17:25 +0000 Received: from localhost ([127.0.0.1]:59822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyDyf-0008AL-Eo for submit@debbugs.gnu.org; Thu, 24 Nov 2022 10:17:25 -0500 Received: from mx1.riseup.net ([198.252.153.129]:56180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyDye-0008A3-10 for 56398@debbugs.gnu.org; Thu, 24 Nov 2022 10:17:24 -0500 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4NJ1nV27gQzDqkj; Thu, 24 Nov 2022 15:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1669303038; bh=PBTIpqsEZ+mYNnFNEe9k5jAAD2Ms1pRR4Tzf3aPOjMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JXe1yDJlj8rRN/XlVSZW9c8zJHZmNP/HKhkFkUAw050amIKOC0mRxAtRGCguy44S1 Qvo7dusb0aR01b9SoYonHUy5g2LMeL+PkrbeXVtrc6ulRBuYTKdEYtSkCGXVSyNlHZ 5DE2zMavG2brm2zeYe2akDtHXbwClVd5d4LvGIVE= X-Riseup-User-ID: 51520BE9F34480658987A0402D33F2B89CFEEE12BDC907D1D1184BD614F3A28A Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4NJ1nS6y8nz1yQ0; Thu, 24 Nov 2022 15:17:16 +0000 (UTC) Date: Thu, 24 Nov 2022 12:17:01 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> <87h72smd7r.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h72smd7r.fsf@inria.fr> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi! qui 04 ago 2022 às 13:59:20 (1659632360), ludovic.courtes@inria.fr enviou: > I think we should instead report it upstream. Do you feel like doing > it? I guess we’d need to give them the C version of the three-line > snippet I gave earlier. Upstream issue #6433[1] Apparently, GIT_SUBMODULE_STATUS_WD_UNINITIALIZED isn't actually set in this scenario, only GIT_SUBMODULE_STATUS_IN_CONFIG. 1. https://github.com/libgit2/libgit2/issues/6433 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 24 18:52:14 2022 Received: (at 56398) by debbugs.gnu.org; 24 Nov 2022 23:52:14 +0000 Received: from localhost ([127.0.0.1]:60534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyM0r-0005fV-Ng for submit@debbugs.gnu.org; Thu, 24 Nov 2022 18:52:14 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:36904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyM0o-0005fG-Nm for 56398@debbugs.gnu.org; Thu, 24 Nov 2022 18:52:12 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id B751C66D06; Thu, 24 Nov 2022 23:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bokr.com; s=easymail; t=1669333924; bh=WLOuFqmDHWcXebdzI/QILTEaxNhRTaHjE8+UYVs7n5k=; h=From:Date:To:Cc:Subject:References:In-Reply-To:From; b=Q7GYPW8yfuaiWfWmA/uKk8wKFck0U/UFQGoqiTIoTq90AsfNGYUZVGqxgt3zXOEsx XJPoav5Z3RoY+v6+YLj5irz1MTwxpTppiic1ujMOIVMtes3wW1xbP77+kEVMkJ0EFQ 6ki+A03+SrW8VsHW7f110+736azQMqiteJ7F4BtmQ88Up0e+zIxaq8KeLSrk8QOwTO d4BvdUoivQEJPQ4JiwbQ8SfTDyBFAJ+5YO5Vh0L3oiu2cGwWAfxHXuoEIhNsf/+v3u gMDO8ZOboMs3wXKlHEGH3a6Cf6iEcC+UrlxC08453VgihUqlRDh3fYJXP8DAbQIV4q j/LJE53xTZQ5Q== X-Virus-Scanned: Debian amavisd-new at emo09-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo09-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xzx58rBk8zsp; Thu, 24 Nov 2022 23:52:04 +0000 (UTC) Received: from localhost (m90-129-206-71.cust.tele2.se [90.129.206.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id BB2E066B89; Thu, 24 Nov 2022 23:52:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bokr.com; s=easymail; t=1669333924; bh=WLOuFqmDHWcXebdzI/QILTEaxNhRTaHjE8+UYVs7n5k=; h=From:Date:To:Cc:Subject:References:In-Reply-To:From; b=Q7GYPW8yfuaiWfWmA/uKk8wKFck0U/UFQGoqiTIoTq90AsfNGYUZVGqxgt3zXOEsx XJPoav5Z3RoY+v6+YLj5irz1MTwxpTppiic1ujMOIVMtes3wW1xbP77+kEVMkJ0EFQ 6ki+A03+SrW8VsHW7f110+736azQMqiteJ7F4BtmQ88Up0e+zIxaq8KeLSrk8QOwTO d4BvdUoivQEJPQ4JiwbQ8SfTDyBFAJ+5YO5Vh0L3oiu2cGwWAfxHXuoEIhNsf/+v3u gMDO8ZOboMs3wXKlHEGH3a6Cf6iEcC+UrlxC08453VgihUqlRDh3fYJXP8DAbQIV4q j/LJE53xTZQ5Q== From: bokr@bokr.com Date: Fri, 25 Nov 2022 00:51:43 +0100 To: =?utf-8?B?QW5kcsOp?= Batista Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: <20221124235143.GA8148@LionPure> References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> <87h72smd7r.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56398 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, On +2022-11-24 12:17:01 -0300, André Batista wrote: > Hi! > > qui 04 ago 2022 às 13:59:20 (1659632360), ludovic.courtes@inria.fr enviou: > > I think we should instead report it upstream. Do you feel like doing > > it? I guess we’d need to give them the C version of the three-line > > snippet I gave earlier. > > Upstream issue #6433[1] > > Apparently, GIT_SUBMODULE_STATUS_WD_UNINITIALIZED isn't actually set > in this scenario, only GIT_SUBMODULE_STATUS_IN_CONFIG. > > 1. https://github.com/libgit2/libgit2/issues/6433 > > > Wondering if this[1] is all history in gnu/guix-land: [1] Wherein it says --8<---------------cut here---------------start------------->8--- The problem has been patched in the versions published on April 14th, 2020, going back to v2.17.x. Anyone wishing to backport the change further can do so by applying commit 9a6bbee (the full release includes extra checks for git fsck, but that commit is sufficient to protect clients against the vulnerability). The patched versions are: 2.17.4, 2.18.3, 2.19.4, 2.20.3, 2.21.2, 2.22.3, 2.23.2, 2.24.2, 2.25.3, 2.26.1. --8<---------------cut here---------------end--------------->8--- Is there an automated tool to answer the question, "What executables (command line directly, or indirectly (including config-directed interpretation)) does my system contain that have known vulnerabilities?" BTW: Newsflash: :) RMS paranoia now dernier-cri[3] as cited in [2] [2] [3] Something[3] to get (more) serious about for gnu/guix? -- Regards, Bengt Richter From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 10:42:26 2022 Received: (at 56398) by debbugs.gnu.org; 28 Nov 2022 15:42:26 +0000 Received: from localhost ([127.0.0.1]:49308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozgH3-0005X9-MP for submit@debbugs.gnu.org; Mon, 28 Nov 2022 10:42:25 -0500 Received: from mx1.riseup.net ([198.252.153.129]:39906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozgH2-0005Wz-2W for 56398@debbugs.gnu.org; Mon, 28 Nov 2022 10:42:24 -0500 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4NLV8V11SbzDqjd; Mon, 28 Nov 2022 15:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1669650138; bh=WNbS/Vjo74BSE1MM3yGY2vulxGiSjOxIB7Bp+qFI8YY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=epzYdQxrcY7/7ednshk5riOPGehiqk4wRkkBc3fkLDtcq/oIMWbcEAVwVcFjY9oFF qqJh1jT2MsHtfulfQrwu0/FdEzNwCd5VHQNGRpEJgiUKGXrDng5kpbMjTZjOjW/rMZ G5LXb9sQL89gpi0JEGB8mmSJXHYM4TkAxXoCZGt4= X-Riseup-User-ID: CDF6CB9FB98936D66576C53E6DB721FB4D542DB3AB4DF004358FEF9BA53A317D Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4NLV8S25VTz214Q; Mon, 28 Nov 2022 15:42:15 +0000 (UTC) Date: Mon, 28 Nov 2022 12:41:57 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules Message-ID: References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> <87h72smd7r.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) qui 24 nov 2022 às 12:17:19 (1669303039), nandre@riseup.net enviou: > Upstream issue #6433 Fixed on upstream commit 936b184e7494158c20e522981f4a324cac6ffa47 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 11:57:50 2022 Received: (at 56398) by debbugs.gnu.org; 28 Nov 2022 16:57:50 +0000 Received: from localhost ([127.0.0.1]:49711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhS1-0006Dp-NT for submit@debbugs.gnu.org; Mon, 28 Nov 2022 11:57:50 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:30143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhRw-0006Dj-Id for 56398@debbugs.gnu.org; Mon, 28 Nov 2022 11:57:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=4+VPkTKIarn5qKTI3b7+xEjK3gUD7AEN7ulPR57ZNNg=; b=rMsQ/qbDhbdwP1sZSLlj1oYFxPXE9JtjYgHtLXRJvq/Q8B8ckUZQqdax ppWlNeC62grlAJZZ6ndvol3q6mK93WGlVwx6cvYweBDQXxgzMQHd2tqxB lI2kPFc2js/yMTdctdzUI8fAsJUiMls/em0XURNgcqiiDCFjhl9fMqNgy 4=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.96,200,1665439200"; d="scan'208";a="41127015" Received: from unknown (HELO ribbon) ([193.50.110.137]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 17:57:38 +0100 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?Q?Andr=C3=A9?= Batista Subject: Re: bug#56398: (guix git) fails to check out repos with nested submodules References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> <87h72smd7r.fsf@inria.fr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 8 Frimaire an 231 de la =?utf-8?Q?R=C3=A9volu?= =?utf-8?Q?tion=2C?= jour du Miel X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 28 Nov 2022 17:57:37 +0100 In-Reply-To: (=?utf-8?Q?=22Andr=C3=A9?= Batista"'s message of "Mon, 28 Nov 2022 12:41:57 -0300") Message-ID: <87tu2jauf2.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 56398 Cc: 56398@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Andr=C3=A9, Andr=C3=A9 Batista skribis: > qui 24 nov 2022 =C3=A0s 12:17:19 (1669303039), nandre@riseup.net enviou: >> Upstream issue #6433 > > Fixed on upstream commit 936b184e7494158c20e522981f4a324cac6ffa47 Excellent. Let=E2=80=99s close this bug once we=E2=80=99ve updated the =E2= =80=98libgit2=E2=80=99 package to a version that includes this fix. Thanks for following up! Ludo=E2=80=99.