GNU bug report logs - #56391
`cp --reflink=always` creates empty file on failure

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#56391: closed (`cp --reflink=always` creates empty file on
 failure)
Date: Tue, 05 Jul 2022 15:05:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 5 Jul 2022 10:04:48 -0500
with message-id <8edadd5f-a640-09ce-340f-71ea17e5ea02 <at> cs.ucla.edu>
and subject line Re: bug#56391: `cp --reflink=always` creates empty file on failure
has caused the debbugs.gnu.org bug report #56391,
regarding `cp --reflink=always` creates empty file on failure
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
56391: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56391
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Benjamin Gilbert <bgilbert <at> backtick.net>
To: bug-coreutils <at> gnu.org
Subject: `cp --reflink=always` creates empty file on failure
Date: Tue, 5 Jul 2022 01:39:11 -0400

[Message part 3 (text/plain, inline)]

Hi,

When `cp --reflink=always` fails because the filesystem does not support
reflinks, I'd expect it not to leave anything at the destination path.
However, it appears to leave an empty file instead:

$ ls -l
total 0
$ echo "some data" > src
$ cp --reflink=always src dest
cp: failed to clone 'dest' from 'src': Operation not supported
$ ls -l
total 4
-rw-rw-r--. 1 bgilbert bgilbert  0 Jul  5 01:27 dest
-rw-rw-r--. 1 bgilbert bgilbert 10 Jul  5 01:27 src

I'm seeing this on both coreutils 9.0 (Fedora 36) and 9.1.31-fa332 built
from Git.

Best,
--Benjamin Gilbert

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Benjamin Gilbert <bgilbert <at> backtick.net>
Cc: 56391-done <at> debbugs.gnu.org
Subject: Re: bug#56391: `cp --reflink=always` creates empty file on failure
Date: Tue, 5 Jul 2022 10:04:48 -0500

[Message part 6 (text/plain, inline)]

Thanks for reporting that. I installed the attached patch.

[0001-cp-don-t-create-empty-file-if-cannot-clone.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.