GNU bug report logs - #56387
[PATCH] computed-file: Clarify comment about guile record field.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: jgart <jgart <at> dismail.de>
Subject: bug#56387: closed (Re: bug#56387: [PATCH] computed-file: Clarify
 comment about guile record field.)
Date: Thu, 07 Jul 2022 21:40:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#56387: [PATCH] computed-file: Clarify comment about guile record field.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 56387 <at> debbugs.gnu.org.

-- 
56387: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56387
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 56387-done <at> debbugs.gnu.org
Subject: Re: bug#56387: [PATCH] computed-file: Clarify comment about guile
 record field.
Date: Thu, 07 Jul 2022 17:39:31 -0400

Hi jgart,

jgart <jgart <at> dismail.de> writes:

> * guix/gexp.scm (<computed-file>): Clarify that what goes in the guile
> record field is any variant of a guile package record instance.
> ---
>  guix/gexp.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/gexp.scm b/guix/gexp.scm
> index ef92223048..eba65e92cf 100644
> --- a/guix/gexp.scm
> +++ b/guix/gexp.scm
> @@ -581,7 +581,7 @@ (define-record-type <computed-file>
>    computed-file?
>    (name       computed-file-name)                 ;string
>    (gexp       computed-file-gexp)                 ;gexp
> -  (guile      computed-file-guile)                ;<package>
> +  (guile      computed-file-guile)                ;<package guile-*>
>    (options    computed-file-options))             ;list of arguments

If this was a statically typed language, the proper type of the argument
accepted would be <package>, not <package guile-*>, so I'm inclined to
leave it the way it is (also, we'd have to survey the whole code base to
adjust for our current convention, which is to use <package>).

Closing,

Thanks,

Maxim

[Message part 3 (message/rfc822, inline)]

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] computed-file: Clarify comment about guile record field.
Date: Mon,  4 Jul 2022 15:02:28 -0500

* guix/gexp.scm (<computed-file>): Clarify that what goes in the guile
record field is any variant of a guile package record instance.
---
 guix/gexp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/gexp.scm b/guix/gexp.scm
index ef92223048..eba65e92cf 100644
--- a/guix/gexp.scm
+++ b/guix/gexp.scm
@@ -581,7 +581,7 @@ (define-record-type <computed-file>
   computed-file?
   (name       computed-file-name)                 ;string
   (gexp       computed-file-gexp)                 ;gexp
-  (guile      computed-file-guile)                ;<package>
+  (guile      computed-file-guile)                ;<package guile-*>
   (options    computed-file-options))             ;list of arguments
 
 (define* (computed-file name gexp
-- 
2.36.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.