From unknown Fri Sep 19 20:43:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56387] [PATCH] computed-file: Clarify comment about guile record field. Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Jul 2022 20:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56387 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56387@debbugs.gnu.org Cc: jgart X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165696498632464 (code B ref -1); Mon, 04 Jul 2022 20:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jul 2022 20:03:06 +0000 Received: from localhost ([127.0.0.1]:48713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8SHh-0008RY-Pq for submit@debbugs.gnu.org; Mon, 04 Jul 2022 16:03:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:50796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8SHf-0008RQ-RB for submit@debbugs.gnu.org; Mon, 04 Jul 2022 16:03:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8SHf-0001EF-KY for guix-patches@gnu.org; Mon, 04 Jul 2022 16:03:03 -0400 Received: from mx1.dismail.de ([78.46.223.134]:19499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8SHd-0001ae-DE for guix-patches@gnu.org; Mon, 04 Jul 2022 16:03:03 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id cc1e2f5d for ; Mon, 4 Jul 2022 22:02:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=YgtQpPn54js2BGFWSUFZjXqgGMbGDLh0r8whRLOi7T0=; b= OCDwW6EgmZjr7eQoexSX5sInpEZyA8F6m/zQ3TYnezxHCxrVWB8CPTwzrxAsdi8O 1oZxdd82J5KxfRQOrOjQKr68aSLkW8PnKZ8Q4uQ1OrWbrryVG+kVLxJ1pZ4H7Jp5 2TgcJYw2cpN6NwPZvi8ERlCEI+cqV075uRHa9wwSvAaG/PjpbRkX7/oLBtbJSeNk 6bWDhlQW/ZJcbXK9dD3H5K1ZF0um+FaJuNX27iVysXrilnqOW6jlDyTBr/p5ixj4 ND9DVUelodEChBhBI7DWXyzam1KZtjFWzEhohfsCHzbSnBlaebwvCAtbRwxuAxcT 7X6gf94PswEZeVNUQ89hgg== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id bc7aa7f9 for ; Mon, 4 Jul 2022 22:02:58 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id de2df963 for ; Mon, 4 Jul 2022 22:02:58 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id bd746fcb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 4 Jul 2022 22:02:57 +0200 (CEST) From: jgart Date: Mon, 4 Jul 2022 15:02:28 -0500 Message-Id: <20220704200228.17157-1-jgart@dismail.de> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@dismail.de; helo=mx1.dismail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * guix/gexp.scm (): Clarify that what goes in the guile record field is any variant of a guile package record instance. --- guix/gexp.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index ef92223048..eba65e92cf 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -581,7 +581,7 @@ (define-record-type computed-file? (name computed-file-name) ;string (gexp computed-file-gexp) ;gexp - (guile computed-file-guile) ; + (guile computed-file-guile) ; (options computed-file-options)) ;list of arguments (define* (computed-file name gexp -- 2.36.1 From unknown Fri Sep 19 20:43:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: jgart Subject: bug#56387: closed (Re: bug#56387: [PATCH] computed-file: Clarify comment about guile record field.) Message-ID: References: <87r12wvbzg.fsf@gmail.com> <20220704200228.17157-1-jgart@dismail.de> X-Gnu-PR-Message: they-closed 56387 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 56387@debbugs.gnu.org Date: Thu, 07 Jul 2022 21:40:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1657230002-32298-1" This is a multi-part message in MIME format... ------------=_1657230002-32298-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #56387: [PATCH] computed-file: Clarify comment about guile record field. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 56387@debbugs.gnu.org. --=20 56387: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56387 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1657230002-32298-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 56387-done) by debbugs.gnu.org; 7 Jul 2022 21:39:41 +0000 Received: from localhost ([127.0.0.1]:58197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9ZDp-0008OK-5w for submit@debbugs.gnu.org; Thu, 07 Jul 2022 17:39:41 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:33592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9ZDm-0008O5-Et for 56387-done@debbugs.gnu.org; Thu, 07 Jul 2022 17:39:39 -0400 Received: by mail-qt1-f179.google.com with SMTP id r2so24741652qta.0 for <56387-done@debbugs.gnu.org>; Thu, 07 Jul 2022 14:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eOZ6AItGE9Zvx7ISD4L0G/yz627X51sbDaHXhNythFQ=; b=J2V8/2eStQW+E5UBQEO39y2u3GXIdP8+WbHUpdItWZuf3hJDsHVv6No/o4KdQWIYWD pg+3BtdNzLdZoVJvhF7Uli0kxKbkIJRvqtH01elmLKHnn7HA+WAeEv7AqjpSeCtzzTRU Ylik8mLzNxs1EQP2iLJHattNZo8cZ5rqXwU+euX9ZtmAdKWTKLCNXppwjnXU/lhlMh+z ifOKUsi8P9cU1w7JEsfXZy47BDLw0j5qWzRk3iaRs5FFu5JVTeAbHDgiZbVQlMC0VTtG dtrlnZyqVqlOJXblZtpmz+zEEL+D2Jg4iS0r7q1WpAr7l1void5De4YkQZ0dJpndVkpn MaRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eOZ6AItGE9Zvx7ISD4L0G/yz627X51sbDaHXhNythFQ=; b=1SY+PUp/0gHvQ1haohmUh/R7XSSwdsUuvo0Azx0AtQeIYvNHme13CEL49zcqRnxd6b 2mRoKT6OyijxNglP9YEmPlvey+mJP20pgA77Kuw3bOl6OSNX+7YaLdCrSKVdvQttZSeX 1fgFDUyqmQIIhThzPSv9dsFgw1zW2ez8qiEZ8stSsxSZud+AEbwgxi90UTWIG2omSJMF r04Wrr9LmYimGzh9oQd6POlGphCjB1B1f/pJRtXP/O6/BK0fgbaIBtMxgX7mdWR1sF4C mLLw2wKIZlrcKj9xN/qQ4nDVsEVQDt5+moZwQTbrsNCc+Cnx8XtgPgiVDJGgcpL5QorA cq7A== X-Gm-Message-State: AJIora+ynfzthQJbD8dbDwoDQKDNonvLJhvYMwS87tfgQTL6oIqpXJ4H a84G2r+lpxF2s+tMhbyOjlrWl21QAJ0wPMt4 X-Google-Smtp-Source: AGRyM1sKTps4VeE7QgjhkqvDVOEMjFiSBKFz5y7Rcg4eSxA6JBVTX9PEpSyEfRKHa/kIN7ZTKCyvQA== X-Received: by 2002:a0c:ab8f:0:b0:473:2937:a05f with SMTP id j15-20020a0cab8f000000b004732937a05fmr155306qvb.90.1657229972585; Thu, 07 Jul 2022 14:39:32 -0700 (PDT) Received: from hurd (dsl-153-127.b2b2c.ca. [66.158.153.127]) by smtp.gmail.com with ESMTPSA id y11-20020a05620a44cb00b006a37eb728cfsm29088313qkp.1.2022.07.07.14.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 14:39:32 -0700 (PDT) From: Maxim Cournoyer To: jgart Subject: Re: bug#56387: [PATCH] computed-file: Clarify comment about guile record field. References: <20220704200228.17157-1-jgart@dismail.de> Date: Thu, 07 Jul 2022 17:39:31 -0400 In-Reply-To: <20220704200228.17157-1-jgart@dismail.de> (jgart@dismail.de's message of "Mon, 4 Jul 2022 15:02:28 -0500") Message-ID: <87r12wvbzg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56387-done Cc: 56387-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi jgart, jgart writes: > * guix/gexp.scm (): Clarify that what goes in the guile > record field is any variant of a guile package record instance. > --- > guix/gexp.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/guix/gexp.scm b/guix/gexp.scm > index ef92223048..eba65e92cf 100644 > --- a/guix/gexp.scm > +++ b/guix/gexp.scm > @@ -581,7 +581,7 @@ (define-record-type > computed-file? > (name computed-file-name) ;string > (gexp computed-file-gexp) ;gexp > - (guile computed-file-guile) ; > + (guile computed-file-guile) ; > (options computed-file-options)) ;list of arguments If this was a statically typed language, the proper type of the argument accepted would be , not , so I'm inclined to leave it the way it is (also, we'd have to survey the whole code base to adjust for our current convention, which is to use ). Closing, Thanks, Maxim ------------=_1657230002-32298-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Jul 2022 20:03:06 +0000 Received: from localhost ([127.0.0.1]:48713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8SHh-0008RY-Pq for submit@debbugs.gnu.org; Mon, 04 Jul 2022 16:03:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:50796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8SHf-0008RQ-RB for submit@debbugs.gnu.org; Mon, 04 Jul 2022 16:03:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8SHf-0001EF-KY for guix-patches@gnu.org; Mon, 04 Jul 2022 16:03:03 -0400 Received: from mx1.dismail.de ([78.46.223.134]:19499) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8SHd-0001ae-DE for guix-patches@gnu.org; Mon, 04 Jul 2022 16:03:03 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id cc1e2f5d for ; Mon, 4 Jul 2022 22:02:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=YgtQpPn54js2BGFWSUFZjXqgGMbGDLh0r8whRLOi7T0=; b= OCDwW6EgmZjr7eQoexSX5sInpEZyA8F6m/zQ3TYnezxHCxrVWB8CPTwzrxAsdi8O 1oZxdd82J5KxfRQOrOjQKr68aSLkW8PnKZ8Q4uQ1OrWbrryVG+kVLxJ1pZ4H7Jp5 2TgcJYw2cpN6NwPZvi8ERlCEI+cqV075uRHa9wwSvAaG/PjpbRkX7/oLBtbJSeNk 6bWDhlQW/ZJcbXK9dD3H5K1ZF0um+FaJuNX27iVysXrilnqOW6jlDyTBr/p5ixj4 ND9DVUelodEChBhBI7DWXyzam1KZtjFWzEhohfsCHzbSnBlaebwvCAtbRwxuAxcT 7X6gf94PswEZeVNUQ89hgg== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id bc7aa7f9 for ; Mon, 4 Jul 2022 22:02:58 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id de2df963 for ; Mon, 4 Jul 2022 22:02:58 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id bd746fcb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 4 Jul 2022 22:02:57 +0200 (CEST) From: jgart To: guix-patches@gnu.org Subject: [PATCH] computed-file: Clarify comment about guile record field. Date: Mon, 4 Jul 2022 15:02:28 -0500 Message-Id: <20220704200228.17157-1-jgart@dismail.de> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@dismail.de; helo=mx1.dismail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * guix/gexp.scm (): Clarify that what goes in the guile record field is any variant of a guile package record instance. --- guix/gexp.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index ef92223048..eba65e92cf 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -581,7 +581,7 @@ (define-record-type computed-file? (name computed-file-name) ;string (gexp computed-file-gexp) ;gexp - (guile computed-file-guile) ; + (guile computed-file-guile) ; (options computed-file-options)) ;list of arguments (define* (computed-file name gexp -- 2.36.1 ------------=_1657230002-32298-1--