GNU bug report logs - #56377
[PATCH] gnu: pipe-viewer: Add dependency.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56377 in the body.
You can then email your comments to 56377 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: pipe-viewer: Add dependency.
Date: Mon, 04 Jul 2022 02:08:26 +0000

[Message part 1 (text/plain, inline)]

Without mpv this application gives the following error:
sh: line 1: mpv: command not found.

[Message part 2 (text/html, inline)]

[0001-gnu-pipe-viewer-Add-dependency.patch (text/x-patch, attachment)]

Message #8 received at 56377 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: "56377 <at> debbugs.gnu.org" <56377 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: pipe-viewer: Add dependency.
Date: Mon, 04 Jul 2022 02:21:25 +0000

[Message part 1 (text/plain, inline)]

Sorry for the ignorance, mpv has to be propagated-input to work.

[Message part 2 (text/html, inline)]

[0001-gnu-pipe-viewer-Add-dependency.patch (text/x-patch, attachment)]

Message #11 received at 56377 <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: "56377 <at> debbugs.gnu.org" <56377 <at> debbugs.gnu.org>
Subject: (No Subject)
Date: Mon, 04 Jul 2022 02:33:25 +0000

[Message part 1 (text/plain, inline)]

Sorry, again, as using the app I understood that mpv is not hardcoded, in the settings I can use any video player. So it doesn't make sense to add mpv as a dependency. I would request to ignore this issue and close it.

[Message part 2 (text/html, inline)]

Message #14 received at 56377 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: Sughosha <Sughosha <at> proton.me>, "56377 <at> debbugs.gnu.org"
 <56377 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: pipe-viewer: Add dependency.
Date: Mon, 04 Jul 2022 08:44:08 +0200

Hi

Am Montag, dem 04.07.2022 um 02:21 +0000 schrieb Sughosha:
> Sorry for the ignorance, mpv has to be propagated-input to work.
Rather than propagating mpv, could you patch the place in which it is
invoked?  It doesn't matter if mpv is used as a "fallback" or whatever,
if it calls mpv we might as well make sure it finds mpv.

Cheers

Message #21 received at 56377 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Sughosha <Sughosha <at> proton.me>,
 "56377 <at> debbugs.gnu.org" <56377 <at> debbugs.gnu.org>
Subject: Re: [bug#56377] (No Subject)
Date: Fri, 29 Jul 2022 18:38:45 +0200

[Message part 1 (text/plain, inline)]

On 04-07-2022 04:33, Sughosha via Guix-patches via wrote:

> Sorry, again, as using the app I understood that mpv is not hardcoded, 
> in the settings I can use any video player. So it doesn't make sense 
> to add mpv as a dependency. I would request to ignore this issue and 
> close it.

Assuming that mpv isn't overly large, I think it would be nice if 
pipe-viewer can always find its default player -- the user can still 
override what player to use when desired.

Looking at "guix size mpv pipe-viewer" and "guix size pipe-viewer", mpv 
adds 20.1 MiB; I don't know if that's worth it (I'm leaning towards 
'not' but I'm undecided).

Greetings,
Maxime.

[Message part 2 (text/html, inline)]

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.