From unknown Sat Jun 21 10:17:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56375 <56375@debbugs.gnu.org> To: bug#56375 <56375@debbugs.gnu.org> Subject: Status: 28.1.50; Calling "convert" from thumbs.el is broken Reply-To: bug#56375 <56375@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:17:59 +0000 retitle 56375 28.1.50; Calling "convert" from thumbs.el is broken reassign 56375 emacs submitter 56375 Benjamin Riefenstahl severity 56375 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 03 19:49:22 2022 Received: (at submit) by debbugs.gnu.org; 3 Jul 2022 23:49:22 +0000 Received: from localhost ([127.0.0.1]:45647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o89L7-0002xX-4D for submit@debbugs.gnu.org; Sun, 03 Jul 2022 19:49:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:34308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o89Kq-0002xB-UG for submit@debbugs.gnu.org; Sun, 03 Jul 2022 19:49:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o89Kq-0003G7-Kr for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2022 19:49:04 -0400 Received: from odoacer.turtle-trading.net ([93.241.193.16]:49139) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.90_1) (envelope-from ) id 1o89Ko-0007ql-MX for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2022 19:49:04 -0400 Received: from zenobia.turtle-trading.net ([192.168.2.111]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1o89Kj-0003ZZ-56; Mon, 04 Jul 2022 01:48:57 +0200 Received: from benny by zenobia.turtle-trading.net with local (Exim 4.94.2) (envelope-from ) id 1o89Ki-001t8K-TF; Mon, 04 Jul 2022 01:48:56 +0200 From: Benjamin Riefenstahl To: bug-gnu-emacs@gnu.org Subject: 28.1.50; Calling "convert" from thumbs.el is broken Date: Mon, 04 Jul 2022 01:48:56 +0200 Message-ID: <87czeln4ev.fsf@turtle-trading.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=93.241.193.16; envelope-from=benny@turtle-trading.net; helo=odoacer.turtle-trading.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * dired to a directory with images that are larger than 100x100 pixels * M-x thumbs-dired-show * I get a buffer with the first few images in the directory in their original size * I expect the images to be scaled to thumbs smaller than 100x100, see thumbs-geometry Tracing the code I stumble onto thumbs-call-convert. Some time in the past this was converted from using the shell to passing the parameters directly, but the fallout was not handled correctly. I will post a patch as a follow-up. ---- In GNU Emacs 28.1.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2022-05-12 built on zenobia Repository revision: f03c5d81bd4a7af1364558b406e2b87a78b3af73 Repository branch: emacs-28 System Description: Debian GNU/Linux 11 (bullseye) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Group Minor modes in effect: gnus-topic-mode: t gnus-undo-mode: t desktop-save-mode: t display-time-mode: t xclip-mode: t xterm-mouse-mode: t delete-selection-mode: t cua-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: ~/Projects/ttf-mode/arc-mode-compat hides ~/emacs/arc-mode-compat /home/benny/.emacs.d/elpa/transient-20210920.1038/transient hides /usr/local/share/emacs/28.1.50/lisp/transient /home/benny/site-lisp/dictionary-1.10/dictionary hides /usr/local/share/emacs/28.1.50/lisp/net/dictionary Features: (shadow bbdb-message emacsbug dired-aux gnus-html help-fns bookmark gnus-kill nnselect gnus-search eieio-opt speedbar ezimage dframe find-func nndoc flow-fill misearch multi-isearch smerge-mode diff compile descr-text cus-start termshape shr-color color format-spec benny-nitter eww xdg url-queue thingatpt benny-url sort gnus-cite mail-extr gnus-bcklg gnus-async gnus-dup gnus-ml pp gnus-topic jka-compr url-http url-gw mm-archive url-file url-dired url-cache url-auth qp gnutls nndraft nnmh nnfolder bbdb-gnus bbdb-mua network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache pop3 nnrss gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom gnus-group gnus-undo mm-url bbdb-com crm message-x bbdb bbdb-site timezone gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601 gnus-spec gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail rmail-loaddefs text-property-search wid-edit mule-util imenu time-date desktop frameset highline benny-calendar-cfg ange-ftp comint ansi-color ring generic-x autoinsert cc-mode cc-fonts cc-guess cc-menus cc-styles cc-align cc-cmds cc-engine cc-vars cc-defs ps-print ps-print-loaddefs ps-def lpr advice cl-extra help-mode dired dired-loaddefs benny-x-clipboard disp-table time server protbuf xclip term/xterm xterm xt-mouse cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays hol-loaddefs vc-git diff-mode easy-mmode vc-dispatcher vc-fossil diary-lib diary-loaddefs cal-menu calendar cal-loaddefs delsel cua-base cus-load benny-file-cache filecache derived sendmail mail-utils benny-tools autoload radix-tree lisp-mnt mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr finder-inf edmacro kmacro info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 361711 129281) (symbols 48 39764 19) (strings 32 212367 23946) (string-bytes 1 6513504) (vectors 16 52664) (vector-slots 8 1676247 215016) (floats 8 1030 1251) (intervals 56 1742 1237) (buffers 992 29)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 03 20:04:57 2022 Received: (at 56375) by debbugs.gnu.org; 4 Jul 2022 00:04:57 +0000 Received: from localhost ([127.0.0.1]:45653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o89aC-0003Ky-JT for submit@debbugs.gnu.org; Sun, 03 Jul 2022 20:04:57 -0400 Received: from odoacer.turtle-trading.net ([93.241.193.16]:45765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o89a6-0003Kh-Va for 56375@debbugs.gnu.org; Sun, 03 Jul 2022 20:04:55 -0400 Received: from zenobia.turtle-trading.net ([192.168.2.111]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1o89a0-0003Zy-Ff; Mon, 04 Jul 2022 02:04:44 +0200 Received: from benny by zenobia.turtle-trading.net with local (Exim 4.94.2) (envelope-from ) id 1o89a0-001tDY-7E; Mon, 04 Jul 2022 02:04:44 +0200 From: Benjamin Riefenstahl To: 56375@debbugs.gnu.org Subject: Re: bug#56375: 28.1.50; Calling "convert" from thumbs.el is broken References: <87czeln4ev.fsf@turtle-trading.net> Date: Mon, 04 Jul 2022 02:04:44 +0200 In-Reply-To: (GNU bug Tracking System's message of "Sun, 03 Jul 2022 23:50:02 +0000") Message-ID: <874jzxn3oj.fsf_-_@turtle-trading.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-thumbs.el-Fix-calling-the-convert-command.patch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56375 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >From 7418e68266b9d593219c6a84be5d519844855f3a Mon Sep 17 00:00:00 2001 From: Benjamin Riefenstahl Date: Sun, 3 Jul 2022 15:52:13 -0700 Subject: [PATCH] lisp/thumbs.el: Fix calling the "convert" command * lisp/thumbs.el (thumbs-call-convert): Pass 'action-prefix' and 'action' as a combined parameter. Do not pass 'arg' if it is nil. (thumbs-modify-image): Do not pass "" as 'arg' to 'thumbs-call-convert'. (Bug#56375) --- lisp/thumbs.el | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lisp/thumbs.el b/lisp/thumbs.el index 3bf08dd6a5..e622bcedc4 100644 --- a/lisp/thumbs.el +++ b/lisp/thumbs.el @@ -215,16 +215,17 @@ thumbs-call-convert FILEOUT is the output file, ACTION is the command to send to convert. Optional arguments are: -ARG any arguments to the ACTION command, +ARG if non-nil, the argument of the ACTION command, OUTPUT-FORMAT is the file format to output (default is jpeg), ACTION-PREFIX is the symbol to place before the ACTION command (defaults to `-' but can sometimes be `+')." - (call-process thumbs-conversion-program nil nil nil - (or action-prefix "-") - action - (or arg "") - filein - (format "%s:%s" (or output-format "jpeg") fileout))) + (let ((action-param (concat (or action-prefix "-") action)) + (fileout-param (format "%s:%s" (or output-format "jpeg") fileout))) + (if arg + (call-process thumbs-conversion-program nil nil nil + action-param arg filein fileout-param) + (call-process thumbs-conversion-program nil nil nil + action-param filein fileout-param)))) (defun thumbs-new-image-size (s increment) "New image (a cons of width x height)." @@ -610,7 +611,7 @@ thumbs-modify-image (thumbs-call-convert (or old thumbs-current-image-filename) tmp action - (or arg "")) + arg) (save-excursion (thumbs-insert-image tmp 'jpeg 0)) (setq thumbs-current-tmp-filename tmp))) -- 2.30.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 06:57:58 2022 Received: (at 56375) by debbugs.gnu.org; 4 Jul 2022 10:57:58 +0000 Received: from localhost ([127.0.0.1]:46244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JmA-0001PF-74 for submit@debbugs.gnu.org; Mon, 04 Jul 2022 06:57:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8Jm8-0001Ox-Sg for 56375@debbugs.gnu.org; Mon, 04 Jul 2022 06:57:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5CqtBViRR6xoBL5uNfDQ61qO+jYgIvqURt0a7z1kD74=; b=RKwLgLW3mL7iUhMuaHeG0iypP0 HNS6RsJc/NSUbOjAQtOIBMLndRcD4VTvqMxS0EQHo/CaOTDojUPduYXV0TZbuE43D1o9rfsuup+9X 3Tpr6175dKFkSRcZZTgS8Bb2oJOylW549F6cJ7t2XiM1c6wjFheqyZcbQhefdKV9CqzI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Jlz-0006Vk-PM; Mon, 04 Jul 2022 12:57:50 +0200 From: Lars Ingebrigtsen To: Benjamin Riefenstahl Subject: Re: bug#56375: 28.1.50; Calling "convert" from thumbs.el is broken In-Reply-To: <874jzxn3oj.fsf_-_@turtle-trading.net> (Benjamin Riefenstahl's message of "Mon, 04 Jul 2022 02:04:44 +0200") References: <87czeln4ev.fsf@turtle-trading.net> <874jzxn3oj.fsf_-_@turtle-trading.net> X-Now-Playing: Joe Jackson's _Big World_: "Man in the Street" Date: Mon, 04 Jul 2022 12:57:47 +0200 Message-ID: <878rp987ro.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Benjamin Riefenstahl writes: > * lisp/thumbs.el (thumbs-call-convert): Pass 'action-prefix' and > 'action' as a combined parameter. Do not pass 'arg' if it is nil. > (thumbs-modify-image): Do not pass "" as 'arg' to > 'thumbs-cal [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56375 Cc: 56375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Benjamin Riefenstahl writes: > * lisp/thumbs.el (thumbs-call-convert): Pass 'action-prefix' and > 'action' as a combined parameter. Do not pass 'arg' if it is nil. > (thumbs-modify-image): Do not pass "" as 'arg' to > 'thumbs-call-convert'. Thanks; pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 06:58:02 2022 Received: (at control) by debbugs.gnu.org; 4 Jul 2022 10:58:02 +0000 Received: from localhost ([127.0.0.1]:46248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JmE-0001Pj-EB for submit@debbugs.gnu.org; Mon, 04 Jul 2022 06:58:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8JmC-0001P5-OJ for control@debbugs.gnu.org; Mon, 04 Jul 2022 06:58:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YQJdQTwAiFKfYq3krQ7MU5npN92ZsF8cJ9EVSIcxdv8=; b=s3MBb+MM7eIuT2WXHZ4/2PBPU2 e6s9Kx9yhKosq6iMcFjTrjul/z1IKtn+NUSxRw8wztRum/uztsIgS4kxXzaRmK344oMsJyrQULWvQ jZ3W/RTUqwosePZTnMb6wYRxX6FFFyeWU5QeNKmLBzJt+nHl7hG+jZybFeueWTlY93sM=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8Jm4-0006Vr-PB for control@debbugs.gnu.org; Mon, 04 Jul 2022 12:57:54 +0200 Date: Mon, 04 Jul 2022 12:57:52 +0200 Message-Id: <877d4t87rj.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56375 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 56375 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 56375 29.1 quit From unknown Sat Jun 21 10:17:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 01 Aug 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator