GNU bug report logs - #56369
29.0.50; abort-redisplay: Crash after 'recenter'

Previous Next

Package: emacs;

Reported by: Florian Rommel <mail <at> florommel.de>

Date: Sun, 3 Jul 2022 15:56:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#56369: closed (29.0.50; abort-redisplay: Crash after 'recenter')
Date: Sun, 03 Jul 2022 16:12:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 03 Jul 2022 19:11:09 +0300
with message-id <83czem9nxe.fsf <at> gnu.org>
and subject line Re: bug#56369: 29.0.50; abort-redisplay: Crash after 'recenter'
has caused the debbugs.gnu.org bug report #56369,
regarding 29.0.50; abort-redisplay: Crash after 'recenter'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
56369: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56369
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Florian Rommel <mail <at> florommel.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; abort-redisplay: Crash after 'recenter'
Date: Sun, 03 Jul 2022 17:55:50 +0200
[Message part 3 (text/plain, inline)]
Tags: patch

I get a crash caused by a failed free() [see attached backtrace] when
running vterm [1] which calls 'recenter' from a loaded module.
With gdb, in 'safe_free' I see that the address of the to-be-freed
arguments array (allocated in 'module_funcall') is off by one word.

I don't know the details of the specpdl stack but I assume that there
is a missing 'ubind_to' in 'recenter' before an early return.  When I
add it (see the attached patch) the problem is gone.

[1] https://github.com/akermu/emacs-libvterm

[backtrace.txt (text/plain, attachment)]
[0001-abort-redisplay-Add-missing-unbind_to-in-recenter.patch (text/x-patch, attachment)]
[Message part 6 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: 56369-done <at> debbugs.gnu.org
Subject: Re: bug#56369: 29.0.50; abort-redisplay: Crash after 'recenter'
Date: Sun, 03 Jul 2022 19:11:09 +0300
Closing.


This bug report was last modified 3 years and 18 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.